From nobody Mon Feb 9 08:34:17 2026 Received: from pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com [44.246.68.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D6D4345CBF for ; Sun, 8 Feb 2026 06:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.246.68.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770531572; cv=none; b=Il4LGHi0U2faP2dz/2z0vu0bf3GmSFyvlxjZ6GwitKZye4SbQvizhjLn4t2Bk+VVF7DeeC99rl1IiUPZ92Q0K1Mb08q37OAj2ZbzYJWSsL3+HWvBdEqHUicJ0sT3mPFAvvnl7KfNZX/icO97zZdwv+TJFeUBEOF3H9quQi2VJ2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770531572; c=relaxed/simple; bh=7R3oQ+gY64LEgUdD+rrHOLyEH2xx5P0cbAZhlYV97tE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L2Y0Eel4+NHjysGeI2CbcnkkUAergl5AHVIFhJXmdJs0IzeglluR/A/Gq4U7/eEL8028+9f7q1ImowrUfSZda2rJJ5GfWu6tElkwZBuuCYIC2aY/4angjpQgPvSmf7zYg4mKehfZMC8Ysxt/eNAnc1RW0mdombQ4dJEbevmP53g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=obKCuPMU; arc=none smtp.client-ip=44.246.68.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="obKCuPMU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1770531572; x=1802067572; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kt+JYlmLC8S632f23NjynpBZGNVCDSSCZjdmoEG0rs4=; b=obKCuPMURRLRwBzqpzWcw7D31lM6IXV9GK4Yl0C3WZ3OKKfCx1Gf1gXn He44pPq2iDgRxfdkvhbNqvxOQir7cc66q6iWiVtcPvvQiI/SOUhqb9sJR I1EWADDeKnnE/ZRvJRfpvxvvCoPRBK19awT0cbmfMY3UW0vu69joog4zG d4cuPaxHgnt86dxw16B758bixOQXAqCz6pbA0Hab2vy+g+G9g/A2+gPc0 CGvXXRyu8RLyNVg/9oX9QMbfp+U4ywB28H9h00Vl7s2npEBGhojj9nme4 xQyq57mEKcRglnmGlTiD+Uuppv29jPsZ8g9ZM7ejUuOdlQ036rhr06q0L Q==; X-CSE-ConnectionGUID: 1IigKDfwSKax7H5DRDa94g== X-CSE-MsgGUID: loBlZqD6T3qnE+WLyb+e+w== X-IronPort-AV: E=Sophos;i="6.21,279,1763424000"; d="scan'208";a="12622004" Received: from ip-10-5-0-115.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.0.115]) by internal-pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2026 06:19:29 +0000 Received: from EX19MTAUWB002.ant.amazon.com [205.251.233.111:16392] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.50.153:2525] with esmtp (Farcaster) id 1b6970f0-5227-40dd-bb4b-b1af4b6f95a1; Sun, 8 Feb 2026 06:19:29 +0000 (UTC) X-Farcaster-Flow-ID: 1b6970f0-5227-40dd-bb4b-b1af4b6f95a1 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Sun, 8 Feb 2026 06:19:29 +0000 Received: from dev-dsk-farbere-1a-46ecabed.eu-west-1.amazon.com (172.19.116.181) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Sun, 8 Feb 2026 06:19:27 +0000 From: Eliav Farber To: , , , , , , , CC: Subject: [PATCH 2/4] mtd: spi-nor: winbond: Fix locking support for w25q256jw Date: Sun, 8 Feb 2026 06:19:17 +0000 Message-ID: <20260208061919.30498-3-farbere@amazon.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260208061919.30498-1-farbere@amazon.com> References: <20260208061919.30498-1-farbere@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: EX19D038UWC003.ant.amazon.com (10.13.139.209) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Content-Type: text/plain; charset="utf-8" The Winbond w25q256jw device: - Supports lock/unlock via SR. - Has Top/Bottom (TB) protect bit. - Uses Status Register bit 6 as the Top/Bottom (TB) protect bit. - Supports four Block Protect (BP) bits. Update the flash parameters by enabling SPI_NOR_HAS_LOCK, SPI_NOR_HAS_TB, SPI_NOR_TB_SR_BIT6 and SPI_NOR_4BIT_BP. Without these flags, the locking configuration is incorrect. Reference: https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3Den= &DocNo=3DDA00-W25Q256JW.1 Signed-off-by: Eliav Farber --- drivers/mtd/spi-nor/winbond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 55f1209936d5..6d325da121b4 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -274,6 +274,7 @@ static const struct flash_info winbond_nor_parts[] =3D { .id =3D SNOR_ID(0xef, 0x60, 0x19), .name =3D "w25q256jw", .size =3D SZ_32M, + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_= NOR_4BIT_BP, .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, }, { .id =3D SNOR_ID(0xef, 0x60, 0x20), --=20 2.47.3