From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C046E2C11C6 for ; Sun, 8 Feb 2026 04:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523447; cv=none; b=b6DsBhSRZUU5x0cOzg9ZvrI7PmESAqaYcOVdXoQZieEsbh9MXxDUoCINpRVEPIcKvP0p3YGMfzUKoqQ/r8dZdLFRxQoTZrg4OJJbbe8k5XtbsthegZzqAmdqdlo1JXkFbTBRWzzw+7rqztrhVZKgorPd7EZyHaWf/WZzBIozJbw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523447; c=relaxed/simple; bh=6sWk+ZD5EZZpFdZwa80I6qB0RSa/sFczAV6WHYqa1ag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WywVnjWhLoHE2AKd2nF98CK+0MmrJH8N2PW+bEy8i8EDgO4O4Al4NMG7oLcN6QhZPtpGrDytbtSUx/hOu5/AR0zybQauxKIwq6mM1cP7Swj9qP++3WF3XV/3FJvbS04W4v/jexyXiGVvlnBD5iQgZmYpDTYFbELs1BIXEP6OGDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ltDvnGtR; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ltDvnGtR" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1249b9f5703so2505412c88.0 for ; Sat, 07 Feb 2026 20:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523447; x=1771128247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U37aKUtc6RlOePvT1hsucle0pebLyklaSQDosLHQp6Q=; b=ltDvnGtRcGf5B+cxKtuAB/QHl4Pk1JDGGi39lkhneTUggKtjbehjd67CXEPog5qFTE 0X5avq3gXUJrUfruBap9PA9l7xrLb52SeRq+/CcBMhH0g0oy/+xdg6LkMennMGeiwURj xULNrRZOzztcJw38ljmhCY1NzTxlfYHTencZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523447; x=1771128247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U37aKUtc6RlOePvT1hsucle0pebLyklaSQDosLHQp6Q=; b=RKZhbb78t+DlW+vZMav7BbNOE3bvkoLRy2qWQNdvm9VdcowXIArW3KF+LCUa7N2yXb zWQ8DuCACc+V7jsCZBPBvA21Yaur0+mZ+atMfuDfNwdFvKrsJk4R29VZ85EyjQh/M5jP H/WrH8LhIeV+LRN2fpKaGUe3AH3GHDArsbLclVytgD3GxsqrVlhbiTdexpLbhwVSFEL7 H1CpIoV3n94V/2pUOD5NlaP6g/kTYEEP72E9Nee6+CvnCNj6vEhxUPNktV6bVYe6lUgJ Reb6O7FH+s23P+McybgEUmabXf2nGW2BZtJNBf5xHdJNOwf9bIWK3YS3+s8oa6qPTCSx 7/aw== X-Forwarded-Encrypted: i=1; AJvYcCUbhM4fk5PIpsR4STTrV0wmp7m/CDm3DQPeXIja26PyihO1uNAbOC0tEP7A/WzlP5/Uh88XxLEhfpiAXJA=@vger.kernel.org X-Gm-Message-State: AOJu0YwlXzoxQ5iw4BYFrmOTPXpTjxLX3zbm0ItetmlI2w+UMm5+/VNy GXykDf+bCHJ1kZjliAKgfCYfV9rH3LDY/bfvPDRUDJV/0yugsH6MlYz2+z5q7DfUlg== X-Gm-Gg: AZuq6aJVy9paKwcLwuuvmJxXZL1y3DTsYmSilj7Wtey7hCKBwctonUIc9t8K/TCjwui Zmh5akzLINTrOM4JksiN+SSGt69M7xYGOctQGkZeJ+CzE2KjBxK5D+wDV+tnmuy3pZRUBwPbsnu CoGQ2oA7gagiRlKjqHEPgUGnvoqA1092a6TgImA19jAwfdFS2i8AsoBGjYOlN3zuVOhKUfciRKn cVWuZL5Bd3Da5+QHxAHlKo0Is32vUfR37SGvA/Dkk1+/OY/NKw1IY5pbYHDI2k08hUFkTFQl7vy Y/zD9VZNK+kHLbbPJ6tMAX75OlMQKwyPB0fvnmibWdsg1ytTta6YyOKUQM/0cGqp2EDPbalH934 rh0PUytLGN9NXwDJRcrBBRz7IpsEZacmj+jjRa/CzL2fOczf3QDU1A9KwTz58bvLDq2H/mGktBc qodF+qVeUW+8iUS1w2fFXHe+c6+bCR8tYSqjaddcSHEfSHCQEJrCrTBoJ5uHFxsvgrnzN61H4= X-Received: by 2002:a05:7022:250e:b0:11a:2f10:fa46 with SMTP id a92af1059eb24-12703e569femr3754647c88.0.1770523446753; Sat, 07 Feb 2026 20:04:06 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:03 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Frank.Li@nxp.com, andersson@kernel.org, arm-scmi@vger.kernel.org, cristian.marussi@arm.com, festevam@gmail.com, imx@lists.linux.dev, jay.buddhabhatti@amd.com, jonathanh@nvidia.com, kernel@pengutronix.de, konradybcio@kernel.org, krzk@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-tegra@vger.kernel.org, mathieu.poirier@linaro.org, michal.simek@amd.com, nm@ti.com, rafael@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawn.guo@linaro.org, ssantosh@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, thierry.reding@gmail.com Subject: [PATCH v2 01/15] mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell() Date: Sat, 7 Feb 2026 20:01:23 -0800 Message-ID: <20260207200128.v2.1.I600d04c0553f5c5ba39c2f92201da313aedfe746@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The way the mailbox core behaves when you pass a NULL `mssg` parameter to mbox_send_message() is a little questionable. Specifically, the mailbox core stores the currently active message directly in its `active_req` field. In at least two places it decides that if this field is `NULL` then there is no active request. That means if `mssg` is ever NULL it will cause the mailbox core to think is no active request. The two places where it does this are: 1. When a client calls mbox_send_message(), if `active_req` is NULL then it will call the mailbox controller to send the new message even if the mailbox controller hasn't yet called mbox_chan_txdone() on the previous (NULL) message. 2. The mailbox core will never call the client's `tx_done()` callback with a NULL message because `tx_tick()` returns early whenever the message is NULL. Though the above doesn't look like it was a conscious design choice, it does have the benefit of providing a simple way to assert an edge-triggered interrupt to the remote processor on the other side of the mailbox. Specifically: 1. Like a normal edge-triggered interrupt, if multiple edges arrive before the interrupt is Acked they are coalesced. 2. Like a normal edge-triggered interrupt, as long as the receiver (the remote processor in this case) "Ack"s the interrupt _before_ checking for work and the sender (the mailbox client in this case) posts the interrupt _after_ adding new work then we can always be certain that new work will be noticed. This assumes that the mailbox client and remote processor have some out-of-band way to communicate work and the mailbox is just being used as an interrupt. Doing a `git grep -A1 mbox_send_message | grep NULL` shows 14 hits in mainline today, but it's not 100% clear if all of those users are relying on the benefits/quirks of the existing behavior. Since the current NULL `mssg` behavior is a bit questionable but has some benefits, let's: 1. Deprecate the NULL behavior and print a warning. 2. Add a new mbox_ring_doorbell() function that is very similar to the existing NULL `mssg` case but a tad bit cleaner. The design of the new mbox_ring_doorbell() will be to maximize compatibility with the old NULL `mssg` behavior. Specifically: * We'll still pass NULL to the mailbox controller to indicate a doorbell. * Doorbells will not be queued and won't have txdone. * We'll call immediately into the mailbox controller when a doorbell is posted. With the above, any mailbox clients that don't mix doorbells and normal messages are intended to see no change in behavior when switching to the new API. Using the new API, which officiall documents that mbox_client_txdone() shouldn't be called for doorbells, does allow us to remove those calls. There are two differences in behavior between the old sending a NULL message and the new mbox_ring_doorbell(): 1. If the mailbox controller returned an error when trying to send a NULL message, the old NULL message could have ended up being queued up in the core's FIFO. Now we will just return the error. 2. If a client rings a doorbell while a non-doorbell message is in progress, previously NULL messages would have been "queued" in that case and now doorbells will be immediately posted. I'm hoping that nobody was relying on either of the two differences. In general holding NULL messages in the mailbox core's queue has odd behavior and is hard to reason about. Hopefully it's reasonable to assume nobody was doing this. As mentioned above, it should be noted that it's now documented that "txdone" shouldn't be called (by both mailbox drivers and clients) for doorbells. That being said, in most cases it won't hurt since the mailbox core will ignore the bogus "txdone". The only case where it's critical for a mailbox controller not to call "txdone" for a doorbell is when a mailbox channel mixes normal messages and doorbells and cares about the txdone callback. Specifically, when you ring a doorbell and immediately send a normal message, if the controller calls "txdone" for the doorbell it could look as if the normal message finished before it should have. This issue also would have happened with the old NULL `mssg`, though. Signed-off-by: Douglas Anderson --- Changes in v2: - Instead of just documenting NULL, introduce a new function drivers/mailbox/mailbox.c | 82 +++++++++++++++++++++++++++++- include/linux/mailbox_client.h | 1 + include/linux/mailbox_controller.h | 4 +- 3 files changed, 85 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 2acc6ec229a4..c1e7f6b1fe72 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -161,6 +161,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_received_data); * The controller that has IRQ for TX ACK calls this atomic API * to tick the TX state machine. It works only if txdone_irq * is set by the controller. + * + * Should not be called for "doorbell" messages (any time the message + * sent was NULL). */ void mbox_chan_txdone(struct mbox_chan *chan, int r) { @@ -182,6 +185,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone); * The client/protocol had received some 'ACK' packet and it notifies * the API that the last packet was sent successfully. This only works * if the controller can't sense TX-Done. + * + * Should not be called for "doorbell" messages (any time the message + * sent was NULL). */ void mbox_client_txdone(struct mbox_chan *chan, int r) { @@ -222,7 +228,7 @@ EXPORT_SYMBOL_GPL(mbox_client_peek_data); * mbox_send_message - For client to submit a message to be * sent to the remote. * @chan: Mailbox channel assigned to this client. - * @mssg: Client specific message typecasted. + * @mssg: Client specific message typecasted. Should not be NULL. * * For client to submit data to the controller destined for a remote * processor. If the client had set 'tx_block', the call will return @@ -249,6 +255,28 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) if (!chan || !chan->cl) return -EINVAL; =20 + /* + * The mailbox core gets confused when mbox_send_message() is called + * with NULL messages since the code directly stores messages in + * `active_req` and assumes that a NULL `active_req` means no request + * is active. This causes the core to call the mailbox controller a + * second time even if the previous message hasn't finished and also + * means the client's tx_done() callback will never be called. However, + * clients historically passed NULL anyway. Deprecate passing NULL + * here by adding a warning. + * + * Clients who don't have a message should switch to using + * mbox_ring_doorbell(), which explicitly documents the immediate + * sending of doorbells, the lack of txdone, and what happens if you + * mix doorbells and normal messages. + * + * TODO: when it's certain that all clients have transitioned, consider + * changing this to return -EINVAL. + */ + if (!mssg) + dev_warn_once(chan->mbox->dev, + "NULL mailbox messages are deprecated\n"); + t =3D add_to_rbuf(chan, mssg); if (t < 0) { dev_err(chan->mbox->dev, "Try increasing MBOX_TX_QUEUE_LEN\n"); @@ -277,6 +305,58 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) } EXPORT_SYMBOL_GPL(mbox_send_message); =20 +/** + * mbox_ring_doorbell - Client function to ring the doorbell with no messa= ge. + * @chan: Mailbox channel assigned to this client. + * + * Send a notification to the remote side of the mailbox but don't actually + * send any data. This is typically used when the client and the remote si= de + * of the mailbox have some other (non-mailbox) way to communicate and the + * mailbox is simply used as an "interrupt" to notify the remote side. + * + * This function has a few important differences from mbox_send_message(): + * - There is no concept of "txdone" for mbox_ring_doorbell(), even if the + * controller itself would be able to tell when the remote CPU saw or Ac= ked + * the doorbell. + * - Because there is no concept of "txdone", there is no need to wait for + * previous doorbells to "finish" before notifying the controller of ano= ther + * doorbell. + * - Because we never wait to notify a controller of a doorbell, there is = no + * queue for doorbells. + * + * The above properties mean that calling mbox_ring_doorbell() is the equi= valent + * of re-asserting an edge triggered interrupt to the remote side. If the = remote + * side hasn't yet "cleared" the interrupt this is a no-op. If the remote = side + * has cleared the interrupt, it will be re-asserted. Expected usage: + * + * This CPU: + * - Update out-of-band (OOB) memory shared between this CPU and remote CP= U. + * - Ring doorbell. + * Remote CPU: + * - Clear doorbell. + * - Read OOB shared memory and act on it. + * + * The remote CPU will always be guaranteed to notice changes, even if thi= s CPU + * updates / rings multiple times before the remote CPU has a chance to ru= n. + * + * Mixing calls of mbox_ring_doorbell() and mbox_send_message() on the same + * mailbox channel is allowed, assuming the mailbox controller correctly a= voids + * calling mbox_chan_txdone() for doorbells. + * + * NOTE: For compatibility reasons, doorbells are sent to the mailbox + * controller driver by passing NULL to the mailbox controller's + * send_data() callback. + * + * Return: Negative error code upon failure. + */ +int mbox_ring_doorbell(struct mbox_chan *chan) +{ + guard(spinlock_irqsave)(&chan->lock); + + return chan->mbox->ops->send_data(chan, NULL); +} +EXPORT_SYMBOL_GPL(mbox_ring_doorbell); + /** * mbox_flush - flush a mailbox channel * @chan: mailbox channel to flush diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h index c6eea9afb943..e3fc11e42c58 100644 --- a/include/linux/mailbox_client.h +++ b/include/linux/mailbox_client.h @@ -42,6 +42,7 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox= _client *cl, const char *name); struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index); int mbox_send_message(struct mbox_chan *chan, void *mssg); +int mbox_ring_doorbell(struct mbox_chan *chan); int mbox_flush(struct mbox_chan *chan, unsigned long timeout); void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_con= troller.h index 80a427c7ca29..36648fa7b6f3 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -19,7 +19,9 @@ struct mbox_chan; * if the remote hasn't yet read the last data sent. Actual * transmission of data is reported by the controller via * mbox_chan_txdone (if it has some TX ACK irq). It must not - * sleep. + * sleep. Will be passed NULL data for doorbell-only messages. + * Note that doorbell messages are always sent immediately with + * no queuing. mbox_chan_txdone() shouldn't be called on doorbells. * @flush: Called when a client requests transmissions to be blocking but * the context doesn't allow sleeping. Typically the controller * will implement a busy loop waiting for the data to flush out. --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47143288515 for ; Sun, 8 Feb 2026 04:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523450; cv=none; b=dfK4X+nj1Vntg+jdvXg8PyLGcaonfcsgp3kYH5fwjedWXIl49UwlAlt1Rm0l8ixse0871eRAFd5aJ3MSBpz2qqH4977bCKuYX319adP1kIemdicg+qegHzIgvzNM9y57GC9nkyENZN09N8yPJb/GVuhvhNCemCIVzab2c94h6g0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523450; c=relaxed/simple; bh=SwRM9LTR2QUOgaPTFf+sezPTqw3NitYdjpeSCcdcW0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NJ/9ZPGmbXOymMgSXEl81uL2G1rfJKS3U50RtBjdoHGlBbgzC2DVFzVOKhF4JXczisPZEt8EICkHHg7lNM/quiJjVdxWEoTFmbCBDoXcG9hZu3JqCcS5OqQat4Ioty3xVJHKHmLt0JaWpYhkvLjjMlHM4SF3p70C6kEr0WBZVVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kyVk2OVv; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kyVk2OVv" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-124a1b4dd40so6661218c88.0 for ; Sat, 07 Feb 2026 20:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523449; x=1771128249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eDmFN1mVg5seJ+q06CZhGBYTZV2fU/sK9RfIemTnpDU=; b=kyVk2OVvyLzq7C7CaEbShgB15EOVqQp6qAohRkw4VHSQQW+Cz3Nx6BsrzQgVCe4lVZ 1BFBmn6dtKwG1T7HWaaV1n6+is0n776L3xioyIWAP8drz6bI+t8cSEtJzPiJmGX7j1Hk XNUsD0lfnY8W58dUFYSvR5W2EQqB5c6dit4cM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523449; x=1771128249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eDmFN1mVg5seJ+q06CZhGBYTZV2fU/sK9RfIemTnpDU=; b=R5T2f/fI71A8lFxKUc1iQGu1GeBCRjxa52dIDqsClE4ZTa9mysEnau54OygBD3VY4y e9BZjtdFoa7vMDtbp6Xrpt/ORbk/NxRpc9RtK6Hgnw7Um+dmUHsrWOpYhFnjqGT/IRhM SGmb93q4BF1RLjL2kbr46EUatZEukJduDVbfjHNh1e4kFFxDUhAkaKcnRDjHeT5UawHS JZtZyc79RB7MBYayk1gFbEmhwbTYbOtPHcpQ0kUefAKoJUTB33bfrF7WNjGrMlShh7Cc 1LJxlzr/RlJsnesJBkQiBO4TWZajkSeXDHYpyD4cBV7ejCDC6MIei1naATUB/AxBHrtT l/EA== X-Forwarded-Encrypted: i=1; AJvYcCUQ2L91ocuGEv6wHAq6WpIJFy2Z4jSuQen9n9aTh7qnmlBSS+/QW9gN9oosYgVHJoM3UnTWZu9MOijjJEM=@vger.kernel.org X-Gm-Message-State: AOJu0YwhEdlr5KNdwRqogVCu6k2kNvnNO0A3M79f+auEylHLW6al+w3b 92ePx0PebvF9h3x/8DOAeVi6qeR9o9y7dP0smf7jNQlmkoBbxdsBxhoVi2x6E07VgQ== X-Gm-Gg: AZuq6aKeoZYYKu0a/H1TFGwmQ9ie0KwbWsZVBIqClIlhbpogoBYgjeoZdcPGKlSlZHr 6YnqUEARWugVjSORY3mgnoIEJP8o+a0uhR6+TCbB64hbkeeTlDsIbUmv5q58kmakn5qG5p4HU5Q tgWiQT4/vbSLm5B2wBqVl3NrPBIeZ9E78eMXTOFQFTtEeIFAvhNZXPf1Ow0ij7nYZ5bAGib3l2n sc81f2cvFmBpJDBlcn6jKLERAI06+q6dg4rqO2D7tkeA8ZS7OFAsHlTLk5u2Tp0E3/zqVRf8tm/ lJlys/8yIyGghFRjvlqf6rVvdtOtKGi9z3Qw+XkK0TrJgw88NR20fRAn7ELm2AZT3dJc/CSu6sl aiQZaG12ppYM502I4mPmYn7hsco2hLbHsDKTWb6Z8bqapqDwm1knbtSZSHtj2rBh4T+OQ9IbyDJ ZefqI9IvLBkBjbnq271Kf3h3s4A5jCNCBVPD+sHgQndPmJ9oolrr0ynlKwBadI3o+ksxGsen4= X-Received: by 2002:a05:7022:6ba6:b0:124:8d7d:2d63 with SMTP id a92af1059eb24-1270401e29fmr4298462c88.35.1770523449409; Sat, 07 Feb 2026 20:04:09 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:07 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org Subject: [PATCH v2 02/15] ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:24 -0800 Message-ID: <20260207200128.v2.2.Ibc0c2b7d0280f23aecade13c49dedc2bb7fdd7a2@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). From code inspection, it appears that this driver only ever sends NULL messages and thus the conversion is straightforward. The only change is to remove the call to mbox_chan_txdone(). The call wouldn't have done anything in the past anyway (since chan->active_req was NULL) but with doorbells it's officially documented to not be needed. Signed-off-by: Douglas Anderson --- Something seemed a little fishy in this code. The code seems to be a _client_ of a mailbox, yet it was calling mbox_chan_txdone() which is something mailbox _controllers_ are supposed to call when their "txdone" interrupt goes off. It appears that this client even reaches into the mailbox controller and confirms that `txdone_irq` is set, which should mean that the controller itself signals txdone. If the mailbox controller is actually signaling "txdone" it should ideally be improved to not do so for doorbell (NULL) messages, but it won't matter much for this client since we only ever send doorbells and don't care about the txdone callback. (no changes since v1) drivers/acpi/acpi_pcc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index e3f302b9dee5..3d240ecd98f4 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -106,7 +106,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, /* Write to Shared Memory */ memcpy_toio(data->pcc_chan->shmem, (void *)value, data->ctx.length); =20 - ret =3D mbox_send_message(data->pcc_chan->mchan, NULL); + ret =3D mbox_ring_doorbell(data->pcc_chan->mchan); if (ret < 0) return AE_ERROR; =20 @@ -123,8 +123,6 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, return AE_TIME; } =20 - mbox_chan_txdone(data->pcc_chan->mchan, ret); - memcpy_fromio(value, data->pcc_chan->shmem, data->ctx.length); =20 return AE_OK; --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BBE2D0C62 for ; Sun, 8 Feb 2026 04:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523453; cv=none; b=XZzHxkapIZCHEs0xwrLwUO/C3gHrJn+qYJIicMrP24Bq5zpAWogFmIBoeKGLrJKVIuu2i1E/fpW7zRGddbv7rGCzMGzL/a6BxckWrgdkfWiquEatimcejuMYYojF8+OtuIO96pdyQaPv3IWzAujH3PqXeJijZ6Ve1SwF4vps6Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523453; c=relaxed/simple; bh=JpvsAwKddEADXQxk09Dwny3N8gtaPchBx889GIKR2NI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MYohxcRBC0UEfds/rf70BvQcWTn+rCmicdr3xP6h7Q4e5e49g3HY1xnJw4gDKZzucqMe6tJgVwLTe3ctjfpbi/eZSahSVaHo4Tcnxqrfi9YS3Jg/mbDy2N+eFZXQTrHULRMaMuJuuzHjuFiPsCNQuIJfD17jp7KZg+RdN6m+QZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O+29arQk; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O+29arQk" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-1233b953bebso8196850c88.1 for ; Sat, 07 Feb 2026 20:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523452; x=1771128252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z+bhAXarAsiDSi4QI3h1a+wfZmeyXg3FMQowAFnpxGg=; b=O+29arQk+1P7++u+ZGydSNTyRVzibEtJv08Cn3LoRy3PjgGSzKi+HmP121viEZXO4z s/vXxY9WQwb0SxYP2Fo3edwdMGwGEi7+MDvn741aZHp4jkAVGLvu755RfBynMBjyKJLQ muLlR6Ke6R2U55ROx0fdFiJ+z0iva2okVmuMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523452; x=1771128252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z+bhAXarAsiDSi4QI3h1a+wfZmeyXg3FMQowAFnpxGg=; b=pP9u+vlAXouWZwA4iZtqRtgaWaHVpwcrsSWOJN0jmQRs7EBQxUX3t4Fp7DHYL6Q5LR HhAy7BWqILZpWev2+gQ+NSYPggvEObiJaUAcy62G/ENs6QJAwPIKD++4awh7EGYf3ZPw 6ed9ofZX1NRf8PmVcuPnzclRmJF7WTwMqQgrTolnwkAl8i+BN0UfgWrfNf+j2XgPx4dX wsljf1HbUz+eNFAkjzXC2jxsPfXaU4pxzhXnSJ8u5lr75nf+pZSfMeBDTLec2phbYN+U 16C3XACH01MD+WJcK1Co5ch2bm9GkAZf5C9GgdXIGYsCPc6/t5fbtLkHo6z8DvAJ3nDO AonQ== X-Forwarded-Encrypted: i=1; AJvYcCX49Hu0FkACc37TIrH79DFGfPbbtl2qFb85uOAibRribFMVE4E5Ud/sHLs43NIhEs8Ih1l9bM6KlTQ+YuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpWibKIGYLn8Easeisqu+HNkml3r0pSslqYMHBE4kKEj5PMnQP rFNbYWdeNU97gV2hJN5Gl/eYKBnDNUpuMKL/anANCllkhg5zKZ80tiYJdKkkcBehZg== X-Gm-Gg: AZuq6aJR4OC3W0lHwCaLA/uJ91jc1rzG7e948leYXvwKob4NrkmXWTLsJjBjQXMSA2C em6Vu7tiBiaee749unqyvq5qIzwnIHhHgPn0VEtD2iIXRIt9tKpvfLtfMA6XmOmPgrAUwWXINSj 82O8FjPbqhHTV1CYVm43zsR/22ahDV6GeqLE1ZkSywlG3nsHNch78pUZxcAXze530FDlcdzK3iN ApI1+pSrwetUP+YTzg7cXs8JQlFVoK9AQph3fodpZtAUSOO1Atr55uWENjLlxl1sz0hU5LeYqYN QUkYw1yOWTHL/A2x8mTS4f/W8OewhKjug9kSyQGhekzpz0AAMbAkLxHJzF7n+BmObjdf1WAn/O0 mN9HdTwtRgkQQrByOJN/9dZeVc8OT3Y/OilDw4ZsQZw7N4cmjwodNNH59zdNZ0iaztcrJsbIXe0 3bAcE304G3ilX9FJUnHjlsrHQT67K+CCdpMJba3PhM/fGsXdBxaxK62u09tQijvi8EPPvTkYA= X-Received: by 2002:a05:7022:6ba3:b0:11b:8278:9f3a with SMTP id a92af1059eb24-12703fe4606mr3754776c88.8.1770523451893; Sat, 07 Feb 2026 20:04:11 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:10 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , arm-scmi@vger.kernel.org, cristian.marussi@arm.com, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sudeep.holla@kernel.org Subject: [PATCH v2 03/15] firmware: arm_scmi: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:25 -0800 Message-ID: <20260207200128.v2.3.I4a01e1fa771c0b1ea7e35882784e4b7f8f33f65b@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). The mbox_ring_doorbell() explicitly documents not to call mbox_client_txdone() for doorbells, so remove the call. NOTE: this mailbox client appears to send doorbells and regular messages on the same mailbox channel (smbox->chan), so it needs some extra attention. Specifically, the new API behaves differently if you ring a doorbell while a non-doorbell message is in progress. I don't believe that this is something we have to worry about with this mailbox client, though, because the code was calling mbox_client_txdone() after sending the NULL message. Had a non-mailbox message been in progress, that would have marked the in-progress message as done instead of marking the NULL message as done. Signed-off-by: Douglas Anderson --- Given that this mailbox client appears to exercise the mixed doorbell/normal message case and the behavior there changed a tiny bit, I'd love any extra scrutiny on this patch. Thanks! (no changes since v1) drivers/firmware/arm_scmi/transports/mailbox.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmw= are/arm_scmi/transports/mailbox.c index ae0f67e6cc45..c4561441ac2e 100644 --- a/drivers/firmware/arm_scmi/transports/mailbox.c +++ b/drivers/firmware/arm_scmi/transports/mailbox.c @@ -324,7 +324,6 @@ static void mailbox_clear_channel(struct scmi_chan_info= *cinfo) { struct scmi_mailbox *smbox =3D cinfo->transport_info; struct mbox_chan *intr_chan; - int ret; =20 core->shmem->clear_channel(smbox->shmem); =20 @@ -338,12 +337,7 @@ static void mailbox_clear_channel(struct scmi_chan_inf= o *cinfo) else return; =20 - ret =3D mbox_send_message(intr_chan, NULL); - /* mbox_send_message returns non-negative value on success, so reset */ - if (ret > 0) - ret =3D 0; - - mbox_client_txdone(intr_chan, ret); + mbox_ring_doorbell(intr_chan); } =20 static bool --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB0F21A92F for ; Sun, 8 Feb 2026 04:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523457; cv=none; b=Qj2A1I1N1wd9v3nlDaUhmTEUscLslYthHyReTPa7heKNcEPispRYgLW/OUa2KUucpCOX8dtEjI2O0bMAHY99X6QWpRTURE/tSKg2q5IsNydkSYAiYyGwons5gLq8yS/WvNw4yKu6l/HFiJbsZ87+WBs7iFf6uwVDCIMDhnck7Gw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523457; c=relaxed/simple; bh=UJz87G8Y0ORGtLcqOEYAMn9sU9uvOZ+v8CVug7VuQno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dRdRUNtdviUAGUBpVtyImc1aSYnLrFtgfXPg4Uk61NM47/ZQSTFGBntS4sgs4rQCZWE9gcFbqOE4LA6roQb9I+bgEQbCads/joC7ApFrlCmXsyGziD8ssQAw6+Ai0vA3AO3hlzcg8bmdUPAYMIIfuZRXYk+R7V/N1tTMJv2MML4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iXehSACG; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iXehSACG" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-124a1b4dd40so6661325c88.0 for ; Sat, 07 Feb 2026 20:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523456; x=1771128256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2/KpZ57tlZKoE0FDCGiBRE/ls/IVaskc6zgTU7KwZw=; b=iXehSACGZjep02AMRdzcgYDgu4ep4TXAuml/Doe15MxltaY9NJZpgDazxp+Cct8UCk vLCLhvi3zcltPHNP4BgYcaFkIaMs/CuP8WVY8lR+h+OqChkGHaV0HQ0IgvoMCe5QYT5Q fBM6N/HPcT/dDfBkIn0sWn+3BQkwLW1YBouSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523456; x=1771128256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2/KpZ57tlZKoE0FDCGiBRE/ls/IVaskc6zgTU7KwZw=; b=mGI6jUwh+flhGogEBKtdGdRYVNGWAoxqaCbIJNi/kq80oTkL24jsfx0S3ASh9wOHBe /qb2XYncfpu/wa0q+T38UNXznVziTM5sYafgtj7kw7ThLumIW54/J0Hdl8eeewkEdJBw 6b5JVGfhtE0Jm6D3SZZYWUC5G8QQvQFiyVhOS4LAZ8g9xudoUvl8DyqKSjOqCswQiYXD /58QirhCcn6G0LCyspq5k33sYC+SVu9MkdozFJSpe8TSu24YIX/AJ1x3+LVielNUK3YG GFQy28c3OrmkVQFKBZGXb+Pw3M0STTnHnLzEDiUmHU9XNL/zakLN+jZb3DneVP+peqRo 6GdQ== X-Forwarded-Encrypted: i=1; AJvYcCXuGMZxeT2S/2+yZkEZ3Y7hqv1ocxZMdUNOFAnZ01uT/wwu7qlInelnC9o/6NI67V6p3mgENvMfhruO9pU=@vger.kernel.org X-Gm-Message-State: AOJu0YyR2tqJ/wzgMDzdNzCuGe1TgFaNwvG+/MBRGn5JzYYWcRNdDCEg ZiI7lPVX4yEG4hh4zhMTT64V5/MQ9bl4CBqQ4V1dpX67BV9Zy62kpzzV6s0RIE2EZg== X-Gm-Gg: AZuq6aJwjAj/494945yrlNfXENs+9aJx7fKJWaAc6+GFUu9JHSikA0SQe7A/o8ePjJk k70TeaXRkwhT0aa7iPQhwmVvYmPzfK19Dm9dOn+wwfk80tfHlGq3frcewJPWQXbtCerOxEHmLNd s6sWzsihQVgnrG06UoF4l6hIda2+5PHrE5AI5sVpuVt2fpj+Gy7WGmcNxgFr5E6cXV1PzpxjENz SbgD2P7iVVpVuFXZChn+dIzfgVUWPD/ydylj73iXE/TQZeX+ofFXN4+z2aRV13LGtcZ6WISlBnb hD3GusQsRH3r9MzJqK/0wmumg1v6OiGTiQ/kYatmFlVUcEFolmKEhNSMGgQTMh6m6iBzcww8cr6 CK8rijQFaTk76z5x7h03Kc5BFvfIyVxUtODRLdjM0lU23i/yA+X2749dp7CQYrLwWKQdTUeGuk/ hIygyIPcWpcNh3GySeCVXGzdMEPe2mfU8HqGDhy6puNN6xrggh1L450NUqZlJ1zp+s94Tsgrw= X-Received: by 2002:a05:7022:24a0:b0:11a:335d:80d3 with SMTP id a92af1059eb24-12703f9b5afmr4420639c88.22.1770523456083; Sat, 07 Feb 2026 20:04:16 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:14 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Frank.Li@nxp.com, Sascha Hauer , festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/15] firmware: imx-dsp: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:26 -0800 Message-ID: <20260207200128.v2.4.I4a571bdd344dfe8e819cfcba37ccd0ec29284e49@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/firmware/imx/imx-dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c index ed79e823157a..231e9f841226 100644 --- a/drivers/firmware/imx/imx-dsp.c +++ b/drivers/firmware/imx/imx-dsp.c @@ -30,7 +30,7 @@ int imx_dsp_ring_doorbell(struct imx_dsp_ipc *ipc, unsign= ed int idx) return -EINVAL; =20 dsp_chan =3D &ipc->chans[idx]; - ret =3D mbox_send_message(dsp_chan->ch, NULL); + ret =3D mbox_ring_doorbell(dsp_chan->ch); if (ret < 0) return ret; =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC2C2293C4E for ; Sun, 8 Feb 2026 04:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523460; cv=none; b=jdGxTGtugLtIN+NLoq0/q2JZoYwksW3Ompt+ABhogTBvRdwF/5WoKPgK54dFOrOyQPZi0nuAU4OP+KzVlSjcOJDFHWQYEMkQ9oAVSLbZyyi4GWoRLIcfPrk3WY1r8sVn2f+XRRwbQUSkshzKcJzI3EAltNuCP5grmi2eVRNT/vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523460; c=relaxed/simple; bh=1nmI592gVRRRNazHbetRGlWzODgcIIgosQMVHzt+Rxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dqMIqGTJP6wthCLGfs3v9HYQMo3f3TFdxPlUsbecvk/KYmkpP8Ij3VELflv+ZlpeH1FkBOfiJRTGhtxgpJVWas/YzRVo6Ao6goB+Uuf2SJ744syDl37Gp28VRkV5ZSAgWpF1bsG4v5dJoxnT5uXHCPaFqMnHAqFGUSQJURX3dG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=oCR8ysfT; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oCR8ysfT" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12460a7caa2so2240013c88.1 for ; Sat, 07 Feb 2026 20:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523460; x=1771128260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FFjxbTsIX43trF9X6h4ASWW0dwvPNCEYejqKDfbp6FU=; b=oCR8ysfThUl6jfjHJNvGseJMVp+YJnP4S8SaBHpt/WCNr0KVD0V1719Xg3eC1QwT5s JtMK5uiwC5HRUssqD64YaUSMRWUggMcJqVJDhzzIz1uyCBABOc5zoRd+vwMmBlbAfLQs Vv88xYL3EKobLos5Tmr+XD0Qgts1l+a99k3N0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523460; x=1771128260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FFjxbTsIX43trF9X6h4ASWW0dwvPNCEYejqKDfbp6FU=; b=SIEt1I082My3zRM0y9I6t0Ve6rwlOfdAlB2dKSZEYaCVZOrGTR03mQGsZJMuyCLSoO ENwbyAAUNm/LnVLDEAT7wnPs15LOsv5LQ2rQngTpX3j9N5qzQyO6kMpzz0JJXeBpn3Kv m/Q9sPIONU+3qx1VVBK+yzhOrOpH2/zyPVmeVCa4k1pZ9WjDjagSQvDirvBIqRHkznlb pKjG+OuUFXKvLTC6amzrPjpEOQg+68usMf2FRFFl09LfHSpIqBq29SATa94xTYppMkAp qBv/C5adF968wq2b0cw9tF6K3WCYp1pAVYDa/hIC7kTFQQcoLufg+7+l0P2dmAlpzVLz mKBw== X-Forwarded-Encrypted: i=1; AJvYcCW7X84mFpmkgIubt6yUqV4lnZrfDnLDf+jAap7J9VyxpHLatYYuqBJSiNB00R3BifwMQUKd2861MFdtqA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxG29/hnhWsNKkmjZRhuGrNf1glQdb6LPFcfA3UKGq2rmze+tcg 6oG+B26yDLiCslXGdeKBlF+LlTWLvTUqKblz30qpMAMKSImMVHsfc3ywfGYrfhhh7Q== X-Gm-Gg: AZuq6aJiiCBgJkHsAqwPgvp2pRE0aT/+D6L3/64e+WTyJxpDAINmcOrD4Q90+ZVrn5A evCvO1Cd0K2mgBYNcb0HOfNztUR7P6fI8SKgcsossBKt8coMVCdVLo9l6EMCSSsaBZlJBDqvT87 6Ge9o/Kt77SwwhXLpOvCyKm0GGy9Le6+XYAbuQns5dyl5kou4OxNexJODhRLVHiyLOlO9xyukSj yBXafUWHHSXzG2Pp4myrXPLPHLguV+U9y2Y4Iz2vRvNUSiaeUCfupVUYPgfQX4HBIyKqNr2LvZu Hd2tHfGZYNC+EtCF4JnwYqTxKokIsrrcB+h1cZt06mYM4TjQykzx+WpaUWxzi4CHmu2ERFgL+4g G1EK/OM8c/f7R1GCuk5KG9eAQV0Jj9rZGxO3sspiZUvW92YicS4Gne2U3GAEXARbzjmCestBwXE fb3k2uZSQNBuI7rhsh/efydkRCtGisFINZLqp3HaAE/gWoVql5GOt+uysX7QC7PQcUyQYRy9Q7F aLux/slmA== X-Received: by 2002:a05:7022:250e:b0:11a:2f10:fa46 with SMTP id a92af1059eb24-12703e569femr3754818c88.0.1770523459863; Sat, 07 Feb 2026 20:04:19 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:18 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, robh@kernel.org, thierry.reding@gmail.com Subject: [PATCH v2 05/15] firmware: tegra: bpmp: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:27 -0800 Message-ID: <20260207200128.v2.5.If1255977439f4cdbb3193f73f90a784566254f15@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/firmware/tegra/bpmp-tegra186.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/tegra/bpmp-tegra186.c b/drivers/firmware/tegr= a/bpmp-tegra186.c index 64863db7a715..c45ea66aabfb 100644 --- a/drivers/firmware/tegra/bpmp-tegra186.c +++ b/drivers/firmware/tegra/bpmp-tegra186.c @@ -84,12 +84,10 @@ static int tegra186_bpmp_ring_doorbell(struct tegra_bpm= p *bpmp) struct tegra186_bpmp *priv =3D bpmp->priv; int err; =20 - err =3D mbox_send_message(priv->mbox.channel, NULL); + err =3D mbox_ring_doorbell(priv->mbox.channel); if (err < 0) return err; =20 - mbox_client_txdone(priv->mbox.channel, 0); - return 0; } =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E65326461F for ; Sun, 8 Feb 2026 04:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523464; cv=none; b=SORgtAGgCkvBnTIDd+ZoIiMaoIjGgdm1cc5RHFq4Y67LM1AmoOD8MnBSEMAKegnP0EI1pzw9bTpWPOKQecHF8r7nska5bdNSj88peBbnospZJYVMcdpiPG4e/MEnCsuOVLKMSGXBfGuy8lwmsj4mp9eeNi7bFzM9t+S9puecwYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523464; c=relaxed/simple; bh=txr719J4cCWYPpjOEE0+kHQ4fgzzKgIW5LxC1IVkmss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jx4vzMnnX2CWErUZ4Y9v2tdYjh3oDoLt2qI78wNKQTKcqlzXIN9uTsJFm1e5U5R1dZ1ffiFs9sfzEewGhWAOj2bSeOP65JMtKH3z3F93DmyMx7YupsucacVzt07Einnev4Iz3SQMWElYnpTB2ITLNPTb7OZsG52VEFUvq7nVpJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iEv+8P/j; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iEv+8P/j" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-124afd03fd1so2657356c88.0 for ; Sat, 07 Feb 2026 20:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523463; x=1771128263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=61QyqKZZDzPUAhRYwKHV653iYzO49yK9wZp4QzIFCTE=; b=iEv+8P/jY5QVeqwPFq7Hlb0/hs985UPHPnDLuH5gK95M2hDcLEedU+pa+HoVWAKXWG uKU22orPd6wbYv0kuXt3vsXPwuQJn+c4xLANx1hwAotlVRTV5p6evG5enBQSo5Jo3swQ gQagTMDvwTwutdXjK6lSq+JRYIRBbxtjT74zY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523463; x=1771128263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=61QyqKZZDzPUAhRYwKHV653iYzO49yK9wZp4QzIFCTE=; b=grt51E7EkFqGK0eZC0RyjOyl003fifGNW3gFfj/zx4CHGyZXf5zN7gRcg68OymYj2+ MNJN6k+2UuCEZRPvyDAtTRAqOXIdPP8nCqAkljVaop94Q/EKpxhB945blEYiCRqzW3V7 4AyAp9Uf2NuTSZF3hkQJUtq4FhbWU0ATKJc5SeLu9pECM3+e0BX+dCynL6Xzwj7G5uDI VPZcxD8sUmXSbaMJOd36DzuUExHPN2evjQKG2F1/tqQPxP+C7GO/GxSraWg/LNyCKBas vW+ppv+KD7IfTli1FlE5wHm2+b/JgTPMZZXKAPg2niUyE58uCPS+HMA9JYPrB/PeDVDI h9dg== X-Forwarded-Encrypted: i=1; AJvYcCUzhgAvIYMGY0QsXfSpIcuZMTSMakIFvts0uhaow9y5Ms7j+ir0S8CRJOmkNoZA3oMaKBp4xZ4p3p+iDJw=@vger.kernel.org X-Gm-Message-State: AOJu0YxeIlvlxNAwhUUiNWnEO+dQO3IJm9o2c1idiS92rnhz43MOiIp7 nTgdH+A9AAXpBo1+JYdUPPskMx7GwguubSAxYjwyUeD7fxwaEXe+9zs3yR1hGUR11g== X-Gm-Gg: AZuq6aLK+VGMI5XDmpNWee+4q9CIHoJIlA88LAFeF6nqPBfmZQzrRhOFzdGaKQ4It5/ B7U1vMX6qFSbaeatuiM0Nsqf9Vx3vEulqsfk6gesW7QYK5fCzJzwdoCnKtnoOrpU7HA0nP93y7Z 72+ynmFSbsZJf5IgrnvcTd4ODQTk47J9lVTlV5QqnRylpSurfGZjQ/T3B+9EmNwuaNvhvUrwBag sAqrmG0gUR9j5YA3GcBFiCjp3rymXEyCQDrZHdYhsyfzHRaFHWxv88hUl3kbsfcNhqXISshKbim bGYReLQ3huwoAO5LIT2CO4tIJcwAE6an0baE7SVwKUQem09QaX7AzUWzoRKC18O7ej0zV3ABJfO ZvznVmbtUM6+4I5UKFiKVoSiOyaVs/wFXg/mGecZu5ajq4votFQ1OZozlEWvg9Np4PQks32mo8y HLvBeksnPHciEw3DhOawhn/njxNi+RD+/qVO168ATF3ft3+bRblYAp7F7mLazLrgP/vO4f5JATL SB/DcbWjg== X-Received: by 2002:a05:7022:24a0:b0:123:3488:8969 with SMTP id a92af1059eb24-1270402f8f1mr3692667c88.45.1770523463523; Sat, 07 Feb 2026 20:04:23 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:20 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , linux-kernel@vger.kernel.org, tglx@kernel.org Subject: [PATCH v2 06/15] irqchip/qcom-mpm: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:28 -0800 Message-ID: <20260207200128.v2.6.I59d887fd641f70e40950b7545ed31f193cd1c270@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. This client didn't previously call mbox_client_txdone() and it appears that the mailboxes it hooks up with (qcom-apcs-ipc-mailbox.c or qcom-ipcc.c) have both `txdone_irq` and `txdone_poll` as false. Presumably this means the client was relying the mailbox core's quirky behavior when sending NULL messages. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/irqchip/irq-qcom-mpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c index 83f31ea657b7..5b79d95bf1fb 100644 --- a/drivers/irqchip/irq-qcom-mpm.c +++ b/drivers/irqchip/irq-qcom-mpm.c @@ -302,7 +302,7 @@ static int mpm_pd_power_off(struct generic_pm_domain *g= enpd) qcom_mpm_write(priv, MPM_REG_STATUS, i, 0); =20 /* Notify RPM to write vMPM into HW */ - ret =3D mbox_send_message(priv->mbox_chan, NULL); + ret =3D mbox_ring_doorbell(priv->mbox_chan); if (ret < 0) return ret; =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEDD293C4E for ; Sun, 8 Feb 2026 04:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523468; cv=none; b=XAvHPzCKt/xux9uYPvolB1gmjUrVtld0boyBKM/M/9+UAmM/+bFn6O7mmD8MDpdU80zw10Tkk3SfBNp3TcDC/wslS+1e62Agn44mJzqM7KBpO+iJzWhacBXdjwZZAF9HCkp0tpIVXyWq6Vv2XAyywp/1+QN1jK4CMLiu9qKe0z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523468; c=relaxed/simple; bh=JqdQec0rOs+m0iMnaYW4aaX9cdF6Y7D2liUU6inn8OI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rW9FrMHdp6noqu+ce0mL7k0otoL/zXFZ9p0a3jZvbJvdQgAMlL+bvVXvoEKngz7mP9irkLl+SCcgaeZYZaeQ4eiJk7inwL3d6X+3FDU6OAiFObmVf/cMCdXR+A2NpEyN7GUq9NBm096xrBLRRjEKBAwnqJ9EncbyVbT27pd0/1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=icwSfZBu; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="icwSfZBu" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1249b9f5703so2505518c88.0 for ; Sat, 07 Feb 2026 20:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523467; x=1771128267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fnzf7MWfTqKt5CULJ7VuleY2h15FU3dGyOhiOi+Ey4Y=; b=icwSfZBu22HlS5tXNTzpO1kYfXysJE6J9CPTdSc5odA0xJXRhD4Ti55W/Q/KtO2O1K ida1AZXg4G7OeIoy3oLl6iatR0I8X1yqtgw5mpuU7nZ5262qKXN6L6Lco8kFraq3L+fR tWtYLniMfXM45iLkDI5UiS1ZVu6UkQs0yDhf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523467; x=1771128267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Fnzf7MWfTqKt5CULJ7VuleY2h15FU3dGyOhiOi+Ey4Y=; b=nqPRfdRxstfGiHjRfVYfxtrCqhmGtQkczraJoAFozREJYG2Mz0HSEB98t8iW4weLfG DIHtV9WB41jEMqUmGcXCDFRomgfNW7jTrLBVHvaXbLm5cDrho8jnmEZ7/wn5eBDen2tr VQe/ixjK7s3iJcX/mIt7cPO44ikzw0A6tpTwHhehDxtH3hTAkbO7Vi/05dME5LGmpr3J M4IEEjZ53jEB0frE1Xa0AelT/SlSK6J9vlPqZ2yul+kU4hWrcQNPfY+wSIfnUex0NVsk zZPrEYIlnV/uNJWjj4HpEaCcedRRfJfLysm/XOf1iJIkjoCEA147J6qK/n3sfi4OkoXX 5oYA== X-Forwarded-Encrypted: i=1; AJvYcCVwa62rknjGq8qa8/kr8DMyGwlqpwYgveqi4ahaqpjmFL/wLDhUE71XL4ShWT25krplKani4e6FK9Os8mU=@vger.kernel.org X-Gm-Message-State: AOJu0YwOQ407wQd35ch528niTDUaYV/unHh2XUtQU6JuZ8VaP5OjGoaS EzG4Mp+vkOdlgp4+2cxXxFI11LTvv65hkX+1BGZiOQBttcBJc/xxmffaYrghBPhfDA== X-Gm-Gg: AZuq6aIY1ijVfRwZAVeQGAfdHgfPd7ybOXdFyzYjpCIVOyN7soTup7iiAxlz77i3+YY cU6oZxZ9I/Wj5f18xgNwRs0U/oAm37KoS7XYzlPigWjSIYAfs2hiqMmh3jKvUjAPDgV4cIozu/X zLXWgwQCioVNwgQFjRKnAqDORsLBCjKpBMnE7aL4XjWkgcVXn8q+ecXLVVoliZWwEGaz7dr6Xt9 0m7ZSABat+J4QjhmE9Iv2jma9zc6FDvI11KmsQtahabwPBqSjWZqsGJKfh+HfajbG9BfnSHZVgJ U7Gw4aKUYZ59kXtYWf97oWkDFEagFVaVpmUFPF26hTpi7V6Rdu7LYiZMIjmhS/5EQioMczvMb2d ca9P4dWbllhBlEsgdZBMDwcYmD7s3L5VBAceTeZu56M8U85QPr4ltulnJlhY7c5GJ22FYYMSR+r TecvevtEeYCXrKZxje+Igs3xfDjmpB401+4+403zto/RMQHYq8yo39hyB9u1fq8dlzq8UTryo= X-Received: by 2002:a05:7022:7a6:b0:11b:9386:8264 with SMTP id a92af1059eb24-12703fec496mr4040054c88.41.1770523467431; Sat, 07 Feb 2026 20:04:27 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:24 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 07/15] remoteproc: xlnx: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:29 -0800 Message-ID: <20260207200128.v2.7.I90e87b8f7d6ddccfa0372bb96d196d2d9d7685db@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL message on the rx channel, so the transition is straightforward. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/x= lnx_r5_remoteproc.c index a7b75235f53e..de807247e9c9 100644 --- a/drivers/remoteproc/xlnx_r5_remoteproc.c +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c @@ -245,7 +245,7 @@ static void zynqmp_r5_mb_rx_cb(struct mbox_client *cl, = void *msg) memcpy(buf_msg->data, ipi_msg->data, len); =20 /* received and processed interrupt ack */ - if (mbox_send_message(ipi->rx_chan, NULL) < 0) + if (mbox_ring_doorbell(ipi->rx_chan) < 0) dev_err(cl->dev, "ack failed to mbox rx_chan\n"); =20 schedule_work(&ipi->mbox_work); --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B232C21F6 for ; Sun, 8 Feb 2026 04:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523471; cv=none; b=PmCOxjL31sJKrcLusp3Cez1d5MGJ4bU8+XwwGeosTuSaICsRO6CvJGcW3ZJe5Dw0nvidyr6+fBcCs1O4lV7ps+j9LUog7vjE9swqefzN+Q8FqofmPH+xDtHYdsDncknB/t0vnywicyXROr10Mp9Nv9BnmUzPhzcUrB2qoudezjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523471; c=relaxed/simple; bh=Orbri32xHuv03gpzS9cVteJyifmJeQFoiQPoqhr6j3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XhUl83MCZNKtp9yKvwV0N5bcJiUXYR35oCTn295wRLFKKY/gh2xYHG/P7yCW8GlUFBSbFzFQe5hP1xXJJU3uC+bzW2pABLR7nYDFn1Thcb41pDrCpo5S27GX+1fya/ypHvGGDrtEvau6DQI+MCapMc6YfAm+FsP6QkPqwtSHXZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Dur/ZpZu; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Dur/ZpZu" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-126ea4e9694so7465361c88.1 for ; Sat, 07 Feb 2026 20:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523470; x=1771128270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VyL5nxa/XcZnD8gJCLsBtvC6TjJ39RzGnqL0OD02oLA=; b=Dur/ZpZu/xLlOINpbgtdb0mJdPH1RNQFYiLpqTVxUlIH1wHWRTnNkAcEZw5XWF49WG RKJcB7pZ7HMX+q92sa8wts9P4w5uU9++bp4U/S6Lf0EueAr+FzZhN0LFy8Zi3Nuz5oeK S4jTWgqgXBdy+PaZKiao5HbW1d3eMn904MuvI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523470; x=1771128270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VyL5nxa/XcZnD8gJCLsBtvC6TjJ39RzGnqL0OD02oLA=; b=ClQuEEqxqe2tb2NX/flGcI+qXSq3T8AJV+ns4q2SObCE8yKsILsgU4ycyfh+CIs78X gGO4Szis4CO0dkMSPJgkCXUwiIU9xmWw2aHe97fQ5QZpmkYcPM0312ibMky5YKcNBA0i MH2fi/YKizzmGu2eJQuutyQXtlTIs1uHgJl3qMZ9sUS6moaBrvwrG9frxH9mlnYVXmHa qhl/sJY74vUajmcOCWpDsLJ3nH66ewkH38sBwEGx790SPKBwzCqw38lGsxhyfXwmpXNW xYXYTXUE3ovmmWjxWq+WI/MOmxy7doRTUKo5D0wx2cwPnnNjxM2LnI97VqpzqLBa8Lcj pXDA== X-Forwarded-Encrypted: i=1; AJvYcCUAiK/8hD/I9VoFlT8byVeXb+ABLKhQbIdGYgIwfzf0Y+3r7LIcevU8SpDpu1Wx+L3LQk7pHEa/UOTZYDs=@vger.kernel.org X-Gm-Message-State: AOJu0YwIUuRGADQEbwH7kexFndC9u3VO1vsFAQcqqHxs6MSsrT5tHl4M 4XwAhAt4tNQaZJPOPlwdg71fYh0WdwUVScdKPGGG3O5w4jz7XzIKA6h1pTmax/ck/w== X-Gm-Gg: AZuq6aLkLs6G4rTuul3CymZbc2+VEvo8FU6bA+5IZkcGRemfuBrjfJMiRnFtuNYNsq+ vaZgQi7H3Jodl+uB9t1BmJD4GO+zOE3PsC8XPToiwRGgb6A8LO40RgzH+xENxtnoSVeAtZBiSqM PoYh+fEri6IDP8ad/96AtgN1M02wfIbw2gPhvHRVU7PhEwPqmp2hbLZOM1BftmOp/jG0SrNEW51 yAzoiagffnTxj36AAN2Z7JjeR6LQPzbY/PVCjF70SnTmtUQpwGa2YXQwDokrBAzEobgF6jGZWi4 UKr3hkE5sR8FyEkoVFjWeh3dh3cGOIY34kBtMvh0HvRpJX0aKMER/MFx0cH0e6O6z+qW+BrdoYV pfczH3i5dE2FAiqUodsL98A71BWHP69wnYlFhA0OsLZxkrGmiy3IL0PaA+Nk6poWYMgBTQSRAg2 afmoA+aa6NywjkxCJhDufWAbpnjIkvQoYTq110LGuqxFmVeYdazUS+6t6Sb+touQcy+Ipapkc= X-Received: by 2002:a05:7022:6ba6:b0:11b:8161:5cfc with SMTP id a92af1059eb24-1270401e496mr4235997c88.36.1770523470198; Sat, 07 Feb 2026 20:04:30 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:28 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 08/15] rpmsg: qcom_glink_rpm: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:30 -0800 Message-ID: <20260207200128.v2.8.I700ba93ec437db5100c0076941d8470344ea9995@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_glink_rpm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c index e3ba2c63a5fc..4cb9c36adcd4 100644 --- a/drivers/rpmsg/qcom_glink_rpm.c +++ b/drivers/rpmsg/qcom_glink_rpm.c @@ -197,8 +197,7 @@ static void glink_rpm_tx_kick(struct qcom_glink_pipe *g= link_pipe) struct glink_rpm_pipe *pipe =3D to_rpm_pipe(glink_pipe); struct glink_rpm *rpm =3D container_of(pipe, struct glink_rpm, tx_pipe); =20 - mbox_send_message(rpm->mbox_chan, NULL); - mbox_client_txdone(rpm->mbox_chan, 0); + mbox_ring_doorbell(rpm->mbox_chan); } =20 static irqreturn_t qcom_glink_rpm_intr(int irq, void *data) --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E167C2C21FC for ; Sun, 8 Feb 2026 04:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523474; cv=none; b=Pbel4DfbSfPr0RocSA641p2vVKFQ4TGEHZDoZ3U/nXf2uzr8U0+6PzIfnMF5siiz9PlNidKrHBXaIr9mK122NN9ltO0AlyriXjP7G9x+/066L8Lebma5aIX7Jbvr8JtolF6tjVuPZd8/mjFS141rg+neozO6654DgvAVfjvgXbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523474; c=relaxed/simple; bh=XFJ6n04/sV0RGWx96Y0deEcCBY9lYJ4aO3gH79dt61A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XRvPSm6RAIDZqQq2hEdXIqbCdB/zxqlLMx6MlwMxOS2kCOxq43LSBawvQFy5TiCPVz0Rio+bHsGkKueDeeyu4qvTV2yN5llxzIky1TRNKHeyjtiqe3I6N+DHWruquJTZ8bWT419FQ0pWCaEwsi07qFlpVE5t9LwEVOBwW2R/0AY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=hgxq1nOq; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hgxq1nOq" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1270be4d125so4010304c88.1 for ; Sat, 07 Feb 2026 20:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523473; x=1771128273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xeTwNqi+XJ/8HLrMMWD9b0KlELdWsXmDwflMIt0OPRI=; b=hgxq1nOq02T0QogV3fyJQfW79F0GIaC8H/BZ8cCtW4RhigiY0Wn1h7UyP1o9ysdari Gs34ygCFmkrJsi+ZuC+a6NFi0vwuwWdV9zXOeOXtaH3IZxRF21p/jnIJFBJXWN7JdAq2 bAIMxaa4bzvi4Gj6UNhWWsQe8apDV4/pY4FKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523473; x=1771128273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xeTwNqi+XJ/8HLrMMWD9b0KlELdWsXmDwflMIt0OPRI=; b=Uwug7d9vd6+++BQE31LXk6c6P0V48iInfnhM7MBzwTuv6DNTwhgPUdKWToz3y7Z6C3 ibWKVNhtv8exNlYlknR6I/nYOFnp9+kv2bglnVfxS60a+v2L2bghbZppQKZM0u7PnTF/ pJm5Kz73eEDow4u1CNXQksm9KQixvmZL5cEV/Q/EdOXrCr+vhZu40Gl7Jxek8xq56rPE IWQ0m5AFNFWyY1FYZZ8aOKH/DOdsAN5HcvRVDkOEuKAjczjC01Bn0lnVPsxhi4cMU8+1 zN3pMk4NlqHEDWXm6OhcBtlBD88d/jj33xBI4PpEAJYQVO3st3B4kSsJZz/SYWWR5oKS 6mmw== X-Forwarded-Encrypted: i=1; AJvYcCWanh00EfX1nUdj40+9SjBMscld/jiCF9Dcod3RMy4LAaw0r7SJXoyzh+ko6x2aWLzhBy9PEpadW2jQM9o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/M2akfeccsX6QwauPDbQBUeAtTItVzKtXIn9OIEWKVl3YEXln iwXkK7re1dbI56Cfo1FANT1s9nNPrJmyVjKxHkldfYKjacv8W7YjGXWbi7jn95HHkw== X-Gm-Gg: AZuq6aLAkHCgyTBCsT5/q8m3o4wKiduFAKTwP4kdAgZZPV/qU5LcsauRTPsvY2AoOkV H7ZOwLDbVyDdrSf0d0gtHUILq+2qSy3fkGvXtNgqAX0R711E86Flra9/gafKixlFFeZ97MP4gHZ 4C3qQIaxSBaIs9obNc41ZfCekij0i+fLy47Dc6/gbKtV+QMBja3dW86Zsa08YNv7qBPHTS8hz9m BKLKiF6UXFTVf5iBbA2xSYnx2afArjOgRbzzFYg4ZpXYB0scMlVc3T9C3Qr2CWbK73gRfvNLJSV 82PszvO6/N8EoPNDycWB6XGqXKG+Z3CvcGZkc4G7w065JyZfPauIsMzNRqexU1KMmBwgFK6bxtt 9KaRJsLEfK8uYO8HD53Uq2dZ24QKUJIPnIFs64Zyct7CXHwL8OZpQneWrw0UrzUPyUdHPU0eL5B ZM+qrG7RQKXmohbOZHYuz1P6giaTgEACqkWt9vH+eLFfNDov+9Ez74ZMqeRG+IYXr7/sYJMi8IM c7DqF737g== X-Received: by 2002:a05:7022:7a6:b0:123:3bba:fc4c with SMTP id a92af1059eb24-1270407387amr3855209c88.38.1770523473030; Sat, 07 Feb 2026 20:04:33 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:31 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 09/15] rpmsg: glink: smem: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:31 -0800 Message-ID: <20260207200128.v2.9.I6973a32c3fcd6d2edebdd6fd868fe0a046420ed5@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_glink_smem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 7a982c60a8dd..f2a6d94e72ea 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -197,8 +197,7 @@ static void glink_smem_tx_kick(struct qcom_glink_pipe *= glink_pipe) struct glink_smem_pipe *pipe =3D to_smem_pipe(glink_pipe); struct qcom_glink_smem *smem =3D pipe->smem; =20 - mbox_send_message(smem->mbox_chan, NULL); - mbox_client_txdone(smem->mbox_chan, 0); + mbox_ring_doorbell(smem->mbox_chan); } =20 static irqreturn_t qcom_glink_smem_intr(int irq, void *data) --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B28293C4E for ; Sun, 8 Feb 2026 04:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523478; cv=none; b=d+JY9jZmou/WwDJE+r881wW6Yy7IG449Co2EYqXuCukI/t5O/FuO82GKY2/OcayAuRNLJqvGrc/sWlvE4WLWiNqeQhzNVBjPZtrSFl3x0BLp2ZmF7wtMUOuaGsfivmZZWGAZa2k71YLywg8N6gsH5Rh1JHZ8kpewn1V2dn6YC/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523478; c=relaxed/simple; bh=SAIOYHmewH8+YpnZCmSgyUNdDUrB0z7/bJKOh98QEn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tYsya1Nu6vG5kYlfcQSdmewm8Pn2kw5j/3VJxBADQZGIiBJIbQVUrSfibkccHkUGSRnr+fXqiMMRGScsmoFcwvw/s2RFWgn4b92HYiLcQQRg6bVag82/94Gwqt6YJ6qvf6h0Y/u23GaTwAFCTMhDgmHpvJJNUpw7SwuFFXrfeP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Cj3qW0yz; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cj3qW0yz" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2ba64b5a53aso340619eec.0 for ; Sat, 07 Feb 2026 20:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523477; x=1771128277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rhq2fvDAB+z0+8+dqvd5EVUWoDgUFedDXtHNQ2aZ3r8=; b=Cj3qW0yzM0kMFj7sHk2DuAmK/FBfwUDIrELDp3q5Pedyt6x9lC81zMsAJXBkiXTmc7 QmDEyVqdLqDb8yxHFi7n/3fhMMdPj7EylK3EXgySiFLOJECiTZ4qCWz6EnAXEOQ8pEwN Syv5+CFuMSTJMx43yaHKCTOWJoM2X+ut8+KGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523477; x=1771128277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rhq2fvDAB+z0+8+dqvd5EVUWoDgUFedDXtHNQ2aZ3r8=; b=BEs1H2ZcRGLX7/mFJ9anZCowHmR/7FKWdRP3wJZBvYfMuP4NxYTliP3CBPPEtZSLN6 7KdbYKtBE4KuuMUkoozcozatjlFK+bgEzasEanbVo8hGnoja9BoD4MBOT4fmvkFR+eTN 4v7o8EhnVPOB60V3ipAPWf0OSaAZ5xgeZ227IpqTdsoodMlWmp1BgQeOnAQi8FfXg46y tybNeVK8brIVANtyoaS6ITgy7r95IB7MqvV+zx+B3680aPOB8laSMecpEk2aUeKCDJTq Sbrs9Go+MEfbidlTni/SMEO/YUoqFPxFLwQZyJO4TLIlM1tfc2B1m6iZ1Tx9o5cuZm/M 7XlA== X-Forwarded-Encrypted: i=1; AJvYcCW6xazXi0LJBJPl2s0wu12hitvASSjYp7pL/ZVzXVA0/XyKssACUHMPYhOnNg/YnIZU3JuARepQUjSsqqA=@vger.kernel.org X-Gm-Message-State: AOJu0YzTTRMp3rHjQ/lgJAlw89Do29kDHvbT16Qf6Gm7gN+nPa8q97la kOTQRFe9uElhVHYpJ7zZKNYItAVkWqVs8Ym4tCalXQ9JrXmymlER53Ye3V/SMJKCCQ== X-Gm-Gg: AZuq6aIDGmySSG1K4irPh3Uaoc3GUhKajXdjY1JIk63Y07fUMJWx79WAB5WJJkRfpmt Q5Tnes22bMoWHRl468YG/9Uk+wbVj/XCjLlbJuxXg9jNPt9y/iWBhw8pbS7aYmmLnjVFMix2WvQ TXDLgRwmAiLv/vV3MfSKVB+ecvOiMRFOrxHh1dtzkH4Ok4X1MAoy3VU8v5cP6oreYPhN4EJK+D9 1A2x/5txyJqX8FREMY4lpOdS8CxWbMsiIGmQ2xgaiu/Irhm6dx4m4k6tAHN9l4Qc5ngyVc6xVx7 B0SmtetsZxM5K014dbEtTLBsfPgG3f4o2reN8seKW9xjPLgLDH2O8UOTh+AtUtqHmZwyXrHGXuc Nhc7dcmou+lolsvJht/j/vCmvffFjiSFessYsdnfZvOgnQpDC6XCRTLWgZt2xgJJYAZ/shj5ERe v2s+KhghB4ER5Gwm1PNWhGG6AwzKb1z0TE34HNR+3gvMrP9RooaZhO/6LboI72BoTyqf0kot4= X-Received: by 2002:a05:7301:38a6:b0:2b8:209d:5983 with SMTP id 5a478bee46e88-2b856833715mr2948032eec.29.1770523476783; Sat, 07 Feb 2026 20:04:36 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:35 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 10/15] rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:32 -0800 Message-ID: <20260207200128.v2.10.Idbe327f5b4ce65a284b55033627d0819e2fed21b@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Also remove the comment about the only cause of errors for mbox_send_message() being if the framework's FIFO was full since we don't queue doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_smd.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 42594f5ee438..afe1177d092e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -371,17 +371,10 @@ static void qcom_smd_signal_channel(struct qcom_smd_c= hannel *channel) { struct qcom_smd_edge *edge =3D channel->edge; =20 - if (edge->mbox_chan) { - /* - * We can ignore a failing mbox_send_message() as the only - * possible cause is that the FIFO in the framework is full of - * other writes to the same bit. - */ - mbox_send_message(edge->mbox_chan, NULL); - mbox_client_txdone(edge->mbox_chan, 0); - } else { + if (edge->mbox_chan) + mbox_ring_doorbell(edge->mbox_chan); + else regmap_write(edge->ipc_regmap, edge->ipc_offset, BIT(edge->ipc_bit)); - } } =20 /* --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F182D3ED2 for ; Sun, 8 Feb 2026 04:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523480; cv=none; b=ouUWP+6Lu1pOCBmGE0ZwczTa/2passb5J34vvhfeB/ICKj2gN5Iq6p6A+Y99WOAMfGzkFt0BS+buddqwwNVdUuVvm3KEwtk0zrmM8+bvnAFi/S+jXBSBu6uedWxLVxojNiXUVIQIw1oeBiFAl9DjcEk46AMs+mnerjyNqWrqdBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523480; c=relaxed/simple; bh=Ml7u4mN4bbcyRsGnR1dXDGVW2z9xrPW4BKd3PDwYeFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WqA1teZGuBm+UZUqLCmizFbs83uc++tNKC/r92CHcwv+GI9LsD9kSs+aDyUP5btxHRq8CbaDpTIQYETVwCX9ww6t9zusmOCUb3oIvaZZRuZyKPjOG5iISDEJOaELD99ynBqHtZQdUdhi3Xj9vetYgJeNOgSP9N/CGJDPw5cAdq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JewUcUnO; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JewUcUnO" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1270ac5d3efso1416100c88.1 for ; Sat, 07 Feb 2026 20:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523480; x=1771128280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=11XHbq/AgNOnUOiTdM58KM+JxnC6t9mJBJNAw1b2Iyg=; b=JewUcUnOUJvHBopFK/XurjrDegdUJJgs4OXsrcu29EC7h/FpvRwP8ar9YVf0D9Sxib CMK/bYKy7cZt4+j8+okDWBwWpOcI/D+GIKdsoB4HRUfqO2U2ZgKPnZqqLjY6fuEUmuLr wxkqE6nd2HyJDVGB03e/+t7XuLs3XSJ+4wkqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523480; x=1771128280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=11XHbq/AgNOnUOiTdM58KM+JxnC6t9mJBJNAw1b2Iyg=; b=iZ03R5KzjbbK2kqfq4EocIZcR2mrGfkeQ3Dj2PVgzvDTML0gtCUQVx8lM4K4+uR24a nHzCeKyePEIWc6i5mqJlR94VK9ja4u3UJyogVqLXBZWDNplXmapaEdJRiMcbabqguUT8 TFxBzb0955tRraSTRNegWWEo4xnMwWdtj1p+g/z1a/JsxNgNMg8uPXLs21Esig2jhGgZ 6LGUsL2vGncI9U6DHtHwJaNW4JGzR06eXeWfRT61miYp5B4AeVIkdUYSsH3RKa9ph5ME 5LBwbdVj6m3E4/JLyzmaqKqZaQxwbA+hs+TvCEUATKmyW+Ob0+ngIJxi+cFfMSDZIWJT 5Anw== X-Forwarded-Encrypted: i=1; AJvYcCU9zjc975xL4l5DkEfzK2kMq47bpw0k3pKmgze6prt0jsjbjcTKjZF9ogAJqrb7MHhhgd+ikXx14nfF9x4=@vger.kernel.org X-Gm-Message-State: AOJu0YxM8fzp3yMC1qZJjV5ynchs6TwicNS3pLbz4LHf7+Slrmq1eYrg zmlrUAMkgJH8vZrd+im5BvxaO2hCJ+yjzDU4fvb8QIN0Nj35gH6HUOFbGUOrTE/b6Q== X-Gm-Gg: AZuq6aK9HD6GCUtdhkorkg6ILNhDT1BbfEfTSE4PE2rDiAvVipZxLW2+7BjIBBvVG3d QOx0BJPsnKfz8Gopc/8oj5wCVwIvEfBH3KhVrt5PE2P79TNlEShKOmOVS6iWefPwf0gWteVIOTq WP8TE+7eP5hP+xkM1hGIc8MX+i9ANx8uAg+Fr0kIJZuAbK0ekWHDKzRx97T8RSOnLbuq1LQanmw t+iUrQeNUly5HDh+BRF66oKjbYGzw0c588YLFTLmxQCxf86GXXjZVmhhftDiR5WCOj5aklO807D vLfBmpm8a7YKHVco0/17YdtMj6p6GyFPCCna/8lBrTW8Iq7pjiRh0v4aUC5LMZsG+5PHdt+cl6n QGv6Nd0U0pa6AYy63rlDM6PixRGQVAy+w21S3iBeFLGA3HnDeEb7iCMuSQRx5OvOVCF5OnOam9+ vo3p/XOUFMlqb0+SfRJjn5KHlCLwc0SAbqAsLRDhDaXSYBsc6VBZOXZ1JQEWge6RuKOCA5KC0= X-Received: by 2002:a05:7022:660f:b0:11b:baa5:f4d1 with SMTP id a92af1059eb24-12703f54339mr3576543c88.6.1770523479996; Sat, 07 Feb 2026 20:04:39 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:37 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/15] soc: qcom: aoss: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:33 -0800 Message-ID: <20260207200128.v2.11.Id882cb3027e9d3a948ae95dfa6d310e3b29faa38@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/qcom/qcom_aoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index a543ab9bee6c..2ecab93239d2 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -97,8 +97,7 @@ struct qmp { =20 static void qmp_kick(struct qmp *qmp) { - mbox_send_message(qmp->mbox_chan, NULL); - mbox_client_txdone(qmp->mbox_chan, 0); + mbox_ring_doorbell(qmp->mbox_chan); } =20 static bool qmp_magic_valid(struct qmp *qmp) --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5042D8364 for ; Sun, 8 Feb 2026 04:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523484; cv=none; b=Pd5agUwZME4RE+hwZfWH6GUug+63IbR4me7hgAB8iOvWeELreGf5gHMYMjFHQ5HPdE+Mw1G98eIumDGIftJJ4musfHpJkmF68Zt3dmDEUtUwHBIXJIegeOf+8sdOXMBYpAqluwEGp1C4S7atUUXiAfPbObjGQvhd38954q9CRDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523484; c=relaxed/simple; bh=SWVYxfhi7Dcfk51X4QoCD2Wwg3Cgacsl82Cb6EpvNzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kFWkqXZrQu8d58KKgesdSzBuRNKkmrEpSlFf8hls+TktzwdrV8i22nbrEaW2VPPmppL15FHWpFGVcAMRtqHvA+igj8rysU0Yqw9p1bsJ/njjgfaOrDXKKsQM6pI7DjCjSgFBW43NHDz2i0FzSkA+CAsXiO03Obg1Z8XcDuS3JVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YJzv1Ite; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YJzv1Ite" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-124a1b4dd40so6661851c88.0 for ; Sat, 07 Feb 2026 20:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523484; x=1771128284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=naSNPUx+BkuxDTEggI2WXPi5YGqGZjA04QrJqdp3Ffw=; b=YJzv1ItecSZj/XM++k0WON8Zpv7MwMyjEdJv+REOZWW2dCys8Ck6hJn4JfVs5U5/t9 zb2PQ3wzmHFnEHmJwyvWI26vvjWsL9OtRyp65YwWAKWPeUfIHC7In85AnygwH/+i0wir LchdmbilJ5mPD+O9+snBvkJfoVy2vA4Ku/pCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523484; x=1771128284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=naSNPUx+BkuxDTEggI2WXPi5YGqGZjA04QrJqdp3Ffw=; b=jSK1w72WDKsIM3i7jvALRVIeKfxPU1m3WsQG6kz7GMjSuPpqXouXbpo8KUlj8IZYjw 7a5fAkH/dfv74meezDGaWoHSaQw4+4GCXrUxsT/6ouwBWN6rQLzjhyEt5zteuO9W4Pko immnRRUT2sa38c5w+EAfZLlTfVphRwvvfdfTdyjQyqBufrUok8xV9m27CCRB2TTjeZL1 UNw+oTwG8+7ZDMMilyBLm5gNNQ8PgP4gW/8s+fKHO/VcX7ufO04zDfp/0t/8YMCUVWli yLdOnMUjEW+VFCfYqOJgZ1lOsUNEPCXZzT7n4sVAlWTaq7HLLr//oktfd2X5K6Hj1mpo qThA== X-Forwarded-Encrypted: i=1; AJvYcCUachgqkiq91FTeNyVQK4uIljgOoId/5KuJ5SxZhq1k/oAiaLcVHHvUPL9mmQ0UPXF6K+FTZAegqzxGWbU=@vger.kernel.org X-Gm-Message-State: AOJu0YzauNUhGX/DNxFmItz/BxdhhI8nFKRZD0LkhL4OWYSuTZlogFbd 9wqyMxHrVbPl29fH7t53IyCO/pFcB8rmHIjRL29Vja+SmtNiXuJtXi4L5sQrCCDJ9A== X-Gm-Gg: AZuq6aJkvIgtD0lgUMNsqkyZtR2aHAy7GWLjAofqM4kXGMgeahLRBVtq+2RbkrWrfEx VMVP87dUM55o0h4eDg3E1GwQm4+OIIdQRTGFTFbCyiJJbQV9p/sZT/axisMzSE/CycpF01bni3B PML98LU32PL260KUkGDSJoksY1oofJAQMN5yclOO7bT2rmivgaPUVmi8jPppi9567Q7HZkHVMod URyEXoffyuutaH3Q+eVWSSRoyRVwprN7RO/Bly1LjZyt2qH/U/XTVxC6z2ZuQx6jmAFHBGOj+kr cT42arhEWYc85jtQHqxTc1FHJ17nukWxeaQgEAhK8JEDQG4moFvaJmApGq7Vw2NsZVp2tklktr6 Q3TkMy6mBGF0NZiO9U9J5jF3h8Vq3LSGjBim+DInCbk2Zs7rj9AvYQAPglp/qKzsqXUvZyodrp8 bDB9mK9rrpACikeB1HgoiAo3viOtZj4712fpnuyVr3xAurFuoEVDW/AA7CxY3apwV9Z5M0fTF2b +WKq1eD2A== X-Received: by 2002:a05:7022:2507:b0:11b:9b9f:426b with SMTP id a92af1059eb24-12703f9b0e6mr4093184c88.20.1770523483646; Sat, 07 Feb 2026 20:04:43 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:40 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/15] soc: qcom: smp2p: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:34 -0800 Message-ID: <20260207200128.v2.12.I4e47dc2356edbaadac7298ddd65dd649d9b5ee16@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/qcom/smp2p.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index cb515c2340c1..139307b66a47 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -169,12 +169,10 @@ static void qcom_smp2p_kick(struct qcom_smp2p *smp2p) /* Make sure any updated data is written before the kick */ wmb(); =20 - if (smp2p->mbox_chan) { - mbox_send_message(smp2p->mbox_chan, NULL); - mbox_client_txdone(smp2p->mbox_chan, 0); - } else { + if (smp2p->mbox_chan) + mbox_ring_doorbell(smp2p->mbox_chan); + else regmap_write(smp2p->ipc_regmap, smp2p->ipc_offset, BIT(smp2p->ipc_bit)); - } } =20 static bool qcom_smp2p_check_ssr(struct qcom_smp2p *smp2p) --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7622C21F6 for ; Sun, 8 Feb 2026 04:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523487; cv=none; b=IyDtHEY0UoXPAK29npHYpeZZsBrHHmiDP5NcKALvmaLscIfUCRr4CFfSyJac1vFgchhVUDQXnH7oYs9fZ971A2406XfgHl47wQtKgmPSR2dVYixgENSRrkU8C/AuX7dO8Rv2i5Erek16AeivLjXxDZbdPbUjm0OanE4LmBSQk8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523487; c=relaxed/simple; bh=G1nudZutYj6d9MNzox0nHfR1iYoPe3imRgM6voCKXqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hkjZq5xJwxkbolOeLx4v3D46DRwDjVBTW96J0Xfy+ZLA4JvqlaYCDOMGHg7snLk5tJuNpnlelm21jGTRuECLdJbqVuxsvALh1AQupRjcg+jQFYe5U6RGep6GZ9F7S+x7FD0GqTYKRGowSPPwXraQPgFQFUeUyJo0kBiQut7K8cQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SrsrWVWE; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SrsrWVWE" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12336c0a8b6so967667c88.1 for ; Sat, 07 Feb 2026 20:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523486; x=1771128286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZDSoxJmUAFCsFOozdtCEnUcIaNdh6KfxLjvN8lzvaUE=; b=SrsrWVWEQ4GV9FKiXWl0C6wpWS+xgTlrd77iq5c+tvlRIM9yQ/Qfd5F+wIB12vSUKC hSFyrqZxuQPjb+BmU0k5rky7expVU48+o9v5Bp79TlfaTZjgR7/BvyLRWyRu2dPwNHog hp3pu8HDPQhLdeOUgxkFcR4Xv8FRRkako++YE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523486; x=1771128286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZDSoxJmUAFCsFOozdtCEnUcIaNdh6KfxLjvN8lzvaUE=; b=E2K+gyFGZ+JeIh3kFPpeObC5RpT/QaKw8C0erTPzUU8qZmKGXtwEklKo97aCDGMfAz xN/EOZo+Tp1Zpr6LHMPfcn2BK+tTgstdsWGWsWZMnTAKd/EkoSykRc8qu3TfoG5E5tqi Exj69zhUPy/wWAuTk//fgb95hQOKyiU0aHudJFYno74aupxgKg+/XVrIGCKvWwVIaM8D hYdvwF17L88WwgELH9hDF684cTMqIqaI9vvpEVc3YlBq0rU4TeLrW9hqsJgj/iV02r/i vaXG91iiCJg2Z8YZgR5Ox+RhpNN7GKvmC6AqGSqU3+wxB9x5MmIeP4RTWvmy+gMWpWl2 jfDA== X-Forwarded-Encrypted: i=1; AJvYcCXoz5tcOJIMjaP0c5EP4qW9j89WlBPwxHQaSWFb+nJMvyJsRbjbnmd3nbLLOSp/IZrLTItx+k3E12Zv59w=@vger.kernel.org X-Gm-Message-State: AOJu0YxH05hg8v9oEWftfXEnw8YdG/8zywJqEW8gL+pLfqNUm+H4N97W oHJC3Sm8UsQUc47iGZfLHM8VzQOLvAhAE6uXyUyUEsvwY/4hr5j00MkjJ97sroOZzlLNCqU8Yet +oXg= X-Gm-Gg: AZuq6aIfq/hp6EwKlYelqcZkrC2aka9TBiml8VQnF3k88JBPfLohu4cgskdLnJji8un /pfNzIpU6GfYij54qhW3QU8vqfjrKTg+nsLNQct34hc6LY/2w6qQQwu9CMUT7saZUOgu1k7t5ec 5bFKcBZanfS+z2HdYs02+xqWiEoOkMzClXLvuXLdp3zXDxjCh1gp3FHIxSwCgGOUrsydkcjTT65 TfmQnZp1xgafZrRGoRDJiy/1YXHeZ96ivRyDxokCUkG6ufnwEAzJyIMD+pnvgPIhgF3rxYA06QE Wv1OnJ6Dw3SHhMeSfQP6gEiAvVDS2IYcweCEaCv55vywjAgzmfvvittl7paV++vdB0o5SHcHcog 9PkK+wgX50uqmz9NxzLPQ0XY9ylXP3HmFUJMkx90/E52kDGnMO9dY5HChrRUsvz9qsrDnmPZpYd MwquFf8EXqeivCZjEpZ3VF/+zN5DgNDwiTkBwd2yQ5I2N6JSKyMsyQgROFu89qsDzQW1lDiv4= X-Received: by 2002:a05:7022:301:b0:122:345:a948 with SMTP id a92af1059eb24-1270419f523mr4166171c88.46.1770523486146; Sat, 07 Feb 2026 20:04:46 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:44 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/15] soc: qcom: smsm: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:35 -0800 Message-ID: <20260207200128.v2.13.I18ba5837ac5c89cdd3531b6b09a2ab24a95912fa@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/qcom/smsm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c index 021e9d1f61dc..1e127678fd9c 100644 --- a/drivers/soc/qcom/smsm.c +++ b/drivers/soc/qcom/smsm.c @@ -182,14 +182,12 @@ static int smsm_update_bits(void *data, u32 mask, u32= value) if (!(val & changes)) continue; =20 - if (hostp->mbox_chan) { - mbox_send_message(hostp->mbox_chan, NULL); - mbox_client_txdone(hostp->mbox_chan, 0); - } else if (hostp->ipc_regmap) { + if (hostp->mbox_chan) + mbox_ring_doorbell(hostp->mbox_chan); + else if (hostp->ipc_regmap) regmap_write(hostp->ipc_regmap, hostp->ipc_offset, BIT(hostp->ipc_bit)); - } } =20 done: --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDCE62D5932 for ; Sun, 8 Feb 2026 04:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523490; cv=none; b=DQUZnRrrZYg0mvMx+MiOigy5tpHm5Ee+9TXw8JFexTcbdnmxfoc4sRrv8C7laFLeCUbEx/JWElcwtkCsmdbZiuMmNLoWIffSaPSpkaxpKc/GbLGnepR3AmxI0EcdTZH3M8S2VPRR+GYTOW1cN7GQwmxsVAQtFHl670YCKv/s3Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523490; c=relaxed/simple; bh=XJo3+dQeXOoxks2zOfR04dpyEwj8mxQt4BQYHZrVsYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kF33yPzbRMF2dfSn3WHv0ibV0EZJR9JhznbKRCFEzWlkRKltV/k49hVeu/pr/YndW5Tnn+fCwm8LW7Gax/Nq8wgyfdv8baiiO7s0h4UYBKlplKIC63S+/bDsvTsaJU/vFtJuVFT6hWSsAYUUUpX8HqAj2tehh5hJsNu0OiVHy3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Q8r83b4w; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q8r83b4w" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-1249b9f5703so2505638c88.0 for ; Sat, 07 Feb 2026 20:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523489; x=1771128289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SlwiE2/GmO3LoEyvjlAxI3xvPLTPdJVhsPeNQZFpN6E=; b=Q8r83b4wx+qi7tDsfkK90ZaFUZLyJc18cElyiffMcGZuta20vtjm0B//03+CBhp+BV yblbaA7DFJJ25akQc5fClUj7Lho4LitH4vzXcEXnHuxVkgIyHcLPXw/EuW/1rvTXlClE BU3T+t4qFJTaIteOcGwKh0XjFrQ9v7fyO9yPY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523489; x=1771128289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SlwiE2/GmO3LoEyvjlAxI3xvPLTPdJVhsPeNQZFpN6E=; b=UBkTi7OCTAXhs9eZJv5s30YEZokE10ewfpAxjQmUhAiyB3ljqJSbLOd2n7AIA2fCqj Cmv0fbFrYZP+qX75yCUOULM8iKecUq+XMmdNqEweyuGiYijCWW/zWolLpIyCm8g3tzC/ EVUW6L5DQxs1FF6oktYo2aJD8bFXdmTYxKrEetGpZkdvaJgI6wkREvRclD8vEiNh5Ks6 v3aF7+qhkC7QWDw3ma80QSudsmAwzaVBb6Im1CbzymjrkRY9805Q0dv4FrozklyaBQKF mn2CFyQmHNLSx1EilcK4u9IxhzonxTlWhCh2625cC+1iV/wOXfwBCZRrGyq3nwaNX/qa aA+A== X-Forwarded-Encrypted: i=1; AJvYcCWXzZzkCv1gyYsyTHj5ymtie82u0eCuf6vuURe4YQGcJaIWsyNoF7niEf9NnZAJdqxpwnTx5OZYm7RCq9k=@vger.kernel.org X-Gm-Message-State: AOJu0YzsdrRYqHbY1meY7KgQxMFRJ5KKf+ETdWk5mAt4q/Z54+1ntQRC Op1BLwtxyZ/3eYmnpoFlVQcCfmFT7EyXDs3vrHEr0lQ4z3wUJTOx2OtBVZuCH3rAaulFJlvF5L2 cIXE= X-Gm-Gg: AZuq6aIReS7qRG68r3T5ez+oS+HnbtgY7cgsk4aaN262flowZ4yDfnkNHMLfKCxzJTE QyWSNQQ1voGDwGDI7a+2DkIGCPGlO5kSnwczEuDmSSTKqXF/wQXW9DkVq1L/mY0cNsOarGZ79Sj p/eEJT23E4zLWREQ1+w0LTulR22Y/QGd6cS5WW2AaN3z7uLh1T87aYQVVvkirkKG+Mt9LvcIoTj 3fhFnQ0T6c6s7aN7zRuRv6+mL4v735r+TTM0Qe5DQo/arnTrAzNau3I4OLAtQuLSOZpVKzs0qgW daul/Ymhg7qPFx2mFSHDwGAvIrneNlpebxZMO5ETjTkN7tQtYljQTolc1w67P6xFLXqGqMIV2AV 8O6DG2szeLcdx4Z22aE9q6J0ry+RkeY9sdo0JHpRf4XuxpdCkziJC71NrERlj5n7zIPfjyVmbmx szPoLC862MbopgvmzuD//Ci8N0smoDlT3Iv5daHhwUUqhbpTM/M5laAGQV93ATz/pymDqhbAyG0 EDcZQmSquo= X-Received: by 2002:a05:7022:697:b0:123:34e8:ae8e with SMTP id a92af1059eb24-127040147c5mr3631257c88.50.1770523488941; Sat, 07 Feb 2026 20:04:48 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:47 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nm@ti.com Subject: [PATCH v2 14/15] soc: ti: wkup_m3_ipc: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:36 -0800 Message-ID: <20260207200128.v2.14.I0334ef23106cca2014f28ae56930741ca9238105@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/ti/wkup_m3_ipc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 5845fc652adc..9f74f2dfc217 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -328,9 +328,9 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) * the RX callback to avoid multiple interrupts being received * by the CM3. */ - ret =3D mbox_send_message(m3_ipc->mbox, NULL); + ret =3D mbox_ring_doorbell(m3_ipc->mbox); if (ret < 0) { - dev_err(dev, "%s: mbox_send_message() failed: %d\n", + dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n", __func__, ret); return ret; } @@ -343,7 +343,6 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) return -EIO; } =20 - mbox_client_txdone(m3_ipc->mbox, 0); return 0; } =20 @@ -358,14 +357,13 @@ static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_= ipc) return -EIO; } =20 - ret =3D mbox_send_message(m3_ipc->mbox, NULL); + ret =3D mbox_ring_doorbell(m3_ipc->mbox); if (ret < 0) { - dev_err(dev, "%s: mbox_send_message() failed: %d\n", + dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n", __func__, ret); return ret; } =20 - mbox_client_txdone(m3_ipc->mbox, 0); return 0; } =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Sun Feb 8 12:20:31 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8862D7DED for ; Sun, 8 Feb 2026 04:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523492; cv=none; b=etl01kNjObbVy7/z0kf96S0JXKMYMYBLyOWNVwmyHUjYOjoOXkmzbjC+rlPAVyIzU7BGY9X1+7IDJEKP+O8X196PbPl/9fAI4KefAzLx/KB7EzONc+iX716yzDzDvgMaof7gd4AGIDQMyLRzjUtZLtb3OFpMsbULhBwBp9M//uE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523492; c=relaxed/simple; bh=QDXdBky3iRnaXcciRzg3imKseW1sBCybxAE/HnrwUqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bTNe3L5MgZn+47QDMrmzQqIFF0ZC0DCLjSOlnlhj8xIlDUvD0Jpvg0cExZQLz4N4UBWBYNftxr1fR3KXbmmUTOLkVlbpth3IugUgC3HQO1zPQGJrMfOnGKZKKA0O9AJ4MWXN0EMHafruaM2CGNpSc3+gHaJinuUJ81cxkeGJ56Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iE0gkcc5; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iE0gkcc5" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12713e56abdso287835c88.1 for ; Sat, 07 Feb 2026 20:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523492; x=1771128292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X1WMZsabyRtxW/BORr83pHAp7XMgNG5LzmQLBp1LufE=; b=iE0gkcc54mzTCZ4Ci1ydGTeJLbhWgjT6hICGbN1UhSRtRgDCttPhnPhiQXZ2bIT9fx Nz1e50IxV+/nUVU338Ei6ljHA1vEUKy7DtuFvg4h2eWhoxccivvp5qAcQMZZ+4n2B6Y7 4/oIo2XlkW3x1Yz+5FM7/s0sm4r80VjBWxYTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523492; x=1771128292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X1WMZsabyRtxW/BORr83pHAp7XMgNG5LzmQLBp1LufE=; b=HEpokP9AgEtEjOjKDbf1sjGBkDQKly+wZz6g+DXiMpPdo06py/Pnau42onpAuvoePO bfiSRc5JSoBtQNXM1K4rlHQ8Tj6rw2622uQ7bIPvMARodW9hR31/MBu12fWV19V2ukO7 8diPrLjNlm1dYhxFonRy4+u9VngiP3TWULMX0tvPUISE+T/l+jq9Usgc7kEUZvbfIAd2 rlcqR6nqu4mJEYpjViWLgkUvlDknMKJkM3Yox1xpRkx6G6nJ8P0fvS3Ny4Qy+FaNaYvP LfywKLb9rX68IASF1b3bRx1DYBKo7SCW3dPfRfSd2Rq3HylPQJr9MWmQVtJ+DuhWtJT9 n1xw== X-Forwarded-Encrypted: i=1; AJvYcCV4SI355JbnlJ4+YBLp00JPoB4dPPxb8Rr24sfDBRL/k3uKKmEBdBXU3qG1N2hH+7h6Xprc0oNskwA8Tp0=@vger.kernel.org X-Gm-Message-State: AOJu0YwD/6CYrcnL+wqAMzQBoeFIHdLWsjnCDneGcKeCcYJ+7lm5BRVR dmrJ7RwUXJPewn6qS569iWBRA1M0LE6bQNzCdZmV7FrKCX3o/AtG+rU0wNO4+sajaw== X-Gm-Gg: AZuq6aIunQPQdI+3NJ3wJ284P4syUqSHWOT6sdcIgnSabtXK1uvZKZF6ijcGyOSCdzc OtlLU0qtHm0VQYjBLt2x4JSSBM8iivzriyLo7TlfHnl7G7Mu7IYUs/IVOjaIuIwEpsOQTBSVebN fga+JjMXsqZfQ20ax5EzneK3QUcK54O5aXm3OvuGUzfgGbxHC7E1ndliV1ZDLDHLqLZIPpfQYJb b5RemOQIyWLm8jucPLP8WWWpP7BwYVGrqtzHh895R9bq7ecDxE+gkJp7mE+9elx1SCaRqre2vhh BTy/AQBXCRN9UkkdZpR+1mpGgmuOejYZ678lK2+7lBnC9Vc2pFrsYGXtUXpeBNbOTvm7kMs7kTw rlOc8CfKQ9JP2Eb/NnjuCJ10MRqKxGGJ8m9GAFEBj1Orm2/s3+RVtSSq7WiHNDzhnmuqqI1jwQn iqrRtWzy9r+8qvMGXACYGRnTsZ7DfWZK4MrXokKP957giwBsX0Aiixy/BGIjNDgFqpCgm7YO0= X-Received: by 2002:a05:7022:92c:b0:123:35cb:96d2 with SMTP id a92af1059eb24-12703fc6b75mr4209766c88.21.1770523491742; Sat, 07 Feb 2026 20:04:51 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:49 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , jay.buddhabhatti@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, michal.simek@amd.com Subject: [PATCH v2 15/15] drivers: firmware: xilinx: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:37 -0800 Message-ID: <20260207200128.v2.15.Ib15a93253dc4bf021c41036096b8e289702878ba@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/xilinx/zynqmp_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_= power.c index 9b7b2858b22a..7d8e311fcdc7 100644 --- a/drivers/soc/xilinx/zynqmp_power.c +++ b/drivers/soc/xilinx/zynqmp_power.c @@ -144,7 +144,7 @@ static void ipi_receive_callback(struct mbox_client *cl= , void *data) &zynqmp_pm_init_suspend_work->callback_work); =20 /* Send NULL message to mbox controller to ack the message */ - ret =3D mbox_send_message(rx_chan, NULL); + ret =3D mbox_ring_doorbell(rx_chan); if (ret) pr_err("IPI ack failed. Error %d\n", ret); } --=20 2.53.0.rc2.204.g2597b5adb4-goog