From nobody Mon Feb 9 05:55:32 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B34325FA29 for ; Sun, 8 Feb 2026 03:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770522832; cv=none; b=RYbiHCeiw36pz0HeNJiBrrc5gd8jfaZg/RGz34saRF6J69wyExpAP66ANO+BGmfCpnv2ubmXhqJQN+wHOR+xfsNan1GzQ5DSHS7nC1EoUkXAh9x4K/Y6wb/XmjGlFy6ngzcTXbbvSQLN6gPvPZ8i5FXWY3l23x5gng8COyQLulE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770522832; c=relaxed/simple; bh=IAG5hEnEbNpHR7VILo/dgAe3AccnKofEghqYHX5gO0w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jSLsUao/HRW4ZF0JcaN07wCDKbYXLeSgCmzmb4dFowkz43L9/OYS3em++VJiQkteUkFRr/vEVVOkPbPgG7bPGjvuE3/mBNoFHBfOm6IzI0ZkPJqHg/5h0nF1i++aDp/i9z5LRf0eON9UZ1h/tipR+SRBuz4DCC6wMzHCJPfdgas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=DfSNL8yH; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="DfSNL8yH" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8c70b5594f4so390979085a.1 for ; Sat, 07 Feb 2026 19:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1770522831; x=1771127631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zsiMnCWsDue3HgjqSN6ua103luAgmACwCAaDl9Hd5SU=; b=DfSNL8yHRyJm3N96qXAu2D9+RREl2w2HA8VkuP+78cktk/yr8doB4xh1Kpm1SJvG5x nN6tIEhkeQ0wfcAxeV7vDZL1c9x+Lwk24Zkz4GcR3wF4IP0IxmRUF6QLGHT71ZMFqXrt cxUaJuQvNOxdE4qpo7242eQxXRVQKnPRI8+pVVYb+NaT86C4ir6PvjYgIysVJBN40vxh CVpuWQ8nUVbKrZi0upDla9ZrgLj44o3ZKGEJRECA1hrnmyBHgrEBhtdSkkyEEY2HEqNn k7jaqYXl+S0esdfWYHUk8nCfsAJUhLC/n/9uQ/1fOrIV6Vn51N8xA1pQ/FuvrBu1o3WN 9kRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770522831; x=1771127631; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zsiMnCWsDue3HgjqSN6ua103luAgmACwCAaDl9Hd5SU=; b=Hx2PcR/0vbEr/IRL3S0o82aiNf17xkIx0PxU6Cah1ajtR2qnl6F/Fw3BY3Z8ys3pbf ldaSvxK9j4rHVmhTE5Eb4TMQdWzHApbaRXzoqGPPv2Tp4crGfMVQz3P1Z4gwX8JVLmXU PKNv66QtbFCb3fG1jH5ulzRrYFMCAvLvTCPwe4TtY2BnxPdknTTb+fdN8fFPW5sXy2BH dVStVxs6X6SNodxW4Q7/AjSYr0AXsiEClQbISYoz5YRglOytSTTFVyu26gpr//pT4ai8 JInjIJyplgzfgefI8Sb6VkdyQmJseojwqeh6XSENykfYg37mgY5k7r5fpPa7YQZerT/k onOA== X-Forwarded-Encrypted: i=1; AJvYcCUvxRxPuN1XQdQ8QCorwO7cbs/tRxs1RdYezgZ9PO08LXSa1ff2sDJ8GxNUytSS3VduSu63T6OQK6fCStg=@vger.kernel.org X-Gm-Message-State: AOJu0YzWr/7+C1aH3kgQiedhDw1axSzHZ85qkbGyBaA1yR9AQ3knzidJ Wlf+PVbwzYdTrmRWOZXj0kZfWPiHGC3tEdVBvt6mR9EGLbQ8LmhwsW3Jkl97isRUzmc= X-Gm-Gg: AZuq6aJe8kve49hNAsthT/6LhetW1V3iysxuwZ1AxcvxiZ5XOpT1BY/8ugxHah6drMC e7vlgckmG2CJbZii/rXW0I2f9fKKjUMZosFF82jQNSSlFqetRbXTppMtECGFzwJad/YdbhotfiY 0EBNR4HOPtJ5zaD0QnU0VYaOotbR5YkU7UStQW1FHmtOR+KBzomnF1O85Ez7oGpHVL6cHtzH0qf 7Vkz8syEPa1OQZBDX8ukYx6RHMh+wozhYZfg5e45ctWRNBcx20LraLJPo6YOK1i/54We+iyJPtp OEt2miJ1r2hEBDBCGGDQ9Tabif4aoopbYNvzETdwCM0i7/hLjRQXB5C0AIWyltjHPqqC5e9WfCj MjhNKQotJuleQfMh2wF37cgbLhFALzWu5CEDs22i8Y95gvyob8DPqOCaOLHe4l55eab7GdaEM2p zReoE6dHDaLUJvf0nJi3ytKq6x3GYT2WqDcT5LxiN4xEzKjHuAjyfOXsM7y6wxeJ1yOzhZXs0fG BLlXgYp7dpb7CN1CRK37aqHa7xgo9xs1HlTSSimPA== X-Received: by 2002:a05:620a:4486:b0:8c7:1b3f:1d02 with SMTP id af79cd13be357-8cae3388853mr932093585a.40.1770522831259; Sat, 07 Feb 2026 19:53:51 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8caf7be4366sm509430785a.16.2026.02.07.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 19:53:50 -0800 (PST) From: Ziyi Guo To: Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil Cc: "James E . J . Bottomley" , "Martin K . Petersen" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] scsi: megaraid: add mega_proc_dir_entry check when proc_mkdir fails Date: Sun, 8 Feb 2026 03:53:47 +0000 Message-Id: <20260208035347.276181-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" megaraid_init() calls proc_mkdir("megaraid", NULL) but only logs a warning and continues when it fails. If pci_register_driver() subsequently fails, the error path unconditionally calls remove_proc_entry("megaraid", NULL) for a directory that was never created, triggering a WARN at fs/proc/generic.c:736. The same issue exists in megaraid_exit(): if proc_mkdir() failed during init but the module loaded successfully (pci_register_driver succeeded), module removal unconditionally calls remove_proc_entry("megaraid", NULL). Guard both remove_proc_entry() calls with a check for mega_proc_dir_entry being non-NULL, aligned with the check of=20 `if (!mega_proc_dir_entry)` during megaraid_init() creation stage Signed-off-by: Ziyi Guo --- drivers/scsi/megaraid.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index a00622c0c526..ab901ad6c480 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@ -4589,7 +4589,8 @@ static int __init megaraid_init(void) error =3D pci_register_driver(&megaraid_pci_driver); if (error) { #ifdef CONFIG_PROC_FS - remove_proc_entry("megaraid", NULL); + if (mega_proc_dir_entry) + remove_proc_entry("megaraid", NULL); #endif return error; } @@ -4619,7 +4620,8 @@ static void __exit megaraid_exit(void) pci_unregister_driver(&megaraid_pci_driver); =20 #ifdef CONFIG_PROC_FS - remove_proc_entry("megaraid", NULL); + if (mega_proc_dir_entry) + remove_proc_entry("megaraid", NULL); #endif } =20 --=20 2.34.1