From nobody Mon Feb 9 21:18:38 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1D32848BA for ; Sun, 8 Feb 2026 02:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770518964; cv=none; b=Bqjag5bS+5W1xuFuEaxyia+PUSj9Fh4YK66q1OgHelYfjjL6sMjQEuSKkMGQvueEeT6sz71tro/Bm20bkIEbL79Kcca+7A4oIxFS/6hdkk9RHK4uuSYvJ9+lHULGOxAooJKwJG+l5ueFYm77P3Ycy4ykYSSr1EDVD/YvmXCh1LM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770518964; c=relaxed/simple; bh=/foDnsw9txtdA8j295ZjAzzfzsK+5/oJh72tn7OOjPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HpCrW5lxp46GPrO9YImbUN9VFEeVlEXXCSsvChvg6ksYyWGiBytXNVv2rcMY1RNiAtKqG4TvhD8qyb1S9kF/EwDfby08pjd/dHWChnq+byut71vExJSsrcMBO32iWMgH1r/KRM+OvF004I9piikwQlrq8t/AZRAx40yDj1LFE5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HW8alwmX; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HW8alwmX" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2aad1dc8856so3232495ad.1 for ; Sat, 07 Feb 2026 18:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770518963; x=1771123763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OQ8kSHh93BFAAIINgkYl0/hpSL7dAAj2kQue7tV1qds=; b=HW8alwmXSd4s7gwBCEf4wYuu0QL2ntgiDE0FfIDFh7ZhbOECo9FH7fsVR2u8a+cu+b wtS55Yg57debJ5S5zDqiSO1hFeMuTSaHnl19pXIcc497Isruq9oIebZADEeEercVqplj t0FYKu7QbnROKJK6boLa5IuBxgk4G9ZKqyim7DaIVEVIx8Q/wim+9jWj4D1NljRiOhPs QjfZ0dP/ycKvysllyoIUA4MA464fL9a1YqLOqOtFBqJ/VIEq9W0Yd2HQrGHWR7UxbC9T uRHX9BQ4PBO0K1EkpsM+6ayy2irNmOpBKIG39nL06lgwxS27fTjhjDH9PRbcB6U1BkkO Nz6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770518963; x=1771123763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OQ8kSHh93BFAAIINgkYl0/hpSL7dAAj2kQue7tV1qds=; b=B46LL0tJJ3nsksKag07EMP0AZ1iRFniIiccxi1OIUe4r95opgtagtV5PqFGAcNiB6A yy2b8LBhc6r8wN+6KLJLAbLU8QQv+ivLNYEt4tyTcuVVIDwHfdzglTMHsfSMW1gVA+e9 M4yK+f9jieNedgryaTjXFKV6Isk81rQ8ew8x4E9TGJvpHRcD/YNbeTiZCsE8gFP7k01h h9nWVs+HsJiQXQ6blGwVxmZktrDQOTMyBk33OVTAFDYR00nIg2WBISEMWDVOZAcUZVNN 340o45CRMSbeVB3qiBA9dNxMklSzh8gbamxZ8c6KIAFw1UIAQkSXT4q4VwX85bAgTXA2 G+Vg== X-Gm-Message-State: AOJu0Ywsh/UcPEZovoBPWOMSX8rfYjlUgj91lob2hmexGDccHc/pVv40 eHhge4g1qEbX020eFjTowDRtcvLop7hJAiavBOUJbUFT1qHfvQnz9sr1 X-Gm-Gg: AZuq6aJdHT0CkNL+OqxM68hL5ZlXC2Zhptlk94HluilL5O6GsBb7bdfvGTyaSB97rsq +bQ2GAK83J65FfVKTGmwDuetjmxeeHiDoImLOr5cN9rqB79ajutF9AK24tbvOXmNURT8xEshThQ 69XJHpLpsrlG5RNXtdPKGxR1G7/1CR35RzIKRToPEFi9Ac9unRKlttteWOWMFSNqtjuu4PzFS+K WEwvo/9O5DdD4NhazP3ys8sBl6ki5TduLlcQKZnG9T+wClBNgl+hhdrYbeL/yM3MxrCvrrsYjtl KnHdJXYsLwZV+zJToYxgtA8gfiS1+/IzCY85h3TU0HCKxbJlBPYX1rCxSFeagsAoAOzmyfJJNR2 8vUnhakHXhHtZnPC4HlLn0z3t8bk0zFTmSURRYCK064vi/R7uBxuz7NvNWMkrqnMsFBAO/b//iF oKKI/LeeO10PWKMNStAQu6sHxGg15GkzR1QiQPFLIs X-Received: by 2002:a17:903:2b0c:b0:2a0:c1e4:e25 with SMTP id d9443c01a7336-2a95194449fmr73990145ad.54.1770518963312; Sat, 07 Feb 2026 18:49:23 -0800 (PST) Received: from localhost.localdomain ([113.218.252.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a9521b9f5esm67194715ad.51.2026.02.07.18.49.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 07 Feb 2026 18:49:23 -0800 (PST) From: Chengkaitao To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, yangfeng@kylinos.cn, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Kaitao Cheng Subject: [PATCH v6 2/5] bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set Date: Sun, 8 Feb 2026 10:48:43 +0800 Message-ID: <20260208024846.18653-3-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260208024846.18653-1-pilgrimtao@gmail.com> References: <20260208024846.18653-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kaitao Cheng When traversing an rbtree using bpf_rbtree_left/right, if bpf_kptr_xchg is used to access the __kptr pointer contained in a node, it currently requires first removing the node with bpf_rbtree_remove and clearing the NON_OWN_REF flag, then re-adding the node to the original rbtree with bpf_rbtree_add after usage. This process significantly degrades rbtree traversal performance. The patch enables accessing __kptr pointers with the NON_OWN_REF flag set while holding the lock, eliminating the need for this remove-read-add sequence. Signed-off-by: Kaitao Cheng Signed-off-by: Feng Yang --- kernel/bpf/verifier.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 05a6a6606b6c..bb3ff4bbb3a2 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9260,7 +9260,8 @@ static const struct bpf_reg_types timer_types =3D { .= types =3D { PTR_TO_MAP_VALUE } static const struct bpf_reg_types kptr_xchg_dest_types =3D { .types =3D { PTR_TO_MAP_VALUE, - PTR_TO_BTF_ID | MEM_ALLOC + PTR_TO_BTF_ID | MEM_ALLOC, + PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF } }; static const struct bpf_reg_types dynptr_types =3D { @@ -9420,6 +9421,7 @@ static int check_reg_type(struct bpf_verifier_env *en= v, u32 regno, } case PTR_TO_BTF_ID | MEM_ALLOC: case PTR_TO_BTF_ID | MEM_PERCPU | MEM_ALLOC: + case PTR_TO_BTF_ID | MEM_ALLOC | NON_OWN_REF: if (meta->func_id !=3D BPF_FUNC_spin_lock && meta->func_id !=3D BPF_FUNC= _spin_unlock && meta->func_id !=3D BPF_FUNC_kptr_xchg) { verifier_bug(env, "unimplemented handling of MEM_ALLOC"); --=20 2.50.1 (Apple Git-155)