From nobody Mon Feb 9 10:42:50 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E62D3112B0 for ; Sat, 7 Feb 2026 23:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770506763; cv=none; b=ABWySx+evFlLmqHGVNLO8CuWOfmOyqxkCDyMzLSBJUyl6LX2D+JV+ShHGLDYv1rP4hvlHrBWpA9Q0ZV9C1wBFy3ZwBsiUFYsrz6dNznac9XUCH6gxV4DDiL84RMslRbDpN9zhypf/NBJzXjf58xydKbx+xeAuYOxOayvtmTY6dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770506763; c=relaxed/simple; bh=FfyweDV0C0w13I8FYMO5+SK1v3RNiAE6HO5b4hXCNnQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FcCderz13GtfdqPvcmTF2vY1bJj688oOAKFOHI99V/8H+2LQtCLYMhkTDhzzV+Vb1uieOG25tbhD7lYkcKs0TCj/Q5/Ers34g+HCvPsnBjTfbrgGbdggROVioXctv6Y3y0sOakCcX9DMDz6KOa3LSIZ49eYTSf8Zjhah0LEga9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=Gt4rpVhL; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="Gt4rpVhL" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8ca01dc7d40so351974285a.1 for ; Sat, 07 Feb 2026 15:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1770506762; x=1771111562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AkFXjU38A5sw4srZ4rRr/u08i5+VyD7JO4xylQ4ub84=; b=Gt4rpVhLdxYMEaVLPuYdnbj/Y5V5QLLTW6bkIzNxbyJQLBwtay1Ar0kUq9VNWOIOym dBXQyk6oXpkMG68L0Fzun+JRmTp5bV2/S75Ns3ujxQtAbE179YWGtNEh8AbRN4IZ+yJK GjBdtbi00YYw5bm2OdXVZZ4yTjYWEmGa3CBMJOG5qCWQNt3HpZ2gZBjMoWfSGc/VlYyq yl9PUMk8iyQzbTlLB7b/1aLCqmU421c+QCTbd6lkaCQgWykChPzqT1HMCxmPYW04K5n/ ejj2IxBheOog0AY89ZixeJ1SNy3es2VnoNuejqs0RnvOER0f6zm3hOdnmP7ovGhwmcqi rfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770506762; x=1771111562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AkFXjU38A5sw4srZ4rRr/u08i5+VyD7JO4xylQ4ub84=; b=mFxhN41ukc8iLcuyeXj5ayBcCknH/TRiEPhJfYZaUNxMhPQkyzBYczqBzLojyMwmFz ZjjrheL0St+Wut67uAxgU0hFSttQsVEuKHvcRkX6GFkeGv9Jvdpn3gIBX+3nI44dyYNO w1qDYIc3llaXauJxzlGrgsD3EOffy+LFH53AeqPnOYwf6yYm8bdTw9Ctuop1+PK5ji1b 2JKrsvrZGrb45oGQgxakyWu04SluTHGXim1BU9PBhX1b6eRWzsjSnN49VnucnSXod/up IpI05ACWt6wiVpuw6rla585HKHeWkTXcq8Z/15AWaci0hLXuX8CUdLEX1uiSl9IPBfpD hM1g== X-Forwarded-Encrypted: i=1; AJvYcCUpgb4hoTHTsXlRQQVuLgDtFBQA6To3++WAoMAfEhRTfTBPZPg+96f9LtUTsdcDsxB4ekkWNhP8ZpAGsfI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7Omgs4uaIA4JJnz/8WZF+G2gi2DFPDj5U8f24RbbrExlgafFt 4YBs+o1jyA36z4zfezmLqu1ChkvbBTXSSHeNnvHPjJkbyWw5U1z13JgMlYAGx7HUTXP4vPx5AS7 PsQ5e X-Gm-Gg: AZuq6aIw+UmMC4oD/uitbBHUlEe4ACKFVE83UlvkpHQWa5yl7YNmBZnuTln8jYpTxfz VezD24/mXVSYl0NzR1WNWjD8fsrBgNfGBcvaY6optXbwSg5UoTigZarfyNwVCKzOJNT0Pa3/NzX PBHx4K5Stoa9v3fV1Xk67l1v+8dll9wJgrCJamXW6aHxBGV/t2xxa11rkmiEIrI73XKD4yass98 QL+n2GVj0kvQjJ1K9O3uuaX67ABI7i+gIluObGt49BgJ9+QC7js+nx95fIoxBJKXHVjdm1Rhhqv p4pm3KhDLZhV+7MCuNTxb0m6efCEMj90Hq/jKrhyd5MyNdUjA9jF9zOptofl0er55BMRDwPdvLD iHeFWO1Rflf/Wi2vJA1RIlzE5rTGiAV9tZ6m7zAkp3luqTP/JS2VcFBcmmojbvg9ttAbaJC4S5C OKvOJvKMnIxJcF2hxYYUJZPN/b9VCgVT6OW2TUH+g9CbnLvkhIK4U7sT4r3iNKvwb8H7GmzThDk xdyzzdcFvFR7z7t0yU3WEQvkJ2YWRs= X-Received: by 2002:a05:620a:1990:b0:8c6:de6f:89a2 with SMTP id af79cd13be357-8caf2789759mr914848785a.85.1770506762357; Sat, 07 Feb 2026 15:26:02 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8953bf3b6b2sm47190196d6.6.2026.02.07.15.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 15:26:02 -0800 (PST) From: Ziyi Guo To: Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi Cc: David Airlie , Simona Vetter , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] drm/xe/sriov: add size validation in packet init Date: Sat, 7 Feb 2026 23:25:59 +0000 Message-Id: <20260207232559.4037731-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pkt_init() passes data->hdr.size directly to kvzalloc() without any upper bound check. The size field is a u64 sourced from userspace via copy_from_user() in pkt_hdr_write(), and the only validation performed by xe_sriov_packet_init_from_hdr() is a version check. When a VFIO migration manager or debugfs writer supplies a packet header with size > INT_MAX, kvzalloc() reaches the size WARNING in __kvmalloc_node_noprof() which triggers: WARN_ON_ONCE(!(flags & __GFP_NOWARN)) This fires a kernel WARNING, taints the kernel with TAINT_WARN, and causes a panic on CONFIG_PANIC_ON_WARN=3Dy systems. Add a size bounds check in pkt_init() before the kvzalloc() call to reject oversized packets early with -EINVAL. Signed-off-by: Ziyi Guo --- drivers/gpu/drm/xe/xe_sriov_packet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_sriov_packet.c b/drivers/gpu/drm/xe/xe_s= riov_packet.c index bab994696896..04483eeba11b 100644 --- a/drivers/gpu/drm/xe/xe_sriov_packet.c +++ b/drivers/gpu/drm/xe/xe_sriov_packet.c @@ -127,6 +127,9 @@ static int pkt_init(struct xe_sriov_packet *data) if (data->hdr.size =3D=3D 0) return 0; =20 + if (data->hdr.size > INT_MAX) + return -EINVAL; + if (pkt_needs_bo(data)) { struct xe_bo *bo; =20 --=20 2.34.1