From nobody Sun Feb 8 12:19:42 2026 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66ABA314D36 for ; Sat, 7 Feb 2026 22:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770504556; cv=none; b=sVyupEDwfvwuVD/Dh2jHW6pWTI9HOHIxJfnQYfoyZuBDSWR3PBpfmJfu2myyubR2Q68MsO2oAn9ngMHo3Yc15uAWDqa3QcPxA5yYR3orPqzTd8sYmY33+5qPECjVxXGVLi9W2ZeMpcZobF/S9IkUMnPtG5ODDDyrIY7vXOjwjwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770504556; c=relaxed/simple; bh=uQirNH56o08PQezOI08ix5FjG39GPzqmN/bNEBVo/4Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XLZ7iHVXmZliZSQTsVxljeOu9Levd3OAuyxQ//hHhH+PBepRMzqoUtnV6tXvK1725ey7nwFoVSaWFfTb0J5PtjDxWBBzGDEM6aeIj18RMD+BR7YFugbjzhJUDKmdXvx0t+zoG/2S+B+Qq27ARXKQYkc/ARMBl/eedsPA3gEwMsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PwDaZQ20; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PwDaZQ20" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1271195d2a7so1441742c88.0 for ; Sat, 07 Feb 2026 14:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770504555; x=1771109355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/EcHLlTg9s6jqE6NFJ8zFZFNhespaoej6nRnFgBGlWs=; b=PwDaZQ20N5L09YiO6s2WDz/wSEGdYaE3HwcVzu7FR2DNfjoGXy6IXpEvqobGF5keDY nC3mvv8eunpmuTVjRR9FrE+y+0w/zxX46GXJraNVzeSNz0aDtjdJViObKGWxoYGN5GRR t0La0XJ+VNmuyru0wtbsuWwjHFKOCK4k/2a7YuOC/wUqKK7JsOpmGR+9f59Wb3tQ9gvW hYSFu4IW1Ab4SZLfdiQUorFLJufrodbazdtp7PsLHbrRhab6Nn1Q8YvIjYyJwGJYwOIg cCmxolOC0Tpa8F10/Qb9u6Kvhgl0dtyJxvVSIt7cDttgpAj1md3fZr8RFaLeWZfarjXY Svnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770504555; x=1771109355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/EcHLlTg9s6jqE6NFJ8zFZFNhespaoej6nRnFgBGlWs=; b=WUOPF6aKm5LKO6r4v32Ww4DL+ntkwLtoTHFFGNQPX/wpniaxg/G9w2VJV5G9zZmO8O 9NKISIR/qmcwtz4w+1qXbJGClc/X9hz9c4vZPv2jb4aFRGG0feG+pbb+SR5yoX0lXfZB WZLp1rDvanyGrDsuBT+YBvmWPWHCZYSlfARpWtY1Au6LStQQT+la5vaqp5BSQSHJDxZ8 BoMv6qaBAZdApN0sREDGPdJcH+4cPRP7FTpyVbR3If1Z9jUOLoP6j4tI9nL/2HmbVEG2 4Cn0SZE1dBbY5xxMPNCnUjC2vrSwoYAHLZO11dqpa2fYaw1LQqvvXr2Ao8l3lnF0lTEi 5GWg== X-Forwarded-Encrypted: i=1; AJvYcCX8tXdzTzqLD0D4D1Mup5dF9wNQo7xP1lYEXdSjpjJXyXckF3ugG58bIJKJhf2CKZ4av/qf80fdksm4Fjo=@vger.kernel.org X-Gm-Message-State: AOJu0YyLcun2MApZd0adw52yTb0CK5oC6yWYzyR9IVEp8gbxC/dbAse9 S0ftgogZNAZ57idSkgvTwUyskzjbNZLtcXHgItRNePxrOfdRUiv3K40MIKGnbw== X-Gm-Gg: AZuq6aLNNIkU9i4EVtsXvlK2AzfYMIEtaLzSUhFwOP/OtzNWJLfzWpyQH9T0+buyYlj v+D3JSpMZooiRn2uQEiDMjZgC8eJJco/15bRNtmr7KB/7kfIo3bZtAWZXvixE8bleeTEM3UFSur /I/2QEGl6uV04z5a7s8fDT5/eoJlYmLp4/kgFnA053OOoXz1SeZJRkvz8UaoIHR0Oh3sVElL5jd NVQ/lgBnZ4g3yKLKAQZL+plbg0b9DoNOps1BrFV8o3+EkPO3AmZPhLzWF4muOXcAbYpaZ3VnFSZ D13PUAkL5G+dblHgpGuNLS8t1ZXlZSX2ycMN8pR4lDN9m7Pi10GtIHXLOWPm1L/oum5qXHd9b2o 5ktymWUNsUAWrNXRo048NBYXn99HCKCoeEqs6OA5IWBxta2Qn3n2+00sOSxdTCItUIQnZIV+PG5 kSHT9++/yciWiRRCEwbBUs66iFsFMxaqeb/7dp/CBELdkWerR1kblvRCn/p81gJqmU X-Received: by 2002:a05:7022:24a4:b0:119:e569:f275 with SMTP id a92af1059eb24-127040597admr3161433c88.30.1770504555446; Sat, 07 Feb 2026 14:49:15 -0800 (PST) Received: from jason-hall-A520-B.. ([2600:8800:41a0:8000:987e:6d8e:7cd5:6e71]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855afdbfbsm4648131eec.11.2026.02.07.14.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 14:49:14 -0800 (PST) From: Jason Hall To: Miguel Ojeda Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches , Boqun Feng , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dirk Behme , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Jason Hall , Miguel Ojeda Subject: [PATCH v9 1/2] scripts: checkpatch: move Rust-specific lints to separate file Date: Sat, 7 Feb 2026 15:49:06 -0700 Message-ID: <20260207224907.234815-2-jason.kei.hall@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260207224907.234815-1-jason.kei.hall@gmail.com> References: <20260207224907.234815-1-jason.kei.hall@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create scripts/rust_checkpatch.pl for Rust-specific linting logic. Add a conditional loading hook in scripts/checkpatch.pl to call it. This will allow Rust linting logic to be maintained independently. Add a new entry to the MAINTAINERS file to track this new file. Suggested-by: Joe Perches Suggested-by: Miguel Ojeda Signed-off-by: Jason Hall --- MAINTAINERS | 6 ++++++ scripts/checkpatch.pl | 14 ++++++++++++++ scripts/rust_checkpatch.pl | 16 ++++++++++++++++ 3 files changed, 36 insertions(+) create mode 100644 scripts/rust_checkpatch.pl diff --git a/MAINTAINERS b/MAINTAINERS index 2c0bdd08b74c..57831dc30e6b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5880,6 +5880,12 @@ R: Lukas Bulwahn S: Maintained F: scripts/checkpatch.pl =20 +CHECKPATCH RUST LINTS +M: Jason Hall +L: rust-for-linux@vger.kernel.org +S: Maintained +F: scripts/rust_checkpatch.pl + CHECKPATCH DOCUMENTATION M: Dwaipayan Ray M: Lukas Bulwahn diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0250244cf7a..f75cb70ad0dd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -20,6 +20,12 @@ my $D =3D dirname(abs_path($P)); =20 my $V =3D '0.32'; =20 +my $rust_checkpatch_available =3D 0; +if (-e "$D/rust_checkpatch.pl") { + require "$D/rust_checkpatch.pl"; + $rust_checkpatch_available =3D 1; +} + use Getopt::Long qw(:config no_auto_abbrev); =20 my $quiet =3D 0; @@ -2947,6 +2953,14 @@ sub process { =20 $cnt_lines++ if ($realcnt !=3D 0); =20 +# Check for Rust-specific lints + if ($rust_checkpatch_available && $realfile =3D~ /\.rs$/) { + my ($type, $msg) =3D process_rust($line, $rawline, $herecurr); + if ($type) { + WARN($type, $msg); + } + } + # Verify the existence of a commit log if appropriate # 2 is used because a $signature is counted in $commit_log_lines if ($in_commit_log) { diff --git a/scripts/rust_checkpatch.pl b/scripts/rust_checkpatch.pl new file mode 100644 index 000000000000..56c1bc29d3f2 --- /dev/null +++ b/scripts/rust_checkpatch.pl @@ -0,0 +1,16 @@ +#!/usr/bin/env perl +# SPDX-License-Identifier: GPL-2.0 +# +# (c) 2026, Jason Hall + +use strict; +use warnings; + +sub process_rust { + my ($line, $rawline, $herecurr) =3D @_; + + # Reserve for future Rust-specific lints + return (); +} + +1; --=20 2.43.0 From nobody Sun Feb 8 12:19:42 2026 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05CAB3148B8 for ; Sat, 7 Feb 2026 22:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770504558; cv=none; b=t1O/tvo9wjhDJZ5d4TF5X1AnmGdVaDSF4imAn/XWnCoUp0+/9T9hvHDTNLZd25BwjF35G3TShlXgasmnWsy65PIXp7j/EpK5LGMfCdNWWUaesjL6akKdDezWL1WtW/WvZRDLC92735aWv4iKZRa7Y2bVFBmagj/0EeYuoH6jrAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770504558; c=relaxed/simple; bh=N9pershJ8e4rvEbkF8C/A07Ofmb0EdWd37g1Gj224KI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GtUc0j3oRW7eZS8Ie6/J3VoPAGRYtqL0YBMdHldd68vt8PCaxD9BHRbVTsuAMOYb65RnC2xdtSOl+p+9GdLqwV3S2I2lFWAyUh1terwM79IT/RYrsj/VFGNIe04O42VIKkt2Z6WtgXxiu3H707dvQhdwz4V/1kPSLb5KTGNWYN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VdZY7ZhP; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VdZY7ZhP" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2ba64b5a53aso257810eec.0 for ; Sat, 07 Feb 2026 14:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770504557; x=1771109357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2RAjLQ4BwQYjhZxICswmV4n1e2QMlosSu6zi3A56XsM=; b=VdZY7ZhP4SSkokZM07GwZo+TvnP6KFWBbMoPEF3bpFUZy5jgIU/nrSuLfzsG5sRvx/ 3VRAjw7K60i96LTULuUmuUgojFWiajeRh8X1CxRZeVezIzwYUK4fsJJbM8jv1YWl0whB LznawH2dHv5ak41/CchgaV3VcGCguYCjGHikuyTvuN7jXJIyOUEAxzPu7u/oJpk+uTEd mvPi45/8ZDcysSZpw9FNxUGh5CHe9Qd556mdtAv1I8Pos904+xgAuODQYbudDyN5phlR uWenFGv1LTzZzpEZ4o74hxYM8lgqf3+OKLWZIlAx5ULYJnCNHGjvf890FVIV+zIrO4q7 LQIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770504557; x=1771109357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2RAjLQ4BwQYjhZxICswmV4n1e2QMlosSu6zi3A56XsM=; b=o1yujMAloOjKN/MCogpM5MfqGBjOJG4tv1w2YDTdmdikQwoxBx80MqZEyj/4YQ1jXG JM8B0YrFjEpvfW0Xr7JVa6OBzcY1hQZoDsZ0nttcNfiAKi2+BlGdaVCP77hq1MCcj68v fYpFtu381ZDbu1Q3lzzbR0RYwCEK9g+0lrfzoDryD+i4Yl8kLuSyIvynJLB2g7Pz963x rLWT62bLunxYlW1v3Trm0ZlkwE4mK8dWxAZR63IdY3/bjTy9/3LUWBJcYhz7WNfYrS6d boPSUYZl4XsoRZTGxKv7MWJxYNGu+a2dykoi8/oJ479ozwzhgO/XSzfRO5I0xusYnnkw H50Q== X-Forwarded-Encrypted: i=1; AJvYcCWD/RdKvzKaNlpgygOcWz3yiz97s+oQFTAIac7AlwNvrsbFOBoRnh8HhxtXM/8Inq3aPwW2ihcJbqSdfTU=@vger.kernel.org X-Gm-Message-State: AOJu0YyxKoc9BKRn6zpUR+hJcFEaxl7d0Kls/nVkyeVyRyiJ9ppMC7Xm t7e1YIOrog7s+qEXG3NnsHgExSxtCUA6yrxkYvlWcQjleBDnMmPHqjgj X-Gm-Gg: AZuq6aJwCgx4t16EF05bokdCDinqtGbJmJYASR+mG+EpyEMZyHlQfntSJJVj1JxMVor gc/Z71oQrCPU96l1LdN2SkdYwdjXSDqdb/n5VmfD6NSrglhG8VHMcoMeGSqTi/qAvH41UqlY0gY DNUwmLVAGWSs8HUOkht19ujAx2PxQnt/kuhvd6z4cFAUvRl7GzJpgUWA4R+dMF7GGAxb8ahdcwU rmUjWZPBAluOBLZP/c1lDlw207uJjCKZMTOGfP9zPdRuluGlpVpP/x2ymMmzwQJ/JOsGjBfmRHX KW/7AMmPWiAN4t5T7vwpLh2oT02tKvHc3MMrksktd9zpbIFDxtNg9582qvkylg+PvG81QbhVNI+ 5Y5VwRTpibYUKlEYvUi7bzhu3w3/xIMZBmLJS98svBZZWGf8nOzrLSdPlMQJ/7EjYdS6mOsGZ5W zLJT3aiL47TVO8c1c3Pibxvm3iq2r6SIsiDBGxzpiJGtJPDPX8XQUmSL5rqI6HyR4b X-Received: by 2002:a05:7300:e80a:b0:2ab:ca55:89ab with SMTP id 5a478bee46e88-2b856b55787mr3387299eec.42.1770504556959; Sat, 07 Feb 2026 14:49:16 -0800 (PST) Received: from jason-hall-A520-B.. ([2600:8800:41a0:8000:987e:6d8e:7cd5:6e71]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855afdbfbsm4648131eec.11.2026.02.07.14.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 14:49:16 -0800 (PST) From: Jason Hall To: Miguel Ojeda Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches , Boqun Feng , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dirk Behme , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Jason Hall , Miguel Ojeda Subject: [PATCH v9 2/2] scripts: checkpatch: add RUST_UNWRAP lint Date: Sat, 7 Feb 2026 15:49:07 -0700 Message-ID: <20260207224907.234815-3-jason.kei.hall@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260207224907.234815-1-jason.kei.hall@gmail.com> References: <20260207224907.234815-1-jason.kei.hall@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Warn against the use of .unwrap() and .expect() unless accompanied by a '// PANIC:' comment. This enforces safety standards in the Rust- for-Linux project until upstream Clippy lints are integrated. Suggested-by: Miguel Ojeda Link: https://github.com/Rust-for-linux/linux/issues/1191 Signed-off-by: Jason Hall --- scripts/rust_checkpatch.pl | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/scripts/rust_checkpatch.pl b/scripts/rust_checkpatch.pl index 56c1bc29d3f2..fa7adaed264c 100644 --- a/scripts/rust_checkpatch.pl +++ b/scripts/rust_checkpatch.pl @@ -9,7 +9,21 @@ use warnings; sub process_rust { my ($line, $rawline, $herecurr) =3D @_; =20 - # Reserve for future Rust-specific lints + # Check for Rust unwrap/expect usage. + # We skip lines that are already comments, assert macros (common in te= sts), + # or have a '// PANIC:' justification. + if ($line =3D~ /^\+/) { + if ($line =3D~ /(?:\.|::)(?:unwrap|expect)\s*\(/ && + $rawline !~ /\/\/\s*PANIC:/ && + $line !~ /^\+\s*\/\// && + $line !~ /^\+\s*assert/) { + return ("RUST_UNWRAP", + "unwrap() and expect() should generally be avoided in = Rust kernel code.\n" . + "If the use is intended, please justify it with a '// P= ANIC:' comment.\n" . + "See: https://rust.docs.kernel.org/kernel/error/type.R= esult.html#error-codes-in-c-and-rust\n" . + $herecurr); + } + } return (); } =20 --=20 2.43.0