From nobody Mon Feb 9 17:21:36 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FBAE26FA77 for ; Sat, 7 Feb 2026 22:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501926; cv=none; b=JayuYzOnNokicnohCFzE06QDpyUrqvSbA9s1QJ4o/uMJQXwazTkE+IFbcRKXqDZLt7KMPbDzD79/WDMWVssZNaFFOKFUKkDIOJ2pclB3lgMb7aSHvBsNHrBdJimWY991DXk7mIKH5afgOqrhK2QN8vVfx2YjDKesKSP4FKCjXfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501926; c=relaxed/simple; bh=8H2Ql6oifHkT4CjsqLdLoTTkCv7GeOjtLl6+VhEXK3Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n+PnzyZ6s4fmz5cQnPRfpgSZ+znfIq8Fom4oQ3MjyMLMy9AMV5x2S2i2zFBcNU56ODmxmcBMLvwwCMPLuwM5Dkr0W4E/DUWXZCPjnRkfdOOErl8/JjvMKIMRn9kh+RXPb4qtxWatp9AssTR+hTg5XkOtNvzG5DB4gQFALVgvkVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eHtJgOvu; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eHtJgOvu" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b8e9f89a8e3so359842666b.1 for ; Sat, 07 Feb 2026 14:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770501924; x=1771106724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CkQTUcevqbbom2GaQZHgQn6sBJw6oM5+vBUm2+nyG+U=; b=eHtJgOvuy2oElYjR859Wij2npV9D7oaW8AnAaZJ51eDDHJ2RNjZblcLjF66hw4RXDp YLZbCDlP9h5XT3jdZplj0glejiLcS9AoZG0JGHWzugQuY6HKZVz1/9+ZzLMxNGTrMMBF 0aGrZ60+799fLffwcoOFHu7XkvY45tmt4ZsjUigpKZHO/O2RLk1bId/rD3yZ4Ds7rfvs eGuuFHAJuPkPX19adN3Mbr8OoBS/ZiXWV65RVuGzq6/kMlNvAVrCYnh9WeHyvWk5oBGl tE0Uw5ePiUoxzQhq1Z3NMTjeRRg0jz1fydlR36y/dMTJK/gRTiXTXIki1fT0Rq2DdQH7 1riA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770501924; x=1771106724; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CkQTUcevqbbom2GaQZHgQn6sBJw6oM5+vBUm2+nyG+U=; b=Z2sIccgRznxS/UnA43BkrkYpIpB3pnMlAO1TWwhVp9M+1CFOCQWgrAVR9qDCvsl2X8 TFpxKXLZAuHXZFR4OQwB42/Wh5bft7LcmCCt25u/wxNdpkFpHiWj4u5ZY+dNMK+K9y00 YtSCVRNJHOP7zu9ZoVsU6gHnw4KYDM7jHjcX3ujUD4untVqUr7UVV+wPxNzzI6THlEcE Tu2NCfEDHOFd3awQ14014oufMBEGgsCPDgAzFoaq5vsTYI/fBB+9Dde3FSVaXiAIGurZ T7gp6avYSY4xnHdKbduhpqct99KuzeMS58Hr8JP8RwQkoCHqO2hCgURh/yp+DfiA0dk/ HUUg== X-Forwarded-Encrypted: i=1; AJvYcCVDIT0xcPPAG6rU4JHSL+SgXObJVvNMMiDmIYD5qS6tCHFCcuZtRDvHs+dZuuyw6bgfxkB+USLqsLBj680=@vger.kernel.org X-Gm-Message-State: AOJu0YykZMp/4vSx6tWHEYnOPZb/lfkIeqZWn215ehmyJOUuGg1tS8PV 1O3b0rQuYRt3WDX1EGGReTGwM4J9MW+GJvYxLC//7SMWr3KpnhPKA6gf X-Gm-Gg: AZuq6aIoCH+h8kJqvEhLDQ9Eh5jt8WXzCqFEE1YhG4SCQxSoZxcE4wigEKhFkm+DcY3 jcMCWQ9b9F8el2doi6GyBLweb3fqPdRy2JdMrNnSav0VdgLX+CsivDhVBbpIQvikAbeOtMxMTfe gAdVisSrF33eR/YEOb7mCKV4934VOAVug1+5zxk9FDAoILLRZ3OM//j7XGYwbERTCeXnxzrIi/A w8F8Y/pjKJIAxgNK1Omax5ZKIg7mQ7ek0reoixe2cvkqGzEvybyK1dQrRyQL05+NCkUmhkNygg0 yGcuW2M3jjTuSG97I3qgNsbLvZ55xue941s+a/C+wgoVkJyIiTFxERkbRD9RrnoFrYJS4OmO8Ry EdQPpM79vUL4jgFap+Yg5A8Nn4lUhO+RvqJtCWPSRyBWcojhNxF6KLPN5GYYJaXydDMz3X3ZfAt rkDJxZwAZ0PWaxfskaDW7AarQ2+pjh3ZY+3cnh7vfSIvhYtGPf4QBshTOznPMU63JU4ZEb9KfAF IoP8xx7/eXOeUP7IbeKfpXH85juDL32K3sofcTMOodTRYgaaIfc9gw2 X-Received: by 2002:a17:907:802:b0:b87:1590:d528 with SMTP id a640c23a62f3a-b8edf2fe560mr403194166b.40.1770501924363; Sat, 07 Feb 2026 14:05:24 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.od237066db22328bb-tp.internal (99.86.90.34.bc.googleusercontent.com. [34.90.86.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8eda7a46ffsm222487666b.17.2026.02.07.14.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 14:05:23 -0800 (PST) From: Artem Lytkin To: Andy Shevchenko , Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH] staging: fbtft: fix unchecked write return value in fb_agm1264k-fl Date: Sat, 7 Feb 2026 22:05:23 +0000 Message-ID: <20260207220523.3816-1-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The second call to par->fbtftops.write() does not capture the return value, so the subsequent error check tests a stale value from the first write call. Add the missing assignment so the error check applies to the correct write operation. Signed-off-by: Artem Lytkin Acked-by: Andy Shevchenko --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft= /fb_agm1264k-fl.c index 207d57854..b4883c365 100644 --- a/drivers/staging/fbtft/fb_agm1264k-fl.c +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c @@ -375,7 +375,7 @@ static int write_vmem(struct fbtft_par *par, size_t off= set, size_t len) =20 /* write bitmap */ gpiod_set_value(par->RS, 1); /* RS->1 (data mode) */ - par->fbtftops.write(par, buf, len); + ret =3D par->fbtftops.write(par, buf, len); if (ret < 0) dev_err(par->info->device, "write failed and returned: %d\n", --=20 2.43.0