From nobody Mon Feb 9 23:38:07 2026 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E839926FA77 for ; Sat, 7 Feb 2026 22:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501715; cv=none; b=cqWeilc7dAIOTcCTq4hilKSFk2YInh2DgDc7q5RyPg8vJxFdSFVxtB5DKLa5Cdm8a4/D3caXsmCaooQw08A/KM00OCZCAqzV9Mp+OncSkKK0d/CjaaMuK0jHYrdRx7l8MuY8nq39vhacJ4FtxzChsUto0QSAOBtoaMaXaInU0tE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501715; c=relaxed/simple; bh=5i28y3bOhvY7qUTiuP2vhHlAoptFOxVbl8rjHTYhd2o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A5iDD55qTcBzlktuz7yXlxyxvg3+7rwJdL+oBCnggQS/NeGR6VRpVv4XEBEMBd1Jrg4isHiBntDhwymamN15ZvJyklzJOxO/g/z0vP62zrisnlrriNtC8vJEjuw39mtr0a0sB7WzPv5ISo6ZAW3iufifFGviAgsm3oa8ViA+3DE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LmzuQU+b; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LmzuQU+b" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-8946e0884afso39093086d6.1 for ; Sat, 07 Feb 2026 14:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770501714; x=1771106514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=anCKl9qRpb11WqLX89rOt28JKjQak6JjoMzSr7aZOxQ=; b=LmzuQU+bOFiL9r9jCq/+l3nmYDNfv8ZbZ8xLIwGAY0HmGMIoNeYxyPxUIdcWwYByo2 nGb88TSBHcO5WKIsMNKR5mkOmneI7/4emF3TO6/UIyKCAN0shfx62YVfQQ1RqwYHFp9C u3Fly82DibFWcsCET+rF9d//eGZfroBPiVZJpMNi03YmZQ3yzUct5ZZmI+BqqFOdSWh7 7rquqzrSLD0Ihpn0ZQuChOnwZXnBhcKHA3Ej5J/JAWIGA4E0xYc/LB7syR+P0h2APkqp CnukxHll83TkkRpVQ5my0gOQIoA1e0K22Fr8Ara2qIfEQkHfzFK4EUiCB1sYSwL6gGXA v5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770501714; x=1771106514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=anCKl9qRpb11WqLX89rOt28JKjQak6JjoMzSr7aZOxQ=; b=YfhUDEECQ/xVlQyN4/tVnbh5ekX2zO0eTklGC0AUeSF6SnKlH2r15vY9MuJy/L0X8g knKzd/Ewl+hmTAmOQcr9tdNh69PpaybbBSJTpXWmJEC7FdjjgRpwZN7PBqfl90E7TP6C eG3YEqIxObARLccGUFgqaCnFdIEgWbMRf5dnqmK6u3Zzdk5pSsnkG3AaWC4WmqYmNiuR Rq0/I1ijraBv7DZ3BMeGmY9+Iuq+d6b+HPk4JQcsPAp18FoMrlS4+YdSqpF0Zkn++tVQ t0KHUg7lL1UWup5jKb7O5kNyoNKvtN3WQLbHhtjL0iK6tejjynQlw0LKvGUu3NhHEwuc gBxA== X-Forwarded-Encrypted: i=1; AJvYcCXI9k4e0nP+MSfFWte6XpVzk5jUMiAUCPCwmpiOpKRmFRiCjKRf2opjAZAm1oan0Yt/yaYsDCq+yrGUp+g=@vger.kernel.org X-Gm-Message-State: AOJu0YxscZFQ4fyTYhxnihUYzC34l9mPjHNhSRV759ku+wUFRiT/UNqK 2oG1NVCH2sYMRIM50TTXPFe1aefZOtRr1hKpbqG6GmFTq5BLcF9JpitT X-Gm-Gg: AZuq6aJB41qA1nMTTP7v3A03cd4EkjPQmV32m1gxNK+D1YJ7mb4cKpYFro+Vfxjc+/d xNo+KiwZbRFKnIoh7aGxkFjc4qlA9vNQVtEvQea1u8MGyrpCM/CSFumr4ES1Vj5XvEhRzVnk3PQ 3Zj0hg/ABY/bahb2rwzmOGMp4KUDRTPUXsE7SfuFhI/R0/JJVeORLE48y/Wz/c0LEE987Eo4ca3 WuQ3o46PmX5HAqVYJ0WAFWjN2avPXTiHhbsCoHP7CzROprNG6PBLRY/1nIlhq+4PTOkkWaDEu1z kMcKVDiWx7WzUBt/YEzI83Ih1o3hGZbHOARSdPCMxFS7Kxy9OwrX3hKDUhvDXjIGaxQgASnLIRC spsyUjxQbfA5gilBCvZ43dEoxPTugC6ZV5ESzGDEFJc/DRH6Fo3n3gVThGbggV/9oUlWQztw+My YtO9yNrho0J2ssj+DBev/xp7KU X-Received: by 2002:a05:6214:492:b0:894:6c8e:ed1c with SMTP id 6a1803df08f44-8953c7d62e7mr102501196d6.5.1770501713932; Sat, 07 Feb 2026 14:01:53 -0800 (PST) Received: from localhost ([132.216.195.165]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8caf4a97997sm452720585a.0.2026.02.07.14.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 14:01:53 -0800 (PST) From: William Hansen-Baird To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, david.laight.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, William Hansen-Baird Subject: [PATCH v4] staging: rtl8723bs: replace ternary min comparison with min() Date: Sat, 7 Feb 2026 17:01:36 -0500 Message-ID: <20260207220136.67923-1-william.hansen.baird@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change type of local variable wpa_ie_len from int to u8. wpa_ie_len gets its value either from elems->wpa_ie_len or elems->rsn_ie_len which are both u8, and thus there's no reason to cast them to int. This allows rewriting ternary min comparison using the min() function from linux/minmax.h as now both sides are unsigned. Rewrite as well wpa_ie_len + 2 to wpa_ie_len + 2u, to keep the expression unsigned and avoid overflows. Signed-off-by: William Hansen-Baird Reviewed-by: Dan Carpenter --- v4: -Rebased changes on main tree rather than previous patches. v3: -Applied feedback from David Laight and Dan Carpenter -Reorder include alphabetically -Made wpa_ie_len unsigned -Rewrote title and body to reflect change from min_t() to min(), as min_t() is now unnecessary after changes, and should be avoided. v2: -Drop unrelated style changes and fix style issues by running checkpatch. -Keep min_t() to make the signedness of the comparison explicit. drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..4c3a89064c3f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -8,6 +8,7 @@ #include #include #include +#include #include =20 static struct mlme_handler mlme_sta_tbl[] =3D { @@ -936,7 +937,8 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) struct sta_info *pstat; unsigned char *p, *pos, *wpa_ie; unsigned char WMM_IE[] =3D {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01}; - int i, ie_len, wpa_ie_len, left; + int i, ie_len, left; + u8 wpa_ie_len; unsigned char supportRate[16]; int supportRateNum; unsigned short status =3D WLAN_STATUS_SUCCESS; @@ -1158,7 +1160,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) pstat->flags |=3D WLAN_STA_WPS; copy_len =3D 0; } else { - copy_len =3D ((wpa_ie_len+2) > sizeof(pstat->wpa_ie)) ? (sizeof(pstat->= wpa_ie)):(wpa_ie_len+2); + copy_len =3D min(sizeof(pstat->wpa_ie), wpa_ie_len + 2u); } =20 =20 --=20 2.52.0