From nobody Sun Feb 8 21:27:16 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F4382882B4 for ; Sat, 7 Feb 2026 21:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501305; cv=none; b=UOMuLDDd2m18d58gv3ooEH7+ISCBmxlpAOveq1KOotNdp+rSkbgB4fsxCmWX4gieHjs22bPF0R4I2vAm7rN4YSKFr8RTgucRJ136SXWz+xdWqHNx4YH5tmr8LXDoP2N9cAhD+MEqdDROBb3djtxxk+zxuOTkik3Jqrq/M1zWPP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770501305; c=relaxed/simple; bh=PQjivCNOY439ktYx5tKX1e++2US1TGIavnBo/qyhzOY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tFYuqGhNjao9jC+XK+Lq+NIjODO6fWfbBXrqy2MGZVEay/Zhtbt1Wj0Kk+6Z8pjrRiMMCdWkjsq4pa+vQFbj/E6WtpoZP6TCQTDQFMGWX2Q1ZcL7/o7YJ6IwWrmHFvPx1e98gYUjB+v0s9oGQYIEDSkrxBKUVCqPk1sDgeWKywE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LDdZssf/; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LDdZssf/" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b884a84e655so471496666b.0 for ; Sat, 07 Feb 2026 13:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770501304; x=1771106104; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D0DWgxZB6DONIOv0yYTd0CypbGD8Y7w74yVvt15oBiM=; b=LDdZssf/CejcEUEAGW948F8+AoIMT77nDOSqkgT7V/ga519xfAUmDPWWLIIGtlfUDJ bWhVvjM/T7Fw2tOWrBKDve3KBMPaW8Y8wnFeh58qdLu9kZmtlUtDdq9aE7QEt5Y1Bp5A S4KQGFC7kwQEAIXfIzKTm9UEkEljdhVhl6s3nY3cGPwMlZ9tMHtHZj3qbyzuRSC20tbw r6NYrXlwKqE49a3Upk6GPS+t77NjivL25ubTd2p7tYZpviTwiF/E+HF0WygXcoPVk5fL o+DedjV8iOIoXxdCkanPYwpugvC/UNaooLxuzKCl8J6QP0uN0/dv5nLoQHoIxP2uBX9p cJFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770501304; x=1771106104; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D0DWgxZB6DONIOv0yYTd0CypbGD8Y7w74yVvt15oBiM=; b=EQNr6+q0a0MpbYr4Lp6qWx5c7mpnTdZOXbFg2BDWsrjUmfavF/TH8JifbKH3wW9kh7 yGCV7H48j2tFPIXt2i6Jr2V9S3Zw6qXZrkaufqiIpSxEpHMjPe5Y8n2JkIKLxJg02Ztk 5etyu4x/HQHReKB8xSSxo0z3nSEoq4DWVp03kfFAzU/7MM/JNpvDFRY6GWwK+6jjjC+q H5jTLz21CDQKrSKNVjXrWOTIpvRqZ7klnr6PrVS9OKQPaD+RkQeX+c0qymf8kSRiF8cX xFsh5ylbjxV5lX1CtGTQ5KfvMXZZkhlBctuF/dwWhgyziBN5eVLfJA/PyrILz9a9dAuU Uliw== X-Forwarded-Encrypted: i=1; AJvYcCV2fPQ1fgnwtKvQE5ZPWzgz8kBUs/PySovhLVKWHWQN69VV694IpBPWeyd6fgnB8Fy32Ja874RG7VggEMY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5qRHQqs5igkL8+4+H82dL3awAB1BL3RojPtID1vrPwAc72V3I k2BKEOLXtmDPjW37XobrMO9v2wHOG5lRTvGWAGJSiwKLioKu/C40U4gw X-Gm-Gg: AZuq6aLXnQTBSgt5HFH8+DAooHWWxnhPuMD4VtM7d9e6rTUXFRIVKnZRUMZbQpUPmt8 0pUrUVQmdSTAvU0V0WH7dldeOQ1FrghnStN5k1nTAXish1PaVLx2wnMB37ZFA55EIHkhczqPc3Y YiAhEpdCgK/7bg+N2WZqRZpYpKtSbtuNSz1Glpr2yuhfteukcj6ibcbtsYl8BdwqD2ysfqVR6Ob tFUqM52K0L9hWNE+x6R9sBrGl52AodHHrJsonii9JtrSlPM+zaeOoqKw6dvCHhuNPnckD77H5jw uvsE/TLziUhH0BgaECq2cSAR147twSxetDIN+HnfLPEnNsyE/Tre0WwHTX9E4MZ1ilkAwRwMTh2 it4OXatKn7b/2TgVqzoIWkwAuNmXrm14qf3PNG4K6/ERbegzUR1m0E8+uzNG4v5mKHDUScJ+7q6 EC4g4lYV6YtClgw8EZ4X8ObtbzOLEf+9jsMTUGaM4B+MDZPtE2vNl+pYaBNxnixojhqX1uys+n7 4nOOnrGnCefSC/qWU3HQpHApGKryJAlTMmIzfiTz55RO05yrKJlc6XWSIAv3Az3V5Q= X-Received: by 2002:a17:907:3d50:b0:b8e:2a8a:430d with SMTP id a640c23a62f3a-b8edf22fc44mr357048266b.26.1770501303318; Sat, 07 Feb 2026 13:55:03 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.od237066db22328bb-tp.internal (99.86.90.34.bc.googleusercontent.com. [34.90.86.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8eda7a3045sm218635666b.22.2026.02.07.13.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 13:55:02 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH] staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init Date: Sat, 7 Feb 2026 21:55:02 +0000 Message-ID: <20260207215502.1961-1-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move the NULL check for bridge->crcsr_kernel before its use in fake_ptr_to_pci(). While fake_ptr_to_pci() is a simple cast that handles NULL safely, using a value before validating it is a bad pattern that static analyzers flag and could become a real issue if fake_ptr_to_pci() changes in the future. Signed-off-by: Artem Lytkin Reviewed-by: Ethan Tidmore --- drivers/staging/vme_user/vme_fake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user= /vme_fake.c index 731fbba17..506bc5439 100644 --- a/drivers/staging/vme_user/vme_fake.c +++ b/drivers/staging/vme_user/vme_fake.c @@ -1029,9 +1029,9 @@ static int fake_crcsr_init(struct vme_bridge *fake_br= idge) =20 /* Allocate mem for CR/CSR image */ bridge->crcsr_kernel =3D kzalloc(VME_CRCSR_BUF_SIZE, GFP_KERNEL); - bridge->crcsr_bus =3D fake_ptr_to_pci(bridge->crcsr_kernel); if (!bridge->crcsr_kernel) return -ENOMEM; + bridge->crcsr_bus =3D fake_ptr_to_pci(bridge->crcsr_kernel); =20 vstat =3D fake_slot_get(fake_bridge); =20 --=20 2.43.0