From nobody Mon Feb 9 15:08:39 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E172C3542EB for ; Sat, 7 Feb 2026 21:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770498523; cv=none; b=qBAh48aoapv0rrJkjA0e9FIDNv4an7yRSccuDQuOPsyYQSJIdwLVJyd76iZBNUDaVdTIv0pVC+BK0B4ZT0KgbB5Rlg0ZOwrT8qQFFTDQ+xiH9hxyOHiHzzLlY9bKvOAuAKmRu3CPmU/CVyiTSv4PhaVvRAdr5RxTDQZKyZnQ5aE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770498523; c=relaxed/simple; bh=ZIlr47XYC6O3tGdR2UH0kFG4K374+y+PTnueSMvm5ck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D1GeDf6/9JgxpMuwyyYna/WOhwgTR0Jdc6KgAb5OO74OersSSLzSWvhkC2AzXLvBlywtngoU4PN4D3hrcy0bf7rMORJ7PMlviOaS8CoYqen2ZuSvsgZmdb38peFoZpQcY+u4lwcZuMOEi2XTN/p6PDfSSA5uxJY+5WzvneagOik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CkTzTKsl; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkTzTKsl" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2ba6aa57d5fso2549eec.1 for ; Sat, 07 Feb 2026 13:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770498522; x=1771103322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kCBIlVtV+zq8f7gfIO2xxsTQyhC9pk+Xjp2VgrBosxw=; b=CkTzTKsl5YZaXwwVIq/Q/XCExA6+YYmFqpzLtbMB752vVe4TlPSsPrmWlZZQ357U4D x+mJ4Q0x8+3Hf3yVhp6sZaqL2X4tczPkn6TmtB0c+1bEWrGdPZG3HC+Qhi1huYZSprH+ agO0H06nVPQyv0aGjopibodNhDfWupERT2Kb5bRcEi+oy4444EU6TGNS5gFAQjHtnFn0 8dPkKBl4ZBrzMUWPEDjPwi4SNlvpNG2cArx+w5wa2aTqOjgwkXXj9ts1x7MN/MgrCn4q DKLiZWZPD6I72WRQRQDKZNrO7t0zoPCH7lX/G14x1iFum90Ew74ta59qc5upN8sXmaQl YH8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770498522; x=1771103322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kCBIlVtV+zq8f7gfIO2xxsTQyhC9pk+Xjp2VgrBosxw=; b=fVkIwSuZFUwfNCK+QJgx9B2SAghhs2y5nP8+3050sG4EJSQh/pNcEias+UoN2qFyZB eXatLS5i6wsId7T7drGF3Kcir8xMQiOIxUsHpMg7o/rcjBKDgKLeA8SVFmWLU2rj+4Zu KxutppGOLcU6gDQcx/Wql5HjHvPaBoaxN77ze70mRgET7bsrT7IHoMrTLjonh/6a1JYb LgpIHzayvRgU3L6/7Pt5sPsBzDwfZbw7Il14JyUVY+iudpQgXkA0Y72XPV/rPt2tSPQj 7/zNjeTzKBq3AuGAjOIBP7WCOxTBkiKuTseEX11Hsj1CaF365TPq0A7wUFU+Moouus78 EoaQ== X-Forwarded-Encrypted: i=1; AJvYcCWdjz6rjuMxyD6ElS+BSZ8VGy23WWhutnazjiRQLnE6+wtOx40k3vTF0ZGjTu0YD4Dw/0QJrQoGaC3tVk8=@vger.kernel.org X-Gm-Message-State: AOJu0YxzMA4x8yu44+gpiyoAAHTUNnlt57UfQMlvujApQ2vGlqni8lI4 uLRxY8Q7B0khYMEuAUeKria94NbSTjQnklGOmGvCvgCd2+uE7SODzNRj X-Gm-Gg: AZuq6aKGjB9IYnXbFO6y8RIuf0D7xDP2FuswxKQHdjDwoIA7VOn1NjFESeaVE1gyc3f JXeA6hycXcL4mNvzHZ7jmZEvSpLSVyYta6BWuyRmSyDDjFzQq/6sJlTpUFm0EGdSfh4Pi41bV8h jjE+JhY4l1bm+EoNxjnCPKIUsIZqYb+ZpeCVpTC19rnzamnfeHJjEDspA0apC6mKAVDKYHnxwEm rYTFM0GR2QT4MU9GCLyE5EwRxk+ZJO9XLXzj+GLf1Qhkiu0R9EHyKF5/myCtzKUwlFdlJo/Nw8s XuLANL1E5qH9cLn3X290ZPFYWkDIKcuHDsy6Us5Kp7/rLOHrSjhbhkcDNzWmEWostPVHNjhBb7d GKR8jlvRpMpFh07bFoTi8HUOJfhWkx/O5R8CrZqpWXbmFkOnQvVVH42GvLuCxXVTZWMrIMxjUgZ 5gO3/T7DeanURcXfe/VBgN5tOZjFznqKBQ95VJKdrgTbaWPiTtpaEGvMKUyLaIc3ws41eivChva WA= X-Received: by 2002:a05:7300:7b94:b0:2b0:5028:bafd with SMTP id 5a478bee46e88-2b856453d5cmr2860785eec.8.1770498521927; Sat, 07 Feb 2026 13:08:41 -0800 (PST) Received: from jason-hall-A520-B.. ([2600:8800:41a0:8000:987e:6d8e:7cd5:6e71]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855afdbfbsm4504628eec.11.2026.02.07.13.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 13:08:41 -0800 (PST) From: Jason Hall To: Miguel Ojeda , Joe Perches Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Boqun Feng , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dirk Behme , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Jason Hall Subject: [PATCH v8 2/2] scripts: checkpatch: add RUST_UNWRAP lint Date: Sat, 7 Feb 2026 14:07:46 -0700 Message-ID: <20260207210805.196759-3-jason.kei.hall@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260207210805.196759-1-jason.kei.hall@gmail.com> References: <20260207210805.196759-1-jason.kei.hall@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Warn against the use of .unwrap() and .expect() unless accompanied by a '// PANIC:' comment. This enforces safety standards in the Rust- for-Linux project until upstream Clippy lints are integrated. Suggested-by: Miguel Ojeda Link: https://github.com/Rust-for-linux/linux/issues/1191 Signed-off-by: Jason Hall --- scripts/rust_checkpatch.pl | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/scripts/rust_checkpatch.pl b/scripts/rust_checkpatch.pl index 56c1bc29d3f2..9a4e256a4ec4 100644 --- a/scripts/rust_checkpatch.pl +++ b/scripts/rust_checkpatch.pl @@ -9,7 +9,21 @@ use warnings; sub process_rust { my ($line, $rawline, $herecurr) =3D @_; =20 - # Reserve for future Rust-specific lints + # Check for Rust unwrap/expect usage. + # We skip lines that are already comments, assert macros (common in te= sts), + # or have a '// PANIC:' justification. + if ($line =3D~ /^\+/) { + if ($line =3D~ /(?:\.|::)(?:unwrap|expect)\s*\(/ && + $rawline !~ /\/\/\s*PANIC:/ && + $line !~ /^\+\s*\/\// && + $line !~ /^\+\s*assert/) { + return ("RUST_UNWRAP", + "unwrap() and expect() should generally be avoided in = Rust kernel code.\n" . + "If the use is intended, please justify it with a '// = PANIC:' comment.\n" . + "See: https://rust.docs.kernel.org/kernel/error/type.R= esult.html#error-codes-in-c-and-rust\n" . + $herecurr); + } + } return (); } =20 --=20 2.43.0