From nobody Mon Feb 9 17:59:54 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BBE2D0C62 for ; Sun, 8 Feb 2026 04:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523453; cv=none; b=XZzHxkapIZCHEs0xwrLwUO/C3gHrJn+qYJIicMrP24Bq5zpAWogFmIBoeKGLrJKVIuu2i1E/fpW7zRGddbv7rGCzMGzL/a6BxckWrgdkfWiquEatimcejuMYYojF8+OtuIO96pdyQaPv3IWzAujH3PqXeJijZ6Ve1SwF4vps6Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523453; c=relaxed/simple; bh=JpvsAwKddEADXQxk09Dwny3N8gtaPchBx889GIKR2NI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MYohxcRBC0UEfds/rf70BvQcWTn+rCmicdr3xP6h7Q4e5e49g3HY1xnJw4gDKZzucqMe6tJgVwLTe3ctjfpbi/eZSahSVaHo4Tcnxqrfi9YS3Jg/mbDy2N+eFZXQTrHULRMaMuJuuzHjuFiPsCNQuIJfD17jp7KZg+RdN6m+QZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O+29arQk; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O+29arQk" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-1233b953bebso8196850c88.1 for ; Sat, 07 Feb 2026 20:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523452; x=1771128252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z+bhAXarAsiDSi4QI3h1a+wfZmeyXg3FMQowAFnpxGg=; b=O+29arQk+1P7++u+ZGydSNTyRVzibEtJv08Cn3LoRy3PjgGSzKi+HmP121viEZXO4z s/vXxY9WQwb0SxYP2Fo3edwdMGwGEi7+MDvn741aZHp4jkAVGLvu755RfBynMBjyKJLQ muLlR6Ke6R2U55ROx0fdFiJ+z0iva2okVmuMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523452; x=1771128252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z+bhAXarAsiDSi4QI3h1a+wfZmeyXg3FMQowAFnpxGg=; b=pP9u+vlAXouWZwA4iZtqRtgaWaHVpwcrsSWOJN0jmQRs7EBQxUX3t4Fp7DHYL6Q5LR HhAy7BWqILZpWev2+gQ+NSYPggvEObiJaUAcy62G/ENs6QJAwPIKD++4awh7EGYf3ZPw 6ed9ofZX1NRf8PmVcuPnzclRmJF7WTwMqQgrTolnwkAl8i+BN0UfgWrfNf+j2XgPx4dX wsljf1HbUz+eNFAkjzXC2jxsPfXaU4pxzhXnSJ8u5lr75nf+pZSfMeBDTLec2phbYN+U 16C3XACH01MD+WJcK1Co5ch2bm9GkAZf5C9GgdXIGYsCPc6/t5fbtLkHo6z8DvAJ3nDO AonQ== X-Forwarded-Encrypted: i=1; AJvYcCX49Hu0FkACc37TIrH79DFGfPbbtl2qFb85uOAibRribFMVE4E5Ud/sHLs43NIhEs8Ih1l9bM6KlTQ+YuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpWibKIGYLn8Easeisqu+HNkml3r0pSslqYMHBE4kKEj5PMnQP rFNbYWdeNU97gV2hJN5Gl/eYKBnDNUpuMKL/anANCllkhg5zKZ80tiYJdKkkcBehZg== X-Gm-Gg: AZuq6aJR4OC3W0lHwCaLA/uJ91jc1rzG7e948leYXvwKob4NrkmXWTLsJjBjQXMSA2C em6Vu7tiBiaee749unqyvq5qIzwnIHhHgPn0VEtD2iIXRIt9tKpvfLtfMA6XmOmPgrAUwWXINSj 82O8FjPbqhHTV1CYVm43zsR/22ahDV6GeqLE1ZkSywlG3nsHNch78pUZxcAXze530FDlcdzK3iN ApI1+pSrwetUP+YTzg7cXs8JQlFVoK9AQph3fodpZtAUSOO1Atr55uWENjLlxl1sz0hU5LeYqYN QUkYw1yOWTHL/A2x8mTS4f/W8OewhKjug9kSyQGhekzpz0AAMbAkLxHJzF7n+BmObjdf1WAn/O0 mN9HdTwtRgkQQrByOJN/9dZeVc8OT3Y/OilDw4ZsQZw7N4cmjwodNNH59zdNZ0iaztcrJsbIXe0 3bAcE304G3ilX9FJUnHjlsrHQT67K+CCdpMJba3PhM/fGsXdBxaxK62u09tQijvi8EPPvTkYA= X-Received: by 2002:a05:7022:6ba3:b0:11b:8278:9f3a with SMTP id a92af1059eb24-12703fe4606mr3754776c88.8.1770523451893; Sat, 07 Feb 2026 20:04:11 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:10 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , arm-scmi@vger.kernel.org, cristian.marussi@arm.com, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sudeep.holla@kernel.org Subject: [PATCH v2 03/15] firmware: arm_scmi: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:25 -0800 Message-ID: <20260207200128.v2.3.I4a01e1fa771c0b1ea7e35882784e4b7f8f33f65b@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). The mbox_ring_doorbell() explicitly documents not to call mbox_client_txdone() for doorbells, so remove the call. NOTE: this mailbox client appears to send doorbells and regular messages on the same mailbox channel (smbox->chan), so it needs some extra attention. Specifically, the new API behaves differently if you ring a doorbell while a non-doorbell message is in progress. I don't believe that this is something we have to worry about with this mailbox client, though, because the code was calling mbox_client_txdone() after sending the NULL message. Had a non-mailbox message been in progress, that would have marked the in-progress message as done instead of marking the NULL message as done. Signed-off-by: Douglas Anderson Tested-by: Cristian Marussi --- Given that this mailbox client appears to exercise the mixed doorbell/normal message case and the behavior there changed a tiny bit, I'd love any extra scrutiny on this patch. Thanks! (no changes since v1) drivers/firmware/arm_scmi/transports/mailbox.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmw= are/arm_scmi/transports/mailbox.c index ae0f67e6cc45..c4561441ac2e 100644 --- a/drivers/firmware/arm_scmi/transports/mailbox.c +++ b/drivers/firmware/arm_scmi/transports/mailbox.c @@ -324,7 +324,6 @@ static void mailbox_clear_channel(struct scmi_chan_info= *cinfo) { struct scmi_mailbox *smbox =3D cinfo->transport_info; struct mbox_chan *intr_chan; - int ret; =20 core->shmem->clear_channel(smbox->shmem); =20 @@ -338,12 +337,7 @@ static void mailbox_clear_channel(struct scmi_chan_inf= o *cinfo) else return; =20 - ret =3D mbox_send_message(intr_chan, NULL); - /* mbox_send_message returns non-negative value on success, so reset */ - if (ret > 0) - ret =3D 0; - - mbox_client_txdone(intr_chan, ret); + mbox_ring_doorbell(intr_chan); } =20 static bool --=20 2.53.0.rc2.204.g2597b5adb4-goog