From nobody Mon Feb 9 14:33:50 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47143288515 for ; Sun, 8 Feb 2026 04:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523450; cv=none; b=dfK4X+nj1Vntg+jdvXg8PyLGcaonfcsgp3kYH5fwjedWXIl49UwlAlt1Rm0l8ixse0871eRAFd5aJ3MSBpz2qqH4977bCKuYX319adP1kIemdicg+qegHzIgvzNM9y57GC9nkyENZN09N8yPJb/GVuhvhNCemCIVzab2c94h6g0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523450; c=relaxed/simple; bh=SwRM9LTR2QUOgaPTFf+sezPTqw3NitYdjpeSCcdcW0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NJ/9ZPGmbXOymMgSXEl81uL2G1rfJKS3U50RtBjdoHGlBbgzC2DVFzVOKhF4JXczisPZEt8EICkHHg7lNM/quiJjVdxWEoTFmbCBDoXcG9hZu3JqCcS5OqQat4Ioty3xVJHKHmLt0JaWpYhkvLjjMlHM4SF3p70C6kEr0WBZVVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kyVk2OVv; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kyVk2OVv" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-124a1b4dd40so6661218c88.0 for ; Sat, 07 Feb 2026 20:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523449; x=1771128249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eDmFN1mVg5seJ+q06CZhGBYTZV2fU/sK9RfIemTnpDU=; b=kyVk2OVvyLzq7C7CaEbShgB15EOVqQp6qAohRkw4VHSQQW+Cz3Nx6BsrzQgVCe4lVZ 1BFBmn6dtKwG1T7HWaaV1n6+is0n776L3xioyIWAP8drz6bI+t8cSEtJzPiJmGX7j1Hk XNUsD0lfnY8W58dUFYSvR5W2EQqB5c6dit4cM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523449; x=1771128249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eDmFN1mVg5seJ+q06CZhGBYTZV2fU/sK9RfIemTnpDU=; b=R5T2f/fI71A8lFxKUc1iQGu1GeBCRjxa52dIDqsClE4ZTa9mysEnau54OygBD3VY4y e9BZjtdFoa7vMDtbp6Xrpt/ORbk/NxRpc9RtK6Hgnw7Um+dmUHsrWOpYhFnjqGT/IRhM SGmb93q4BF1RLjL2kbr46EUatZEukJduDVbfjHNh1e4kFFxDUhAkaKcnRDjHeT5UawHS JZtZyc79RB7MBYayk1gFbEmhwbTYbOtPHcpQ0kUefAKoJUTB33bfrF7WNjGrMlShh7Cc 1LJxlzr/RlJsnesJBkQiBO4TWZajkSeXDHYpyD4cBV7ejCDC6MIei1naATUB/AxBHrtT l/EA== X-Forwarded-Encrypted: i=1; AJvYcCUQ2L91ocuGEv6wHAq6WpIJFy2Z4jSuQen9n9aTh7qnmlBSS+/QW9gN9oosYgVHJoM3UnTWZu9MOijjJEM=@vger.kernel.org X-Gm-Message-State: AOJu0YwhEdlr5KNdwRqogVCu6k2kNvnNO0A3M79f+auEylHLW6al+w3b 92ePx0PebvF9h3x/8DOAeVi6qeR9o9y7dP0smf7jNQlmkoBbxdsBxhoVi2x6E07VgQ== X-Gm-Gg: AZuq6aKeoZYYKu0a/H1TFGwmQ9ie0KwbWsZVBIqClIlhbpogoBYgjeoZdcPGKlSlZHr 6YnqUEARWugVjSORY3mgnoIEJP8o+a0uhR6+TCbB64hbkeeTlDsIbUmv5q58kmakn5qG5p4HU5Q tgWiQT4/vbSLm5B2wBqVl3NrPBIeZ9E78eMXTOFQFTtEeIFAvhNZXPf1Ow0ij7nYZ5bAGib3l2n sc81f2cvFmBpJDBlcn6jKLERAI06+q6dg4rqO2D7tkeA8ZS7OFAsHlTLk5u2Tp0E3/zqVRf8tm/ lJlys/8yIyGghFRjvlqf6rVvdtOtKGi9z3Qw+XkK0TrJgw88NR20fRAn7ELm2AZT3dJc/CSu6sl aiQZaG12ppYM502I4mPmYn7hsco2hLbHsDKTWb6Z8bqapqDwm1knbtSZSHtj2rBh4T+OQ9IbyDJ ZefqI9IvLBkBjbnq271Kf3h3s4A5jCNCBVPD+sHgQndPmJ9oolrr0ynlKwBadI3o+ksxGsen4= X-Received: by 2002:a05:7022:6ba6:b0:124:8d7d:2d63 with SMTP id a92af1059eb24-1270401e29fmr4298462c88.35.1770523449409; Sat, 07 Feb 2026 20:04:09 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:07 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org Subject: [PATCH v2 02/15] ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:24 -0800 Message-ID: <20260207200128.v2.2.Ibc0c2b7d0280f23aecade13c49dedc2bb7fdd7a2@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). From code inspection, it appears that this driver only ever sends NULL messages and thus the conversion is straightforward. The only change is to remove the call to mbox_chan_txdone(). The call wouldn't have done anything in the past anyway (since chan->active_req was NULL) but with doorbells it's officially documented to not be needed. Signed-off-by: Douglas Anderson --- Something seemed a little fishy in this code. The code seems to be a _client_ of a mailbox, yet it was calling mbox_chan_txdone() which is something mailbox _controllers_ are supposed to call when their "txdone" interrupt goes off. It appears that this client even reaches into the mailbox controller and confirms that `txdone_irq` is set, which should mean that the controller itself signals txdone. If the mailbox controller is actually signaling "txdone" it should ideally be improved to not do so for doorbell (NULL) messages, but it won't matter much for this client since we only ever send doorbells and don't care about the txdone callback. (no changes since v1) drivers/acpi/acpi_pcc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index e3f302b9dee5..3d240ecd98f4 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -106,7 +106,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, /* Write to Shared Memory */ memcpy_toio(data->pcc_chan->shmem, (void *)value, data->ctx.length); =20 - ret =3D mbox_send_message(data->pcc_chan->mchan, NULL); + ret =3D mbox_ring_doorbell(data->pcc_chan->mchan); if (ret < 0) return AE_ERROR; =20 @@ -123,8 +123,6 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, return AE_TIME; } =20 - mbox_chan_txdone(data->pcc_chan->mchan, ret); - memcpy_fromio(value, data->pcc_chan->shmem, data->ctx.length); =20 return AE_OK; --=20 2.53.0.rc2.204.g2597b5adb4-goog