From nobody Mon Feb 9 23:40:29 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B28293C4E for ; Sun, 8 Feb 2026 04:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523478; cv=none; b=d+JY9jZmou/WwDJE+r881wW6Yy7IG449Co2EYqXuCukI/t5O/FuO82GKY2/OcayAuRNLJqvGrc/sWlvE4WLWiNqeQhzNVBjPZtrSFl3x0BLp2ZmF7wtMUOuaGsfivmZZWGAZa2k71YLywg8N6gsH5Rh1JHZ8kpewn1V2dn6YC/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523478; c=relaxed/simple; bh=SAIOYHmewH8+YpnZCmSgyUNdDUrB0z7/bJKOh98QEn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tYsya1Nu6vG5kYlfcQSdmewm8Pn2kw5j/3VJxBADQZGIiBJIbQVUrSfibkccHkUGSRnr+fXqiMMRGScsmoFcwvw/s2RFWgn4b92HYiLcQQRg6bVag82/94Gwqt6YJ6qvf6h0Y/u23GaTwAFCTMhDgmHpvJJNUpw7SwuFFXrfeP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Cj3qW0yz; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cj3qW0yz" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2ba64b5a53aso340619eec.0 for ; Sat, 07 Feb 2026 20:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523477; x=1771128277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rhq2fvDAB+z0+8+dqvd5EVUWoDgUFedDXtHNQ2aZ3r8=; b=Cj3qW0yzM0kMFj7sHk2DuAmK/FBfwUDIrELDp3q5Pedyt6x9lC81zMsAJXBkiXTmc7 QmDEyVqdLqDb8yxHFi7n/3fhMMdPj7EylK3EXgySiFLOJECiTZ4qCWz6EnAXEOQ8pEwN Syv5+CFuMSTJMx43yaHKCTOWJoM2X+ut8+KGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523477; x=1771128277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rhq2fvDAB+z0+8+dqvd5EVUWoDgUFedDXtHNQ2aZ3r8=; b=BEs1H2ZcRGLX7/mFJ9anZCowHmR/7FKWdRP3wJZBvYfMuP4NxYTliP3CBPPEtZSLN6 7KdbYKtBE4KuuMUkoozcozatjlFK+bgEzasEanbVo8hGnoja9BoD4MBOT4fmvkFR+eTN 4v7o8EhnVPOB60V3ipAPWf0OSaAZ5xgeZ227IpqTdsoodMlWmp1BgQeOnAQi8FfXg46y tybNeVK8brIVANtyoaS6ITgy7r95IB7MqvV+zx+B3680aPOB8laSMecpEk2aUeKCDJTq Sbrs9Go+MEfbidlTni/SMEO/YUoqFPxFLwQZyJO4TLIlM1tfc2B1m6iZ1Tx9o5cuZm/M 7XlA== X-Forwarded-Encrypted: i=1; AJvYcCW6xazXi0LJBJPl2s0wu12hitvASSjYp7pL/ZVzXVA0/XyKssACUHMPYhOnNg/YnIZU3JuARepQUjSsqqA=@vger.kernel.org X-Gm-Message-State: AOJu0YzTTRMp3rHjQ/lgJAlw89Do29kDHvbT16Qf6Gm7gN+nPa8q97la kOTQRFe9uElhVHYpJ7zZKNYItAVkWqVs8Ym4tCalXQ9JrXmymlER53Ye3V/SMJKCCQ== X-Gm-Gg: AZuq6aIDGmySSG1K4irPh3Uaoc3GUhKajXdjY1JIk63Y07fUMJWx79WAB5WJJkRfpmt Q5Tnes22bMoWHRl468YG/9Uk+wbVj/XCjLlbJuxXg9jNPt9y/iWBhw8pbS7aYmmLnjVFMix2WvQ TXDLgRwmAiLv/vV3MfSKVB+ecvOiMRFOrxHh1dtzkH4Ok4X1MAoy3VU8v5cP6oreYPhN4EJK+D9 1A2x/5txyJqX8FREMY4lpOdS8CxWbMsiIGmQ2xgaiu/Irhm6dx4m4k6tAHN9l4Qc5ngyVc6xVx7 B0SmtetsZxM5K014dbEtTLBsfPgG3f4o2reN8seKW9xjPLgLDH2O8UOTh+AtUtqHmZwyXrHGXuc Nhc7dcmou+lolsvJht/j/vCmvffFjiSFessYsdnfZvOgnQpDC6XCRTLWgZt2xgJJYAZ/shj5ERe v2s+KhghB4ER5Gwm1PNWhGG6AwzKb1z0TE34HNR+3gvMrP9RooaZhO/6LboI72BoTyqf0kot4= X-Received: by 2002:a05:7301:38a6:b0:2b8:209d:5983 with SMTP id 5a478bee46e88-2b856833715mr2948032eec.29.1770523476783; Sat, 07 Feb 2026 20:04:36 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:04:35 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 10/15] rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message Date: Sat, 7 Feb 2026 20:01:32 -0800 Message-ID: <20260207200128.v2.10.Idbe327f5b4ce65a284b55033627d0819e2fed21b@changeid> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog In-Reply-To: <20260208040240.1971442-1-dianders@chromium.org> References: <20260208040240.1971442-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Also remove the comment about the only cause of errors for mbox_send_message() being if the framework's FIFO was full since we don't queue doorbells. Signed-off-by: Douglas Anderson Acked-by: Bjorn Andersson --- (no changes since v1) drivers/rpmsg/qcom_smd.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 42594f5ee438..afe1177d092e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -371,17 +371,10 @@ static void qcom_smd_signal_channel(struct qcom_smd_c= hannel *channel) { struct qcom_smd_edge *edge =3D channel->edge; =20 - if (edge->mbox_chan) { - /* - * We can ignore a failing mbox_send_message() as the only - * possible cause is that the FIFO in the framework is full of - * other writes to the same bit. - */ - mbox_send_message(edge->mbox_chan, NULL); - mbox_client_txdone(edge->mbox_chan, 0); - } else { + if (edge->mbox_chan) + mbox_ring_doorbell(edge->mbox_chan); + else regmap_write(edge->ipc_regmap, edge->ipc_offset, BIT(edge->ipc_bit)); - } } =20 /* --=20 2.53.0.rc2.204.g2597b5adb4-goog