From nobody Sat Feb 7 23:10:49 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4629A16DEB1 for ; Sat, 7 Feb 2026 18:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770489449; cv=none; b=JFekv+gHfqG8i+7ZHGDnF1tSHU7CEFWw9pAUg6a5CyKZkVav14LU0Ft7IGNQyZBg5/1Ly45FZivKr5PJavWWcNhq3ISOdxs4RJ+GWkmGgefcEIB9b+f2cP+nVAdgoYc44cyF6bnxLhl1WuODPDvRbchO70SOZRHEJ8Ei8pKOLVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770489449; c=relaxed/simple; bh=IwNe4bGG0w1C6uBmZeZgOUv6+ikf5UPlumcZkTErkAE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KSU8BX1piGtwfnhzvqjr7b/Igz/NlVMXTh0C9ldvMO3uP50sF+zst7/GVnthfxXLg81W4w1vkG1nrGlf56poyZZiZzdT82hxkNPNiTNHUtv53WcPRSnY5xSx69dm4sQMejRmaAbDPDn58LzNm2QvVOXloKpT2im8g/9ET7WiAro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VLMXiJEv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VLMXiJEv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so19807895e9.3 for ; Sat, 07 Feb 2026 10:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770489448; x=1771094248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1fc9JdHma9XDLTdFb3kvtPOeUV2ZhOtWSv7/jTyQxs8=; b=VLMXiJEv7mstlopo0pyx74iv3sBMsHlLFPO0EYMNQqNmPCuZ/okd2RzMbFt13OgI3t qrkgVif7+2l0oXcePbE1Jfta4cgAcVZVll/Vdl/0cmVhC4mt6D6SqN7pIQYi4fu+ipSY CK3OYUX/DhdgxrUj/vdy6T2kV3WDC2Ge7pMSQuKsKqm9BgUdBnxccEEjnGA9BqekTFVC rTHBeUOILiX0SE8DbF/kMNO0XzaW1M9oAgCkfryxM09fzIHWZNFcblrzBazNjl0IpYCS PMycDIk1Ol6PWapp9ZpZjAWiafyXQoSENFqKtef93iZJDeULJ6x+EViUIl7ZU9xGJ2wb M04w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770489448; x=1771094248; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1fc9JdHma9XDLTdFb3kvtPOeUV2ZhOtWSv7/jTyQxs8=; b=Y1Q3dq4FsFKZbVa/Q1zRY1UoaZrQWA192cKpqZhdidOmN0WLAXlwJ96/pRBY2ClG+d gQpXkYbU+aJFjv6LV4hTpFqhEQSi835yqsVvc14ekl4uyDMtFYhKXMfROV3nAk2T2zN+ YBoF1sLzeSwV41cEwNmKakoAdXGlB0Vzt/7vypVEfLyr+y5/rfP7bSqn7Q8xEd5/xA9s l4jkgybJ3sPyrPM6oPZb9VqPMcLNVbYIS+DPp6sjcNPgUkEgWHihofTAP2qnHEUUReyA Tf94xxOWhuToIhxq2l9EjEtJKe/PfXAB8m28aqHWnGGZEkq2YXZqiIqHGQlXT5g6hdIl bYWg== X-Forwarded-Encrypted: i=1; AJvYcCXEg6gZZ0jZJcLHe0AoYgfrkTBhL5x7VINqkevHoMxWEQQ9aDCouTnnKGDkVivBtxFUpu81uVMyU/npn7M=@vger.kernel.org X-Gm-Message-State: AOJu0YywSDrFrfw7LwoBQEVHqW4nOQhcdiJ30v72qXznCrVvWJMs8Dlv E/GerP+3OxoYhlnL9Z9sq8YLfQStZUz8htbdKky006xxlJ5UsKYoG16z X-Gm-Gg: AZuq6aKOvHAwwvKdFVNJxX/ZpQHMLtVXpN5/4cl+Prsp7whw+t3uumA6Qp697YXCjRN tsIaAMvh4OQZzo5LUWRp8EjJDC45NnbCt/f2GeEAKzqxqmFKFfcvjRjApuILcmtOoReT7lcxc+n JT0mNL9yiTlVqhQVuRCo+S/tTEGGqxJL5RsfxNMWEIQ0JUNHmCnywMQLPJaH0HqUWqB78LTXMew EujcK+98P8W0aejcjV/j420sj7EMJ+i6KtotjTB+rrlfz8iU339tqxB18S0/iZgTp4b4FKrOpxH 3vW2mD1w5JlgGCWH+2Tgw+Sn+rxRexRTnclN5PgDwogpyAIJNkjCq+p16ujPvk4o7RtFgVNEcll sLsh9jr8AIbocnYk1MgL+Qna1xVNSST31fUYM8QsFqGhGmtGkmE7DG7bz5NkXjTi3VpDjxVl6Wr +/c2oesAH3oHoVb1zlbbe4VNHTkqO813a4lYX3sXfRMJAH X-Received: by 2002:a05:600c:34d1:b0:482:ef72:5787 with SMTP id 5b1f17b1804b1-483201da065mr81990065e9.1.1770489447388; Sat, 07 Feb 2026 10:37:27 -0800 (PST) Received: from osama.. ([197.46.155.47]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4832a38425asm72529845e9.7.2026.02.07.10.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 10:37:26 -0800 (PST) From: Osama Abdelkader To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] drm/bridge: samsung-dsim: Fix memory leak in error path Date: Sat, 7 Feb 2026 19:37:20 +0100 Message-ID: <20260207183721.43087-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In samsung_dsim_host_attach(), drm_bridge_add() is called to add the bridge. However, if samsung_dsim_register_te_irq() or pdata->host_ops->attach() fails afterwards, the function returns without removing the bridge, causing a memory leak. Fix this by adding proper error handling with goto labels to ensure drm_bridge_remove() is called in all error paths. Also ensure that samsung_dsim_unregister_te_irq() is called if the attach operation fails after the TE IRQ has been registered. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/samsung-dsim.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index eabc4c32f6ab..4712637749f8 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1881,6 +1881,8 @@ static int samsung_dsim_register_te_irq(struct samsun= g_dsim *dsi, struct device return 0; } =20 +static void samsung_dsim_unregister_te_irq(struct samsung_dsim *dsi); + static int samsung_dsim_host_attach(struct mipi_dsi_host *host, struct mipi_dsi_device *device) { @@ -1955,13 +1957,13 @@ static int samsung_dsim_host_attach(struct mipi_dsi= _host *host, if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) { ret =3D samsung_dsim_register_te_irq(dsi, &device->dev); if (ret) - return ret; + goto err_remove_bridge; } =20 if (pdata->host_ops && pdata->host_ops->attach) { ret =3D pdata->host_ops->attach(dsi, device); if (ret) - return ret; + goto err_unregister_te_irq; } =20 dsi->lanes =3D device->lanes; @@ -1969,6 +1971,13 @@ static int samsung_dsim_host_attach(struct mipi_dsi_= host *host, dsi->mode_flags =3D device->mode_flags; =20 return 0; + +err_unregister_te_irq: + if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) + samsung_dsim_unregister_te_irq(dsi); +err_remove_bridge: + drm_bridge_remove(&dsi->bridge); + return ret; } =20 static void samsung_dsim_unregister_te_irq(struct samsung_dsim *dsi) --=20 2.43.0