From nobody Sun Feb 8 13:39:29 2026 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B893299AAB; Sat, 7 Feb 2026 17:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770485042; cv=pass; b=Aj07GLLhzdtx+DAJD2SD8Fo+0u1D7dPwgobiE9YsPnJ8tXxF3ENBfI6Zz4/Qge1JdlACOfb8JILvd+sW5RDFXcevEE6qmDYwevGkoezbV/jgrOoRb3aAoB5LumKkYpFuU7G9gd5xMPBzPrOBikTJcxe+Yjv9fdjCGghgI4JqA+o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770485042; c=relaxed/simple; bh=s41gT87dWvuzHdqIUv41leecdIo/clKsPj7uK0KyjcM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FVJqu/tWdEDxR+7r9KD5HFBpHQK/4WTGlbqM8/7yami4yHt68qh4LTDDlzPhmZM6eHfccZlzl/+p/dHOJVLOsnlo1CMrY59XQ3X/3l5MznFMiH2EjD+GBXJYJwFHt1AvV1mWPIcaJMUEQ7ffCrvqh8gbHxIaQ3wypJZQd9rI2wk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rong.moe; spf=pass smtp.mailfrom=rong.moe; dkim=pass (2048-bit key) header.d=rong.moe header.i=i@rong.moe header.b=jXLxCrBm; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rong.moe Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rong.moe Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rong.moe header.i=i@rong.moe header.b="jXLxCrBm" ARC-Seal: i=1; a=rsa-sha256; t=1770485018; cv=none; d=zohomail.com; s=zohoarc; b=A8b6ucQgsHtCFZX9QWtRpFb6BqxWFrC7T0Bu4xZ0ErtC7SV2sZDVh2AzBen9Rs0t2yfFsPJOaBTOyht0uUlKtuup4St0kDOgSuMFOO0dnJMHWQNbzeuvcGHen8NZnA10nzTkZMDIZtTphzdwSp3DKlDIbm2/pTNzN8az8+HHJpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770485018; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=faMM77TcsvJrLJnEOJkg9GDeZL+mgoEejPqj8vRk9u8=; b=MSrhfo5ksRH3c6lxzSKC31bDbljy/MyJTTrOuqxmGU8+Mp9xM/rvQfIbtPTbUOjNj3sKyoulR0WMMz5jPTlUS+lcJlCx4YafkB/Zy1L4pzPXGDCmRckXDrapTFgg40rr0940bd05I9iX96sKvuOeCgDQwaOe1JRuYpQIKEO8+Bo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rong.moe; spf=pass smtp.mailfrom=i@rong.moe; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770485018; s=zmail2048; d=rong.moe; i=i@rong.moe; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=faMM77TcsvJrLJnEOJkg9GDeZL+mgoEejPqj8vRk9u8=; b=jXLxCrBmwZ09vVYjcVtQ9tzkyXlXoACPj4Wuwcq63JaReciULr+1JzhFvyzXuAgu JIWbtEu1OdEzLGXky6F14ck6/DAVCQwVuWCXEqvL0XUvs3QgJSuSxjNw2zGahF8ClNU hXOZPt90QrWVO1QxSoEW8/l+KQsMH7FMfScWlswE+7PUBQUkpA6KbysPqynch24Vmhw Ck4xNkY/NhvZHW/W/xMRxyimTq2oD05zRmQYZkG2lK5+j3/hCbNg57J7dZyv6ZVgRGx 5KRLq8NHTfbWibuciJRFZj8O9sb1JJGcYCz4BggPA0UHm6m4yYBs0NvYmvMLBTrZCtF 8/nFc239qw== Received: by mx.zohomail.com with SMTPS id 1770485016956754.7552455871597; Sat, 7 Feb 2026 09:23:36 -0800 (PST) From: Rong Zhang To: Mark Pearson , "Derek J. Clark" , Armin Wolf , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Rong Zhang , Guenter Roeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON channel visibility Date: Sun, 8 Feb 2026 01:23:27 +0800 Message-ID: <20260207172327.80111-1-i@rong.moe> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" The LWMI_SUPP_MAY_{GET,SET} macros are fundamentally broken. When I introduced them, I meant to check LWMI_SUPP_VALID *and* the corresponding bits for get/set capabilities. However, `supported & LWMI_SUPP_MAY_{GET,SET}' means *or*, so it accidentally passes the check when LWMI_SUPP_VALID is set. Fix them by only including the corresponding get/set bit without LWMI_SUPP_VALID. Meanwhile, rename them to LWMI_SUPP_{GET,SET} to make them less confusing. Fixes: 67d9a39ce85f ("platform/x86: lenovo-wmi-capdata: Wire up Fan Test Da= ta") Signed-off-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-capdata.h | 4 ++-- drivers/platform/x86/lenovo/wmi-other.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-capdata.h b/drivers/platform/x= 86/lenovo/wmi-capdata.h index 59ca3b3e5760b..8c1df3efcc553 100644 --- a/drivers/platform/x86/lenovo/wmi-capdata.h +++ b/drivers/platform/x86/lenovo/wmi-capdata.h @@ -9,8 +9,8 @@ #include =20 #define LWMI_SUPP_VALID BIT(0) -#define LWMI_SUPP_MAY_GET (LWMI_SUPP_VALID | BIT(1)) -#define LWMI_SUPP_MAY_SET (LWMI_SUPP_VALID | BIT(2)) +#define LWMI_SUPP_GET BIT(1) +#define LWMI_SUPP_SET BIT(2) =20 #define LWMI_ATTR_DEV_ID_MASK GENMASK(31, 24) #define LWMI_ATTR_FEAT_ID_MASK GENMASK(23, 16) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index 2a9ede27e13d4..6040f45aa2b0d 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -216,7 +216,7 @@ static umode_t lwmi_om_hwmon_is_visible(const void *drv= data, enum hwmon_sensor_t =20 switch (attr) { case hwmon_fan_target: - if (!(priv->fan_info[channel].supported & LWMI_SUPP_MAY_SET)) + if (!(priv->fan_info[channel].supported & LWMI_SUPP_SET)) return 0; =20 if (relax_fan_constraint || @@ -233,7 +233,7 @@ static umode_t lwmi_om_hwmon_is_visible(const void *drv= data, enum hwmon_sensor_t return 0; case hwmon_fan_div: case hwmon_fan_input: - visible =3D priv->fan_info[channel].supported & LWMI_SUPP_MAY_GET; + visible =3D priv->fan_info[channel].supported & LWMI_SUPP_GET; break; case hwmon_fan_min: visible =3D priv->fan_info[channel].min_rpm >=3D 0; base-commit: eeeb4c9874bb7ad11d322156443b1d3ebfaaa1cf --=20 2.51.0