From nobody Sat Feb 7 23:23:11 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBAB3B2AA for ; Sat, 7 Feb 2026 14:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770475561; cv=none; b=YrKfpsBJ6XZVPW6UtbqkfVjP9mhETwlwnj9rDhTeyHXC9HlU5RPgIKrpF74zB4UiRt/IIXB6/nBgI15oML0VDRmGd9axY6Yom9LG6leqxiHXnKTyQWHjN8ZC54oUTDNbwIY9VsdUTAu9rNZXwuwsHJipJaNrlw9eh3W6h0Q9ucQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770475561; c=relaxed/simple; bh=JSVkV+kpw6j52+88N+QfRdheyCwuYYp4nV1ZKZkhJvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ASC3kFBPqxB4FjQg6yvi/NRcOSRSfK+cZ3XT4fsdsJWNejgdog6Km9MxPMeQIrtku9fUAgdarf+V5GH6DCWvWOJoGV3GuwxSUzvfsl0mmFvQKWsIk+fDNRVPVjMp0wlcv54OQv2don41Z1AwVguegoGKo2njAnjVU159bhTctSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l6EvdhFK; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l6EvdhFK" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-126ea4b77adso3429521c88.1 for ; Sat, 07 Feb 2026 06:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770475561; x=1771080361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IonYphKR0CQp0rm1ICLqevRTebRTstcO+T+JXtAhtbE=; b=l6EvdhFK7OjQfuLWK/T2rE9fjUWrOLKZrpaybF1z8OIYBJlyRi17c6wFW11cv7ZDIR gUAqUUiD+RYv47pmTlC/QbTa+6gXLxttlvoqYUuTlaadNqFMRPWtcdv9ocOHQmcTy8b/ WF9k9PpMMpMnIkyts7asbAzy6KhD+rn5rHpBjde1KyoW8UEJE41voI3u7aL9kuOUJ2Vk mbUZh+rVAaBwr6/Aik9W+7P1Aa11tvqtOj/iaLXbm3gxRubjm++wkpslFkgloBM1kZbE uwKQpbdpTncTuEMTos0vYEULx/tnRAHJoI7Q95zFVH+gQ0Gy8dzppfA6BsZ+67XJBFB8 51iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770475561; x=1771080361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IonYphKR0CQp0rm1ICLqevRTebRTstcO+T+JXtAhtbE=; b=Uh97qd8vaMCHrjrLj9sNSG+kjJH3DKbfyvacBbku6SZhODVG1IYyqtDlhy4AGNTJNI 4+NNuhegOlTyb4aZ/y2/566RLEK0+0AEwmYCzyyJ6VuBw3fmVtb/NURv601Sr4HEMoD4 TQAHgJM4o6Lqi/QyeZvlKpBFVEpys2gC1CjS4I4qGUaLq+1NGda39qlFkvfxejElnQ3t Y/8EFI6iSpRXooxnT8j6SYFyM0PVRXy659EWvXjmr7SfETR75ZbR2iejop9TroWOXOUF Sq8BC62w9X0h8e5txjRKu/hRRhoCKDjE0LFUuD/K017TEZPZYT7Yef4UVf9boSLVC1KI /Bqg== X-Forwarded-Encrypted: i=1; AJvYcCWQI80PMUT/Jqxx/rMchbAfu2oTWePqTdCJBPv6wBCRiFlUYQ/s/8kCRidAAzQDeFIrXrKXrP83CyIDviA=@vger.kernel.org X-Gm-Message-State: AOJu0YzznKADYzGR/V7U37o+IpNDudDGvgUcQO8zQalnwUzvXs9na2FJ GhDLnJQyEeOGBUXlSWj8YyZjwS4issoknsQfMHODqExZkqQjlm9MSj7A X-Gm-Gg: AZuq6aIxKBAuc5DaA1O9KHajggT2YH2nSmC6MBu8BN65z9AdEx6L+FIzhdss+YZeVu9 1xLzv4/jhrw2nJXE4lpImlgEq74ojUELFsbLuvbaD5m8CDj83tGCIIM3FB3rl3kxuy1XF07+eGN hKtzB/jd2MqWBUNQmdU83oqt1iNHx3/HhtLntUhe4bggG8yE+q5axkNP0GTFMEjV9Wqdwahi3/1 +UcmzXbitXlJVLErCcnSiqERJvbfKApGmfoZIs6pf3T1AaT/9AfpF9bDwQMmZcJSFvrNY+dyAbm 17S+CANqhQsdpr529efHDlxM4YdA6lRmGztPWrPcXjsX+S10haxMehFrYISBj2lht8cZExzVlaT qLV6u7PSzhcNNGQiNGL3GupxEY1qVmTlMFlTBHlVCoolCukVRUI6uCV3NrFFhGbVSjknBWkqLnM PeoRZViOgWnX2N0MNhTuUVYs0UeVgrW9wXi/UIOJYCPAoZ0sxOyvu6iulHWoc9vqqmT4rIONSgH l0eKH8Eyg== X-Received: by 2002:a05:7300:724e:b0:2ae:53da:979c with SMTP id 5a478bee46e88-2b8563d948bmr2732277eec.5.1770475560570; Sat, 07 Feb 2026 06:46:00 -0800 (PST) Received: from localhost.localdomain (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855c3c846sm3856122eec.16.2026.02.07.06.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 06:46:00 -0800 (PST) From: Sun Jian To: almaz.alexandrovich@paragon-software.com Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, lkp@intel.com, Sun Jian Subject: [PATCH v2] fs/ntfs3: return folios from ntfs_lock_new_page() Date: Sat, 7 Feb 2026 22:45:52 +0800 Message-ID: <20260207144552.2322468-1-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260205094934.10500-1-sun.jian.kdev@gmail.com> References: <20260205094934.10500-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ntfs_lock_new_page() currently returns a struct page * but it primarily operates on folios via __filemap_get_folio(). Convert it to return a struct folio * and use folio_alloc() + __folio_set_locked() for the temporary page used to avoid data corruption during decompression. When the cached folio is not uptodate, preserve the existing behavior by using folio_file_page() and converting the returned page back to a folio. Update ni_readpage_cmpr() and ni_decompress_file() to handle the new return type while keeping the existing struct page * array and the unlock_page()/put_page() cleanup paths unchanged. Signed-off-by: Sun Jian --- v2: - Fix build failure in ni_decompress_file() by switching the local pointer to struct folio * (reported by kernel test robot). - Reported-by: kernel test robot - Closes: https://lore.kernel.org/oe-kbuild-all/202602072013.jwrURE2e-lkp= @intel.com/ - Closes: https://lore.kernel.org/oe-kbuild-all/202602071921.nGIiI1J5-lkp= @intel.com/ fs/ntfs3/frecord.c | 43 ++++++++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index 641ddaf8d4a0..6169257cf784 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -2022,27 +2022,31 @@ int ni_fiemap(struct ntfs_inode *ni, struct fiemap_= extent_info *fieinfo, return err; } =20 -static struct page *ntfs_lock_new_page(struct address_space *mapping, - pgoff_t index, gfp_t gfp) +static struct folio *ntfs_lock_new_page(struct address_space *mapping, + pgoff_t index, gfp_t gfp) { struct folio *folio =3D __filemap_get_folio(mapping, index, FGP_LOCK | FGP_ACCESSED | FGP_CREAT, gfp); - struct page *page; =20 if (IS_ERR(folio)) - return ERR_CAST(folio); + return folio; =20 - if (!folio_test_uptodate(folio)) - return folio_file_page(folio, index); + if (!folio_test_uptodate(folio)) { + struct page *page =3D folio_file_page(folio, index); + + if (IS_ERR(page)) + return ERR_CAST(page); + return page_folio(page); + } =20 /* Use a temporary page to avoid data corruption */ folio_unlock(folio); folio_put(folio); - page =3D alloc_page(gfp); - if (!page) + folio =3D folio_alloc(gfp, 0); + if (!folio) return ERR_PTR(-ENOMEM); - __SetPageLocked(page); - return page; + __folio_set_locked(folio); + return folio; } =20 /* @@ -2064,6 +2068,7 @@ int ni_readpage_cmpr(struct ntfs_inode *ni, struct fo= lio *folio) u32 i, idx, frame_size, pages_per_frame; gfp_t gfp_mask; struct page *pg; + struct folio *f; =20 if (vbo >=3D i_size_read(&ni->vfs_inode)) { folio_zero_range(folio, 0, folio_size(folio)); @@ -2099,12 +2104,12 @@ int ni_readpage_cmpr(struct ntfs_inode *ni, struct = folio *folio) if (i =3D=3D idx) continue; =20 - pg =3D ntfs_lock_new_page(mapping, index, gfp_mask); - if (IS_ERR(pg)) { - err =3D PTR_ERR(pg); + f =3D ntfs_lock_new_page(mapping, index, gfp_mask); + if (IS_ERR(f)) { + err =3D PTR_ERR(f); goto out1; } - pages[i] =3D pg; + pages[i] =3D &f->page; } =20 err =3D ni_read_frame(ni, frame_vbo, pages, pages_per_frame, 0); @@ -2190,18 +2195,18 @@ int ni_decompress_file(struct ntfs_inode *ni) } =20 for (i =3D 0; i < pages_per_frame; i++, index++) { - struct page *pg; + struct folio *f; =20 - pg =3D ntfs_lock_new_page(mapping, index, gfp_mask); - if (IS_ERR(pg)) { + f =3D ntfs_lock_new_page(mapping, index, gfp_mask); + if (IS_ERR(f)) { while (i--) { unlock_page(pages[i]); put_page(pages[i]); } - err =3D PTR_ERR(pg); + err =3D PTR_ERR(f); goto out; } - pages[i] =3D pg; + pages[i] =3D &f->page; } =20 err =3D ni_read_frame(ni, vbo, pages, pages_per_frame, 1); base-commit: 2687c848e57820651b9f69d30c4710f4219f7dbf --=20 2.43.0