From nobody Sun Feb 8 05:28:36 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58604319605 for ; Sat, 7 Feb 2026 09:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770457733; cv=none; b=kL+ldHYcMGEOgYNEhMIpb2iXdKXJt1MTuNz4DZm2OqqIXPNaJxPwewq+p30NqgPqX9R8SOdcwVAoSvHoWbdrg0HsoAjgg4BauqoMnWloniYLNSljaAohlhu07S7vRzVlVpfYCGl+Kz5+s6C+58FxhSFjx/k3A2dLblzTiUOyOgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770457733; c=relaxed/simple; bh=TGsE2fB5VTyKMU0l7HF00EXkkyMHxoKJRndW309YkdM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G9PdDQAsNkJytmMKgvq1XOj54R3rVvWJPNOLYWeMe0/UV/8bJ7YC9t1loVzj+FPbkavrm6i+Bji4tU/zoRX8wJFaU57vp6vpGX5pdsLWrvB3IhN2M5v1TcGNtYW4VtndlKvnsDtMdq3laz3jWUfFCBf3R5dSv6yd+NMZ4H3IA8w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EF7iw2Ay; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EF7iw2Ay" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-59dcd9b89ecso3966813e87.1 for ; Sat, 07 Feb 2026 01:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770457731; x=1771062531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wEM++L2wpFRImt5jUOuUMN5DTiB5ZK9kF5mPmLtnWQA=; b=EF7iw2AyRwwdgSO9PcJnc6SqpKEduQNx0gwTLCh/KMbiWxkTLE4VNhioD3yaNKgsif bAdt8p4EgeqUjKfURMJl9r8t7TItHLCch85k5ioIyCY1u9LrPSnHOYrm+soc2We2cmXe IKbrxo07N0ge1P0X2lPa/oU1qrVLeQSBaMHz9tonNIeSYjZmVZqpu2s680ffF2NuOisF KNGAOfdEdPo/RwArgMRjkewXvRQeeMlW68YNUKqhYmvXNt9rRYDPMLlzl9/tGd44qxFY XMmdwOkL798mOo6XwDY8leUxIjdcakVAX6uITIzkG0TWM4EpKovRynqj0YiYVcNeumdZ U1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770457731; x=1771062531; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wEM++L2wpFRImt5jUOuUMN5DTiB5ZK9kF5mPmLtnWQA=; b=hJrwu+3yKj+9c/l8YDGc9gTb7wcsRiRSDb89sEIRRJLWhS8uBTiAbnufUiNIiANeCe eHAONG42BM/NNxNapkhoBW2ulKnZfFn+qHbwgtxJ1K/aGRrutF3rF3Fzqk5DBMp0XCeL lXubeQ9VkB7ykws1Dq5CUr4QHpT9DEURkkgxezDLIM9Lalemw5uCRv8hvMlF5emIDCy0 8dMzHdD6W6OEFPkC9ZtYyik31CYRkNy0QfKjF7yAgPYGSzL/PKb8u2EX0IUWRDg5A8hK nKr/f0WVON/u78nVemY53dG87q1a8yWnAs/s7tY2X1PrscU4oEZ5jSksmChA/5zfjTvj xxGg== X-Forwarded-Encrypted: i=1; AJvYcCUGwt1HXDYqePRZa9PMAzgHGsie/qi3W15vlqLvcEfvrZSUtLuDlnO395PZOdpdMnOiCgBHBiDs4pW/L2E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6uWRyjeqf/Zt4MWX4lNGYT54CGYsCQXSMOuCgiXmmW3JvLJ18 0vlrPpn/wZ2t1boqTZcxLTq7VyLdBNVBSQOkDo5xYustvopPqfsld+1km4FurA== X-Gm-Gg: AZuq6aKHAwtsHATWcQI07yi9hgHyRcw2n9v767Y+g7v+PBGTE0HKZKq/LXUJiFlg2Mn GadjK8Je2c/4ml09PXWXmgFXROqVPH2B3xA6Nv4YQW+A+MQ8vzqVPIET4E4Va5oSYAM0HDy3LV3 CvKwY9ZVA95tqMhLZ6GTAR8ymlI5jz+cK/ydX6r3sUjvsavg6Mf69vBdaz3Zi7RjRBdUgWTUbRD kfSWK2+o+GvalfwBTG0bFRNF4RCIpUZZl28hbO2KXLSbBjKWdVTWfvhY6MnUgS7+yZ1bFiGGzLH SKKHVnnCcg/kn9SaKXei0Z0hgHTvcgEFIHYRM97zS+s6cdAnosjIVTmIeL9h6cntcobXKvRigBZ 7KvrhiP+347/dSQQeDyu6s25OGRIWGIZVjUv0lfEL914uqo6mCxqt8aJL4rYNnfDL9oulx0Erda GUB0Hc7AUXy7kVuocL+hcAcr5w3MrPPVbDwjxeSJd4tcx7flPrwocwYKaVG47Dx2lRDydaPDEtG BnpmIv2BoazIU7nns7lKnHiMQ== X-Received: by 2002:a05:6512:1327:b0:59e:2d6a:b8a5 with SMTP id 2adb3069b0e04-59e44b59e59mr1936663e87.0.1770457731309; Sat, 07 Feb 2026 01:48:51 -0800 (PST) Received: from localhost.localdomain ([176.33.64.73]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf700dsm1210132e87.11.2026.02.07.01.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 01:48:50 -0800 (PST) From: Alper Ak To: Laurent Pinchart , Lad Prabhakar Cc: Alper Ak , Mauro Carvalho Chehab , Hans Verkuil , Tommaso Merciai , Daniel Scally , Jacopo Mondi , Biju Das , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: rzg2l-cru: Fix possible ERR_PTR deference Date: Sat, 7 Feb 2026 12:48:39 +0300 Message-ID: <20260207094841.603932-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The media_pad_remote_pad_unique() can return ERR_PTR() on failure (-ENOTUNIQ or -ENOLINK), but the code was dereferencing the return value without checking for errors. Add IS_ERR() check before dereferencing the pointer. Fixes: d7d72dae81d5 ("media: rzg2l-cru: Retrieve virtual channel informatio= n") Signed-off-by: Alper Ak --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 162e2ace6931..a34c2188df1a 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -411,6 +411,12 @@ static int rzg2l_cru_get_virtual_channel(struct rzg2l_= cru_dev *cru) int ret; =20 remote_pad =3D media_pad_remote_pad_unique(&cru->ip.pads[RZG2L_CRU_IP_SIN= K]); + if (IS_ERR(remote_pad)) { + ret =3D PTR_ERR(remote_pad); + dev_err(cru->dev, "Failed to get remote source pad: %d\n", ret); + return ret; + } + ret =3D v4l2_subdev_call(cru->ip.remote, pad, get_frame_desc, remote_pad-= >index, &fd); if (ret < 0 && ret !=3D -ENOIOCTLCMD) { dev_err(cru->dev, "get_frame_desc failed on IP remote subdev\n"); --=20 2.43.0