From nobody Sat Feb 7 21:24:51 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE7427AC28 for ; Sat, 7 Feb 2026 09:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770456292; cv=none; b=WBaxe3yPg9gR5f6UAa/gBvCKPovPRUDvHu2jokUIj1SVajq21hjTWVEJzj6mUxyT9VCEGCqdYiTMwK25dX6fDD9mHi84SVYzQMZZMkgAZfVMOUfAJdnk2A4BNbQD09rk2WfrS+Ad2/j+lR8x+6ZIwDoUPwJ+Rjy72y1C8zKiCCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770456292; c=relaxed/simple; bh=wUi+1tQcSs1jUeMdG1g/Ttx+xkD+cUrFmQPm4ODEwcs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JDkNhdkWQ/i6m7KcUxL/U+cmzIdkZvY1O2Jjo4RlOqKEU9RXl0H+u0xDwZGjASaihs1zsbl5OLDDQetucSFZGtH6H3+s6c4ouscFq72to2oQTxeM5QGJfsXI1oX1znCcInBIvOjhnCx/44cbl07qF+rsgvMuUKN1ImgATiJC7G4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jM4A9GqW; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jM4A9GqW" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-823075fed75so1738507b3a.1 for ; Sat, 07 Feb 2026 01:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770456291; x=1771061091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Nx5rw5vV7wCFXhenBh4c2nzOVeIsTPIG4fq2x3EDzVQ=; b=jM4A9GqW3MDGF5O/NcyKTk3iMXGLTg3u37orDFjNKFbCg8VwnGnr4srshB78gnRiDi Bx+5sCkBqVuJDq+puXp8qcURE+LFV9QRrdX7Z0oFPfEQl+Noo+hNjvNN0WrwNI/OayiF bN77jaxSfZC75dui34h4yZ8xQAqdNl7AWp1ZyOezkTqhZ3pjvtzKwJYU0GaHiz6vBsxT qFM6Y5iVtu4ua1VeZRMqFx4I29jB2NjLT8CZqJRZLfsw0VH3M2ZVU83F1oV+6fUGEa1P 6OW+h8By8tNhDvE9xoaTLUNoKcEnOrarEE3yjXLIa4AvtJW9QUjQQsZd0KFIZ1A2EsSW DcTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770456291; x=1771061091; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nx5rw5vV7wCFXhenBh4c2nzOVeIsTPIG4fq2x3EDzVQ=; b=QFOcsIOsx5nv5h+gbVupE/wBaJaCeFXpFcvWZg4BriMLJteCNZLQTeWcFsRQJY6P3T 4KTqkT5+BHX0QRYKpjq+rbSjjoDxCf4Ichk4msWxCUT3nB89pU3JeD5K8j0WeAcwpbpD jZ16rhJqKoImI62xiMVq/3kYB45IqHZfCENRerXyQovhSI2H5ymCsEa9BhTKdhYHOU54 038iHXtgL+bjVgGg2MGFOX66m4k0BIwGxVANFK9gYQUgAngHr2E/NX+T7eEQEzZVQvl4 DL4bCqsdAw4nOgLrAJl/FzadOkyrGuQylEK13CLtdEvOaXXggvFoa3BL2fVBPxSt5Nb/ YFeA== X-Gm-Message-State: AOJu0Yzf+wzR0Uvh71aFwlyF3NYDQSZPcGQFY2H+PziXmkLTGivqnOh9 MTm3G8bqvy2C8UXMOIbyYQ7OL7SfLKZumlsI54SjBiKI0CDUxD9Lw98vBOOvfQ== X-Gm-Gg: AZuq6aLpntoNnJGRt1aeymchXYlX1kGb3uMhvt7tAnE2ClTMxPrLIsBT+RwYaSHj6am xAMLT8AzrCQfOTw8UAAfGSqnmvwrkCTme3zLsbHAI5O8NyOr7hV2so2HBwQiOJ3rmJ7M6PwHKds 7cjX0hGw4ZySOJOGgcV2QFHjkp7p9EFj7rGrCBmbrlgcPRsDO3npIKy+ntP9TGvbSr8tnufsk45 PppSthQkY+ES6sjq5RFd/KCqXm+rsvuAzUXBK2ngGYqmk3BhnWcnZ/o4ZT0lXb19HbezxGKj9xG 5tBDjSFZ7OJwhuU64l3hQd1m5c0MFOdkfQuP+q1ibeUR0Z9ohaa4WfeQDZSXNPql2MOo7E9vLpj 5RSn8zKWDD2IBJACiEIkXDxNlnUq+BKJgRE/FI05MCEKfyGxAH9A66iAwheU7nfahYwndjT8vD8 YqsgWk1YSCEw== X-Received: by 2002:a05:6a00:3a1a:b0:81e:f280:f341 with SMTP id d2e1a72fcca58-8242d3d5072mr7363617b3a.6.1770456291384; Sat, 07 Feb 2026 01:24:51 -0800 (PST) Received: from archlinux ([45.119.31.85]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418812c5sm4165163b3a.41.2026.02.07.01.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 01:24:51 -0800 (PST) From: Adarsh Das To: linux-kernel@vger.kernel.org Cc: Adarsh Das Subject: [PATCH] ufs: replace d_type switch with fs_umode_to_dtype() Date: Sat, 7 Feb 2026 14:54:21 +0530 Message-ID: <20260207092421.85256-1-adarshdas950@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ufs_set_de_type() was setting d_type via a switch over S_IFMT. Replace this with fs_umode_to_dtype(), which provides the same mapping and is the standard VFS helper for this purpose. This also resolves the existing TODO comment. Signed-off-by: Adarsh Das --- fs/ufs/util.h | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/fs/ufs/util.h b/fs/ufs/util.h index 391bb4f11d74..055b4543ad2a 100644 --- a/fs/ufs/util.h +++ b/fs/ufs/util.h @@ -152,34 +152,7 @@ ufs_set_de_type(struct super_block *sb, struct ufs_dir= _entry *de, int mode) if ((UFS_SB(sb)->s_flags & UFS_DE_MASK) !=3D UFS_DE_44BSD) return; =20 - /* - * TODO turn this into a table lookup - */ - switch (mode & S_IFMT) { - case S_IFSOCK: - de->d_u.d_44.d_type =3D DT_SOCK; - break; - case S_IFLNK: - de->d_u.d_44.d_type =3D DT_LNK; - break; - case S_IFREG: - de->d_u.d_44.d_type =3D DT_REG; - break; - case S_IFBLK: - de->d_u.d_44.d_type =3D DT_BLK; - break; - case S_IFDIR: - de->d_u.d_44.d_type =3D DT_DIR; - break; - case S_IFCHR: - de->d_u.d_44.d_type =3D DT_CHR; - break; - case S_IFIFO: - de->d_u.d_44.d_type =3D DT_FIFO; - break; - default: - de->d_u.d_44.d_type =3D DT_UNKNOWN; - } + de->d_u.d_44.d_type =3D fs_umode_to_dtype(mode); } =20 static inline u32 --=20 2.53.0