From nobody Sun Feb 8 01:21:18 2026 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3FDA1E3DED for ; Sat, 7 Feb 2026 09:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770455921; cv=none; b=cVaHLwsuiaBOJ9cqu/RYoC72EhVYdzkGi1ia3ptUxPk0CS8GYdpRzeM0CgF4Sn8awEbih688qUjyOjqMHqGDmhvyX3vjpOXuE4UehDoSDhK8IvPhFsmMxhqQUDuXYk9Bd2EPV7ouDg3LnXDzaw3RWJ0gxp9SoKYAjE4VqNrwDS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770455921; c=relaxed/simple; bh=Ed5YXu/0utQThGnGpYf8crs4aflH2j7x7y9WfON61U4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rU0ZW/gxhI0a1tekvo654BqPvJcxYPEPkQpBj57MXBXqNhLER1YGQQ38epN9msISwEpgMJSy46JQ9CfvvmM7hsi3Oybh6yvG2DUdekca8QmZ/l7D+g8SpK2TDip/08BrX/39QhTtdi/TAhEyK6QhgjBn3/TCHSJ4wHmIi7fYpdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HYtWUurN; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HYtWUurN" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-382fceabddfso24394611fa.1 for ; Sat, 07 Feb 2026 01:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770455919; x=1771060719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/rR7N+AW3Fn5J5DU4HQ3nGD5R61rhSOpXueOZW6cHuk=; b=HYtWUurNKSz7oi8lIya2kSchUz+aFIiJbY7NTx0JCtGFhrgIVIrIj4ASxOh17Tl0HU pbssJb/OrHefeSMJAu++6G3hasufBE4pcwOzXqaj3qDI6GIy33ghyk63qdrEADweTc31 tr+PKO9tf3CkRmk86OWSpkSba3MNRvIGN9XaiYfvpPa4sM3koikEdO+AdWmcayL5jeBv iUL8WMhPs2r6ZTn2tUMO2MAbPRsDjVAyz8OlWF+3fR69AEMIrxzIS4R8ikIoMdDIxKyr HX0f+l89RfBnm5v5dlYCKpIxCgkMYc91lsLy1wTq4GGfWbjtIdu67OjTv0R7FD0qWtc/ AFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770455919; x=1771060719; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/rR7N+AW3Fn5J5DU4HQ3nGD5R61rhSOpXueOZW6cHuk=; b=J7dNfaieNtyyWF92p1dGRFyMSKXEPvKFS61QQ9zNRUgM7wYVa4t96bf76jerGjflDO w8UO46361bxb5ERBY7RIpAPW6P17CJ0vfzyNLk3yHp8c5hwRUJv7s1VSHA0NI1pSSu5g fA8pnoJbmGvUQIulmcSaUbeXrqfOGykrhvju9AD9FyqN/nEujQHwL6+WzyYt4TUZ5otQ HXQwDzuskZCBZ97Ap0m8NTgT95RBK74drHCGCRexj1hbuNeimfn1v2fAekbqXpexkPyv dHbhvqW5+quqnTo5gTcNvHbH+NOg6vUDuMYESTCvqBADTckRympdHz/xZje1kjeY0aB9 yAlg== X-Forwarded-Encrypted: i=1; AJvYcCWZEIHcOPdx8efJ5wb2zB/e6odhbEchdSGqQ84FBzufffNvkt7/9n3XT57C1rHuLscBccrXSEOWAvN4seM=@vger.kernel.org X-Gm-Message-State: AOJu0YyBl4IRsyUjuEVnz7un1Da8EN2rbTI7sU0lb7Pg6a31w1nYCeQ2 J4bLYTsID2G5nAKCMm0dmgfixnpu/6KA4lwmzhFLpl6A0DXflzxiCZU/ X-Gm-Gg: AZuq6aJFVSXwNTxUOvJp+ZoKgddUDGc8Zz0lTZUePpQA3w7LEq7irMM66b+CmX+cWks a/IKyyNxcN50qbOo5wF45tYm30maginnjlBaFiDQCoy++ErLvrdX5B0eE5h/r5FjgA7GJBx2srb Xi4DobO1th+/VkXV02U3xn6UUwrZCozeXDtVkVQmKDPbrFPCZ4O6TJExNB95FiS7/0bi4I15Bu9 Cz6Q7L0jVbJB9yFGV4lg3Es3ACuBCFWLGnUs17LqBvkqw4cziQiAkfDUaTPWGMBN7QsHJiijHul nWE1hjHrbyoZDJBPErvQI02k1Wm+r8yDZGMgJyQel8Dt3p6hwCk85YDG1blVrzuqyNabKfir6XO z8nh8VcYUYGSQMNArxbeH0oPwj/eNydpKklc/YA3d4zOnP0eBlyEBXrfxv3ROxl2d8aF+F01dJh h8+T5jRLeDwGxD5Ta6c6JEAklSDB3Y+cH0BWG++JFxdX4cN2FdI8jWNC66UEAFCPpuzCAblvH86 EjjW3RFH9QPAQU= X-Received: by 2002:a05:651c:e18:b0:382:624d:a703 with SMTP id 38308e7fff4ca-386b51873efmr18064441fa.45.1770455918702; Sat, 07 Feb 2026 01:18:38 -0800 (PST) Received: from localhost.localdomain ([176.33.64.73]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-386b640e959sm11550121fa.41.2026.02.07.01.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 01:18:37 -0800 (PST) From: Alper Ak To: Daniel Scally , Jacopo Mondi Cc: Mauro Carvalho Chehab , Hans Verkuil , Nayden Kanchev , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Alper Ak Subject: [PATCH] media: malic55: Fix possible ERR_PTR deference in enable_streams Date: Sat, 7 Feb 2026 12:18:22 +0300 Message-ID: <20260207091822.601255-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The media_pad_remote_pad_unique() function returns either a valid pointer or an ERR_PTR() on failure (-ENOTUNIQ if multiple links are enabled, -ENOLINK if no connected pad is found). The return value was assigned directly to isp->remote_src and dereferenced in the next line without checking for errors, which could lead to an ERR_PTR dereference. Add proper error checking with IS_ERR() before dereferencing the pointer. Also set isp->remote_src to NULL on error to maintain consistency with other error paths in the function. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Signed-off-by: Alper Ak --- drivers/media/platform/arm/mali-c55/mali-c55-isp.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-isp.c b/drivers/m= edia/platform/arm/mali-c55/mali-c55-isp.c index 497f25fbdd13..c7225e9c8df7 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-isp.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-isp.c @@ -360,6 +360,13 @@ static int mali_c55_isp_enable_streams(struct v4l2_sub= dev *sd, =20 sink_pad =3D &isp->pads[MALI_C55_ISP_PAD_SINK_VIDEO]; isp->remote_src =3D media_pad_remote_pad_unique(sink_pad); + if (IS_ERR(isp->remote_src)) { + ret =3D PTR_ERR(isp->remote_src); + dev_err(mali_c55->dev, "Failed to get remote source pad: %d\n", ret); + isp->remote_src =3D NULL; + return ret; + } + src_sd =3D media_entity_to_v4l2_subdev(isp->remote_src->entity); =20 isp->frame_sequence =3D 0; --=20 2.43.0