From nobody Sat Feb 7 18:20:07 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CEAE30E0D6 for ; Sat, 7 Feb 2026 08:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452687; cv=none; b=FvaSZjSgLHunT7w4FQwMCipbN2C2snUtuVPGePVc7OPKSt0HBsOA/qVHOcz7T7Q1R3oOanzmB9R9FXXd9mknG5TC41qdbqPaSSFMpONUEEgmLvqeoJumgivXbH3i6DbSj8GTafbJ+EQaGmqXjJS8pqx3rbfZxpjV4nmfhsEeNgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452687; c=relaxed/simple; bh=fQNe+C2ykGl+VIgRxAFw4P2gpNTolHEt92EQYWoDGj4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=VDEz8Kk3a/pY376XruO1UHjKaqPp0BRsXIJnvp1L1eaVjPlmoNCoWn73PyDEODvQ08t0IeYaOtcFhE7XUYjGE4RJmP8mwEWA8Lwh1bbjYntVdUjvi/XbewryZBBsHa7n1yu4OCGudPSO2/e5l5OjnopIGfbtHag2r2X5yXx+73I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Z+HH3+XM; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Z+HH3+XM" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-124627fc58dso5171808c88.1 for ; Sat, 07 Feb 2026 00:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770452686; x=1771057486; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=HR0mAxChVDTPD1V2GKemhoMM82m58RwfPlVP6zevyfU=; b=Z+HH3+XMdZ2TgXrQaUwMSMmzC6fX6MC1wmGeRBsjZ6uzmNcU9c7NKdW6xRjUhDyRnM 0mpAfr1FlP6kYfDetwQ8UAwLUur9QqHjWdZ+LRPUNhsGpnSpI9frI2OcAzwBbh3uw7ef V3BNlnWFhd2D7/05B71hkIMxr15t49Q7m1Pa5eswIci7gWttrhBISMjAwdzBX3LI3nYx /c9vUwvmMMvu3MUKBKWco6mihxkPR5SWiOB1MfnBJpnvVE47nPu4Ho6za63OjuR3FWGv ngLFcjiIQuLl2oO5OC/lrxNEZaP2Ywf6v6kVxrGY5dYPUQazgdhTBhDMQbFGR77nVGYg fhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452686; x=1771057486; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HR0mAxChVDTPD1V2GKemhoMM82m58RwfPlVP6zevyfU=; b=crNuEmij/2m8dkIj70AiNxiomraX8wTDTuqG4bsWiCAKOXe239iIw+xC2G89P/Kine Uw6H3U+emuUMdjZOtqiTu9zjlNZSeW8nFpW9Xrs/iOWFG9tKZwPOF1HY1YU+3z75G76+ 0ZVAzE41NA5f8X4BWhTOQ9XLuSEwICJA/mtl+WeG7rh1NOOIW0QnQP3HlJO4yMVNoO+J lgSX3as2iZ1ekbFnVJyldumeYhRXZeVjVv2t+ns6I92l4CKGU389I998UlvJDx5FfCR+ Pp428aDlQUpnzRoYAlGMpEpYtjmjtc2pVuOXcv4fGfvhOdm/wjZHc91U8FiHXb4m7pN+ Vj/A== X-Forwarded-Encrypted: i=1; AJvYcCUnuAN0O6UpSk7TbyPRNORzghtCQrv+iTV3uQXz+JFxNi3SPSCWyXClE09gqjvDxXlpftt3oXuJrZ/q/lk=@vger.kernel.org X-Gm-Message-State: AOJu0YxuXoykz3d3FLHt6cB3sjB7jUHpQg6KQy2gHjVUaSleJIxyFAFT JWq1BmKjBj1TePGiqeyryTwWYtpsMkqODRzwkcVI+CReYQt51DG/OF/b1XpDUZaKKAIKQCyQc2L XohsDZO04Tg== X-Received: from dlii7.prod.google.com ([2002:a05:7022:4187:b0:124:a7b4:135d]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:60a7:b0:11b:998d:bded with SMTP id a92af1059eb24-12704049b56mr2452401c88.28.1770452686366; Sat, 07 Feb 2026 00:24:46 -0800 (PST) Date: Sat, 7 Feb 2026 00:24:24 -0800 In-Reply-To: <20260207082428.1742209-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260207082428.1742209-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.239.g8d8fc8a987-goog Message-ID: <20260207082428.1742209-2-irogers@google.com> Subject: [PATCH v1 1/5] perf symbol: Reduce scope of elf__needs_adjust_symbols From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Eric Biggers , Palmer Dabbelt , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Function is only used by symsrc__init in symbol-elf.c, make static to reduce scope. Switch to not passing the argument by value but as a pointer. Signed-off-by: Ian Rogers --- tools/perf/util/symbol-elf.c | 8 ++++---- tools/perf/util/symbol.h | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 76912c62b6a0..d7582dbf379e 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -1054,15 +1054,15 @@ void symsrc__destroy(struct symsrc *ss) close(ss->fd); } =20 -bool elf__needs_adjust_symbols(GElf_Ehdr ehdr) +static bool elf__needs_adjust_symbols(const GElf_Ehdr *ehdr) { /* * Usually vmlinux is an ELF file with type ET_EXEC for most * architectures; except Arm64 kernel is linked with option * '-share', so need to check type ET_DYN. */ - return ehdr.e_type =3D=3D ET_EXEC || ehdr.e_type =3D=3D ET_REL || - ehdr.e_type =3D=3D ET_DYN; + return ehdr->e_type =3D=3D ET_EXEC || ehdr->e_type =3D=3D ET_REL || + ehdr->e_type =3D=3D ET_DYN; } =20 static Elf *read_gnu_debugdata(struct dso *dso, Elf *elf, const char *name= , int *fd_ret) @@ -1235,7 +1235,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso, = const char *name, if (dso__kernel(dso) =3D=3D DSO_SPACE__USER) ss->adjust_symbols =3D true; else - ss->adjust_symbols =3D elf__needs_adjust_symbols(ehdr); + ss->adjust_symbols =3D elf__needs_adjust_symbols(&ehdr); =20 ss->name =3D strdup(name); if (!ss->name) { diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 3fb5d146d9b1..9aa0016937b7 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -217,7 +217,6 @@ int setup_intlist(struct intlist **list, const char *li= st_str, const char *list_name); =20 #ifdef HAVE_LIBELF_SUPPORT -bool elf__needs_adjust_symbols(GElf_Ehdr ehdr); void arch__sym_update(struct symbol *s, GElf_Sym *sym); #endif =20 --=20 2.53.0.239.g8d8fc8a987-goog From nobody Sat Feb 7 18:20:07 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F44930BB9D for ; Sat, 7 Feb 2026 08:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452689; cv=none; b=Io96n0L4Apr9/3BLW09Cdi4iKUaHKaS+NlpqILlpPXNwKSh5FvnCV4yEowCjVVI1GQ2K9HLPl8x8TEL19jv2urZjPIC8N5/GQI9c78QQR1ZcPDWl8k/TrNmpA/kg+JmwdLRQ0Iktj3maZkAMNDkz6K0z66UdKslXIaS9HxGbgDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452689; c=relaxed/simple; bh=jBXkwhJU0ZdvAAHhKdLYOjGv4tsONXYvOgs5iMwxwUA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=a/qA8zIRobTBcNOd/lMkGEHBLG3dKXXXELvK5kJvwzW+Kcqq2UQHEQYfjscjKfgjgEDg2yS4Z5sMaaxsewOxTZKjvJI+Pg3Fqu+G0GAWDunSuX/gpNoF7bqaaIBqIde0tF+t95W+4z6PFv2wX3hDtbmfjbAk0PGknvZ3JH5s6Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HNOeoAea; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HNOeoAea" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b8335e64e0so8001270eec.1 for ; Sat, 07 Feb 2026 00:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770452689; x=1771057489; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=bDQ88E5cIiIk78l45X12qXAsWQanRerQ44tUWmnKJpE=; b=HNOeoAearbLNSXid/WoKzxHviv39RiEOLebfYfUbmdDgtmTWBx40mCNlIQG73ErvKz EUayuq5madJl4ZYtPWr16jLYofKnVj4hDYNdPHiaVCWmVnhdjdFh3pKxYiOjAx5jNALX SishHQx0ctf4oqKXLTFBxQS9kH66Q6uYh2I/5Ymt4Ss1Wp8Ypkhxw7dYmhBpPdix5/UE nkoNAjeDtrt7hvLHrrgaGvfVURo0JWwAI8j3BgFbbF17gf4o01KhG/nU+PMsQTaTJS75 g9C91xCppqbE72BOlReUMAXnDumSzzZyFZoyUFJTA2asVn1onGrVYNx4zvD6UKIagg6j XOVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452689; x=1771057489; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDQ88E5cIiIk78l45X12qXAsWQanRerQ44tUWmnKJpE=; b=XyPnNw9L3ySzTXul5wCBwDDBK5cDmLzcrYBLCgz5cbGXQCRLrCPXdLIsQ9HUzVmEBS PohOhQchloJmBsi1PZSihynf5QOPlW2EPItRoTI46S8ieJ/Yj1XHzxbr72HtvMsj8Uht f4pNt8ZtyDzmb0Qmd+tA0qccMJcRjB2C+JWNwkEVVrOq8cmp9pI/JbwAlYrQ0WMbVPht IGYS0RDzo/WEIs7jAJdki5T/nf6oGqSb3vnGQ0lxbsb+x/gYQDdD3BxY/OEVTXMlr0JN eHVgucF9UuVrsiAL9zTdkx0wRs3D9phxHnfB/jyAsx0OIb/KVIf0VQ+7qFM02jf5WvVD 94EQ== X-Forwarded-Encrypted: i=1; AJvYcCUwAbkIRNoi0h15zywS9dtsmGn/8sPgKs6/2nLytj68xaSvwdfn4e1F4mfWx4GkWTS40XYJFgss9qpzVx0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8KQBw2I0p8AIfipo00UM8ndoEl8w2lIiEXyCv/L/8JxVbfp21 teibfM6Ua06lRXvkovREIadbMB2Jf1DFEC/rB/eiZKuuFVzO0Sdl10NrtFdWirbkgr87KHIVloA haIZPCdq2SQ== X-Received: from dybpt13.prod.google.com ([2002:a05:7301:408d:b0:2ab:9468:d9cf]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:caca:b0:2a4:3594:d54e with SMTP id 5a478bee46e88-2b8568339e2mr2911177eec.27.1770452688575; Sat, 07 Feb 2026 00:24:48 -0800 (PST) Date: Sat, 7 Feb 2026 00:24:25 -0800 In-Reply-To: <20260207082428.1742209-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260207082428.1742209-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.239.g8d8fc8a987-goog Message-ID: <20260207082428.1742209-3-irogers@google.com> Subject: [PATCH v1 2/5] perf dump-insn: Remove dump-insn.c From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Eric Biggers , Palmer Dabbelt , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dump_insn and arch_is_uncond_branch are declared in intel-pt-insn-decoder.c which is unconditionally part of all perf builds. Don't declare weak versions of these symbols that will be unused. Signed-off-by: Ian Rogers --- tools/perf/util/Build | 1 - tools/perf/util/dump-insn.c | 23 ----------------------- 2 files changed, 24 deletions(-) delete mode 100644 tools/perf/util/dump-insn.c diff --git a/tools/perf/util/Build b/tools/perf/util/Build index bcccad7487a9..89de23dec401 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -149,7 +149,6 @@ endif perf-util-y +=3D cs-etm-base.o =20 perf-util-y +=3D parse-branch-options.o -perf-util-y +=3D dump-insn.o perf-util-y +=3D parse-regs-options.o perf-util-y +=3D parse-sublevel-options.o perf-util-y +=3D term.o diff --git a/tools/perf/util/dump-insn.c b/tools/perf/util/dump-insn.c deleted file mode 100644 index c1cc0ade48d0..000000000000 --- a/tools/perf/util/dump-insn.c +++ /dev/null @@ -1,23 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include -#include "dump-insn.h" - -/* Fallback code */ - -__weak -const char *dump_insn(struct perf_insn *x __maybe_unused, - u64 ip __maybe_unused, u8 *inbuf __maybe_unused, - int inlen __maybe_unused, int *lenp) -{ - if (lenp) - *lenp =3D 0; - return "?"; -} - -__weak -int arch_is_uncond_branch(const unsigned char *buf __maybe_unused, - size_t len __maybe_unused, - int x86_64 __maybe_unused) -{ - return 0; -} --=20 2.53.0.239.g8d8fc8a987-goog From nobody Sat Feb 7 18:20:07 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77C130BB88 for ; Sat, 7 Feb 2026 08:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452691; cv=none; b=t2J5M6bbCq+CoPko+P0hfAxDwtiCDsPA4AM0eu2nFar89OBysVjScPW3fDD4ABRwG3EXYhS1Dxxn8ukKsf1t/hwtKbbplVzM7fZU30+hpkyF6XkqeFZ9/mpYDiR8mNshKmSR0kdSEFS/X2uJJdY3d17MJut148/9RsYBg3QdO24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452691; c=relaxed/simple; bh=N96xkMpy5lP+7H0aWH6pC7j/S+oT22nm8lNiuaa5llA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=OHedgzQRPIyfGyiEHJ06/d3ove6gx00yYBlG3pkiidc1qwNciUlijNx6GaHPiM5rq9eDuZYfIyQ7phXPFw6V2NtsJPYx17tuzbkbl8m+KecesS1AQxZ9Ed8/dgGgsMjPYbVosYwr+ZELu5MqStzCxYhi/o5Na4gOjjExrTvPaOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V4DZLGgf; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V4DZLGgf" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-12711967e0eso167452c88.0 for ; Sat, 07 Feb 2026 00:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770452691; x=1771057491; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=73S70KhFl7MAoO9qRsIjn211Skfv7Zjtw2IW8M3qYRk=; b=V4DZLGgfOnwdYAODUs8NQEZVtzb5x1RYT8WITEPDdYaBNRz5uBcVMTYidITua85lKK L/L6zxBhlTs7QAOL2Yqc++Sjzm9Hg+rz+xOOCbUUhsoMbRlc4o+m7A3u703vn4xQu1s/ zeUH9ICiAQW2nvDj3U60ielvZaAOsm+iXt5OVFyOQAnkntitiRx6k+SOo9X8zdxRsBKi bGpTarDgM6DOXqoVnKnCxZYTJN5eZ4Z0Y9ixL8+RSnVGO41ukOsl3fdLeOlQpl4jwcSE VmyJD+XUtfLl6vupK1p0oCo8vsdYGXGigzpka3NRkq8P9u/2+c6eLuytDpA6QRlXNgx3 Z/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452691; x=1771057491; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=73S70KhFl7MAoO9qRsIjn211Skfv7Zjtw2IW8M3qYRk=; b=wWM7rgqmrmoVCa3WWy5WweDdw5+i4DGJdoxpcZ0q9Yous3Bp1GZKLYRfBOEFdBloUZ XEwj3lt4wU6UCVdiRFuyAehmVCk2alLDDUif1RPBdgv3w6wMXRz+ilOKfYqjs+8rNzEs PuV0UXglh16x7EJjshYSgdoM3dOKTFoRBailK54H9x/ZES2uzzGWtL3nxHe/mFQcOCb1 U+Y/6IHjuV+k6KzMEosCPuO4eN8aS2Mz7PvVrQBea5AHGYm8bEJxXk9sR+1JYoyjy7Rb hYm5iWvck/twkEBx65qaq5z+JYGXS8frQA7m06p+zhlhSywvSx9Xy25QJUHCFE3kD+H5 zhwg== X-Forwarded-Encrypted: i=1; AJvYcCV7+bGAWWpMnhNBvI9sw1H0/jrvtA0RS8/GrRJsSe8PGiCHHLr0a4p8xXF29gnzuk/Fnsu5JUF32AlIVDE=@vger.kernel.org X-Gm-Message-State: AOJu0YwDrI8ZDcvXKYr2vTGt5V55lNaYEIO1D6ow+4wDbGNeEs3ikHxk rXQDbR2k7bRD9fxqSu/k6B5lILvTYs+f0aCHD79dI63EaJqMjL4+ND8dM4lnwwa1BtqV5kRmaFm 0xkwylyV27g== X-Received: from dlbcy24.prod.google.com ([2002:a05:7022:b98:b0:126:faf3:bc29]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:4a2:b0:11b:d211:3a64 with SMTP id a92af1059eb24-12703e8f4c7mr2884395c88.0.1770452690831; Sat, 07 Feb 2026 00:24:50 -0800 (PST) Date: Sat, 7 Feb 2026 00:24:26 -0800 In-Reply-To: <20260207082428.1742209-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260207082428.1742209-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.239.g8d8fc8a987-goog Message-ID: <20260207082428.1742209-4-irogers@google.com> Subject: [PATCH v1 3/5] perf tool: Constify the command and option arrays From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Eric Biggers , Palmer Dabbelt , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduce scope and capture immutability. Signed-off-by: Ian Rogers --- tools/perf/perf.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/perf/perf.c b/tools/perf/perf.c index f475a8664ffc..1f51e8de6b1b 100644 --- a/tools/perf/perf.c +++ b/tools/perf/perf.c @@ -48,7 +48,7 @@ struct cmd_struct { int option; }; =20 -static struct cmd_struct commands[] =3D { +static const struct cmd_struct commands[] =3D { { "archive", NULL, 0 }, { "buildid-cache", cmd_buildid_cache, 0 }, { "buildid-list", cmd_buildid_list, 0 }, @@ -178,7 +178,7 @@ static int set_debug_file(const char *path) return 0; } =20 -struct option options[] =3D { +static const struct option options[] =3D { OPT_ARGUMENT("help", "help"), OPT_ARGUMENT("version", "version"), OPT_ARGUMENT("exec-path", "exec-path"), @@ -280,7 +280,7 @@ static int handle_options(const char ***argv, int *argc= , int *envchanged) unsigned int i; =20 for (i =3D 0; i < ARRAY_SIZE(commands); i++) { - struct cmd_struct *p =3D commands+i; + const struct cmd_struct *p =3D commands + i; printf("%s ", p->cmd); } putchar('\n'); @@ -289,7 +289,7 @@ static int handle_options(const char ***argv, int *argc= , int *envchanged) unsigned int i; =20 for (i =3D 0; i < ARRAY_SIZE(options)-1; i++) { - struct option *p =3D options+i; + const struct option *p =3D options + i; printf("--%s ", p->long_name); } putchar('\n'); @@ -331,7 +331,7 @@ static int handle_options(const char ***argv, int *argc= , int *envchanged) #define RUN_SETUP (1<<0) #define USE_PAGER (1<<1) =20 -static int run_builtin(struct cmd_struct *p, int argc, const char **argv) +static int run_builtin(const struct cmd_struct *p, int argc, const char **= argv) { int status; struct stat st; @@ -390,7 +390,7 @@ static void handle_internal_command(int argc, const cha= r **argv) } =20 for (i =3D 0; i < ARRAY_SIZE(commands); i++) { - struct cmd_struct *p =3D commands+i; + const struct cmd_struct *p =3D commands+i; if (p->fn =3D=3D NULL) continue; if (strcmp(p->cmd, cmd)) --=20 2.53.0.239.g8d8fc8a987-goog From nobody Sat Feb 7 18:20:07 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D907330DD08 for ; Sat, 7 Feb 2026 08:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452694; cv=none; b=lXj5gFABUP3jdUNNgzzEFydg6D3SAfp156kXd8C/U8SJ9lyA+b59nxMaDRKlnKYsplqz+NjjNKn9V+RKBjq7t+Z2A32M+Rzngk4sTDtnrUJyTYSIbDElmrDIikZOk/onGbuzTW/PMH8hIz41sHbcbzpeaSQ7Re70daHnaBAG840= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452694; c=relaxed/simple; bh=rH5/T6FT365KFZmlKnO8FVcvnpa30Sdy8DDRsLNiNPk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=Fs+kvBRxyI7AO3dbnaDBhOtlL68yRELCUvaliQ6jIzBbj6VrLxU1+wuIVDDTpEFZyG9F8/i5k3PrhnojwR6KWuJ5zZkVUe/SKNeUDYiOWwCtLL69nNxuFAa2w8RAgO7kPgh5pLr+NVzK83dKElAHQABtqogRwbDH5+RkvrrioyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tur3aFjv; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tur3aFjv" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-1270dcd11c1so908663c88.0 for ; Sat, 07 Feb 2026 00:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770452693; x=1771057493; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=7d6a//qLSGe67LfY/IQ7qyHIlWhv3Mm2rhpPsBvuHso=; b=tur3aFjviSYOuDgvGlfi203e6LyqHbaXXWjwOlR9Tt0mFOFmoL80sP+FNFADeEPYXm KOiwl8C4ZKKCD+NulodA6wyf7dFwZHxlIeXSsqM8fUIzjfint/XM9ABDKrS6URCHZhWD 2DiHcepKwhJ5fx6Aeuoy6xK+EGJPrCmcE9rhTL4lcaFvQD6/hjwntz6XeU7AjalFLFGv 3CWKX12HnKZynZRGP3ziGc7B0DCaYiusmNWYlhw8KT9z7PtODri6oPs9H0WZPFw14JEO cFMkzy566QWeTE/FEdyCMD4g+uw+CrPL8CBKazae79syTrYjqcgpzISQSWwwo4OOPp8+ c/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452693; x=1771057493; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7d6a//qLSGe67LfY/IQ7qyHIlWhv3Mm2rhpPsBvuHso=; b=OHoX55wdANUo/pvdlSA2N8w4SvgtXI72XO7gzZCyN5OEjvSBzr2ewnm9TT97RZ4CsD WC9tSaHewmjym4AZArWuD1xLb0VbqTzmRpMqWd9IA6oD2Skj2mCvjIEc/7HBEdQbVQAI Phku4ANZylmngrhdb/Ajsb6R5U/TqzsuTQRb5f9lXe5YpYfRAAnYbjc9o+rW+tV28cpD oyGXZT+D5SpYAcu9KJf0paygqBcWmJeAALsuOoBM2Exne1yJwBFFai0FuNev1eKz8Mzg iOZY/6gUNH+Jqtwy6oJqQrd8o1WLfG5ZKFTh4fWNfqu90tnXE3ks54FASEhH5RvcHGPQ efUA== X-Forwarded-Encrypted: i=1; AJvYcCWLoDmWO9S+J33DoilMME0iDGhLi/NVARfoFobR2DXItpEeI7CtHRiptgPxOigGdhwhTwNeA2RSXlqFqY8=@vger.kernel.org X-Gm-Message-State: AOJu0YzuEYtnQnVslijp9M/2/Ilx9/U1E2PPy5IRv5EG8aefm5q9sejJ GBj3nNY7oHGzVZLFSdU0jfkKA7aC3TPw0v3unKpPlksgU51/0qKj5NCzoe2sJSd4zFatQhQ9/TO JZkZg09tZRQ== X-Received: from dlbpk3.prod.google.com ([2002:a05:7022:3843:b0:11b:d8a1:4048]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:1b0b:b0:127:c88:d597 with SMTP id a92af1059eb24-1270c88da04mr1886807c88.10.1770452693030; Sat, 07 Feb 2026 00:24:53 -0800 (PST) Date: Sat, 7 Feb 2026 00:24:27 -0800 In-Reply-To: <20260207082428.1742209-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260207082428.1742209-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.239.g8d8fc8a987-goog Message-ID: <20260207082428.1742209-5-irogers@google.com> Subject: [PATCH v1 4/5] perf bpf_map: Remove unused code From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Eric Biggers , Palmer Dabbelt , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bpf_map__fprintf is unused so delete it, the header file declaring it and the now unused static helper functions. Signed-off-by: Ian Rogers --- tools/perf/builtin-trace.c | 1 - tools/perf/util/Build | 1 - tools/perf/util/bpf_map.c | 70 -------------------------------------- tools/perf/util/bpf_map.h | 23 ------------- 4 files changed, 95 deletions(-) delete mode 100644 tools/perf/util/bpf_map.c delete mode 100644 tools/perf/util/bpf_map.h diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 311d9da9896a..2aaa3ff452ac 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -21,7 +21,6 @@ #include #include #endif -#include "util/bpf_map.h" #include "util/rlimit.h" #include "builtin.h" #include "util/cgroup.h" diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 89de23dec401..70cc91d00804 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -170,7 +170,6 @@ perf-util-y +=3D mutex.o perf-util-y +=3D sharded_mutex.o perf-util-y +=3D intel-tpebs.o =20 -perf-util-$(CONFIG_LIBBPF) +=3D bpf_map.o perf-util-$(CONFIG_PERF_BPF_SKEL) +=3D bpf_counter.o perf-util-$(CONFIG_PERF_BPF_SKEL) +=3D bpf_counter_cgroup.o perf-util-$(CONFIG_PERF_BPF_SKEL) +=3D bpf_ftrace.o diff --git a/tools/perf/util/bpf_map.c b/tools/perf/util/bpf_map.c deleted file mode 100644 index 442f91b4e8e1..000000000000 --- a/tools/perf/util/bpf_map.c +++ /dev/null @@ -1,70 +0,0 @@ -// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) - -#include "util/bpf_map.h" -#include -#include -#include -#include -#include -#include -#include -#include - -static bool bpf_map__is_per_cpu(enum bpf_map_type type) -{ - return type =3D=3D BPF_MAP_TYPE_PERCPU_HASH || - type =3D=3D BPF_MAP_TYPE_PERCPU_ARRAY || - type =3D=3D BPF_MAP_TYPE_LRU_PERCPU_HASH || - type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE; -} - -static void *bpf_map__alloc_value(const struct bpf_map *map) -{ - if (bpf_map__is_per_cpu(bpf_map__type(map))) - return malloc(round_up(bpf_map__value_size(map), 8) * - sysconf(_SC_NPROCESSORS_CONF)); - - return malloc(bpf_map__value_size(map)); -} - -int bpf_map__fprintf(struct bpf_map *map, FILE *fp) -{ - void *prev_key =3D NULL, *key, *value; - int fd =3D bpf_map__fd(map), err; - int printed =3D 0; - - if (fd < 0) - return fd; - - err =3D -ENOMEM; - key =3D malloc(bpf_map__key_size(map)); - if (key =3D=3D NULL) - goto out; - - value =3D bpf_map__alloc_value(map); - if (value =3D=3D NULL) - goto out_free_key; - - while ((err =3D bpf_map_get_next_key(fd, prev_key, key) =3D=3D 0)) { - int intkey =3D *(int *)key; - - if (!bpf_map_lookup_elem(fd, key, value)) { - bool boolval =3D *(bool *)value; - if (boolval) - printed +=3D fprintf(fp, "[%d] =3D %d,\n", intkey, boolval); - } else { - printed +=3D fprintf(fp, "[%d] =3D ERROR,\n", intkey); - } - - prev_key =3D key; - } - - if (err =3D=3D ENOENT) - err =3D printed; - - free(value); -out_free_key: - free(key); -out: - return err; -} diff --git a/tools/perf/util/bpf_map.h b/tools/perf/util/bpf_map.h deleted file mode 100644 index c2f7c13cba23..000000000000 --- a/tools/perf/util/bpf_map.h +++ /dev/null @@ -1,23 +0,0 @@ -// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) -#ifndef __PERF_BPF_MAP_H -#define __PERF_BPF_MAP_H 1 - -#include -struct bpf_map; - -#ifdef HAVE_LIBBPF_SUPPORT - -int bpf_map__fprintf(struct bpf_map *map, FILE *fp); - -#else - -#include - -static inline int bpf_map__fprintf(struct bpf_map *map __maybe_unused, FIL= E *fp __maybe_unused) -{ - return 0; -} - -#endif // HAVE_LIBBPF_SUPPORT - -#endif // __PERF_BPF_MAP_H --=20 2.53.0.239.g8d8fc8a987-goog From nobody Sat Feb 7 18:20:07 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E83DB30C354 for ; Sat, 7 Feb 2026 08:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452696; cv=none; b=H1+RGQboh21k+ve2Yhu11iPLX2+XmZY41QR6Vpln8/D1A+Iq85+GfWgGj1t4toBXqRPsQ2im5AqfaQ5tpF2wEZaGOVqyCQk67PXLnKmS8PWbjS4QCPBpwKegFFrScIZI25HnZWr0bZ6LIKxkKxhueMEL4fLqdAePmAONC6NW3hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452696; c=relaxed/simple; bh=KhN5T8AvFwLNeLAg0jkMyMS0WBRDSb5XoSOUV7V9Q9M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=kXHtRCe/qnZrFUyB+2Unm79zmyTOzfJ6yQxQvwZQMsY9ySomjCp3DfU/iZ1fVUaRKogbsbif5gnT1+xf9HX2B0byzpLCRWQ9pnh5+HJzt1appw+35fPhkww3PnEgtEcn38WW6/IKm+t/NMycqx64KL8Ct5J0oheWTRiC70qcAjg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YKy4Pnyx; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YKy4Pnyx" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-12711ec96fbso1497418c88.0 for ; Sat, 07 Feb 2026 00:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770452695; x=1771057495; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=e5hwRlpZOru3mHo0xtBCmuQo2bn4Bp/qBvnWBCSLokM=; b=YKy4PnyxuZp118gNXEQ4B5CjjqbNMtcW3TC1L9xTNNBR7i3FNYVGnYlxXzBh0gmt10 NYnoYdzMUimG+iFUXbR9gjI8vxAgT/e6CLeptj7+Ee37iNmxovHx6r/9HFOq0ALcerCx q2BD2BHOG4OJPCvnOcHXrhcG/c+eJxsUpg9Skd+EcKbD+77tE5bpnll4FBE0pkLiskPo L2ovATZLuVUFxEvIl5Ch4mnT409GRFkudHp+qOksUXGIFU5a9RSkmNzxQOELk1cCVGZM ShG6HRWOeE39RxR7LbMkBPPcSD8ZSCeNhFqk6uGYBH88xqlzV4B8HSkyDYrZZ5Zw6mwY wJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452695; x=1771057495; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e5hwRlpZOru3mHo0xtBCmuQo2bn4Bp/qBvnWBCSLokM=; b=cxPaBCKAP3Eke5tBcExaWC2ieZQAF19/NDGR58hhkZCivhKu0H2cHmVzS5f73xSwsD 5L/USyFQ+v93/7D1JhOpVgh840493hHlvey8kMY+PgmrQ5dQhBvTi5G7QU6PC9VnfGhd HhrBPUfkjcgtqxqqif8P8hxllCzQWlTE1uk5IpBRYRUvof9tW30/YSbo7mvZ7EV1i2aK E3ZK0J4W/w+vZiQgLZ842DtIABgrnTzUWZp6FGNXEZpkU9VAHYvyKxyXJSCciRIov6x8 7n05UCDjirnG3BR43Df57MNLTao+M7HUu2JfAcwmzsuzr66tfbtQ6lMaUCidfL3eoXcW ME4w== X-Forwarded-Encrypted: i=1; AJvYcCU6qjqpAr3LqxjRmCdFJXYtAWLhlguEectIDIYCsJyfjWgj1CD/0NO13dBHags5N9EJYRXBIS3hGTBWzRg=@vger.kernel.org X-Gm-Message-State: AOJu0YwBd8Lq1oBzIx9P1O0mvC/dUu2PhG6e/jZQplazq3RKmgVQsz6y fglScrGvD5seAV+NFz33HEORSDU+YBlgflLwp44b3KD5eL3Q6mVwsNtAcXqABNIVrMwKunR4+dT FM3he2hRV2g== X-Received: from dlbpk3.prod.google.com ([2002:a05:7022:3843:b0:11b:d8a1:4048]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:629e:b0:11b:c1fb:896 with SMTP id a92af1059eb24-12703fd8ea6mr3245953c88.4.1770452695218; Sat, 07 Feb 2026 00:24:55 -0800 (PST) Date: Sat, 7 Feb 2026 00:24:28 -0800 In-Reply-To: <20260207082428.1742209-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260207082428.1742209-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.239.g8d8fc8a987-goog Message-ID: <20260207082428.1742209-6-irogers@google.com> Subject: [PATCH v1 5/5] perf record: Remove unused cpu-set-sched.h From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Eric Biggers , Palmer Dabbelt , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Header file declares unused macros, so remove. Signed-off-by: Ian Rogers --- tools/perf/builtin-record.c | 1 - tools/perf/util/cpu-set-sched.h | 50 --------------------------------- 2 files changed, 51 deletions(-) delete mode 100644 tools/perf/util/cpu-set-sched.h diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 60d764068302..40917a0be238 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -40,7 +40,6 @@ #include "util/perf_api_probe.h" #include "util/trigger.h" #include "util/perf-hooks.h" -#include "util/cpu-set-sched.h" #include "util/synthetic-events.h" #include "util/time-utils.h" #include "util/units.h" diff --git a/tools/perf/util/cpu-set-sched.h b/tools/perf/util/cpu-set-sche= d.h deleted file mode 100644 index 8cf4e40d322a..000000000000 --- a/tools/perf/util/cpu-set-sched.h +++ /dev/null @@ -1,50 +0,0 @@ -// SPDX-License-Identifier: LGPL-2.1 -// Definitions taken from glibc for use with older systems, same licensing. -#ifndef _CPU_SET_SCHED_PERF_H -#define _CPU_SET_SCHED_PERF_H - -#include -#include - -#ifndef CPU_EQUAL -#ifndef __CPU_EQUAL_S -#if __GNUC_PREREQ (2, 91) -# define __CPU_EQUAL_S(setsize, cpusetp1, cpusetp2) \ - (__builtin_memcmp (cpusetp1, cpusetp2, setsize) =3D=3D 0) -#else -# define __CPU_EQUAL_S(setsize, cpusetp1, cpusetp2) \ - (__extension__ \ - ({ const __cpu_mask *__arr1 =3D (cpusetp1)->__bits; \ - const __cpu_mask *__arr2 =3D (cpusetp2)->__bits; \ - size_t __imax =3D (setsize) / sizeof (__cpu_mask); \ - size_t __i; \ - for (__i =3D 0; __i < __imax; ++__i) \ - if (__arr1[__i] !=3D __arr2[__i]) \ - break; \ - __i =3D=3D __imax; })) -#endif -#endif // __CPU_EQUAL_S - -#define CPU_EQUAL(cpusetp1, cpusetp2) \ - __CPU_EQUAL_S (sizeof (cpu_set_t), cpusetp1, cpusetp2) -#endif // CPU_EQUAL - -#ifndef CPU_OR -#ifndef __CPU_OP_S -#define __CPU_OP_S(setsize, destset, srcset1, srcset2, op) \ - (__extension__ \ - ({ cpu_set_t *__dest =3D (destset); \ - const __cpu_mask *__arr1 =3D (srcset1)->__bits; \ - const __cpu_mask *__arr2 =3D (srcset2)->__bits; \ - size_t __imax =3D (setsize) / sizeof (__cpu_mask); \ - size_t __i; \ - for (__i =3D 0; __i < __imax; ++__i) \ - ((__cpu_mask *) __dest->__bits)[__i] =3D __arr1[__i] op __arr2[__i]; \ - __dest; })) -#endif // __CPU_OP_S - -#define CPU_OR(destset, srcset1, srcset2) \ - __CPU_OP_S (sizeof (cpu_set_t), destset, srcset1, srcset2, |) -#endif // CPU_OR - -#endif // _CPU_SET_SCHED_PERF_H --=20 2.53.0.239.g8d8fc8a987-goog