From nobody Sun Feb 8 11:06:15 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 080222DB7BA for ; Sat, 7 Feb 2026 08:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452708; cv=none; b=amjIC6mBv+5rhxfg1FQioN3Jvl6tJArOMpR2xbR8/v7qamvc0nD7xI5FPsRTEb9bKlPUCmyN9+loSOFGoOlRKGVD0KlVqfqAiFKlD729DiiXON0kfjCZqzbw6tgKyXPe6Id+piSQDxTFlkyE2BPxqBIj0cm1q/wbzvkvfADTwGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770452708; c=relaxed/simple; bh=8mHbMVQTEBdkgJH1+s9Q9dyxHjqjtcqt2kenf65/lo8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lpQdboVfvV9sChJ17gfhaz44fUOLTFmrMGkOQFw6KRLvidLXHXCK5Zx+aBJ1XklCeM3k9MyEmsjkWhwjKgPWGaJ3Br30aoRoqZ3eXBQOt7Yx8K4YpL6luOUIoHuVtSJvZyXUI9U6FMkQYTvIYUtU6UMiETq+4aqzHXwq2TWY828= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NQEWHiaU; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NQEWHiaU" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-59e4993e008so565452e87.1 for ; Sat, 07 Feb 2026 00:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770452706; x=1771057506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6r1Tf3h0z0iSBNclliMh/VjEPgxlX2G5be+P4mBu2BQ=; b=NQEWHiaUesHcFfbtPhYKf1o0NYGZOtnOQko5foO9mUaq3hr+rzvkdsw47MEY4fa7lp cGR+ZCiR4TrYJe+T6Hmkg9oi0W3Z/oXnLHzccn/E/3Cc7XO7rikJ+N2Dgjgmbsm8PbnZ NJnTlAgr1NUp16haa85OOwghG9ZVjDNrqUP5HrYvconeduoAcO3u2BJ0+AMG7ozUzGBm PfOa7KDKf4No5mi4Ab/qskyOJ7PKl05kMOAv/5aAIFUn6zQzGn6bZl53jpRIJ3RGEZr1 IPnFVWP89Up6YwO5DI5+ETjhi14rPbqQ0On0W7GjiqQzYof3Urud7zwRwH1rsVattojc pf0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770452706; x=1771057506; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6r1Tf3h0z0iSBNclliMh/VjEPgxlX2G5be+P4mBu2BQ=; b=pzSdouy1O4/V/GTZlZEag/BIrliz/KYm19mrxcjMcApl2kQI7VmC3fXdu7ztLi0evQ cpAabQZrsNfAdxggCQuAlmsMk9hF5U1Cmva0gmmDNCvqQfb7AH3MCVvj34ks+cLXTvLc H6I87Xov7mQZJUNaBlpWjvXf21lMTNVRjrdf/A5022sgaWEMwiLvZUW7k9W9/UIyvS7+ UWOJe/cTwiQ9PDoucj8pAhb86o7Mdc/MDV9ujhJoOXJrkoGDeQcwH3GRuyWKlTa7q4Dc mSf4vS1YlMxeCZUcvq1XzhnasjtYehzP9S98vreABXVcFavjoAQUJj/kBNOvou631Hxv z45Q== X-Forwarded-Encrypted: i=1; AJvYcCWUXYl6ecvYLK9vvakYK5QzKUYkL+TP8AnyjhnIELDTZqxUCkZOon4WUKYiRx19ZAJOWWtJggR1y5NHVq8=@vger.kernel.org X-Gm-Message-State: AOJu0YzBwtljTFluCsoJTGzWb++Os0oOtNuYzoMK74mPmmJr5sbsO9oz IspiT4pKwMSygwgyinjHKrSm6F/BKPvTNDp4jQ/UqnQZb/gpZkmlsHZ9 X-Gm-Gg: AZuq6aK/Z7yRHF8Mx7dqyRKS/M0bB5o2ionWJaqMoRO6L8+zcEcvVJXEVe9/Mog7Uft 0GMqtvmO61YX/WwaQWcB7pLRr2hWwRwUdEne4vvEYU0u3caToBP1EFeKfRM0gHBcipUD1FMrOiv 2OhWXRwlDEwrfbZ2etNlkFG1raGml5SJU2m1OaFEHrd4/YdbjMyAV6YaHSyNOwP7366aRQ3P4J/ HzlWsd1YnrMDqpQBuooxNAJaTQ+hQ4GuSgSRWVdTFBpma7EEojO8NPXefQAbSboG0Orn+hCENy+ PdcbQUc3bykK1Og2Ygm3cwQ1VTyEyPcTugaz73pTZd40go/Tjb1ifwuRd62BrtyJOXk3rbHDxoG ovQSi3TS+QFesDs6i1MuFzBcvw20VHpqhRnCEwRaGq97+hfqpDmpXsBx6mNO/EUpLZskpp4IJC5 pmeSftqHBkG5jPZuEYi2kLsw0UyNyCFC9534QK9lHMU248D3zEjzuoG8TzSUqBbdRFuD4zjrSaB HwSVA3e/z/o9kY= X-Received: by 2002:a05:6512:1593:b0:598:faf6:1009 with SMTP id 2adb3069b0e04-59e451834f9mr1551959e87.53.1770452705558; Sat, 07 Feb 2026 00:25:05 -0800 (PST) Received: from localhost.localdomain ([176.33.64.73]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-386b63b043esm10666841fa.32.2026.02.07.00.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 00:25:03 -0800 (PST) From: Alper Ak To: Jeff Johnson Cc: Alper Ak , Kalle Valo , Raja Mani , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: ath10k: Fix error handling in ath10k_ahb_clock_init() Date: Sat, 7 Feb 2026 11:24:24 +0300 Message-ID: <20260207082424.596554-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_clk_get() function never returns NULL, it only returns valid clock pointers or an ERR_PTR() on failure. Using IS_ERR_OR_NULL() is incorrect and causes static analyzer warnings about passing zero to PTR_ERR() when the theoretical NULL case is handled. Fixes: 8beff219c528 ("ath10k: add clock ctrl related functions in ahb") Signed-off-by: Alper Ak --- drivers/net/wireless/ath/ath10k/ahb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/a= th/ath10k/ahb.c index eb8b35b6224d..7456f885d2b5 100644 --- a/drivers/net/wireless/ath/ath10k/ahb.c +++ b/drivers/net/wireless/ath/ath10k/ahb.c @@ -87,24 +87,24 @@ static int ath10k_ahb_clock_init(struct ath10k *ar) dev =3D &ar_ahb->pdev->dev; =20 ar_ahb->cmd_clk =3D devm_clk_get(dev, "wifi_wcss_cmd"); - if (IS_ERR_OR_NULL(ar_ahb->cmd_clk)) { + if (IS_ERR(ar_ahb->cmd_clk)) { ath10k_err(ar, "failed to get cmd clk: %ld\n", PTR_ERR(ar_ahb->cmd_clk)); - return ar_ahb->cmd_clk ? PTR_ERR(ar_ahb->cmd_clk) : -ENODEV; + return PTR_ERR(ar_ahb->cmd_clk); } =20 ar_ahb->ref_clk =3D devm_clk_get(dev, "wifi_wcss_ref"); - if (IS_ERR_OR_NULL(ar_ahb->ref_clk)) { + if (IS_ERR(ar_ahb->ref_clk)) { ath10k_err(ar, "failed to get ref clk: %ld\n", PTR_ERR(ar_ahb->ref_clk)); - return ar_ahb->ref_clk ? PTR_ERR(ar_ahb->ref_clk) : -ENODEV; + return PTR_ERR(ar_ahb->ref_clk); } =20 ar_ahb->rtc_clk =3D devm_clk_get(dev, "wifi_wcss_rtc"); - if (IS_ERR_OR_NULL(ar_ahb->rtc_clk)) { + if (IS_ERR(ar_ahb->rtc_clk)) { ath10k_err(ar, "failed to get rtc clk: %ld\n", PTR_ERR(ar_ahb->rtc_clk)); - return ar_ahb->rtc_clk ? PTR_ERR(ar_ahb->rtc_clk) : -ENODEV; + return PTR_ERR(ar_ahb->rtc_clk); } =20 return 0; --=20 2.43.0