From nobody Sun Feb 8 11:06:48 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B1763770B for ; Sat, 7 Feb 2026 02:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770431716; cv=none; b=chP9qtiWLYwnR7Uh/BOZeefwMAaZo16H/SF2t4xvi0iFQbeZTRLaYvn40f7ryg/FkniPmKVFgF/M0WbaTGlge6RJ1nCrpLKKGSXdOWCGD80MHkfxuaf0ZSzBnkEdZQeawfbF/kVURroXgPPNoR8RxpDBjI28R8Z2gafnPN7oZHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770431716; c=relaxed/simple; bh=ppnlubqyDmjaMt7hma1N4XCwciKrKv551fYstqTWoho=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gJqOcQfaaM0oP7yFzr3bmObMo87Pr8zRKMHI8Obxabmu6BHh3+V93U4nIzxP7GFY04sf8HjNqpLApQb8OhAHXLiOk0xNr41JtOgb0WrH537uLDdOm/CQIzHM8ORGHt488/MtV75/Yd7niE1EWxR9+0eGW2Xuti0oKQmsHYtA9Bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CkHBNyQg; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkHBNyQg" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47ee07570deso11408895e9.1 for ; Fri, 06 Feb 2026 18:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770431715; x=1771036515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wOpt3htMY2iz8H2GNKpJZWV8g8hBj7+/EaR4EFNUVj8=; b=CkHBNyQgLg5AnOQzWeQMVWByo12VWCPHnQCBcaN+q73hGlp8VoS7PzJ/dOrGrQ2cgp gIO/tR6xcYnNr/oi/UY2uOlzdQWKxP8cAd7O2caCO7aKc0C0Gv7uZ80cxqqz/2kARo1M TELs9QVjUT0kptqluN3LkDnt/m4AeNwqn8Ms2RmpT3EjpAhk/QpaKP5n5p8+qZ3Un2fK HALXSRl7Ue2QV9XLqfnMHkcckhj67S7gxI8Qp6QqWfxIHiSI/d+o5S47cY02ByV+VETb Cix4QQW7CZcQs40NLrMC7FHL2amG3k04s7EUOT+VazDmHezYFiuwQMz8p9CeZdOR7n23 LhBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770431715; x=1771036515; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wOpt3htMY2iz8H2GNKpJZWV8g8hBj7+/EaR4EFNUVj8=; b=rH/Zu/XHLKr4bVUwser04lezX007/mB4FqjS29urOBQPt5x6ajj+zvK/QMT2YFOVDP yx6/9QrPWPMdiAcvlLDCj5YwmgQz0o7Sjw74jgS0R2LE2aQvjdihr8j54vhcSXiEpk4M APoYWkBl6EPKrhJNYH8TCNYIAVaUUX546pk9y1/DX9lmmfsBT3E13wjUWi5WjGMKIeU/ lvMx3W59mU+sR/gRryXnvJtO3dv5z40UtMD3EcmjTZ4cocImQprMu5H89x4AoGjStkG2 taiwevmgAzSjq6KI55lbo33ZejyQTuc+ErbgFgGLVhBMYpcJh2Nj6jUeRFAWINOLh8uV kbBQ== X-Forwarded-Encrypted: i=1; AJvYcCUh6S0f9LSaNf6oDdanwHjkoAcVBRRHJSbzbj3jMnTNSbRZFxJc62odcHmJpX4npi5FsfBIWs1cGpelV10=@vger.kernel.org X-Gm-Message-State: AOJu0YzJaqI1u1jJKbAKZlllpMSO1O5k3enzTLgd+U6UGXeFLEWYKkAg MWkLI3dGeedYMFteOkqwktlZ146R8vdAp9FHzgrizViZ+S+ZLuqyZhrV X-Gm-Gg: AZuq6aIOJJzy51yXlB2tEXGrGYQuzRp/Hafo9Ue9PkiDApdEfYNp++JtamCQTrdKNYo p9SOoaUHjmpfyBul3JyRFwUorjbid+/CpBMeRQ3Tn7ZFGfLtZ4Py6PA1URHps5JoO66xWkd5yFS VsRg5vnNEXWGtla51HG0x2YiKYjfFa67jtjn/i4hudIcL0GNCpEDgv8rYYcUVp5iNOl+/92rvr5 OT6FsJdsDpQniAz38IQXGCcXy/65YHwAA7zuPBpNgI/1+NHNrFb6HJ4XzaCMJsMPu5GZsOcZ56u 1ZGC+vnenwZgJAYNLRUJZQAwy6RwF86YxNodo/fO/u9H/UHfI3F64lUqb7utb/35ZW9sKLaLyB1 x6GGC1W9iTij5t2Jqqof8yIKzcVnx/k4Zi6n7+2olc+X5oGXeBrCNXozfEcNv04aHkSvF+rOkLU 8mtkcSC6RITrkqWl3rZplklt6j/cu7WzoostIZ34i+ZDV66yj+lr6+quQ1 X-Received: by 2002:a05:600c:3b23:b0:45d:f81d:eae7 with SMTP id 5b1f17b1804b1-4832021cb8fmr63117945e9.28.1770431714400; Fri, 06 Feb 2026 18:35:14 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([103.73.101.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d2bab2sm297129815e9.3.2026.02.06.18.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 18:35:14 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: Dan Carpenter , Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH v3] staging: most: dim2: convert pr_info/err/warn to dev_info/err/warn Date: Sat, 7 Feb 2026 07:34:32 +0500 Message-ID: <20260207023433.3935-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dim2 driver currently uses generic pr_* logging macros. Hardware drivers should use the device-specific dev_* logging macros to provide better context in the system logs, especially in systems with multiple controller instances. This patch converts all applicable logging calls in dim2.c to use the proper device-specific APIs. Signed-off-by: Zeeshan Ahmad Reviewed-by: Ethan Tidmore --- v3: - Removed "staging-next" and redundant "[PATCH]" from the subject line. - Shortened commit message lines to stay under 75 characters. - Added this changelog below the "---" as suggested by Ethan Tidmore. - Cleaned up temporary submission notes from the permanent commit body. v2: - Rebased against the staging-next branch. - Fixed CC list to include relevant maintainers. drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 80af965356d0..4bcafda481f9 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -246,9 +246,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, stru= ct mbo *mbo) { u8 *data =3D mbo->virt_address; =20 - pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]); + dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[1= 7]); dev->link_state =3D data[18]; - pr_info("NIState: %d\n", dev->link_state); + dev_info(&dev->dev, "NIState: %d\n", dev->link_state); memcpy(dev->mac_addrs, data + 19, 6); dev->deliver_netinfo++; wake_up_interruptible(&dev->netinfo_waitq); @@ -472,13 +472,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_CONTROL: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_control(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -486,13 +486,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ASYNC: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_async(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -500,41 +500,41 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ISOC: new_size =3D dim_norm_isoc_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; case MOST_CH_SYNC: new_size =3D dim_norm_sync_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; default: - pr_err("%s: configure failed, bad channel type: %d\n", - hdm_ch->name, ccfg->data_type); + dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n", + hdm_ch->name, ccfg->data_type); return -EINVAL; } =20 if (hal_ret !=3D DIM_NO_ERROR) { spin_unlock_irqrestore(&dim_lock, flags); - pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n", - hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); + dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n", + hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); return -ENODEV; } =20 @@ -608,7 +608,7 @@ static void request_netinfo(struct most_interface *most= _iface, int ch_idx, return; =20 if (dev->atx_idx < 0) { - pr_err("Async Tx Not initialized\n"); + dev_err(&dev->dev, "Async Tx Not initialized\n"); return; } =20 @@ -657,7 +657,7 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) dev->atx_idx =3D -1; spin_unlock_irqrestore(&dim_lock, flags); if (hal_ret !=3D DIM_NO_ERROR) { - pr_err("HAL Failed to close channel %s\n", hdm_ch->name); + dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name); ret =3D -EFAULT; } =20 --=20 2.43.0