From nobody Sat Feb 7 17:41:40 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5680422A7F0 for ; Sat, 7 Feb 2026 02:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770431364; cv=none; b=W3DM+E8z4+eY8rvwF8oUOXkcvFPMzdrOh57fx7CHAWOegmZnKYCy8HtryX7dsl1htRFsCgTiRPmoxXISEu7p8jd7Lx1mNqyCdFgMYosAh+qpY3V1NCzSJQ+7wZNfa6nfG0kD0x6HvsCk/ZmV2IRWa71f5ykqu7LNCFn+KUYFkOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770431364; c=relaxed/simple; bh=W/zKT8pihZuNeRNWFE+Iz0LR9lkmqLLeLgH0gTHNuhA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hfLdju5sZN665zpWgQOSwvSvWMcuhW/61FLSsgHZiDPvoSdh9/I4Tu3TQmVPC/Ot3+O3d5BYb3/69er+EyCcgEPtQUYFIdsa5qUIQtJ4TwBwhnmz8c94V8WZ46YScTvzy8bdRhnh7yUqj1VVrZIFGCwsTQaVhfgPGE3GJqcVyFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N6EnsNi8; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N6EnsNi8" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2b71515d8adso2525272eec.1 for ; Fri, 06 Feb 2026 18:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770431363; x=1771036163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=81NOIKyjXWY4ZCoXjtiblPwU1GJd25Azk4Mn/8eNrCo=; b=N6EnsNi8cZUg4afDNsFmze8tX85L4cTsiQz/mJRlXa3sdHHBsBfazQNmGMnKX9232o EM9MbnTUREBF4b5AcIfvOEUqTc/T/SP13gVSmeNBNJ4U0cpoYi1cj0peOp920CVBlAhK IOPT8sJJ1zXykR8DiXNRQh4npnk+AYraKoKbzwZ23Zbh8Txr3Z2uCiy+RtrA9yWvy5AY ZFGVHApVVNGKWgiqXo2YE++7pZeq3slSXZjNTotKTzAQFbZx2Dj9biu4txNjrAJaAbcP jAY5vefr+v1EogcszNQd3a5ByoyFI8gpMDhzp9n88fQn7oaXCeUCn/pfKcTNhsN//x8l YOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770431363; x=1771036163; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=81NOIKyjXWY4ZCoXjtiblPwU1GJd25Azk4Mn/8eNrCo=; b=QGs9OTGoC4HbcAx5yF+LPezF/VmoFamIgU31XvloBIztQF0m15t4uyaF+Ha9LrdQqj UzcOV11x/GQMTVZnubpT/jIuECElHQzUX/GDYQEll1qxbHfusKXYiSEd536HMeGwuvHR mfy3BxjlC1yMC5MZbdjpTIsS1S3/vt3ohN9Ruy9/gPGQKo268r1DCSm4liPV+PDe7o8b AseN0QeCDFjKf8PcxkYYUAWfJwmar9tRyy3cdjauj6V1roz+FH5IGOGQFCajnEGyaFn9 3nD8GwCJ6yd2vIQBUVPwrEdfDXamqKHKToPgERXPcdHHD/qFgcR9Xq9n4jj9DmoGLrd+ DuQg== X-Forwarded-Encrypted: i=1; AJvYcCUwe/BIya8g1im7w1C4Gr6haEcIThmmShpqGCNUHpovDq5RkmIsPwtUZxfsk7Nno84ZUw2s6/fAi7oTsIM=@vger.kernel.org X-Gm-Message-State: AOJu0YxEXzmEKzds5bByY68xijRmU6vJOeU8Ke/imhTEt16Lgoza3nQk tX0MqB5Ylu8cWqCpBGV2utLnpJ/CMsgN0grNv8td/bN0U3se0JtA9BOW X-Gm-Gg: AZuq6aLLtM/mb2V9PO73PjnHemsjiO+W++WGVT8RGcTeUDiJeKHwwxsR2tnFvOS5Fb8 q65CIzEsa+JoDlBZ4HE/qUxxRnLxJPDERdAo2aPHoC2Nj/pwLhyPEtskplXwr9FJjywfXKYrvmv rw2FIBLo7ObZ7WBPiaOAPgO2+5qU/T+87stY3AUtg/sxR2Vclv1R7o6aagSITSk8DP//lruD0x0 h9GCnyTw2K5OOweasAMmwX+lO/B5wgOpgNGg7idyagP0dPoXQ2dv9qx9hj+28EVkPISK+dOnUvC RNDS98RWoqz2XW0RcaYfknxkCnPBQbt6o+aQmyfOKCt3ci7WlwuFBDZFb3ZlqqbBS6kjX1WhbDY dbADxkUUiAHkAicnh27DcuAfRnMnsaxIbilfkFEPlBEKQLlfwsfQpl0+kxdQHQlmXmgr0PD4Qlp PhntF7EtuFiak44W8c5ZUZXmUrJgqj8Y5n9jSTArL3FQ/WHKFMYgcTjcAX2ER8eMK+1Z96m67T3 bOVVJprSxlMcTgcg8taZZHkF3xbCYdR8S7J X-Received: by 2002:a05:7300:4352:b0:2b6:c617:f79d with SMTP id 5a478bee46e88-2b85647cde3mr2281838eec.13.1770431363324; Fri, 06 Feb 2026 18:29:23 -0800 (PST) Received: from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855b0f624sm3761035eec.14.2026.02.06.18.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 18:29:22 -0800 (PST) From: Milos Nikic To: jack@suse.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic Subject: [PATCH] ext2: guard reservation window dump with EXT2FS_DEBUG Date: Fri, 6 Feb 2026 18:29:20 -0800 Message-ID: <20260207022920.258247-1-nikic.milos@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function __rsv_window_dump() is a heavyweight debug tool that walks the reservation red-black tree. It is currently guarded by #if 1, forcing it to be compiled into all kernels, even production ones. Match the rest of the file by guarding it with #ifdef EXT2FS_DEBUG, so it is only included when explicit debugging is enabled. This removes the unused function code from standard builds. Signed-off-by: Milos Nikic --- fs/ext2/balloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index b8cfab8f98b9..0fee01ed56d0 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -201,7 +201,7 @@ static void group_adjust_blocks(struct super_block *sb,= int group_no, * windows(start, end). Otherwise, it will only print out the "bad" window= s, * those windows that overlap with their immediate neighbors. */ -#if 1 +#ifdef EXT2FS_DEBUG static void __rsv_window_dump(struct rb_root *root, int verbose, const char *fn) { @@ -248,7 +248,7 @@ static void __rsv_window_dump(struct rb_root *root, int= verbose, __rsv_window_dump((root), (verbose), __func__) #else #define rsv_window_dump(root, verbose) do {} while (0) -#endif +#endif /* EXT2FS_DEBUG */ =20 /** * goal_in_my_reservation() --=20 2.52.0