From nobody Sat Feb 7 18:20:06 2026 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 924A423C8A0 for ; Sat, 7 Feb 2026 01:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770426381; cv=none; b=LctAwb/cn8O+pC6VxIU4vhdRV3LLf8aCHCYPzbMELUFFOivvHmx7Xj+bU3UZgS4jv67MSTtHK4eFno6Xfg3TRzwl4ueTpcHFBvob22iiMeVInFeB/BUzbeTIxGE8dlHuxfNTZt1l2n3dDb/DkzFVB90uSxajqzUryCdl2e9ZodA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770426381; c=relaxed/simple; bh=CjoRwzUH4R8x/n/7y1CkznKIRCyKpv3yTyXgli5U4wM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NiOws1Fws+yWwayDbW3z4Y1vdASUs216ytKsI0Bpn4bls5WTSrGaCl0IciM5QU2snFpmMFYz6jZCJ9bvII7+gYqtlH8jrI2SkzMJM4LZNjDY5J9pS5b/FRn1W/TzoFb8jgBzA7RMgDzS2Q4UKctqqRYXZImAxK+h3lCr/GRI9hk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddc4Isqa; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddc4Isqa" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12460a7caa2so1597180c88.1 for ; Fri, 06 Feb 2026 17:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770426381; x=1771031181; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dawYaSkjSeeyfXPo6xA5YUh2ssPoeMLLOdZBaaBhvAU=; b=ddc4IsqasYXu2GabntQJdkV9EtvgP6+CXHue9xCRuYA3AsBv8qqnn2m2qxGJp/zrfU IkFDsHS5pkPJ3Po9het5zE2Cl7dcAwYUhJETtoo8juQuVJcUDGt0WeVaQ5y1imaaYkRp XUaaWDz7LY3ltDiqVyr3ZA2TM+Hz47jpoMkB1Tobij+gI7h4dETDrBTDdPtqpPO6H3/G LVBU5NGqUPYzuXf8HsUWl/AOlqoh719co1nTZmx210z/Lqm6oJDi5P/ynlhfYn4I4aVI FPOZZ4x0dzpeBldUqRGSouztRcpl9DIafxb8LR8S5yTzCjIMuCJew79iUIsDOingNA27 BCvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770426381; x=1771031181; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dawYaSkjSeeyfXPo6xA5YUh2ssPoeMLLOdZBaaBhvAU=; b=e4jUAvXPAYi569ZFesX7IFYEKCO5tb05YxhvrdKSKzuDhvziP8N9ejvPZLo/smK77O Kic91eNxF58jaI+91yzIJwCsG0NsfmNVP8wMMM74lzN5rcfnlmiWEesEPoO/v6nZwT3d m9LL4zf7CAn46swkY6LqiYWeGiTBQL+jYKbmrwPBc/TIcHCT5vR0af7lcPI5uOzKuH0A AOsKt7Tn6LTJNWgOgNdddjKtIReqJBp7UH0UjuYBAKQ/BpFt2+TwgSsxrtvg7rKRs2lL 7oy1oDF4mXVMBpbefDUgNl6n4oQtmgplJ0hqfiTKFl/r6iBVPM8ua/M+mawY4/tYalg8 J/Dg== X-Forwarded-Encrypted: i=1; AJvYcCUG8xXionsCHW7ue3nexqfaW23zzsnDK0NzZxJAejC9QCA8SGrmqWEjRElYJ8BHwo4pgKI0dBOtKjUfCJU=@vger.kernel.org X-Gm-Message-State: AOJu0YxDETwrgjKBUPutuQP3Cq2U8WQYBMjcoyoAWN3ZD2K52MzQE26D 5SXyUiUhGKJND1GFTMmEFOI5x6nC2zmDR9wiY00gYVwrvbh/rXG1MbBaCa/Jpg== X-Gm-Gg: AZuq6aLErvNOz+CZw61cz0fTcCp652tyH93GEv0MyeK7ftlm2IsX0ntCJM/9387Aeac L52vMFQ/fZSjqMDSfaJMMH9YfLO2lk0tggDg5pNLU5q8zyriAHZCbrcP4NlMc9x63ebPk9coMeM Sj67IU+9k4Ga/Q1OGP48LoQ+aYoHY9avTbe8dFEqlK58E2ngjpJLhabwEZGXRQPOQr8Qj17UAjI 8xDj3rC95/fWOI2NB9JuJjIe8R17I1WOLDNMey5frqMvsEVX7LiK6peRaimINocvCQmZ8tGb7JB 2DjJB/tl4XNFoKsC0FgwgnkIORnx/lzV/wagEzi9hShTPCoAUo5wT3PLHWEDcsPtdOkHrCXCamg qeyuwYqbr85d9Zv+7xVz8a5SodaPBWP9O4vNeNZ6hwZiE4SibvK2IPNuhrzr1NEYHPfnHiQYWvz V4Ktz4K9SNMpS/Gj1rhQtYiFyYxzqopjrFG2z5S2XaibABXyGoz/aDeEw8x/roQLTivhP90Brpc faWrDwazl3d3vsxRCp4P/L3awl/glwFW/Bg X-Received: by 2002:a05:7022:250e:b0:11a:2f10:fa46 with SMTP id a92af1059eb24-12703e569femr2185435c88.0.1770426380622; Fri, 06 Feb 2026 17:06:20 -0800 (PST) Received: from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041d9c91sm3690236c88.2.2026.02.06.17.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 17:06:20 -0800 (PST) From: Milos Nikic To: jack@suse.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic Subject: [PATCH] ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks Date: Fri, 6 Feb 2026 17:06:17 -0800 Message-ID: <20260207010617.216675-1-nikic.milos@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If ext2_get_blocks() is called with maxblocks =3D=3D 0, it currently trigge= rs a BUG_ON(), causing a kernel panic. While this condition implies a logic error in the caller, a filesystem should not crash the system due to invalid arguments. Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for debugging, and return -EINVAL to handle the error gracefully. Signed-off-by: Milos Nikic --- fs/ext2/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index dbfe9098a124..18bf1a91dbc2 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode, int count =3D 0; ext2_fsblk_t first_block =3D 0; =20 - BUG_ON(maxblocks =3D=3D 0); + if (WARN_ON_ONCE(maxblocks =3D=3D 0)) + return -EINVAL; =20 depth =3D ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary); =20 --=20 2.52.0