From nobody Sun Feb 8 04:18:01 2026 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B352DC787 for ; Fri, 6 Feb 2026 23:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770420922; cv=none; b=RhpHu7hXG/6Nn+mynOfDq8oqZf65iGMVfI8Yza0YRFuMbY7BJvCJ3kjqr9r7xJCKpN9SFq57VcJjWE0XQAuP/uFa27EMJKUXpWxyypAB9RoZHNOG0OGXWCIcYz7rBeGDqywTVHB/676O2lHcBJzGjP/y1EBp6GjWjWoJSRMxens= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770420922; c=relaxed/simple; bh=ioFVdvu04jyE88Bl/6Klw1xQVaUTbTejnlaXrA2zP1s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N0c97zyJpXyPNva++FXNi45XQ1briFa5FDOXlVHxGmMyN4H5HRnThrSGUqrajQqCCEFV5+DXE6a7pxOvWigiGfFHKJ86sd05elu9rP4hqeqP1vWxRCr0fRTD5LVpXeOHKQWScrw0Koc97fMjghSzWi2m0yhDmd6JZL2gPowim94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dlZ0W8gk; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dlZ0W8gk" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-47ee07570deso10869935e9.1 for ; Fri, 06 Feb 2026 15:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770420921; x=1771025721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k451G6QmqVBd/yN6Z+kczBOVlmYBdf3X7amT540mWgg=; b=dlZ0W8gkY/OsoEB4fcg2hRTmz4qMSV2E9850+4QktXZEbPSPRl2umegqJOAT+LWX3C 4Ox/QAUd0IeEVxQTVasOTDOtxa0Ew+MoreyYGizwenwrkIv+hwDKspmfJMj8pTiEUvcd OVGw2+vzr8shJZxp1lok8vcppTcOkr1sOiyBlolLm/DkNjGnDkLcyP5uY/S4MSzWAXeM TInqfCCo4/w6ANTUkOVs9nnilq8rtJgivHABTsnUgH1I2Q7ttvaUf4QIxv6IiC5KvslM h47TEiBodOA4XmOsf1T2EoMYlTj4VolilZ9IsWfMQ/YFw7wwYWM2V4FQjgOOLlHxUvJG Y08A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770420921; x=1771025721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k451G6QmqVBd/yN6Z+kczBOVlmYBdf3X7amT540mWgg=; b=Y6gwZKv+bFEeo1djXYqFoXVPdomTqv/rSBdYGOufxpSkFP11z+g3xn0bolWwF53ss1 lbQZ4GmWGidK4EtFZ4W6RdrR6oy8rhQfjvQvSRDgBvBi/TBjCZwhop8s5SIIvpuRbbRd Zy5lxbBz/RjP1mOPjGaqaVQ/zCY5nEgHIi3y+jJiSmQCYfRzBGZeJDc4CF9eNZkM/g8n JZiM28kBljU8gJo9OoT5Wezf7Bl8wdpsdqsfYPDY3E/p7Q3KZJfNkJ8qxwLtNtlWbWUG BgYy8cyirPOs2UMsfBeS1VyS/fw81HgLDEi1ZAof0amynVcjUiMDOZPyWPGfm8flukPJ 0/gA== X-Forwarded-Encrypted: i=1; AJvYcCWYbe1yne7boowSoYdXu/c4YkikS66eDZuyz97RbYHGv4IvaFNPWOyzIT3LXbqoAavpx0i877Yg5naCjjI=@vger.kernel.org X-Gm-Message-State: AOJu0YxyOrLOQsneRuDJjHkEOS9bY8KUBHMNBjbPMG5A2/iUb7msG808 gOYKtLMhIZxGhDpct3B0gJiVyyNDcH+owTR+AK5V0v+BZyfh0FvkTGGy X-Gm-Gg: AZuq6aIdvJjdmdtspICCVeHjdtWMXRPq6TkWpkWIb6jVXVdlkF+bPkHiqb3+qvoBqPw QtHM5YGfACjdSqh7pTgqrWkPGkubR1yicR7PBECglrz5UE07roEcI8HUna37VJaQE8L8Hl6sbbj opn/PXFIZtbQqlPrW8l9tkEf3xt2v1yTd52AuTVjLiF/8zHJHx+MoW6bWa1XtvWwZLT3g/FalsI 6h9HICJG9vM3y4bSYiQOKbilRIARrb18inKS+oHyLYkdE52W4E9ZTFVqJwcl3Lh5SNiigNbXeOt 9wK7/bGUEVveK1YHlvursf23OSUc7/TaKiWNosFli/H8DTNDUbEsaB7YEeJU989k2rNbY982UWR o7wQqYAohY9A0pk+6H1+FmZATGs6R9CV7ciix7oq3JIVk0gUoszzQkX0UUoLyBpnX9DuBhAOlyL QE/gkuAeDXuAOx7rjy7maM5GbPCvTe29JIcZYQjgWcIo8R82u7hGbBiEYf X-Received: by 2002:a05:600c:4745:b0:47e:e807:a05a with SMTP id 5b1f17b1804b1-48320226f11mr61273875e9.33.1770420920720; Fri, 06 Feb 2026 15:35:20 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([103.73.101.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296b34d2sm9805767f8f.1.2026.02.06.15.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 15:35:20 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: Dan Carpenter , Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] [PATCH] staging-next: most: dim2: convert pr_info/err/warn to dev_info/err/warn Date: Sat, 7 Feb 2026 04:35:01 +0500 Message-ID: <20260206233501.5682-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Note: This is a re-submission of a previous patch sent with an incorrect CC. Please consider this the correct submission. The dim2 driver currently uses generic pr_* logging macros. Hardware drivers should use the device-specific dev_* logging macros to provide better context in the system logs, especially in systems with multiple controller instances. This patch converts all applicable logging calls in dim2.c to use the proper device-specific APIs. Note: This patch is rebased on the current staging-next branch. It was previously submitted against master. Signed-off-by: Zeeshan Ahmad --- drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 80af965356d0..4bcafda481f9 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -246,9 +246,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, stru= ct mbo *mbo) { u8 *data =3D mbo->virt_address; =20 - pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]); + dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[1= 7]); dev->link_state =3D data[18]; - pr_info("NIState: %d\n", dev->link_state); + dev_info(&dev->dev, "NIState: %d\n", dev->link_state); memcpy(dev->mac_addrs, data + 19, 6); dev->deliver_netinfo++; wake_up_interruptible(&dev->netinfo_waitq); @@ -472,13 +472,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_CONTROL: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_control(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -486,13 +486,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ASYNC: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_async(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -500,41 +500,41 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ISOC: new_size =3D dim_norm_isoc_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; case MOST_CH_SYNC: new_size =3D dim_norm_sync_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; default: - pr_err("%s: configure failed, bad channel type: %d\n", - hdm_ch->name, ccfg->data_type); + dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n", + hdm_ch->name, ccfg->data_type); return -EINVAL; } =20 if (hal_ret !=3D DIM_NO_ERROR) { spin_unlock_irqrestore(&dim_lock, flags); - pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n", - hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); + dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n", + hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); return -ENODEV; } =20 @@ -608,7 +608,7 @@ static void request_netinfo(struct most_interface *most= _iface, int ch_idx, return; =20 if (dev->atx_idx < 0) { - pr_err("Async Tx Not initialized\n"); + dev_err(&dev->dev, "Async Tx Not initialized\n"); return; } =20 @@ -657,7 +657,7 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) dev->atx_idx =3D -1; spin_unlock_irqrestore(&dim_lock, flags); if (hal_ret !=3D DIM_NO_ERROR) { - pr_err("HAL Failed to close channel %s\n", hdm_ch->name); + dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name); ret =3D -EFAULT; } =20 --=20 2.43.0