From nobody Sat Feb 7 17:55:11 2026 Received: from devnull.danielhodges.dev (vps-2f6e086e.vps.ovh.us [135.148.138.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A5E2C859; Fri, 6 Feb 2026 23:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=135.148.138.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419808; cv=none; b=e4r7bZ2UzhCW8zKgHM1p1dj+DgUtbjOfXAEbMkbDKXhd8OZnRsBpNwjA/FkT4eRtrCoC05yOfBZYwa9L9CZA87Sl8yrVuNaRDkRY5REOyA5E2jXKHfy4FuubrWLukcVDSC21e0LGuaTxFNgd/O3mrXIuxeqYbBMdZNBylL1qjBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419808; c=relaxed/simple; bh=Q5D/bWaiDMrUv8iCvFbPFkMO4GO9NMtVwxqehp18Zuw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VTVqfhyvpO9KdQkOojF5e24gPGzZhN3rx3C4f3QxOPOAT0BbIjqJDoEmHEHbtaspUKW577P1ylJTTlT8nJxtKIyNgFmfg49L0HFn9kaP83r7TlCohoaYqxkazzER4h0NcGJ6FY5Ki+400fRFpGMrFDiRjkQyFnvfSE/ps+30JyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=danielhodges.dev; spf=pass smtp.mailfrom=danielhodges.dev; dkim=pass (2048-bit key) header.d=danielhodges.dev header.i=@danielhodges.dev header.b=d9j6/Zj4; dkim=permerror (0-bit key) header.d=danielhodges.dev header.i=@danielhodges.dev header.b=afAea9PZ; arc=none smtp.client-ip=135.148.138.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=danielhodges.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=danielhodges.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=danielhodges.dev header.i=@danielhodges.dev header.b="d9j6/Zj4"; dkim=permerror (0-bit key) header.d=danielhodges.dev header.i=@danielhodges.dev header.b="afAea9PZ" DKIM-Signature: v=1; a=rsa-sha256; s=202510r; d=danielhodges.dev; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1770419802; bh=WX7lfZq8e/BGAi/VMf9RDgS VWFllsUsQSTQySqy6jso=; b=d9j6/Zj4rfhz3jG/pQUmGJ5RBG2bIiZ/yjSTPVc04xcPoqWjUp 7FW6yvhsE+Wk8V8CnkohXci7GXgpl7+hYmXqbAiqbJ86KiWWbIz7g9w7eq1qGvLqCJ5GcIarwOG n/akHQnEanHLAwYwJwFpnwj9Df0D4rZMBuTOA+StraMxOEPuXQ1ccclEwZt+1JoFAZ+vP8df4aw +eCFwWZV/PD3fgSnWAvPEFSVKmX08ZDp4GWST1nLnw9Vr690cE0h0Q/Uh/STV9bVeEMBrpgyxM8 +k6nAcd6mtPOz1js2wPwSr0/rDAzcZo8poZbSD6WHItGciuSjye5BnW2jNLoj67nxow==; DKIM-Signature: v=1; a=ed25519-sha256; s=202510e; d=danielhodges.dev; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1770419802; bh=WX7lfZq8e/BGAi/VMf9RDgS VWFllsUsQSTQySqy6jso=; b=afAea9PZIwvmfVn9e0fC5NZocFEhxOs8TJrwqi2NSVH1Fg2+nG v7T3GByntS/ngTWrCJKRU6gjwYS0t71wJ0AA==; From: Daniel Hodges To: Prasanth Ksr , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Mario Limonciello , Divya Bharathi , Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Hodges , stable@vger.kernel.org Subject: [PATCH] platform/x86: dell-wmi-sysman: fix kobject leak on populate failure Date: Fri, 6 Feb 2026 18:16:42 -0500 Message-ID: <20260206231642.30051-1-git@danielhodges.dev> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When populate_enum_data(), populate_int_data(), populate_str_data(), or populate_po_data() fails after a successful kobject_init_and_add(), the code jumps to err_attr_init without calling kobject_put() on attr_name_kobj, leaking the kobject and its associated memory. Add the missing kobject_put() call before the goto to properly release the kobject on error. Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Managemen= t Driver over WMI for Dell Systems") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges --- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/p= latform/x86/dell/dell-wmi-sysman/sysman.c index f5402b714657..d9f6d24c84d6 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -497,6 +497,7 @@ static int init_bios_attributes(int attr_type, const ch= ar *guid) if (retval) { pr_debug("failed to populate %s\n", elements[ATTR_NAME].string.pointer); + kobject_put(attr_name_kobj); goto err_attr_init; } =20 --=20 2.52.0