From nobody Sun Feb 8 10:33:21 2026 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31FC288AD for ; Fri, 6 Feb 2026 23:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419096; cv=none; b=YGoIBxLVYgK/rwy8ePLFGjSrm+j1tZqc0cLWASjaNJS87PM+yvzHKY0o/PaVGGKjG7FlCgvVaCm6kzHhzuMrGRrJ3JWUk/hGeHPjnMvwSqzJPL/lUov5+9TDqHr/kxi5o1SwMgyzYaEtcULWE+r75ENGEiONgtcvqr+d+GTC5hY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419096; c=relaxed/simple; bh=ig7V0TKS0dSSX25U24x8mom+Pk1QjYSdqNPS+J7Rzvc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PDUajF6kmRE/B04MkhL8Dt2cecao2eiNYbv9OB4/dMteLeiU4ZkcI88XeSm54E2ToUz36MzO37/mdiSjupXhlX+32gWI3horI+n/W6UqR1gVBE+dC6186w2WTqPedB8lf3ObiMCztkaXmf0Ha30W6QbL0wZdYCROAcFLAM8lFWA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TalKYkY8; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TalKYkY8" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-4358fb60802so1778478f8f.1 for ; Fri, 06 Feb 2026 15:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770419094; x=1771023894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8hl2Uvd538kVxn6UO6fv/IoR0P81ZnkQ9GoShqX1Xgc=; b=TalKYkY8KiGwJwZPI/l/2x3SjzH+xWBdx+8ffB+5UCumAs7QkJPjeRabYBX35bx1tc M3KYemcMx6MSgdJiaEBx37ZdwNnV9V8ZKX8uRoPDb8ZNPSVP+368HvGZKvL+y/1txeta 4mNb7HLvVKj8Sci5Z4GSrsEnTIHB5w8uC5pIvA9QQPXBoa3xbHEUpZfjJPPHu+e/TvVI X0mA2Ti4C/+3vIY+6xzkeSl4ouIDdYycLtGae5o/VMGfNxUaTvY+jSdn1/qPGStvXmkG dmelAQK9nX+BlDnwBcJ7Q766Bcef+BGfQDpIYhFULhAp3icNYr4sPfgB14O6C8w1jUQY NLsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770419094; x=1771023894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8hl2Uvd538kVxn6UO6fv/IoR0P81ZnkQ9GoShqX1Xgc=; b=ijKdvyFrlsjp10a5fLt9yZ3UsY8MGoBUaTcOMd60F0VHpT3OnlDDrlhkPuyW+sNjLk whGe8Qx2ULUA4h/vjtdnZ1mRdpjaEQrnPbjnv8LIYev94rTfGMo++IYDqvlEWReofrry iWwNFoOeoqbMp8APiUaeXKpyvooz3AamuF6I3iC5XKq/sg55qVJ8+cZ75LcH85E7hQiI Z7WoJz36gjv/AVgke/sBsnNqv+4LDCCeBGXtr4k2v4qawS4puU+7J6aI43ir3lN4BTad ZAOZ3zIhzxkaZWNzPGGUUXxIeAHNX1d+UGvbxq6CNs2gRpvCSYWCvMQym5NK+Wd6uMoR CwcA== X-Forwarded-Encrypted: i=1; AJvYcCVzQXowXJHT8EFfQSxjEK6xvceoU5A5gTmdaoSEh5STu0ZwSSOvRTsqTRo22h0rcSsqQ5NEZFi7wrV0goQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyP9LDIsBDm+FVfuA+9o90ebZK1ylA5rsR7bFbuHovjYrlRDTiK J6GvEGM1x0jkMTua3M/u5QwnCNyGcd3WTsVBwIkR7zhnR25Ci0qpStqc X-Gm-Gg: AZuq6aKBpXCjCxMwbk2AaZ0S/ziVDkjcxdicHjLpsNz8RhrRApqQ64u/FL39A7MB4s8 KZO9n9Ii+52xCOBZaZCBlT9wrWJqyHoqfWAeXgk121pF1ToiuXyDTxx6dEPSmxqnZ1pOmtYp5u2 tZY/SpEe8oaG/WLbGJaB7DTROC0tAa45sv4AdmLDJbdpUA1GU40UiaectuRhxFkuyohn9HzVbzh BT6ya3KuGxtkSxdWlArugBj8dha8oHbLlA+W0WEkIbghUBIOIQRuoVdP7cBUBHaBatsRXnV5kBF 3pVYACrnztzAbeGAl3+ZYW8uhLm8Cf4Z8+5VY+m+IzhBeTbW38StAeVxXo4elub2lYQym/s2sxc kapS7UxrCxSwgBJddfQkIOM150Kfl3DyjaPH+xQm6/eHyvgQywaX4PFSeWVF5vKMl3OXfYH2WHl GetzGFaNKYYGjhgEs9cXOOgKgEnuf/Io+D6J7bYIo0Hfzejy39Q8PDUCYK X-Received: by 2002:a05:6000:4020:b0:435:bdc2:461 with SMTP id ffacd0b85a97d-436209c88f2mr13186136f8f.21.1770419093913; Fri, 06 Feb 2026 15:04:53 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([103.73.101.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436309ed238sm3258067f8f.19.2026.02.06.15.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 15:04:53 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: linux-staging@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] [PATCH] staging-next: most: dim2: convert pr_info/err/warn to dev_info/err/warn Date: Sat, 7 Feb 2026 04:04:33 +0500 Message-ID: <20260206230434.5564-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dim2 driver currently uses generic pr_* logging macros. Hardware drivers should use the device-specific dev_* logging macros to provide better context in the system logs, especially in systems with multiple controller instances. This patch converts all applicable logging calls in dim2.c to use the proper device-specific APIs. Note: This patch is rebased on the current staging-next branch. It was previously submitted against master. Signed-off-by: Zeeshan Ahmad --- drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 80af965356d0..4bcafda481f9 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -246,9 +246,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, stru= ct mbo *mbo) { u8 *data =3D mbo->virt_address; =20 - pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]); + dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[1= 7]); dev->link_state =3D data[18]; - pr_info("NIState: %d\n", dev->link_state); + dev_info(&dev->dev, "NIState: %d\n", dev->link_state); memcpy(dev->mac_addrs, data + 19, 6); dev->deliver_netinfo++; wake_up_interruptible(&dev->netinfo_waitq); @@ -472,13 +472,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_CONTROL: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_control(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -486,13 +486,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ASYNC: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_async(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -500,41 +500,41 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ISOC: new_size =3D dim_norm_isoc_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; case MOST_CH_SYNC: new_size =3D dim_norm_sync_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; default: - pr_err("%s: configure failed, bad channel type: %d\n", - hdm_ch->name, ccfg->data_type); + dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n", + hdm_ch->name, ccfg->data_type); return -EINVAL; } =20 if (hal_ret !=3D DIM_NO_ERROR) { spin_unlock_irqrestore(&dim_lock, flags); - pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n", - hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); + dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n", + hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); return -ENODEV; } =20 @@ -608,7 +608,7 @@ static void request_netinfo(struct most_interface *most= _iface, int ch_idx, return; =20 if (dev->atx_idx < 0) { - pr_err("Async Tx Not initialized\n"); + dev_err(&dev->dev, "Async Tx Not initialized\n"); return; } =20 @@ -657,7 +657,7 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) dev->atx_idx =3D -1; spin_unlock_irqrestore(&dim_lock, flags); if (hal_ret !=3D DIM_NO_ERROR) { - pr_err("HAL Failed to close channel %s\n", hdm_ch->name); + dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name); ret =3D -EFAULT; } =20 --=20 2.43.0