From nobody Sat Feb 7 22:21:02 2026 Received: from mail-dy1-f227.google.com (mail-dy1-f227.google.com [74.125.82.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA7F26D4CD for ; Fri, 6 Feb 2026 21:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770415089; cv=none; b=mYrOOgKI1NNTW06D0jubzrFiG67uz4X3XELtznX3Y/k+oo7zseEDg9oImYsu0x4gI3/SMaS+NjuM4+vYCcQEX0h7LL7vil+YE4skQQSfOxsd7zy7WPUkJJ3rJ1bQyFz4WMroKLq3nqttUpkN78mguZiEmIBWJ2RFnl9juT0qhHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770415089; c=relaxed/simple; bh=YQhVmDwez2F4WBxYw0HKce+xrh2MBzNfIgBrxHJgTXE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Lkuq2hCN89wuOKdYl/OTohdRVBdy9R0fw16HhoP9wOqQzF6y/JSFfm/J8M+HiBdlfaaH/YVpKCo2kivpX4GbU6EuieIOd7wUhA99x2AEcfKt8qDCHfrw0lISuGXEyQz+p/jMNyhNvK3PT/hQPnTdmOhb12ubSxj78k7DFHJ21WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=YmCMXJoM; arc=none smtp.client-ip=74.125.82.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="YmCMXJoM" Received: by mail-dy1-f227.google.com with SMTP id 5a478bee46e88-2b867142b07so44413eec.0 for ; Fri, 06 Feb 2026 13:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1770415089; x=1771019889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iRTAskpVWcpE1JTBduaT0XNtGXYotQNdR4rRO6QLXL0=; b=YmCMXJoMJm9CpkLD3Z2O8iJQnJwFmBdRT8emw0wtXYb3DQTagzvcPgfQWGOoR0xckd YIAVF3Sw2PJ9A2TrcvHjD4a/C2NzoDeLDahDLPHNsQugbDDBslrdyLr7djLO9NLm8EUc A2vUD3CL4NYfAEE353nAmG0R5BF5Kli8PDzhzQt1up4VelIn0D57qgHRg3kDPhlfSHzs kW9TdbMWxLJSI/G0nhqDh8ZayY0J4XMiGByQGXzStUzV/Wkip543p3IEzuhekDODu497 Gv6trwuUwD71gj0KktIzby1gUf1QsNCPKcNlSstrxcCIYDHdXhgz7SEVxTkhcUiqXVF9 5hkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770415089; x=1771019889; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iRTAskpVWcpE1JTBduaT0XNtGXYotQNdR4rRO6QLXL0=; b=MA9yfWuCzmTwuG/jygxSyQNiqGCxt7tLLRAiizIlaLlKofR8BL6ZOhWKpAdUxLptuR D6anNdK+INajV6pFZc5D1pA7IapvW/dICF9fE46FytFOGFbfo8WNXGwIRQZHjcY3l3dc JgbWtinMLO/xMzrjANbAxvom8TCAf0vdwYiXAYUuP6jPEsb+HYNKBdGeVKTXR+XryPBn fUgmwEZ0cx/S+0xUh+FfsAZbM4laF2+Uf0U2BocAqhfdZYUuW/6VjN3Yh2S0ywdfpwxc AtPePT8jArDGvY2aierO1VknjZit9SEw/uYG/EkqWeXhODTOEPl+BfXC3NFzn7UvVzrb bsOg== X-Forwarded-Encrypted: i=1; AJvYcCVrBq83yYMYiMT4nRNlc3flmJ3aGdxm6yntV8N/EQtqdvVIdF1iGXsRHQgbXCBHy/sinBhsIVZGYac+AEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwAw+TmeuMMResGHRjwDQ4djQCDQHBYzQ1rjMyuv6LhNSDa5me2 17F8R6uM46NSFWyatj/YiMV19ULLFleanAxfdhyFuKAA/JyPCoNwiHSUjBQbj1G9RkNMxDS3UaW R72QoChoTP+fYoA8GCWwjsDh5yoBjnJ0PMRb8 X-Gm-Gg: AZuq6aI+UD38z4s4GRAUeT1wscrrdAxbcCqG9ARavm4c8w107wVIUPS6tCzj/W8p1C+ EUlPT8Zc8j688URHTczzqhHRxeglCl5y2q1sKrQzk4KRXMkyOSzxdnF6ICAccImFQjLucpGAHKE 1wsH894lEKLVkeBmEEYnB9n/G9V8qr24HaLgTMikTXtL5HcJbAm1dh9O2ZZ3BTmBO7BOl6VOML0 cJ47PGjb7QTjN2Noq+tqhpZyl7eZpoio35GuE75MrNwYqHwAzqRWmQRhaQdnC+ncpXGbUoXzDOS XtovQhYo8WmQCKnu9DweFpPP4AhLarzSX0T7Tk4FxC1VJJ5PnO8XaZ2xRYNDrhXx7SgyS+/8+cG yvFHT0mFbhW0ZHAPcZIWkOkgS1Rt19QHLgECnFVcZxw== X-Received: by 2002:a05:7300:4353:b0:2ae:5b8c:324a with SMTP id 5a478bee46e88-2b8564e211fmr1030688eec.4.1770415088653; Fri, 06 Feb 2026 13:58:08 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-12704341962sm848306c88.7.2026.02.06.13.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 13:58:08 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 8B7A53400F3; Fri, 6 Feb 2026 14:58:07 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 7640BE41AEB; Fri, 6 Feb 2026 14:58:07 -0700 (MST) From: Caleb Sander Mateos To: Jens Axboe Cc: Caleb Sander Mateos , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] io_uring: simplify IORING_SETUP_DEFER_TASKRUN && !SQPOLL check Date: Fri, 6 Feb 2026 14:58:04 -0700 Message-ID: <20260206215806.1637548-1-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" io_uring_sanitise_params() already rejects flags that include both IORING_SETUP_SQPOLL and IORING_SETUP_DEFER_TASKRUN. So it's unnecessary to check IORING_SETUP_SQPOLL in io_uring_create() when IORING_SETUP_DEFER_TASKRUN has already been checked. Drop the !(ctx->flags & IORING_SETUP_SQPOLL) check for the task_complete case. Signed-off-by: Caleb Sander Mateos --- io_uring/io_uring.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 5c503a3f6ecc..8949e6d7400a 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -2901,12 +2901,11 @@ static __cold int io_uring_create(struct io_ctx_con= fig *config) =20 if (!(ctx->flags & IORING_SETUP_NO_SQARRAY)) static_branch_inc(&io_key_has_sqarray); =20 if ((ctx->flags & IORING_SETUP_DEFER_TASKRUN) && - !(ctx->flags & IORING_SETUP_IOPOLL) && - !(ctx->flags & IORING_SETUP_SQPOLL)) + !(ctx->flags & IORING_SETUP_IOPOLL)) ctx->task_complete =3D true; =20 if (ctx->task_complete || (ctx->flags & IORING_SETUP_IOPOLL)) ctx->lockless_cq =3D true; =20 --=20 2.45.2