From nobody Mon Feb 9 20:10:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF5140FDB3 for ; Fri, 6 Feb 2026 17:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399714; cv=none; b=XSC7v/YzQfQ0SSu0SAIBNF65dejggdNsnWFonlZCIjwFT7aLGI+rB/TcSka7pWab7R+4XZEUo0C6WVcl6fiePKDFeB1ZSL/YhsUJtk3GIxakW2FEmjvDWUQ18Of++uGOCnVin9ileNuoQXjI9UpUYRYvxPU57mK5oVKeKILtQwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399714; c=relaxed/simple; bh=vinpJK3AdlE6QuECVjsA4xyKYusB2fCdpA1B0h1Sv7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GWB1ODlf1XmIaJayQQUB24fmIhIgua74z0DyrM3acVPOvu1UGBLUsBKyju9pVtH4h1cd8jn2nrNUgIL0sX9ebX68hGr5l2RivFx29alaU/5bsVyOIP0W6aX/4Yoq2z70GCLOGxuRu+iAJyDSTpUHNvgdcf/wq0udSb18gfXxtpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MIgtPWhP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q4ys4HuJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MIgtPWhP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q4ys4HuJ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 616F37qO1853178 for ; Fri, 6 Feb 2026 17:41:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=iEGuO6CekKn dAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=MIgtPWhP1cB88SA9xggokBWzRX5 rX6lduVj09Kktz0Dt60q8ul9cFQCZZd4Xs2ZGaVHkRZ/PZud7fy7d3eawJ8Dy0Px YuMND4PVzf2nxL4irND+grUbzMUtQzofAf0i+XI1P1vXsWvSzACYxzyY1EQkPq1z wltk3Cofzv7No0wAbfgS+tjb46o5DZry1cjtMFVaxdeoQcVWro+g/0AwJsQ7xy+6 CgAfLkctMq+8nwysVak/dccvpXRVtZxQe8A49/46vrcdrvanTIz7S+TxoByfpdIo pcBJb7++BuHQ4FVufMJ+xwUd0oQCKzF3BXdAu6kNeqiNpjMXjUIOckde/nQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c149t3y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 17:41:53 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c5e56644646so2524829a12.0 for ; Fri, 06 Feb 2026 09:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770399713; x=1771004513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iEGuO6CekKndAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=Q4ys4HuJNF8u7jrx9qspgnjLabRD++vfzTJnCcnomL+j19OLfFFKMMtMohF76a3yY5 m/4L2AFRM0R8otaRVitPtJ+SV0axETGpq64SO/1Ok7b0YG9G8FJ7iAz0ut4HOtvNuyd7 i6Zp/RYcmJXrDVXO26xIbzKiKDgejLaTw3Chv0jSeWTqMoyZ5l7U3V8LEnnnDJoLV0sU pTgLDNQROt4el6V7YWOWkEfXZxM6YtPcPqkgLyLl9L4gp7I3HnZxFZ+/zldMtLLLOGrR sVB9+HZz2nLNO5mmcMUR3wBsTCoVUI/G32Is8JYkojUzmf3P23QQ6W8SmNwrBACZ59X4 2wNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770399713; x=1771004513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iEGuO6CekKndAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=BNixdO20ShejClaa6oZlmC/JbufTTdUBI/F9PNghw2OWi1jwDiUJ06lFb8J1UIA0Ws PHHGx9+hFw5CR1vLNVmGaBNkGZ3dp57HKs88Sd099IRaGd7kjACICkUg7vMQCC6BqvbW u7wMAXj7Zgwj1GoWmvjIWnwygkrAywU26mElSbI+yv1cwAEm890bXwL1kF/dDU0MetdB 1vTeJPn73EyHoOd9BkApTbO5JYtAzHBv0k+0GBpYrDEir9T3qPLKReNj0rEkz/Hh/SsM uQiWddZ8scPi3Mp2CYGYihdPYcXQctR35sw8vsPyzLuiob2fN7YfneGwf6q4h8qGVVc7 DoJw== X-Forwarded-Encrypted: i=1; AJvYcCXK4ZJFHOtdBCl1POhv0gMmkcDt9BGZguwmMqoOHVAvndu0LXVi4g2gXiwEJYhTJz/Lu2go0vhUUGstU2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzgyDt6tnePS8aTh/JeL+4D2PSFLUQPSk34WNC3XRhUKuK4byJj R5YNEkRh7IDpztzuhc0U1+y/mLhnhRy1vyNtSbxKClUOgPsedKqjrX0h/CCVOW1QZDKfaC2Vk0Y ndvzt2BblixotFw72vxstFE2FlACincSwp7p58PlnYrjCKm9+Hq/Pbkkbsw0PkI+1UHE= X-Gm-Gg: AZuq6aKjm27NjvC4lbssilch7PxqtXpCR/5jeiyQPw3OQrOzIK58TTdEOZaHZOpb1kb PH/M7yHW7sF76JvsW1JjlYBDsLs+k8eM4bnOHIGbKYVi7fVd1rbUVrDHlgvCgllwb9X0P1bbhdA XOOuYhjCQreeoARJknyuW+dXzCeXdFf5NAF+rnq67Tp01+98Pc5LqRE0pw3uCMPZkgUQnMvyBb8 tlAWhIcYBsco4TPa2IvKev01vEGzJpRXyMx8hkS4PyjQe7f0x2iv1QRdmuV9qTMywrLOhqehvPE jVr6npZTXgcF+ZTTVlqt+b3lVyCbT0pIyknotzXfd692cIZ1ZzwoUtd6or5boqrnSWW1kVvbHCj iKzlCsPODV1kOm19jtqJk5YKJMQ3FCGK7nsr0G0DZU3M= X-Received: by 2002:a05:6a20:429e:b0:375:4503:ef0e with SMTP id adf61e73a8af0-3938f9a2322mr6550397637.14.1770399713024; Fri, 06 Feb 2026 09:41:53 -0800 (PST) X-Received: by 2002:a05:6a20:429e:b0:375:4503:ef0e with SMTP id adf61e73a8af0-3938f9a2322mr6550362637.14.1770399712392; Fri, 06 Feb 2026 09:41:52 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5eccbdsm2639387a12.19.2026.02.06.09.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 09:41:52 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com Subject: [PATCH v5 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() Date: Fri, 6 Feb 2026 23:11:03 +0530 Message-Id: <20260206174112.4149893-5-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=P5k3RyAu c=1 sm=1 tr=0 ts=698627e1 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=fzsqq50RfsZR9heXkngA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDEyOSBTYWx0ZWRfX5CP8OlM7tlRh sor/ZnsL/pwc1IcVIsPuAw6VkI9TxcsOSA2qy4Ty4JwOVjMVEUUssfKT/1qLdZFn2OyvMfhcZzt S0dDDoy3gbGT3aVsUr5szEllopmKbyTFUo5/D8mY96IVaT53EJV0OIVYbUQrFIsRsZ4J9+0rEoc BXZrobG0ZhJW116zH4F0Hz1J7cOenwfMsuG6wl9zlddlcgcrdfiOGCFVcldQqZUqgTIAdEtCIMc 8dHcWl4jcEkvMZBronwJMOmb+dRas2LCnhQJCgXbkJRfkviknDFM1Ld+OxCL9570nqbMSbB+o6K XLtjtaO6vS7LhQ3MHVV7cR2BhOaSuJhVIxo9zl/Vx42N+HMfKNFlyCELL7ve2LkYmyI8T00nrCB EjLncDkcd1c4s2hzPP4jkj1EXk1dg1Tj66Py3J/vvu97KjRhgdjI84i8VaWz9PCOvAmoz0mrFCB b1aahFUN779KOkDy4EQ== X-Proofpoint-ORIG-GUID: Ai1kVi4T51Wzcewbx4Fd2hIUeCLQ2Kp6 X-Proofpoint-GUID: Ai1kVi4T51Wzcewbx4Fd2hIUeCLQ2Kp6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060129 Content-Type: text/plain; charset="utf-8" Currently, core clk is handled individually in protocol drivers like the I2C driver. Move this clock management to the common clock APIs (geni_se_clks_on/off) that are already present in the common GENI SE driver to maintain consistency across all protocol drivers. Core clk is now properly managed alongside the other clocks (se->clk and wrapper clocks) in the fundamental clock control functions, eliminating the need for individual protocol drivers to handle this clock separately. Reviewed-by: Konrad Dybcio Signed-off-by: Praveen Talari --- v4->v5 - Added a Reviewed-by tag --- drivers/soc/qcom/qcom-geni-se.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 75e722cd1a94..2e41595ff912 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -583,6 +583,7 @@ static void geni_se_clks_off(struct geni_se *se) =20 clk_disable_unprepare(se->clk); clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + clk_disable_unprepare(se->core_clk); } =20 /** @@ -619,7 +620,18 @@ static int geni_se_clks_on(struct geni_se *se) =20 ret =3D clk_prepare_enable(se->clk); if (ret) - clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + goto err_bulk_clks; + + ret =3D clk_prepare_enable(se->core_clk); + if (ret) + goto err_se_clk; + + return 0; + +err_se_clk: + clk_disable_unprepare(se->clk); +err_bulk_clks: + clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); return ret; } =20 --=20 2.34.1