From nobody Tue Feb 10 01:31:07 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC0BD42189B for ; Fri, 6 Feb 2026 17:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399774; cv=none; b=OGRvSct726xlKGuOVVzl+/gmN0Yml7+4KBHOLNGSKJFxugXf6LFD32KDTFASqV4+5cUST7yf96dSS0rY2CRmJjBbUTE4tNNx3UeWL9XgwIJSa1xCZldf9a/+duOxOdPC4v8OQLtwhv9vZo7OaC6xq1AQyhFu2J8FBdRiBIEBFkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399774; c=relaxed/simple; bh=BbBD5tNkBQrd31zYVx7NjYHcGjoQsLjnUX+bRHK0MRM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qhJmmQZ6iTHxZfk7c4d5Yc2TudSbvi/RE+03sQkYJwlQITvjrfCYkkE6oP1LU/+XYtW+LuCum3wyn0JE49xi2j9Lz1Fe6xqpG9RdoqyzAdNDAnf4R3OXKRWPS0peOzdOA4SmfkeHNMWsRyMjXt7xx31oL8sXMhalJKrRDHf0H04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oHEAzNIX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=acEcr2x1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oHEAzNIX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="acEcr2x1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 616CEXa43011797 for ; Fri, 6 Feb 2026 17:42:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=2xdIWjPvFPu WeaF1ghJotVpCXxOBg3ohkTZp+i91ty8=; b=oHEAzNIXXfYjfDDZC5U+wj2rtj8 FxziysDKKFears/mcM2gzH2YRQ27n/JjVN7irbCH7emZh+Pz5D3FJY7FxkjfAvI4 UplIwCvJMyis1f2++BPtzApetx2P7i1RGPEjYV1e9a9k6su1Nnzmyvg60I9oTTUe aq058mqVpooKCFST6lD+5dB/mjVVqr2bH+dd+cbQcLpcjbrgDn46capIT6MHYbeO Z3yUuqBX2FNkz69E7qQdl+OhqUeEIi73RzsDyYmXFdVHZK++4PEL+qRDFvycyVlT 1TUV3O8+I2Jt9fLMoB0Wza4ogkLMlGS1q9yeg0AE5ppxBkMEf+hyys7TB7g== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c59ukj84c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 17:42:52 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c634b862fcfso1488624a12.2 for ; Fri, 06 Feb 2026 09:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770399772; x=1771004572; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2xdIWjPvFPuWeaF1ghJotVpCXxOBg3ohkTZp+i91ty8=; b=acEcr2x1ofCvwftyacNsPPt0SAgFIAU6LfpTYytkD7OboMIZiZW+dhc9P/91Pfogn4 P803X6fMGWRHvWRAfcwlkIIJhW0qSynphBTMWgt39vewkIpbaG90VEtLkk+uBQKOFDUG eK9KoCTpdpyY/Mn74+EdighDHm/Xfi6I72zU9pUIwhnOamEtLwmVOCeetBp1pUNQ2Usl /bwmcEvCaZ7w8fYu7OCRtyzNAqcuFdyxN7iVkOEBwigtbM2FQKUDSxwRYa2sn38iOHc2 6a+/TJtpVh23lhZkIRVqtfb/epv8SxICoDTg9v1x9cF6jU42a5TcNcBcyDGppXRH+MoI CiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770399772; x=1771004572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2xdIWjPvFPuWeaF1ghJotVpCXxOBg3ohkTZp+i91ty8=; b=hShbq7Qz/d4Xa6fJj8UE+88NGDlCrMCb5l/OBaATqvtmRQVakcjAvRvra2kxHS/hFQ 94BgZm9DASMkJuQ+xtWSnRtYa03TRXNbw8jsdvIs37g3rHHnzaimb/kVutWt4BvJe960 Gg1YuhE5rfch+6aUrPiZxLB/gLkaKY3NP/Y+kXD8PscXvmA3aJQxP0dsIlbeyyjqGxI4 aA1S6q8efdHtwRqv1Gqm5Obii7MFFBPU6UKp0SyKf5EhoY5MTrurUrl7/j1l8IMekICj S0+vpxd7EbACIjb8Wu2Hq9aTj7fR34piVzJUwZcOZdtCC3XWtCvUlciBWOVXnV23X1+e xB6g== X-Forwarded-Encrypted: i=1; AJvYcCWyTmESXp54sBm3AftvUMGy7yDkej7ZohqtfLLCOGqp5pz9oy6c3EkvUMPbuC1eD1R5MnmW15ATvc/fJUo=@vger.kernel.org X-Gm-Message-State: AOJu0YykNvbeJwpprg5XBUodnLb8Zy/ucUotaDdURpRX6gu2Sq7g8Xnk J7LEkEn69o1IydyZ5z2e0pbRuSjYMLPSWDE6P9TIitfo1WUk7dLFEVMT7+n+iDOQ68kl+KcVsuB Vb7oOpCL7XzSJFQZPhLJBFeYAUQZT5fzawnmOLbauUfMCjBr3af3DL5NzPA2fLGVk2Yo= X-Gm-Gg: AZuq6aLGu5pCojTuzoJArm5354vg5eAw2ok1qva2pHss+aNCPUh9tovZamMeF7pDvIE frEkZYMMIYRmZadxmxxzIdiSEXCh3S6H06nXWuFdVj7mbQxu23rEqSNcWeffA3xHOV9k0oSlz9V r9ROwiV/dYUimMqxzmK9oMdZYmOGi6Z0ptxAHj098qJ2SwA+iTVbH7O9tQF1U9Lbh8NQuCzCMiT DXmkNn46GQ9i95kmRt9QjjIKZWpHvSy3JthPhkMqFYYyymWIfGmvCkpH/A20chmGafkbpkHFE2a Q6T5Vc2qWp0LkbLEfAt/SjGyNS1r4sdQ5lqAY8mMlQvGo/Ug2tn5pj9AGKe7KrDEi3laGBpIM6g F6xRAVW91YUxaU93dqnka+22q5yAm3l05dUlA8JNg2Ys= X-Received: by 2002:a05:6a20:5481:b0:38b:e55a:97c9 with SMTP id adf61e73a8af0-393aef57a70mr3241490637.28.1770399771683; Fri, 06 Feb 2026 09:42:51 -0800 (PST) X-Received: by 2002:a05:6a20:5481:b0:38b:e55a:97c9 with SMTP id adf61e73a8af0-393aef57a70mr3241454637.28.1770399771109; Fri, 06 Feb 2026 09:42:51 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5eccbdsm2639387a12.19.2026.02.06.09.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 09:42:50 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com Subject: [PATCH v5 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct Date: Fri, 6 Feb 2026 23:11:11 +0530 Message-Id: <20260206174112.4149893-13-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OM0qHCaB c=1 sm=1 tr=0 ts=6986281c cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=VoGDZ86lKm6tgvVT7R0A:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDEyOSBTYWx0ZWRfX4BY+flwLC3ZT nOCBfXlRJ16rP6fpJhHr1zS/GjGQBY3vZ2LuKfsiQABvPwlabgRQchJdqAcVx10GN4i44JeXptL 8txYd7toIaOo6UJHBZfAe6xvCfIDG02hB4OlEISe18hJT/8ZtZ90WFAr2y3qmkZI3sqXnd49bdR SuDvosjtauMRIObrBM/z+/5WuQKPENP/ZGxTh+gdkSubv9etIjIuw6iIUs5BGMo4UnoYDN7Cm3W NqgMxtM0ittctPo/oMetPEtjV2qTJgLlGhY+k7/dY0gHQlb/jc+6ayOcktODpX/rXh+7iDfcq17 WH+g2E5wDRPAw8DvIQlZS1plQJ75+5xcStKzAoCUM3eXeWfGlVbLwt6jwUJyzCATsTpw0dQOnMF NJnvDSqGHmsXzRyczIf+eKSfbkxFzPbyNsMJp1neQDs2v2YOqyXeAmKMT2xNQfwHFcat/tqSqEV 8b2ffKHBHkBPqVhMfRg== X-Proofpoint-ORIG-GUID: _sx2hoCn9DXuAfJJQn8h9xybWhlPnkDi X-Proofpoint-GUID: _sx2hoCn9DXuAfJJQn8h9xybWhlPnkDi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060129 Content-Type: text/plain; charset="utf-8" To avoid repeatedly fetching and checking platform data across various functions, store the struct of_device_id data directly in the i2c private structure. This change enhances code maintainability and reduces redundancy. Acked-by: Viken Dadhaniya Signed-off-by: Praveen Talari --- v4->v5 Konrad - Added a null check after platform data struct. v3->v4 - Added Acked-by tag. Konrad - Removed icc_ddr from platfrom data struct --- drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index 0ddfeef6d1b2..9045187ad0b5 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -77,6 +77,11 @@ enum geni_i2c_err_code { #define XFER_TIMEOUT HZ #define RST_TIMEOUT HZ =20 +struct geni_i2c_desc { + bool no_dma_support; + unsigned int tx_fifo_depth; +}; + #define QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC 2 =20 /** @@ -121,11 +126,7 @@ struct geni_i2c_dev { bool is_tx_multi_desc_xfer; u32 num_msgs; struct geni_i2c_gpi_multi_desc_xfer i2c_multi_desc_config; -}; - -struct geni_i2c_desc { - bool no_dma_support; - unsigned int tx_fifo_depth; + const struct geni_i2c_desc *dev_data; }; =20 struct geni_i2c_err_log { @@ -976,7 +977,6 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c) =20 static int geni_i2c_init(struct geni_i2c_dev *gi2c) { - const struct geni_i2c_desc *desc =3D NULL; u32 proto, tx_depth; bool fifo_disable; int ret; @@ -999,8 +999,7 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) goto err; } =20 - desc =3D device_get_match_data(gi2c->se.dev); - if (desc && desc->no_dma_support) { + if (gi2c->dev_data->no_dma_support) { fifo_disable =3D false; gi2c->no_dma =3D true; } else { @@ -1020,8 +1019,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) tx_depth =3D geni_se_get_tx_fifo_depth(&gi2c->se); =20 /* I2C Master Hub Serial Elements doesn't have the HW_PARAM_0 register */ - if (!tx_depth && desc) - tx_depth =3D desc->tx_fifo_depth; + if (!tx_depth && gi2c->se.core_clk) + tx_depth =3D gi2c->dev_data->tx_fifo_depth; =20 if (!tx_depth) { ret =3D dev_err_probe(gi2c->se.dev, -EINVAL, @@ -1064,7 +1063,6 @@ static int geni_i2c_probe(struct platform_device *pde= v) struct geni_i2c_dev *gi2c; int ret; struct device *dev =3D &pdev->dev; - const struct geni_i2c_desc *desc =3D NULL; =20 gi2c =3D devm_kzalloc(dev, sizeof(*gi2c), GFP_KERNEL); if (!gi2c) @@ -1076,7 +1074,9 @@ static int geni_i2c_probe(struct platform_device *pde= v) if (IS_ERR(gi2c->se.base)) return PTR_ERR(gi2c->se.base); =20 - desc =3D device_get_match_data(&pdev->dev); + gi2c->dev_data =3D device_get_match_data(&pdev->dev); + if (!gi2c->dev_data) + return -EINVAL; =20 ret =3D device_property_read_u32(dev, "clock-frequency", &gi2c->clk_freq_out); @@ -1215,13 +1215,15 @@ static const struct dev_pm_ops geni_i2c_pm_ops =3D { NULL) }; =20 +static const struct geni_i2c_desc geni_i2c =3D {}; + static const struct geni_i2c_desc i2c_master_hub =3D { .no_dma_support =3D true, .tx_fifo_depth =3D 16, }; =20 static const struct of_device_id geni_i2c_dt_match[] =3D { - { .compatible =3D "qcom,geni-i2c" }, + { .compatible =3D "qcom,geni-i2c", .data =3D &geni_i2c }, { .compatible =3D "qcom,geni-i2c-master-hub", .data =3D &i2c_master_hub }, {} }; --=20 2.34.1