From nobody Tue Feb 10 00:22:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1A24218A8 for ; Fri, 6 Feb 2026 17:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399760; cv=none; b=LdTMMXDUPWN860nEl6s8POA0ZV/LQScWeZfiqwCmpQBVK/AnOPqOK+f0Q4Rs88SVCRDD3UVN44eIFDnQkUuZ9oAqqZRNWmo8Mx17ppHEfHprJqhxRfJb1EAQmlFawNBlL/ffYc1ce0ENaqoZ041KrYO77rvpvRvbp56eLU/liZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399760; c=relaxed/simple; bh=9fl8bfjYxtflTrpwQ+JEsijZ7KkoNEhoY7/L5W7VcgE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NfJmacsxZ6Ntux26oPUTFmwAyO7gPNKO2xu3p5ReZO44C4L1yHx8XqyzT0ZrTXH+bSNTzyieAGkyoU2EdqUMJfBsqJkGkntdI6eRm6SCFGWHh6TJfef4OiDj6zn6WK6gI2v0I/dHXpZKXOWXfQg1y/jJ3Z0y/E3gysqxe8p2zmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hIEQ/jv+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bbXHqWwI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hIEQ/jv+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bbXHqWwI" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6169QQCe2228092 for ; Fri, 6 Feb 2026 17:42:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=eq1swinsB23 3N5IrjE+XE6BW0OuGc5vycgIlzP3MrF4=; b=hIEQ/jv+dToj7p+dn9SfH2dyODr kv+F5qk5SxsjRWamieih51Z+414NVJ0stADfNad8YNBZAT35cZT1X01jfeOtP6U0 QQnPrv15Sy0QhAfVzZZLC+SJpNsJHdPFjbS21fTNKy0W0rKvYRnximz3a0eB3PAT W1WTyhBSvFVOwOe3ipI57IhXE7IYxBFwWqioP1ONYS5i0Ot1M/7Bq/aT3OQ7QB5u dvRzX5mDfVWi66sPwrpouaskxg6RuKFMPkB30AtzzfosDovSlRpKzA/93GtkR3N6 R61+/L2uDCVGHhAuhyJBJVGfekylltVlhUEUyYR3H5QZJ3aEZQL4fKzFdpg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5dnyhdhp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 17:42:38 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c61dee98720so576920a12.0 for ; Fri, 06 Feb 2026 09:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770399758; x=1771004558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eq1swinsB233N5IrjE+XE6BW0OuGc5vycgIlzP3MrF4=; b=bbXHqWwI9j917j9VEqT042F5maucyPH4tbn2neeyoeCh72eDxSMEiajZkmqWSKtFn/ 1yInq9UikfzM6AR5KngOkQ9uGPFPIcUjw3SgO+++zjE7IN2+cCXGVh9cxxdgeLR2U4SX fhjLtRoMUCJh+Okex+FWTkP2PqzpTxYQnkMcBKE56Z+ceAZqF6p7rRtV7NYqgKTDaUOd 03x3xvzVq06Xv9NzvGK4i+ohYB94rZHAPaAanoyU14HEogFcg0Q7Ey/2bjvlDj9pjQTg aH9AjC/J88GUGsDoBrlCdX5dXPXxBqZrCtRM9Qj4PhWBlw3q32qpVeTXQC5QPukko0/M oeZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770399758; x=1771004558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eq1swinsB233N5IrjE+XE6BW0OuGc5vycgIlzP3MrF4=; b=ms1I/NsODuHnxRHzADDmL2AoCCCrPRQnseh4eUKR5WS0hqpniVvwACBV3BQ4TPdQMQ f0jWa4dx6mS16sVHdFAekT6xjNz6E2rSrl3eulfeAdsJzPlteocYdOXNOm+FjHeNS+Ia g3Q3CTtgyLGPkTLM+9L2JWzXiiigu/8VXGVycZKIQxjIjZCwBIVkMLSy2/3t9FB+oJ3t +Z0JwlXQvHXird96Hcp7mjouvykevcENL1HuFWU2Edw9YBXmbIpKuzuNPtsk8nc4TE8a 9AAKPjgHN/Xz9IHATM58NHckFOisn0ate5vF0YSAdZ7F08Hgz5cP3mCAU+xL/G9di9HV TMTA== X-Forwarded-Encrypted: i=1; AJvYcCUMoQ/WcLZEuGkjibTnuDsIwuVrLQsCZfWIr40kqHQb1EDfMb7fneW3Pk0jgJJ0TVzsPdJjvhapJ2iekDM=@vger.kernel.org X-Gm-Message-State: AOJu0YyBkox20uNACQM364P8FGYOYXHBtrO+zXkdPB/TIQaIzm7ZOQha jrWkTFyH/5XjcuGD6IwbFPudUlSYz8j6bYpcO6txSk02m6uk/vtUzWvPKBkMoZ//ZwtPwZC+p6Y mxfbA+YBXvh8h8TCQo0/QqbYdjVaz4Pe7+FPibXO4oKG61g6JS804X2usiLTwPGiM+nU= X-Gm-Gg: AZuq6aK44B5p5YdeH/wjEkCaVmWcwXAuiJJKwXyfmlGsN3VrcOkvxd/IBPgkswxWRNo jjVwABWB56he4wbDuxSuNqOEROTGf/F/H54512s0V01wwohggtwFhunYoY+9+zey66dl+RjOorA tb4tKwk+H9PY+D1NdChFYl5Pxi0+SKUBh1MvMk/Q/AlSqyk1e1FQUJ8jr8mFVNxD8pPBxgvVIdH ihex4dG2ZoFsDb1iv3WV9fw1EbC0DJ3MrRS8PYPMM8b/VHqUKP/E1+5hv6kSl2i9rRzi73sGi/t 1Nm/BP+sLHRdRYO11Dor0WCMXw+kPbRc5foJluKTlcv6MwBC4A3NhZW5I/E+s5eBgfpPVRcbu22 HrOQSnwVfBRJKKdJrEnD9Du5/MpedlIxips9P0DtNxD4= X-Received: by 2002:a05:6a20:d526:b0:38d:e674:b60a with SMTP id adf61e73a8af0-393ad029dc7mr3808100637.36.1770399757492; Fri, 06 Feb 2026 09:42:37 -0800 (PST) X-Received: by 2002:a05:6a20:d526:b0:38d:e674:b60a with SMTP id adf61e73a8af0-393ad029dc7mr3808056637.36.1770399756714; Fri, 06 Feb 2026 09:42:36 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5eccbdsm2639387a12.19.2026.02.06.09.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 09:42:36 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com Subject: [PATCH v5 10/13] i2c: qcom-geni: Move resource initialization to separate function Date: Fri, 6 Feb 2026 23:11:09 +0530 Message-Id: <20260206174112.4149893-11-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: upcjYO9Nzkpfa8unHr0HvVHLcgj--XCx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDEyOSBTYWx0ZWRfX/aoV1eLT8a3d 45HTME0Q8wOgNQYPWVaZsx6LKxSg8gaLaxtfSws4evB+5++yumqCpniJbpY4Gs6MGO77oFkAwx9 Qm76QFU5ft+OX3/QKoE1UqUXM5Z+Ep18VnxWtFuX+eE2CKvgJWtXGub0g5+XUDkO4ATo6z5fqfS SDagQlYKJpQQ5p6TVcTvbVtA3GgU4ZI0l7MnxhzJaP2U1zGOKGeUKcXvxEuKDvCCv28ugVWVp43 wjnwjueYfK94XYLX4j0HOF9hex1XR+IjPEB9dOzYyj/mxCpBWqdTON4SvQmSw6x1Ivd9Vy8CSfY QAGW68TfWvXmBpKVcMhWJ23elrBAF7gdiKTN5gF9kOx7RL6iAVj06InehiqWLg/VsUIChtOXqP9 loCiX1jj02uZPNZ0Goz7vgmXQUIEG8Mr0H6At62uguEYPMuR9B/izEaFXbtw8W2Nd+Iuam2q+a/ aCDSr3S4wIS++4c1sig== X-Authority-Analysis: v=2.4 cv=C73kCAP+ c=1 sm=1 tr=0 ts=6986280e cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=T4QVXHuY6bPIseVWQ88A:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: upcjYO9Nzkpfa8unHr0HvVHLcgj--XCx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060129 Content-Type: text/plain; charset="utf-8" Refactor the resource initialization in geni_i2c_probe() by introducing a new geni_i2c_resources_init() function and utilizing the common geni_se_resources_init() framework and clock frequency mapping, making the probe function cleaner. Acked-by: Viken Dadhaniya Reviewed-by: Konrad Dybcio Signed-off-by: Praveen Talari --- v4->v5: - Added a Reviewed-by tag. - Removed core clk, has_core_clk and icc_ddr variable. v3->v4: - Added Acked-by tag. v1->v2: - Updated commit text. --- drivers/i2c/busses/i2c-qcom-geni.c | 64 +++++++++++------------------- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index 81ed1596ac9f..05f5705b0319 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -107,7 +107,6 @@ struct geni_i2c_dev { int cur_wr; int cur_rd; spinlock_t lock; - struct clk *core_clk; u32 clk_freq_out; const struct geni_i2c_clk_fld *clk_fld; int suspended; @@ -125,8 +124,6 @@ struct geni_i2c_dev { }; =20 struct geni_i2c_desc { - bool has_core_clk; - char *icc_ddr; bool no_dma_support; unsigned int tx_fifo_depth; }; @@ -1045,6 +1042,23 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) return ret; } =20 +static int geni_i2c_resources_init(struct geni_i2c_dev *gi2c) +{ + int ret; + + ret =3D geni_se_resources_init(&gi2c->se); + if (ret) + return ret; + + ret =3D geni_i2c_clk_map_idx(gi2c); + if (ret) + return dev_err_probe(gi2c->se.dev, ret, "Invalid clk frequency %d Hz\n", + gi2c->clk_freq_out); + + return geni_icc_set_bw_ab(&gi2c->se, GENI_DEFAULT_BW, GENI_DEFAULT_BW, + Bps_to_icc(gi2c->clk_freq_out)); +} + static int geni_i2c_probe(struct platform_device *pdev) { struct geni_i2c_dev *gi2c; @@ -1064,16 +1078,6 @@ static int geni_i2c_probe(struct platform_device *pd= ev) =20 desc =3D device_get_match_data(&pdev->dev); =20 - if (desc && desc->has_core_clk) { - gi2c->core_clk =3D devm_clk_get(dev, "core"); - if (IS_ERR(gi2c->core_clk)) - return PTR_ERR(gi2c->core_clk); - } - - gi2c->se.clk =3D devm_clk_get(dev, "se"); - if (IS_ERR(gi2c->se.clk) && !has_acpi_companion(dev)) - return PTR_ERR(gi2c->se.clk); - ret =3D device_property_read_u32(dev, "clock-frequency", &gi2c->clk_freq_out); if (ret) { @@ -1088,16 +1092,15 @@ static int geni_i2c_probe(struct platform_device *p= dev) if (gi2c->irq < 0) return gi2c->irq; =20 - ret =3D geni_i2c_clk_map_idx(gi2c); - if (ret) - return dev_err_probe(dev, ret, "Invalid clk frequency %d Hz\n", - gi2c->clk_freq_out); - gi2c->adap.algo =3D &geni_i2c_algo; init_completion(&gi2c->done); spin_lock_init(&gi2c->lock); platform_set_drvdata(pdev, gi2c); =20 + ret =3D geni_i2c_resources_init(gi2c); + if (ret) + return ret; + /* Keep interrupts disabled initially to allow for low-power modes */ ret =3D devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN, dev_name(dev), gi2c); @@ -1110,23 +1113,6 @@ static int geni_i2c_probe(struct platform_device *pd= ev) gi2c->adap.dev.of_node =3D dev->of_node; strscpy(gi2c->adap.name, "Geni-I2C", sizeof(gi2c->adap.name)); =20 - ret =3D geni_icc_get(&gi2c->se, desc ? desc->icc_ddr : "qup-memory"); - if (ret) - return ret; - /* - * Set the bus quota for core and cpu to a reasonable value for - * register access. - * Set quota for DDR based on bus speed. - */ - gi2c->se.icc_paths[GENI_TO_CORE].avg_bw =3D GENI_DEFAULT_BW; - gi2c->se.icc_paths[CPU_TO_GENI].avg_bw =3D GENI_DEFAULT_BW; - if (!desc || desc->icc_ddr) - gi2c->se.icc_paths[GENI_TO_DDR].avg_bw =3D Bps_to_icc(gi2c->clk_freq_out= ); - - ret =3D geni_icc_set_bw(&gi2c->se); - if (ret) - return ret; - gi2c->suspended =3D 1; pm_runtime_set_suspended(gi2c->se.dev); pm_runtime_set_autosuspend_delay(gi2c->se.dev, I2C_AUTO_SUSPEND_DELAY); @@ -1183,7 +1169,7 @@ static int __maybe_unused geni_i2c_runtime_suspend(st= ruct device *dev) gi2c->suspended =3D 1; } =20 - clk_disable_unprepare(gi2c->core_clk); + clk_disable_unprepare(gi2c->se.core_clk); =20 return geni_icc_disable(&gi2c->se); } @@ -1197,7 +1183,7 @@ static int __maybe_unused geni_i2c_runtime_resume(str= uct device *dev) if (ret) return ret; =20 - ret =3D clk_prepare_enable(gi2c->core_clk); + ret =3D clk_prepare_enable(gi2c->se.core_clk); if (ret) goto out_icc_disable; =20 @@ -1211,7 +1197,7 @@ static int __maybe_unused geni_i2c_runtime_resume(str= uct device *dev) return 0; =20 out_clk_disable: - clk_disable_unprepare(gi2c->core_clk); + clk_disable_unprepare(gi2c->se.core_clk); out_icc_disable: geni_icc_disable(&gi2c->se); =20 @@ -1248,8 +1234,6 @@ static const struct dev_pm_ops geni_i2c_pm_ops =3D { }; =20 static const struct geni_i2c_desc i2c_master_hub =3D { - .has_core_clk =3D true, - .icc_ddr =3D NULL, .no_dma_support =3D true, .tx_fifo_depth =3D 16, }; --=20 2.34.1