From nobody Sat Feb 7 13:45:54 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60982D5957 for ; Fri, 6 Feb 2026 12:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770382613; cv=none; b=aDSEIMdMol3iLE9FJYWaU3lDkvlqGbWLxORtqXwm0lXxsn8NV3lDtpgVslBtNF3NR+1Nz7/2klYaq5qgwRFlNxRHRYI4hjvgm0+XblN//fdK5vhLwRx00yl28zBAtBAZ2ZhWTMvbPWbUTUPmwW/1WHfs3F8rCkTHbTiGjeLzVfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770382613; c=relaxed/simple; bh=J5wnWBrgDmOOXJUXQQliGR689OAsyLfQOIF2YC3uKIE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A9w7FXduYjG6K80VumgLisaC7z1abctCjHDtRHVGSf5IULpQNMHpaveZzfNedXHFfNAy0j3ED81RgACGb3Xr8pLmI92XvBFWWlLwluxDRHVorz1ipSFdczJXXIhtdf0XijFKzTniDogx6QxBeMYrmS7g7pxkr6YkCCoR17yGyRo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QJPWOzFa; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QJPWOzFa" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2a95bfdb31eso670845ad.3 for ; Fri, 06 Feb 2026 04:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770382613; x=1770987413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5xm0AKu7YJqB8nXfNXMRCkayaRMWeQPv9CgV6YLu1ks=; b=QJPWOzFaeU2AXuH7iTijQioFbOSRunxd1ERquM+fS79efSWdVdMv3aJCAyhaOJ+E08 X/7St+jsws4AHsdXOPMMJhubNxZ+nPah1DjK+/kLQ9HYH1cTHWoy3XryfBEfqsxwFS4h b4hxHTew6s+1v9IKc/74p4H8bDPwKeF1FQay53YMBAUYXc5caOjb8kzUhRKZLxm53+UB aNFpa2mHXA9f9YQoXVKK2PrUefb0UU5y77kYI5oVaIlv4VYmEt89+lCvlYTv/W+eHmFn IZ0m09e6icfpzz0vSwk3fA2CZRFqjgn0JjExgufkK7qUC+9i6Fuo06qIql0eO2DNv/8d ABGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770382613; x=1770987413; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5xm0AKu7YJqB8nXfNXMRCkayaRMWeQPv9CgV6YLu1ks=; b=fq52O/tViTcx5EyG+aYCTo1HKZT+h31/+k0QCMKcjDbJlSXHj2hkOunwDJBWDFSkrt MGLOTbJnjLeHmr6nXgut+d8AneSvpc2bhXdyw8wLRUnSlW4SjmG/ew+irROBbq0Wfz6E BifT/L2zmh9QkSGQALS47PKUN4Ov+JTofVonzgzyTKGj+BwVXXGzfm9XvZyfJahEYGEo D2n702kGxHAjxW+4y0v3jBYpvNkUQasAP+fAVatFwreXQVgj6h7GweFGE0smUFbNBmHk CBZP6+xPYXMBk5kr/5cBbFrPtI8NpJIhiT8oDbpLFsypcetFmxng7qPa8XlKixoHihA2 KVIA== X-Gm-Message-State: AOJu0Yw3nVdfDZXJ0yzoJdhL57J0TaCAhV3sN4NljgbIJ1wRR64rs3rE QoDE2OImwUPslPr+VlQd3buqHABtcd2Gn+79VNgnu62gnEOIQHgdbprp X-Gm-Gg: AZuq6aJsXlLkzswW5Pzfbb37ox+tXHbQ5BP5Jh9cDEuxDwfulg277HAlA+7EsXgOHyo qUYAmoXZG8UqdOJmZYdWmrDwpZly0OkZpuVa6m0N1n6yQ9JXKS7wE1/1q75syRBDDCkALnxXqyo 1+XsTHawTvg6MXUGYs1eklPzIGOMH4ZEJC1dLBdQ1VjR5XUzh+K4IDGEbKmu0Fp4LDCz8V53XHs dqFUM6jqv8O9ldhWMxc/bEgor9HjQN95vfz846GepRbN3SDz4lExP/r836fOAl+K8oaUpB5iedL o7ltYqIscWDgZ1Ri3my1C1CQHMfOoiYXnErYpJOjoO4Z8r0PZ0wKQ7mG8LlImtgiqLpw3/1Jf1u 3eWgRAxkcr/3g90HmMO2VmGczqcBd5zcV7NfWwBDISHy9U/4zTyDSsgdu3UPTZQDN/DQN0HWhU8 F+O/g2ibH1VA== X-Received: by 2002:a17:903:906:b0:29e:76b8:41e5 with SMTP id d9443c01a7336-2a9521f3eebmr30975335ad.30.1770382613142; Fri, 06 Feb 2026 04:56:53 -0800 (PST) Received: from archlinux ([45.119.31.85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a95bff42f7sm4777795ad.68.2026.02.06.04.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 04:56:52 -0800 (PST) From: Adarsh Das To: jack@suse.com Cc: linux-kernel@vger.kernel.org, Adarsh Das Subject: [PATCH] fs: udf: avoid assignment in condition when selecting allocation goal Date: Fri, 6 Feb 2026 18:26:38 +0530 Message-ID: <20260206125638.94194-1-adarshdas950@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid assignment inside an if condition when choosing the block allocation goal in inode_getblk(), and make the priority order explicit. No functional change. Signed-off-by: Adarsh Das --- fs/udf/inode.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 7fae8002344a..4a4cb42319af 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -734,7 +734,7 @@ static int inode_getblk(struct inode *inode, struct udf= _map_rq *map) sector_t offset =3D 0; int8_t etype, tmpetype; struct udf_inode_info *iinfo =3D UDF_I(inode); - udf_pblk_t goal =3D 0, pgoal =3D iinfo->i_location.logicalBlockNum; + udf_pblk_t goal =3D 0, pgoal =3D 0; int lastblock =3D 0; bool isBeyondEOF =3D false; int ret =3D 0; @@ -893,11 +893,10 @@ static int inode_getblk(struct inode *inode, struct u= df_map_rq *map) else { /* otherwise, allocate a new block */ if (iinfo->i_next_alloc_block =3D=3D map->lblk) goal =3D iinfo->i_next_alloc_goal; - - if (!goal) { - if (!(goal =3D pgoal)) /* XXX: what was intended here? */ - goal =3D iinfo->i_location.logicalBlockNum + 1; - } + else if (pgoal) + goal =3D pgoal; + else + goal =3D iinfo->i_location.logicalBlockNum + 1; =20 newblocknum =3D udf_new_block(inode->i_sb, inode, iinfo->i_location.partitionReferenceNum, --=20 2.53.0