From nobody Sat Feb 7 19:08:26 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B227E35D60A for ; Fri, 6 Feb 2026 11:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770378677; cv=none; b=efBZj2gk8tQsSdVjLHWXrH/uToNWQp+zADcjtgsH1jQOHFVgAuN46LDSNIfLRFEtVYYALvgtCRT29JNY//nZFz9uBkXOZzRO+IH3gdcTDjJIYjhbYMzVZTXwI0PqdUZZR7bmuSP4aq6ToTzzyce/DNqK8DWb1iY1FxnZtHuS5Ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770378677; c=relaxed/simple; bh=WbDOpPWO+XY6Hr/JKBnNeyt3QNq4/a39jz7zrhemoc0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rCGrVxFlrgR1qlVmph7arMFTrlZNhy1ujSNci8WqGsxAITvhqR83mzY8RgMIhm8F4jFeTmmza5gJGVGYBGFl+RO7ROMIIp6lDeqJRx98xLB+07ZtSxV9b5DIUIMpagv7dEvfXFrSdWZ8xhZvX0qXNM8nKbFX5r6z1ge5uQGd+4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kxn+GELK; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kxn+GELK" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a8ff2ca490so10441235ad.2 for ; Fri, 06 Feb 2026 03:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770378677; x=1770983477; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=33anR6skOU7C6MY+v0MoVum+PUKxnrSQThfEb3hFZtA=; b=Kxn+GELKfWN046bJ6UwlYJGT5B7EZUa/a9iEf5AGgzCrrlKktYrw5xShctB1mNck9v AQBlB6jPvPmWfFbSK3tDisUJr4nZNGhhD3ngK8W4vh8PUUsxqQQw5YYjzTLu+R/wOGw/ id3zNvyB1dpRfxiAznih0ni2naxS/WZ/ycNxknoBnlJZ0BA1O0J/euUIR7Bopp6Zbtbq d6GHNCZgxmPoRm+nSNIkzwlYrLrb6huT961h0ochESZg2JtsE7tW2nCpomnE94mwEdcI DWNknA8U1XPaWjtB78SuxQm6ytUsxjpHNEssnx6BMgm3LdXjYJMxdLgRidSO0BZ8Z598 bHNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770378677; x=1770983477; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=33anR6skOU7C6MY+v0MoVum+PUKxnrSQThfEb3hFZtA=; b=Ly9EVBYCnsqLRCdMzYU7rfpo9OU0D+BqRZmUEd96bkhupcvXAoLk7RU3a/geIa+RHo 2UfJJJuoDzsPP0Pl3PvvhHGN5zZY2Uh8gywK9YNA9bJFQQQ5NxxZUOudU3ksXwFcxDER jEyTcfZrhi5llydnnxLhosOdOpaHVutRpWmaLZ2vcB7gEf/rt5X4grUIoOltJo9wEU+O Qk62WeLjEEyVxOMjTpi7v1rdtJy4JK59D31L9Ol33JQuDJCn+8Fb+ikYmommDaeu8POe jv6jffvfmrzJED9euHMZhEiRKrq5yNtxyF2CNO8HKqyDjq/phn0/WP0KG3dzsKubvVeS ouIA== X-Forwarded-Encrypted: i=1; AJvYcCU+sGp6rNK35n1SnJbW/zec714au18pWzWpHv+tskltZtk/YF6nAFK5UcImUfhFMEQKx8qWzSEnVSfYAbA=@vger.kernel.org X-Gm-Message-State: AOJu0YwhDvlG9gyEpNwwUGHywJ+lMH9QBFZ9K/Z5/iEAZsoKY1Oq+aUA ch99ZUw0zV2r/+ivVpVSDIF0ISwdFwegTmjSl3tD1kYF9148rzSFWVvBFBdlsQ== X-Gm-Gg: AZuq6aLtn94CipjrIKO4BJan//AWWuqzFpO+jfZP7JR2K7KcOlhpGu0dzWvFvwiDTTV nMGk+OXHt1lO1FAIBL6i/a7Li/dFo8dNdfx9KaY6fhpEvIbYAGzgQsKbh7UViyzjWHORCBm6rD2 7WvnhaluKm+21Rgz+Z2jRCu8gTZyJg0LRshQZhTJddsBXUQCUIORli44iE0jbp4YtGjMtxTXasc lpWACCnxsKhabC1byoyrC26uqxi90vbDQmAbjuLw2kCLmyfW5I436r/XBLqeW0FUGwh9xaOIlk6 q5HuqXuMPqktRSzxTMsguXeleScI9ceuYMHy9yf+tifRFIOXozSJ95rLsnahVrQcktwAhfVfjs3 W0siLSnCJyATfl7xdQ82aQW+z42c/Mfb+k5VCqFuwc5qxGQyvxyeI+YJG5a7aOvh86v2+kVB/io yLGGifFg12JoA1kwyM0uUq X-Received: by 2002:a17:902:cf42:b0:295:5da6:6011 with SMTP id d9443c01a7336-2a95160c728mr25582595ad.11.1770378676928; Fri, 06 Feb 2026 03:51:16 -0800 (PST) Received: from archlinux ([45.119.31.85]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb542c36sm2114729a12.16.2026.02.06.03.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 03:51:16 -0800 (PST) From: Adarsh Das To: dwmw2@infradead.org, richard@nod.at Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Adarsh Das Subject: [PATCH] jffs2: use fs_umode_to_dtype() for dirent type Date: Fri, 6 Feb 2026 17:21:00 +0530 Message-ID: <20260206115100.84852-1-adarshdas950@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use fs_umode_to_dtype() instead of direct bit shifting when setting directory entry type. Signed-off-by: Adarsh Das Reviewed-by: Zhihao Cheng --- fs/jffs2/dir.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index dd91f725ded6..185cf76a061e 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c @@ -261,8 +261,7 @@ static int jffs2_link (struct dentry *old_dentry, struc= t inode *dir_i, struct de if (d_is_dir(old_dentry)) return -EPERM; =20 - /* XXX: This is ugly */ - type =3D (d_inode(old_dentry)->i_mode & S_IFMT) >> 12; + type =3D fs_umode_to_dtype(d_inode(old_dentry)->i_mode); if (!type) type =3D DT_REG; =20 now =3D JFFS2_NOW(); @@ -730,10 +729,7 @@ static int jffs2_mknod (struct mnt_idmap *idmap, struc= t inode *dir_i, rd->ino =3D cpu_to_je32(inode->i_ino); rd->mctime =3D cpu_to_je32(JFFS2_NOW()); rd->nsize =3D namelen; - - /* XXX: This is ugly. */ - rd->type =3D (mode & S_IFMT) >> 12; - + rd->type =3D fs_umode_to_dtype(mode); rd->node_crc =3D cpu_to_je32(crc32(0, rd, sizeof(*rd)-8)); rd->name_crc =3D cpu_to_je32(crc32(0, dentry->d_name.name, namelen)); =20 @@ -811,8 +807,7 @@ static int jffs2_rename (struct mnt_idmap *idmap, =20 /* Make a hard link */ =20 - /* XXX: This is ugly */ - type =3D (d_inode(old_dentry)->i_mode & S_IFMT) >> 12; + type =3D fs_umode_to_dtype(d_inode(old_dentry)->i_mode); if (!type) type =3D DT_REG; =20 now =3D JFFS2_NOW(); --=20 2.53.0