From nobody Mon Feb 9 12:29:37 2026 Received: from zg8tmja5ljk3lje4mi4ymjia.icoremail.net (zg8tmja5ljk3lje4mi4ymjia.icoremail.net [209.97.182.222]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F74236164D; Fri, 6 Feb 2026 09:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.97.182.222 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770371317; cv=none; b=pKBmbwmH1VdeiIUu9IP+Jc8895FS9dnI4STMqeL2rvBUI77GJHg7NzSvqtXYk60dngTGNCjpmbaQMrH2hJvX/3Qks6oJo2MZNDHTW6ZufparxQ3gh9AZNXh67F08zHrxKBSQ+OPbf3nNUW7tzG4dMEFgNKm6sQ/FIJ7eYjG3BWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770371317; c=relaxed/simple; bh=7+e8eX9ZX7Li+sHo37qWBkoU6ScmQgxJbm8VOKZGN2E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=P0ST8mOguuJWOJwkD/nCFaDTw9wwv4lSoymd16+QcezGVUS8YHHJtQAIF6wT0jUbPB1w9YiP2V+FCZYEsxAgs0kLw15nq4a6ItAsCFPVyhMVGrwCBPNF1Z7wzAmla0lYkKtp4l0QKeps/uv07skUya3CLov1bHyJyODs5EUcrhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn; spf=pass smtp.mailfrom=zju.edu.cn; arc=none smtp.client-ip=209.97.182.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zju.edu.cn Received: from zju.edu.cn (unknown [218.12.18.78]) by mtasvr (Coremail) with SMTP id _____wD313nguIVpV5qKAA--.32698S3; Fri, 06 Feb 2026 17:48:17 +0800 (CST) Received: from ubuntu.localdomain (unknown [218.12.18.78]) by mail-app4 (Coremail) with SMTP id zi_KCgDXuH_cuIVp1Fc6BQ--.48379S2; Fri, 06 Feb 2026 17:48:15 +0800 (CST) From: Duoming Zhou To: netdev@vger.kernel.org Cc: linux-atm-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, 3chas3@gmail.com, shaojijie@huawei.com, Duoming Zhou Subject: [PATCH net v2] atm: fore200e: fix use-after-free in tasklets during device removal Date: Fri, 6 Feb 2026 17:48:11 +0800 Message-Id: <20260206094811.23431-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zi_KCgDXuH_cuIVp1Fc6BQ--.48379S2 X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwMOAWmE8ocaTAAFsE X-CM-DELIVERINFO: =?B?Kv60UwXKKxbFmtjJiESix3B1w3uoVhYI+vyen2ZzBEkOnu5chDpkB+ZdGnv/zQ0PbP CR1zXbE/KbOKpOcnYVZjSMniAA292yjs//pM8vtj0Ion0ZY+bLYR4sWGpi3274crccRmo6 UeeWc9aOIaiXpvVxqCjt/Z/A1jXl4Gt2gHnVApjBp+BUuLi7iUSwm59+qb3PlQ== X-Coremail-Antispam: 1Uk129KBj93XoW7Kr43Kw43XF15WF4UWFyUJwc_yoW8Cr1rp3 yxua17Cry8JrWjgw47Jw1Uur18uFn3XFWY9w4kK3y2qF1FvF109r13KF4DWFWYk34xZF92 gF1ktFy3W34DJFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvvb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AK xVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0Y48IcxkI7V AKI48G6xCjnVAKz4kxMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I 3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxV WUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8I cVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aV AFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuY vjxU26pBDUUUU Content-Type: text/plain; charset="utf-8" When the PCA-200E or SBA-200E adapter is being detached, the fore200e is deallocated. However, the tx_tasklet or rx_tasklet may still be running or pending, leading to use-after-free bug when the already freed fore200e is accessed again in fore200e_tx_tasklet() or fore200e_rx_tasklet(). One of the race conditions can occur as follows: CPU 0 (cleanup) | CPU 1 (tasklet) fore200e_pca_remove_one() | fore200e_interrupt() fore200e_shutdown() | tasklet_schedule() kfree(fore200e) | fore200e_tx_tasklet() | fore200e-> // UAF Fix this by ensuring tx_tasklet or rx_tasklet is properly canceled before the fore200e is released. Add tasklet_kill() in fore200e_shutdown() to synchronize with any pending or running tasklets. Moreover, since fore200e_reset() could prevent further interrupts or data transfers, the tasklet_kill() should be placed after fore200e_reset() to prevent the tasklet from being rescheduled in fore200e_interrupt(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Duoming Zhou --- Changes in v2: - Move tasklet_kill() after fore200e_reset(). drivers/atm/fore200e.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index f62e3857144..de04c407921 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -362,6 +362,10 @@ fore200e_shutdown(struct fore200e* fore200e) if (fore200e->state > FORE200E_STATE_RESET) { /* first, reset the board to prevent further interrupts or data transfers= */ fore200e_reset(fore200e, 0); +#ifdef FORE200E_USE_TASKLET + tasklet_kill(&fore200e->tx_tasklet); + tasklet_kill(&fore200e->rx_tasklet); +#endif } =20 /* then, release all allocated resources */ --=20 2.34.1