From nobody Sat Feb 7 17:09:42 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3947834DB68 for ; Fri, 6 Feb 2026 08:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770368108; cv=none; b=j+onprV6hnyy5OUxEfCI6ZjJUYuT1BNc0G56YdWc1GUvSVkB6OTJy9flqp+yfbkczJjnKlOSYI27MjqGY5dEHxHjjz8wspdAVtlVkf5t2Q5d9zpH2gzos7M9RmoMyxF0YKaaY/oXeHJ2jT75WZPFPvckdf6F0Hm4mBeMicKMz04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770368108; c=relaxed/simple; bh=8gJloZSI1GQcrUYIaj8I3nBQOZEH48jxJXr5qkX/U14=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WzxqB8igtmUx7Wmcey0eZCVGx9scrNEmERPm/Mf0lMkqxxl0F40nqMHDIMU47jSD+nFiVzJLp+Z2+tIrPp0zdTFCqtF19FaWOhyW/2qRoS/pHLALJcrV1WpWTy6YlwpTXg+l7cjZNSHKzDCVV6poSARoYhu54bHRIeNnKmkh6RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gjSjQicO; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gjSjQicO" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4806b8fca44so1093635e9.0 for ; Fri, 06 Feb 2026 00:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770368106; x=1770972906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=H4CfwKcayH4xDR1+iMb7IfsfcQiFBuBvxK6Im43iVvY=; b=gjSjQicO5T3W/iqPuXAXKIxzqqgcdFdaQMz1jXcI6cGcv/qsXESXyfVwl2zJ0+WXIs LrVhLZjAm5NZ/J6AlDKm4aJIU3NcIuha8o8k4eBBQQjXlIcu8+P8BCCRverJplUylxC0 eFQLb2mfnqd46takk8AklbPgxqcQGX4+H+F+MpKZlyCdJvwoX3SZjhyF7OqKpObLx/PH dqZiJ0YF3YaHFdx5GQJyIqhvpNqen5BhpcIDTfwzXBzHQuLZIt4f78brZu/iqMOiu66Q TqP/Xsd0/GrMP53Xi9DvXCmOCRYWfGBR/eYOWc51tU/UVvcwiDp4HPgOikkk9+L5/jFL bIug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770368106; x=1770972906; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H4CfwKcayH4xDR1+iMb7IfsfcQiFBuBvxK6Im43iVvY=; b=iAR2hfOOzVgQuvV5srHX7VNK7YlxJ9AvANl8QdSJWHlmecra5CTWQ8zat+wCsaoo3p GAHCLA2/xv6OOvl1Rpk+C96KUiMT42ckSQ1n6x47RsndEWoUNuxES9QZoA29sGef+nV8 oorCm808a7uic/SCPlJh8KlOM7GYsIeu0vV+9agc3qrLtpC4XsmY/E93woQ9g5u6e9Eu SbQrUucXvrQHZn0hps10pn8FJShfqn57Vg6pwj9/KNuccEEhH5mTEuISPeXV/3SzMtKM gq6JEbKzTojuOv+FoWYeW1h8hDg+gBcdz3fJ5uRb53lUYutYbBH3Tc+/AsxYvJzhoROH 1SbQ== X-Forwarded-Encrypted: i=1; AJvYcCUS7FdWYixrvM9e6LbCL28qYZVR+AaluQC8MspAxVrsLBzMGDMRkdUrWJt0kYD+x0VvASK6Qb+r7s0k72k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh/aEp9qa2ApssW/ttWfqmXmO5HoTofAmwC8glcYePNgfZplFv vOMI9Rga1wSOPYPriGwNF2B2wCJ2pxLr8WwjaYsJ5ecGJapFGg/27eS69hp32Q== X-Gm-Gg: AZuq6aK1wML9pOonrm3oxRjUYP3FamgO3vLNcFncOpwfHxmsQRukJYWE22B05pFrq9a O/HxgD/VhT+EpqUXbdcAmc1PY7zT4YlUs7EQ69QfykMe4ZpxUCg2qSl/u+FLlukU/Z3T8LkqymQ 3b5NIjELl6plzSEwSo9GWQ5JOXdIoXWU0nwWy1ZsEiHtZhID1mCTJlP0+ovUS4a2+nHiEWL4X9d IAzHsERNM7756Ynh3aFYoJ1e1nqAysQ5PhMlMri8VBzca1IUSiHdnWSzN8pJTLvSAECTZF0Zq6u WiY3aWpOsd1j5mG4lGUMqzTEwQc3PWf4DgC3y0iEuZDP90FbN/rjtJjVobgJwpUphuxMsm1Sd3Q QMnHPr5KZvZlblsCZCFojV5XCvcnA7YLWGKh1ln5bgpjU2JHj2GuGL9zvgDRwHlvjscZnvObpvI NibefMcIo2Fh0SGUmu3B51cAS69Pr/4mgyfwfkQZeAN8C3PKU/0zTUin0K6GRd5hZuF3LBasnpX TIF9OMg X-Received: by 2002:a05:6000:22c4:b0:431:8f8:7f2a with SMTP id ffacd0b85a97d-4362933ec57mr1767057f8f.1.1770368106350; Fri, 06 Feb 2026 00:55:06 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-213.paris.inria.fr. [128.93.83.213]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43629744ec6sm4878270f8f.35.2026.02.06.00.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 00:55:05 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , Christophe Leroy , stable@vger.kernel.org, Zhao Qiang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH net,v2] net: wan/fsl_ucc_hdlc: Fix dma_free_coherent() in uhdlc_memclean() Date: Fri, 6 Feb 2026 09:53:33 +0100 Message-ID: <20260206085334.21195-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The priv->rx_buffer and priv->tx_buffer are alloc'd together as contiguous buffers in uhdlc_init() but freed as two buffers in uhdlc_memclean(). Change the cleanup to only call dma_free_coherent() once on the whole buffer. Reviewed-by: Christophe Leroy (CS GROUP) Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") Cc: Signed-off-by: Thomas Fourier --- v1->v2: - Cleanup priv->tx_buffer and priv->dma_tx_addr - Fix buffer name in commit message drivers/net/wan/fsl_ucc_hdlc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index f999798a5612..dff84731343c 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -790,18 +790,14 @@ static void uhdlc_memclean(struct ucc_hdlc_private *p= riv) =20 if (priv->rx_buffer) { dma_free_coherent(priv->dev, - RX_BD_RING_LEN * MAX_RX_BUF_LENGTH, + (RX_BD_RING_LEN + TX_BD_RING_LEN) * MAX_RX_BUF_LENGTH, priv->rx_buffer, priv->dma_rx_addr); priv->rx_buffer =3D NULL; priv->dma_rx_addr =3D 0; - } =20 - if (priv->tx_buffer) { - dma_free_coherent(priv->dev, - TX_BD_RING_LEN * MAX_RX_BUF_LENGTH, - priv->tx_buffer, priv->dma_tx_addr); priv->tx_buffer =3D NULL; priv->dma_tx_addr =3D 0; + } } =20 --=20 2.43.0