From nobody Sun Feb 8 11:44:36 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC67346797 for ; Fri, 6 Feb 2026 07:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364503; cv=none; b=cIUy/fOOtjNIgksmyUD+M2VhQ5n1PBzRFTilr6mkB8tAGMGRNZEX3JSo3D4OsysnrsyPNjxs6Wc4a2jsu6tGt3rAtrap0KlfPJJ9ttkiSbDJd0zHPzUzqT5GKQMsrGyUNvIa+TE6tn2Cmgh1SAJdjmdRAuQNt+MknfArXh4OTOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364503; c=relaxed/simple; bh=NnZB31Y4W3GvdHsE/z64093AWpt9r8mlKoM7d/nRwII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZZKwyiFONg1j6iFhOSaM7wfWZIn6ulZfeoSU/YLuv8iC/mBuQftlR1E6xfefgY9wKOhOrTk5xmMMEWvyzG52NJ6wgJUPXglcmy21Y3zqg63f+YH/DJ8H1860ATnAV2qR6ZfiFBjtvSlkR5AFI80AShIkjSEVGGYCsw9nsZGbUNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mb2iL+Zm; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mb2iL+Zm" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43629377370so508153f8f.3 for ; Thu, 05 Feb 2026 23:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770364501; x=1770969301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Qy8Dg0Z8L1ZvD1RAmGsWTraTWkcFbqS+ohdUNoSFHo=; b=mb2iL+ZmgN8C9LZrMsf0oY/QUIacNIiKe8JugPy8auIBKImHri53Y6xfJIpmVvgb00 D/wSRjkWCY2rhYtHIZheKJiebpozGt5O84jDi68czXxobQIirdPYpU8kzLtRTQvw03T5 HVbo0u5IOpKeswHK0k7eyxnTDSEO2ev3Fi9nCf7C+exHPxFB6MLtWbSP3LYBp1F95494 Q6U2DvHdg3pYd0csYOwjq0KtRKNjsbnkI+MriOlgeXEr3VC2O/mrMcSnumKI7Dc6ONw7 NwgtwoCvK0vsPc97VZgZZxZGFh+UfZrdPWY/sJJhgNuHE//YRrsAqY7sBeGskFpK8d5F uANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770364501; x=1770969301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2Qy8Dg0Z8L1ZvD1RAmGsWTraTWkcFbqS+ohdUNoSFHo=; b=ltdPv/Q+iyjhFQIhMJd6TkqeNWKay2JmMEw2/sZ8Yv6j17Ytl2Imrj5yVYp82Q68hm /bNFKqX+8wfTHw+ySJKSLvyb3FIzAzEiRgCMgz/JbyDkFFk1nNN5Gpw90MUY3fZMKBUc 2BSUXyk98aoLVD+mUgyKsTPjIH1AbHnjKwsHVNtGOYxg4/ir4l1mkuhvxuEkbylC5o3R engh1JA4VV/eF4d/jFm0bXEpRVfObcTgYC0Hv6maveM2Jzb/G673trXVsrEsWOaaC5y1 GPiVl8Z9LnmwrbLrJJ2u015P3j8E4yqNKbCXVVRU011Ax/OPGAYSRB7bCYu3kx5XyJP+ al7Q== X-Forwarded-Encrypted: i=1; AJvYcCXRqyCRurDv425+7A/pHC6K9XgUo2OGAuyPIrzlHHbuR8Gc2QHYvqIi8QQV9W9vWBOhV2A8Msdi69vTJuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwNrKMrslpuqbM1Ywdtaz5YfXyFvPvC8gyytmvyugc5SiRCFqnM Dd/jRSbg9VIk96ds3BdNpR5VVJWE76gY5fVFSvdxrvDWKJ06g3deDGw= X-Gm-Gg: AZuq6aKIqvcu6lGzUQB/ktDLVwUs5qG3wZ3ZU+aHgfZe4oOZAVTnMP3VSeC1+p9OkkE PVcMR+tV9uhruQrome32u42F+DAn20SWwU9UKmxkux1eoH8uFaznrt3sFQIk/awJwMGLGyQJtrv 7tekF0TRcEEBnlNVt7+ARYfKzPhYlWbB96il6w1EfuHi+d8XuUP0Dj2wIDFqVe/xO1RXn+H+Vai +2frchdB/LSbdlFDtSolIQDJHIw2sjDC9iLwJIJOiJ4zKinrM7S3l9cFYz/irZ4kXXkY0Eo99ov l0P7XR5eF+Ulbs7KNN8B1CpyDpbAqMtoJpD07Gc4IGEiXp1HJQqE/n5eHwsvVBW0p4GgTqdxto6 Z6gcaDFU50bq7MQ0LKq0FjT05+TAyCdrnlDHGTmpaDhVXuaOKa7fpF4lDa9SiEnAMGLXu/Qe2UE rVHLGw5B/sZ9Er1bCWvdkWpcOeuvGtJVg0Ugd34fQOxw7/FwI7U330RbCb+LfJtxM= X-Received: by 2002:a05:6000:2681:b0:435:a4a9:6f67 with SMTP id ffacd0b85a97d-4362938feb7mr3038219f8f.42.1770364501154; Thu, 05 Feb 2026 23:55:01 -0800 (PST) Received: from LGPC ([31.223.131.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm3836039f8f.11.2026.02.05.23.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 23:55:00 -0800 (PST) From: lukagejak5@gmail.com X-Google-Original-From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 02/26] staging: rtl8723bs: rename u1bTmp to val Date: Fri, 6 Feb 2026 08:54:15 +0100 Message-ID: <20260206075439.103287-3-luka.gejak@linux.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206075439.103287-1-luka.gejak@linux.dev> References: <20260206075439.103287-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luka Gejak Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 +++---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 32 +++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 054e2c2eab02..b2803b33a0f0 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) void rtl8723b_FirmwareSelfReset(struct adapter *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - u8 u1bTmp; + u8 val; u8 Delay =3D 100; =20 if ( @@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ rtw_write8(padapter, REG_HMETFR+3, 0x20); =20 - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - while (u1bTmp & BIT2) { + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + while (val & BIT2) { Delay--; if (Delay =3D=3D 0) break; udelay(50); - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); } =20 if (Delay =3D=3D 0) { /* force firmware reset */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); - rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2)); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN+1); + rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2)); } } } diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 4e81ef53dc47..c774a9009e95 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) struct hal_com_data *pHalData; struct pwrctrl_priv *pwrctrlpriv; u32 NavUpper =3D WiFiNavUpperUs; - u8 u1bTmp; + u8 val; =20 pHalData =3D GET_HAL_DATA(padapter); pwrctrlpriv =3D adapter_to_pwrctl(padapter); @@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->SdioTxOQTMaxFreeSpace =3D pHalData->SdioTxOQTFreeSpace; =20 /* Enable MACTXEN/MACRXEN block */ - u1bTmp =3D rtw_read8(padapter, REG_CR); - u1bTmp |=3D (MACTXEN | MACRXEN); - rtw_write8(padapter, REG_CR, u1bTmp); + val =3D rtw_read8(padapter, REG_CR); + val |=3D (MACTXEN | MACRXEN); + rtw_write8(padapter, REG_CR, val); =20 rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper); =20 @@ -848,7 +848,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* */ static void CardDisableRTL8723BSdio(struct adapter *padapter) { - u8 u1bTmp; + u8 val; u8 bMacPwrCtrlOn; =20 /* Run LPS WL RFOFF flow */ @@ -856,26 +856,26 @@ static void CardDisableRTL8723BSdio(struct adapter *p= adapter) =20 /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 - u1bTmp =3D rtw_read8(padapter, REG_MCUFWDL); - if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ + val =3D rtw_read8(padapter, REG_MCUFWDL); + if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ rtl8723b_FirmwareSelfReset(padapter); =20 /* Reset MCU 0x2[10]=3D 0. Suggested by Filen. 2011.01.26. by tynli. */ - u1bTmp =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - u1bTmp &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp); + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + val &=3D ~BIT(2); /* 0x2[10], FEN_CPUEN */ + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val); =20 /* MCUFWDL 0x80[1:0]=3D 0 */ /* reset MCU ready status */ rtw_write8(padapter, REG_MCUFWDL, 0); =20 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */ - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp &=3D ~BIT(0); - rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp); - u1bTmp =3D rtw_read8(padapter, REG_RSV_CTRL + 1); - u1bTmp |=3D BIT(0); - rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val &=3D ~BIT(0); + rtw_write8(padapter, REG_RSV_CTRL + 1, val); + val =3D rtw_read8(padapter, REG_RSV_CTRL + 1); + val |=3D BIT(0); + rtw_write8(padapter, REG_RSV_CTRL+1, val); =20 /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 --=20 2.52.0