From nobody Sun Feb 8 20:29:07 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90AD634D389 for ; Fri, 6 Feb 2026 07:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364533; cv=none; b=dQHnhkF7nLjmADnpNvlyYkxorCflrN0RT5FlEYyQaNTjS+7JusUCWc29Xs0TQ7maY1VI+ho49Sz+eApn70fPDlktr0LDGPE30HEaq3FCk/VjuXddshET5qUZTwHuxdEifN5kkPL+4RwnblaZDcuXGUqr5YBi35JA8n4czNw8vXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364533; c=relaxed/simple; bh=xxmU2Iz1niZ9TaTlPjBX3e0cq7c/9QkGOrVTrFkgBLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ni5yd4jdq73T2BiMG1ye87VMBkrtloql+YDZwS/Fnhc+kqBD5t9/z0CfmSnnGe39qs+jmx3+sR6DWuC8aSGurSFSUf+m1nmwl+TqegBRxRmoOJLNBtWqbe1SQMlis5NQ8u1MtZs69bGX2JQxD4SE3xq5V1kWZIskzznrgXo0u/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SeTsWkau; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SeTsWkau" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-436263e31abso1128890f8f.1 for ; Thu, 05 Feb 2026 23:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770364532; x=1770969332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aJl9uSxjTmkQN0eYXj0vZRVQ5k+Fy7400lwDxhWwNOY=; b=SeTsWkauRzZsigfC9fymGyqNUpYtWAKRcyvu/RzDIv3C8iXNmsAJlGsfRR0+Znpsbm INNgwDnI3XdlhILPrDp6xuJfTFq8xkrHJM3OGVb1dKpzo8HiO3eZOm6b+iGEm+H30/eD 2SxhhIgdOwfaCB/bQNY4lBG+4ncZW1mLnwq1Wnb5FThkGJ6Lgl5dnFJxRtvPYwvCCY+V mxbUJmdVijmvPQOIuGFOxeDXk7QZkyTHPZDZd6LWI39HcoeGyzVFnPmUDxVXvCWVLMD2 gGp/W0BGws+425Mas8yz/iUzfAIIW3eyrPPDgP4p4JJvVHPzQZtu2XX79e0+uBBufeFf BXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770364532; x=1770969332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aJl9uSxjTmkQN0eYXj0vZRVQ5k+Fy7400lwDxhWwNOY=; b=tlx+xbonfynXVo8EsAOJTqfcBqjuNHl7al2GDHJtI4sifAfh/TMStU56yxQLDAdU7n UUS8Cpb59C977UF3wTDnBa1Vje/xWR+lpzQxfX3ukSaBZHxueJ9ycLyiaDeb5hjF5zev pBeqPed5+6C/2zWTiHl4mvs33X4WtgHq+9edWv6OWljCyOkxGDdvBDr3AhWnRTtqwwKj 2mHZEyPDeMyGWamqBXAPdDRzTWfrzRoBxf+qHJl8hRpF2GWS0eAJDh0hs5gz/4YkjtyH YnzlqGFVS0R7mtjC7Sxd3+CzuijiG0XGrKWntvlbgEQuOktjXZM8u48dQ85y2CgA0x6M JZtQ== X-Forwarded-Encrypted: i=1; AJvYcCXJgZ2Ip7FbLXVafjcR6/naN65fkUfDf3rT9zggYMkOkqfl9T7tuYx6T+pE5p9QKb9ZARWkRC+SQkuVxxc=@vger.kernel.org X-Gm-Message-State: AOJu0YyfTt2cV9KhjDZ18c3tcMROw2q89iMtPm1L5YtVuEaM+kGykhJI fF0boc0r4G0wUxB/XJ+xZgds1Z6wPFTxXjHT6P6ImGdyJDCf4pG4OBM= X-Gm-Gg: AZuq6aKgNbo/L5jN/5N0YZ5gQ3QzBK2oYTqIAXI5ZKL324lEM23/Mlb4XbH5mHAFqrp XabAB8CWLjLMUPNhOwxUBkxmQaqEBeu7m+qbheAeeM5NXd+Bt53rNw+JWcK+1mP5IAcW0yBicyq ODeSAzOjmSF2ORV2sfr3vg8fukfGg8Sk7i5b1ljt5AEBPOlMlm5F7jiNWRpvbtOllEt08Djm/0M BkEuHBWf141+Q4t7gPiacsLg0TUjzaOI3k17U1+7zcI+DttiBFkpdPlBcFOF5IqzEj1hLozme0a Zg6+lravnM3P03RuH6vfE+ZTl4a34py2u5TMpUHRBRonEjWy80np0ElpY+c9a0yeubHqWydQcGm sET5dt56vDthWJU8B+5AZkOnrcwNbp+H+L6vX8uxfdoHF1hL2pbeTB16QvuwKffFlZ8Muv5GWDY 9xhffr9MMyaHLJ6Sjl/xQRMtoUPbBJ0cKPiRH+Q0DLJp5wkz1uY4L/h1zFDWqqBPc= X-Received: by 2002:a5d:5d86:0:b0:430:f437:5a6d with SMTP id ffacd0b85a97d-43629341e92mr2668591f8f.22.1770364531840; Thu, 05 Feb 2026 23:55:31 -0800 (PST) Received: from LGPC ([31.223.131.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm3836039f8f.11.2026.02.05.23.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 23:55:31 -0800 (PST) From: lukagejak5@gmail.com X-Google-Original-From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 25/26] staging: rtl8723bs: core: fix line lengths in rtw_xmit.c Date: Fri, 6 Feb 2026 08:54:38 +0100 Message-ID: <20260206075439.103287-26-luka.gejak@linux.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206075439.103287-1-luka.gejak@linux.dev> References: <20260206075439.103287-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luka Gejak Break long lines exceeding 100 characters to comply with kernel coding style. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 44 ++++++++++++++++------- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 9cead1455bfa..fdacdcf3aa98 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -435,7 +435,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * pattrib->vcs_mode =3D padapter->driver_vcs_type; } =20 -static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, struct sta_info *psta) +static void update_attrib_phy_info(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct sta_info *psta) { struct mlme_ext_priv *mlmeext =3D &padapter->mlmeextpriv; =20 @@ -471,7 +473,9 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->retry_ctrl =3D false; } =20 -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, struct sta_info *psta) +static s32 update_attrib_sec_info(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct sta_info *psta) { signed int res =3D _SUCCESS; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -510,8 +514,14 @@ static s32 update_attrib_sec_info(struct adapter *pada= pter, struct pkt_attrib *p } =20 /* For WPS 1.0 WEP, driver should not encrypt EAPOL Packet for WPS hands= hake. */ - if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && (pattrib->ether_type =3D=3D 0x888e)) - pattrib->encrypt =3D _NO_PRIVACY_; + { + bool is_wep =3D pattrib->encrypt =3D=3D _WEP40_ || + pattrib->encrypt =3D=3D _WEP104_; + bool is_eapol =3D pattrib->ether_type =3D=3D 0x888e; + + if (is_wep && is_eapol) + pattrib->encrypt =3D _NO_PRIVACY_; + } } =20 switch (pattrib->encrypt) { @@ -776,15 +786,18 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr if (pattrib->encrypt =3D=3D _TKIP_) { /* encode mic code */ { - u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, = 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; + static const u8 null_key[16] =3D {0}; =20 pframe =3D pxmitframe->buf_addr + hw_hdr_offset; =20 if (bmcst) { - if (!memcmp(psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118= 021XGrpKeyid].skey, null_key, 16)) + u8 grpkeyid =3D psecuritypriv->dot118021XGrpKeyid; + u8 *grp_mic =3D psecuritypriv->dot118021XGrptxmickey[grpkeyid].skey; + + if (!memcmp(grp_mic, null_key, 16)) return _FAIL; /* start to calculate the mic code */ - rtw_secmicsetkey(&micdata, psecuritypriv->dot118021XGrptxmickey[psecur= itypriv->dot118021XGrpKeyid].skey); + rtw_secmicsetkey(&micdata, grp_mic); } else { if (!memcmp(&pattrib->dot11tkiptxmickey.skey[0], null_key, 16)) return _FAIL; @@ -1029,7 +1042,8 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pk= t_attrib *pattrib) * 5. move frag chunk from pframe to pxmitframe->mem * 6. apply sw-encrypt, if necessary. */ -s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) +s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, + struct xmit_frame *pxmitframe) { struct pkt_file pktfile; =20 @@ -1150,7 +1164,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, + struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1764,7 +1779,9 @@ s32 rtw_xmitframe_enqueue(struct adapter *padapter, s= truct xmit_frame *pxmitfram return _SUCCESS; } =20 -struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) +struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, + struct sta_info *psta, + signed int up, u8 *ac) { struct tx_servq *ptxservq =3D NULL; =20 @@ -2018,7 +2035,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) return allow; } =20 -signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, st= ruct xmit_frame *pxmitframe) +signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, + struct xmit_frame *pxmitframe) { signed int ret =3D false; struct sta_info *psta =3D NULL; @@ -2133,7 +2151,9 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x return ret; } =20 -static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, struct __queue *pframequeue) +static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter, + struct sta_info *psta, + struct __queue *pframequeue) { signed int ret; struct list_head *plist, *phead, *tmp; --=20 2.52.0