From nobody Sun Feb 8 15:28:40 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA268346791 for ; Fri, 6 Feb 2026 07:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364525; cv=none; b=o4FXilbYjkQRLveN5qUtfQCStWaB2LRo/U41PWIzLPGYGAtgll9PS6fYGMik+02XLZr3reejnB4/6jdO7PhFbdEU4KlFJXzs3yQNvkOCmJWUXbogKgue7LosbNwI4S2sd1Eqx0wyWNmY/G31vsPmkmo3dlhndDI72XitnCO6p+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364525; c=relaxed/simple; bh=9RwoaCnbHlgF1fsHH6ESX+0AIMJG1sMgXc247Q7x+k0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NtZCzY2taqlWBcAL/dAQjrTcuNtTsHmwsKTQUrBzukY2d9pV8IEY0/yKSesyL83VZtBdFD5K2eOl9kIJN+9ODA0q5Iv6PAcCBhI2SDbxHvagWfvVPQ53NoOWA+ceguTEbuxGbd3sffjVj1i+VbXLGFLxHqPhpPnOBjidyPEdQso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A3PZ3Wpy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3PZ3Wpy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so13662175e9.2 for ; Thu, 05 Feb 2026 23:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770364521; x=1770969321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R50CaaEOLe9bahQiL94jLLGpNfkGwJIQXyhTbdEaFaM=; b=A3PZ3Wpyd59Hln9D90wMt3fhlObL4PHGPi4CTz2stfpJLgXLoG+nnXX5WT0pZkUVN4 HCdCmgFWXVObTumtQ6EWUfSpEmV3Tgzr2oO1dnApixqup2wBUpweVxcoZic0ZIpALJ8R fa68I9p0aJ7jv2lXF+z0NQIQ3ixY2XxTpPrgE27HPgXi/f0hibMqnrt9+pUgTCuMs+UX 9B7pAZ0+OJUh71yW2p1xtDSCYz4D6nJUKt+oH25BhdqkBYw9OMK7sx+22Eft7DrDaQvb b4oddyvOss+8mDXmStUhLZoYQrtTnudayUwWJYZRgU8Z5nTQM6qJpNUMb1fQQGHRIztD cRGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770364521; x=1770969321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R50CaaEOLe9bahQiL94jLLGpNfkGwJIQXyhTbdEaFaM=; b=G8+WQ2IZWGf5Vhp4xsLe/SvF1iYlcglaEaYycm7VUp4Gga6nUYnNueoOW2n6ddBflk HHvJesrC1QkLmxxIXv3xOWDCIOko2b6AIvNU5QBiFkawo/K3z/NfILbMn5oRvPd7OynM mkaIArpa9S1KBMdZUYIE2hsht68mORNgsLxt+mTtNqR0lahkEP4+kwWvNAK7PL6072wh /aHuelMQzmm9P77l+0l2TziyKjcH2gFEV9rFIwd/WlHNFeBadG4mYyyMfUND47UwLUiZ DuH4wQFn3nHW9CRdICrk65PFOMAc2xQyhjCgG1mn1jAbMhYmgRiru3eWJNCAL/ByoOQT 2Kqg== X-Forwarded-Encrypted: i=1; AJvYcCVBpBjlXnWSm5WhGRO41lRNll3ehmSAz9STwvZLD4RmMxkNQW+KTV53TiDN7PXzyNvFhlJsfipw1X8kl8U=@vger.kernel.org X-Gm-Message-State: AOJu0YwLXpdCbfeYuKOlQ4r5Ty/GWFG32/EL0wpo4QoX+mBzT7rKZM/6 ENqDBRf5Hydz2UJ/RrYwqGKJo7/mYc0oXp2dHx7bazWmy025qVuKVoE= X-Gm-Gg: AZuq6aJxz0X6La+H1XHztOk2yLh6Mb1BVEA04o7s7HFSS+Fs6JwR5v6+P+epHpxM82j LBoumyWjHouoRcPS1cu/vzPYTaKv5A/4C+yXYS27AOonXidY0U7NfP/omWEDswGEKE7FqOJRDbe E4EmhtzmA3TQ4+w6DFFxIqHymlgbBfzqUkDUQjqY1FNoXZnrQIoG3KOlqFE8Z+2ZKfo9onA3cQQ h/uq8sFss6LFxA9quTibU6yCs00yQm9csNajT8iSrQH0w4YZZ3wpBkZAGok+t+OJrVAbtOsg6Qg KkLYzSMTsJlcLgWFWbns6KX3MYP4D61+CAE+M5ooXlKq1GD6f8AayQ7UFiL8gfoZLKybDtBJIWP KphpbrhX0Klpr5VTOh5kHv2Ez09MhDrtjDeR7llHFxNHOHvVAzeZ28wIFHofZWzyYk5yaIoVCeS +81dpgrPoTqCRbeQOrpDDNtytWkssZlYsJAQ9ZopRAgTINUSPL6jN0z8kSuB1iu/Q= X-Received: by 2002:a05:600c:3509:b0:47e:f481:24b7 with SMTP id 5b1f17b1804b1-48320214735mr26719095e9.17.1770364520921; Thu, 05 Feb 2026 23:55:20 -0800 (PST) Received: from LGPC ([31.223.131.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm3836039f8f.11.2026.02.05.23.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 23:55:20 -0800 (PST) From: lukagejak5@gmail.com X-Google-Original-From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 17/26] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c Date: Fri, 6 Feb 2026 08:54:30 +0100 Message-ID: <20260206075439.103287-18-luka.gejak@linux.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206075439.103287-1-luka.gejak@linux.dev> References: <20260206075439.103287-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luka Gejak Break long lines exceeding 100 characters to comply with kernel coding style. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 64 ++++++++++++------- 1 file changed, 41 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 61b95f5703c0..e657e1872a0b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -58,7 +58,10 @@ static int _BlockWrite(struct adapter *padapter, void *b= uffer, u32 buffSize) remainSize_p1 =3D buffSize % blockSize_p1; =20 for (i =3D 0; i < blockCount_p1; i++) { - ret =3D rtw_write32(padapter, (FW_8723B_START_ADDRESS + i * blockSize_p1= ), *((u32 *)(bufferPtr + i * blockSize_p1))); + u32 addr =3D FW_8723B_START_ADDRESS + i * blockSize_p1; + u32 data =3D *((u32 *)(bufferPtr + i * blockSize_p1)); + + ret =3D rtw_write32(padapter, addr, data); if (ret =3D=3D _FAIL) { netdev_dbg(padapter->pnetdev, "write failed at %s %d, block:%d\n", __func__, __LINE__, i); @@ -261,27 +264,34 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); u8 val; u8 Delay =3D 100; + bool old_fw; =20 - if ( - !(IS_FW_81xxC(padapter) && ((pHalData->FirmwareVersion < 0x21) || (pHalD= ata->FirmwareVersion =3D=3D 0x21 && pHalData->FirmwareSubVersion < 0x01))) - ) { /* after 88C Fw v33.1 */ - /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ - rtw_write8(padapter, REG_HMETFR+3, 0x20); + /* Check for old firmware version */ + old_fw =3D IS_FW_81xxC(padapter) && + ((pHalData->FirmwareVersion < 0x21) || + (pHalData->FirmwareVersion =3D=3D 0x21 && + pHalData->FirmwareSubVersion < 0x01)); + + if (old_fw) + return; =20 + /* after 88C Fw v33.1 */ + /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ + rtw_write8(padapter, REG_HMETFR + 3, 0x20); + + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + while (val & BIT2) { + Delay--; + if (Delay =3D=3D 0) + break; + udelay(50); val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - while (val & BIT2) { - Delay--; - if (Delay =3D=3D 0) - break; - udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - } + } =20 - if (Delay =3D=3D 0) { - /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); - } + if (Delay =3D=3D 0) { + /* force firmware reset */ + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } =20 @@ -1000,9 +1010,13 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapt= er *padapter) rtw_write32(padapter, REG_TCR, value32); =20 /* NOTE: Fix test chip's bug (about contention windows's randomness) */ - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER= _STATE|WIFI_AP_STATE) =3D=3D true) { - rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); - rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); + { + u16 state_mask =3D WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | WIFI_AP_= STATE; + + if (check_fwstate(&padapter->mlmepriv, state_mask)) { + rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); + rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); + } } =20 _BeaconFunctionEnable(padapter, true, true); @@ -1655,7 +1669,9 @@ static u8 fill_txdesc_sectype(struct pkt_attrib *patt= rib) return sectype; } =20 -static void fill_txdesc_vcs_8723b(struct adapter *padapter, struct pkt_att= rib *pattrib, struct txdesc_8723b *ptxdesc) +static void fill_txdesc_vcs_8723b(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct txdesc_8723b *ptxdesc) { if (pattrib->vcs_mode) { switch (pattrib->vcs_mode) { @@ -1686,7 +1702,9 @@ static void fill_txdesc_vcs_8723b(struct adapter *pad= apter, struct pkt_attrib *p } } =20 -static void fill_txdesc_phy_8723b(struct adapter *padapter, struct pkt_att= rib *pattrib, struct txdesc_8723b *ptxdesc) +static void fill_txdesc_phy_8723b(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct txdesc_8723b *ptxdesc) { if (pattrib->ht_en) { ptxdesc->data_bw =3D BWMapping_8723B(padapter, pattrib); --=20 2.52.0