From nobody Sun Feb 8 20:29:06 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D62134888A for ; Fri, 6 Feb 2026 07:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364517; cv=none; b=agd4o0Fsi3X/lkQWrcN/wYdqgzmLp/DAtbKAB7wR5s9OZaeBjZAqmRfu531KhQKGTT7yiL1qF8mF7JMu0N7uj/R3iGDXonmksEbgQcx/hOWudTSse0nreJSAESkaIC/8iZSA8vs0o6j9JakGB7ills//aqL9U8VoSCCuUQrYlRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770364517; c=relaxed/simple; bh=apGCEg41N/2hmADje7Vq1oBVnf5A9ngqojDtCDVvYL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ahK3sN3+6imuim8EYCX9jJECNvBipdm4K9NyJaPJeHhMzwVMmKKwSdMnjDgOOQwMopwwGRuXeiLOZdXGCppTSTXjf0bTVYcsA3gqkFb6RTeNYsn78mLjWTGArpmpDqZ0+6cbaNSZDxotj8BG9MRa22ImVUXC0BBlxLi9Zy/9E+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cthu6WIo; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cthu6WIo" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4359249bbacso1777815f8f.0 for ; Thu, 05 Feb 2026 23:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770364516; x=1770969316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uG18KWWpeVRGE5n/fllYKO4ZAPukL1WCC2h6WbjieA4=; b=cthu6WIoSUnP3zoULDlptFqeXPrbnVg2qWaCMjE4jfyjhUL6NpA5crM47yxp2Xcd75 RpnK60yLo7Tddl2jWjsf+hGmsY9xlRdJWzT6bn0rJo1wGtcarMCPM2ahL3iYKw84e1QW fJ+dqaN8efHnyq+WGq/m3JmBlSSMfYEpA9CuWOFceO9diw9+tGPrfMkPNnh/EM6JNbcH 0zRIVyTiW2uipSdVPkaqC1IBxE57Lemf7Gxs7FS7p579cySa0vr6+f0+8NGH64bRgCPP JydBzLG1o+SL4eUSXbA8K9wwJd9e5srYycAYWqWHMQxWedLhfjVpNarN0YmDLv2l+3xt BDFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770364516; x=1770969316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uG18KWWpeVRGE5n/fllYKO4ZAPukL1WCC2h6WbjieA4=; b=Vqk3sEVu6YXQxsy/yAudRF0d8kr/v+CubuqaUpz7Em0N1dh5hc2ioafntBLThyShbO AI2gg6CbaklaWWLwKehbPBzNUBSS5wOTro7OTIAUwGmyto8WQAytrxALsgo6Qj8kbLU+ byhtSnPGef07Dp62kaDgzs6G6TJVy9e0uTKvGG6wDd3G0Q3KQfsirQRKYCWs5IQx2SPG H4GoRCUEhSZHXutmZo/sfB5zh94vBTMej9fQrgDVLeDpLDSg3WX/LOBdLQ0SXw13eC6n yX/MQ6S7orA2fY2p3o70p2Sp7rX6AjgB7OhKH/O3de7J/I376Wq+pp/E1AIqr1PO6gq0 tzBQ== X-Forwarded-Encrypted: i=1; AJvYcCW3ptkt6JOgIh8Vur88GtPE+mQlBryU4YzM0IPqZfk6ZtkgDuEzM6yt96T9f6/ahZ4d1Yij9ljEXHne2bo=@vger.kernel.org X-Gm-Message-State: AOJu0YzyoHMsSLH0fuL9WWBxbZo1WxYK+/OiQZKAUJp0U5QczrUSNbva gYqsbkUc1Ulu0Hugzpe5LG6CNJrzwnezMpQ75QBgJqlHU2cRBRv+pDU= X-Gm-Gg: AZuq6aKNajfaJ8ucmr+65RxIHljtZ6+PQJcFH9DcTxiPV4O7SQXV7VZ2ggS7vjWDYJK tSU8FneUiBQ++2csob5AYqIG9iOMLAC0mmdoV64aa8YThgQXd15V/5Q/p0dwJreb77LXmBsMThd QSroTaKu4I/6uWNgmcVxNpa22OBBj5cuJ5O3wnDlAznIAPzmf+l6xHJX7tarEILCJUZ4zHbVPD8 W4AwNCeJVxIsFZ2qcMBmaNDVtUJLnLQ8LZJg8WskVPLvJScg5R3KJaChy+U0j7+PzvUvqayS4OJ iN34RMtUm1JxJOrHd0BPijy5P4kZImmeKml85rCslZrjq9e2YkgI+QFrdDdk8Vr07LplftY1Ii5 EYZTJUqIgkb8S5QcJfHw+fAF/6Jb4fNKK19LNgaaU4w50hkeHqHquv9cDrXyvhSha24CJbxxb7D 6ANNc5Tht2pliDY+PfXJxjpOna3UkPymQScSu1dMQ4TMPxski5DNQCGo4ED2ldhbVhDuogUCNzj g== X-Received: by 2002:a05:6000:2902:b0:435:9e81:105e with SMTP id ffacd0b85a97d-4362933ed0fmr2710216f8f.19.1770364515681; Thu, 05 Feb 2026 23:55:15 -0800 (PST) Received: from LGPC ([31.223.131.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm3836039f8f.11.2026.02.05.23.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 23:55:14 -0800 (PST) From: lukagejak5@gmail.com X-Google-Original-From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v2 13/26] staging: rtl8723bs: core: fix line lengths in rtw_recv.c Date: Fri, 6 Feb 2026 08:54:26 +0100 Message-ID: <20260206075439.103287-14-luka.gejak@linux.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206075439.103287-1-luka.gejak@linux.dev> References: <20260206075439.103287-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luka Gejak Break long lines exceeding 100 characters to comply with kernel coding style. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_recv.c | 123 ++++++++++++++-------- 1 file changed, 82 insertions(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 0a8725686721..d69906a21b74 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -47,14 +47,23 @@ signed int _rtw_init_recv_priv(struct recv_priv *precvp= riv, struct adapter *pada =20 precvpriv->free_recvframe_cnt =3D NR_RECVFRAME; =20 - precvpriv->pallocated_frame_buf =3D vzalloc(NR_RECVFRAME * sizeof(union r= ecv_frame) + RXFRAME_ALIGN_SZ); + { + size_t sz =3D NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ; + + precvpriv->pallocated_frame_buf =3D vzalloc(sz); + } =20 if (!precvpriv->pallocated_frame_buf) { res =3D _FAIL; goto exit; } =20 - precvpriv->precv_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(precvpriv= ->pallocated_frame_buf), RXFRAME_ALIGN_SZ); + { + SIZE_PTR aligned =3D N_BYTE_ALIGMENT((SIZE_PTR)(precvpriv->pallocated_fr= ame_buf), + RXFRAME_ALIGN_SZ); + + precvpriv->precv_frame_buf =3D (u8 *)aligned; + } /* precvpriv->precv_frame_buf =3D precvpriv->pallocated_frame_buf + RXFRA= ME_ALIGN_SZ - */ /* ((SIZE_PTR) (precvpriv->pallocated_frame_buf) &(RXFRAME_ALIGN_SZ-1)); = */ =20 @@ -390,11 +399,15 @@ static signed int recvframe_chkmic(struct adapter *ad= apter, union recv_frame *p mickey =3D &stainfo->dot11tkiprxmickey.skey[0]; } =20 - datalen =3D precvframe->u.hdr.len-prxattrib->hdrlen-prxattrib->iv_len-p= rxattrib->icv_len-8;/* icv_len included the mic code */ + /* icv_len included the mic code */ + datalen =3D precvframe->u.hdr.len - prxattrib->hdrlen - + prxattrib->iv_len - prxattrib->icv_len - 8; pframe =3D precvframe->u.hdr.rx_data; - payload =3D pframe+prxattrib->hdrlen+prxattrib->iv_len; + payload =3D pframe + prxattrib->hdrlen + prxattrib->iv_len; =20 - rtw_seccalctkipmic(mickey, pframe, payload, datalen, &miccode[0], (unsi= gned char)prxattrib->priority); /* care the length of the data */ + /* care the length of the data */ + rtw_seccalctkipmic(mickey, pframe, payload, datalen, + &miccode[0], (unsigned char)prxattrib->priority); =20 pframemic =3D payload+datalen; =20 @@ -409,7 +422,10 @@ static signed int recvframe_chkmic(struct adapter *ada= pter, union recv_frame *p if (bmic_err =3D=3D true) { /* double check key_index for some timing issue , */ /* cannot compare with psecuritypriv->dot118021XGrpKeyid also cause t= iming issue */ - if ((is_multicast_ether_addr(prxattrib->ra) =3D=3D true) && (prxattri= b->key_index !=3D pmlmeinfo->key_index)) + bool is_mcast =3D is_multicast_ether_addr(prxattrib->ra); + bool key_mismatch =3D prxattrib->key_index !=3D pmlmeinfo->key_index; + + if (is_mcast && key_mismatch) brpt_micerror =3D false; =20 if (prxattrib->bdecrypted && brpt_micerror) @@ -463,28 +479,37 @@ static union recv_frame *decryptor(struct adapter *pa= dapter, union recv_frame *p } } =20 - if ((prxattrib->encrypt > 0) && ((prxattrib->bdecrypted =3D=3D 0) || (pse= curitypriv->sw_decrypt =3D=3D true))) { - psecuritypriv->hw_decrypted =3D false; + { + bool need_decrypt =3D prxattrib->encrypt > 0; + bool not_decrypted =3D !prxattrib->bdecrypted; + bool sw_decrypt =3D psecuritypriv->sw_decrypt; + bool decrypted_ok; =20 - switch (prxattrib->encrypt) { - case _WEP40_: - case _WEP104_: - rtw_wep_decrypt(padapter, (u8 *)precv_frame); - break; - case _TKIP_: - res =3D rtw_tkip_decrypt(padapter, (u8 *)precv_frame); - break; - case _AES_: - res =3D rtw_aes_decrypt(padapter, (u8 *)precv_frame); - break; - default: + if (need_decrypt && (not_decrypted || sw_decrypt)) { + psecuritypriv->hw_decrypted =3D false; + + switch (prxattrib->encrypt) { + case _WEP40_: + case _WEP104_: + rtw_wep_decrypt(padapter, (u8 *)precv_frame); + break; + case _TKIP_: + res =3D rtw_tkip_decrypt(padapter, (u8 *)precv_frame); + break; + case _AES_: + res =3D rtw_aes_decrypt(padapter, (u8 *)precv_frame); + break; + default: break; + } + } else { + decrypted_ok =3D prxattrib->bdecrypted =3D=3D 1 && + prxattrib->encrypt > 0 && + (psecuritypriv->busetkipkey =3D=3D 1 || + prxattrib->encrypt !=3D _TKIP_); + if (decrypted_ok) + psecuritypriv->hw_decrypted =3D true; } - } else if (prxattrib->bdecrypted =3D=3D 1 && prxattrib->encrypt > 0 && - (psecuritypriv->busetkipkey =3D=3D 1 || prxattrib->encrypt !=3D _TKIP= _) - ) { - psecuritypriv->hw_decrypted =3D true; - } else { } =20 if (res =3D=3D _FAIL) { @@ -564,7 +589,8 @@ static union recv_frame *portctrl(struct adapter *adapt= er, union recv_frame *pre return prtnframe; } =20 -static signed int recv_decache(union recv_frame *precv_frame, u8 bretry, s= truct stainfo_rxcache *prxcache) +static signed int recv_decache(union recv_frame *precv_frame, u8 bretry, + struct stainfo_rxcache *prxcache) { signed int tid =3D precv_frame->u.hdr.attrib.priority; =20 @@ -669,7 +695,8 @@ static void process_wmmps_data(struct adapter *padapter= , union recv_frame *precv } } =20 -static void count_rx_stats(struct adapter *padapter, union recv_frame *prf= rame, struct sta_info *sta) +static void count_rx_stats(struct adapter *padapter, union recv_frame *prf= rame, + struct sta_info *sta) { int sz; struct sta_info *psta =3D NULL; @@ -1149,7 +1176,8 @@ static union recv_frame *recvframe_defrag(struct adap= ter *adapter, } =20 /* check if need to defrag, if needed queue the frame to defrag_q */ -static union recv_frame *recvframe_chk_defrag(struct adapter *padapter, un= ion recv_frame *precv_frame) +static union recv_frame *recvframe_chk_defrag(struct adapter *padapter, + union recv_frame *precv_frame) { u8 ismfrag; u8 fragnum; @@ -1257,7 +1285,8 @@ static signed int validate_recv_mgnt_frame(struct ada= pter *padapter, union recv_ =20 { /* for rx pkt statistics */ - struct sta_info *psta =3D rtw_get_stainfo(&padapter->stapriv, GetAddr2Pt= r(precv_frame->u.hdr.rx_data)); + u8 *addr2 =3D GetAddr2Ptr(precv_frame->u.hdr.rx_data); + struct sta_info *psta =3D rtw_get_stainfo(&padapter->stapriv, addr2); =20 if (psta) { psta->sta_stats.rx_mgnt_pkts++; @@ -1622,7 +1651,8 @@ static signed int wlanhdr_to_ethhdr(union recv_frame = *precvframe) return _SUCCESS; } =20 -static struct sk_buff *rtw_alloc_msdu_pkt(union recv_frame *prframe, u16 n= Subframe_Length, u8 *pdata) +static struct sk_buff *rtw_alloc_msdu_pkt(union recv_frame *prframe, + u16 nSubframe_Length, u8 *pdata) { u16 eth_type; struct sk_buff *sub_skb; @@ -1662,7 +1692,8 @@ static struct sk_buff *rtw_alloc_msdu_pkt(union recv_= frame *prframe, u16 nSubfra return sub_skb; } =20 -static void rtw_recv_indicate_pkt(struct adapter *padapter, struct sk_buff= *pkt, struct rx_pkt_attrib *pattrib) +static void rtw_recv_indicate_pkt(struct adapter *padapter, struct sk_buff= *pkt, + struct rx_pkt_attrib *pattrib) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 @@ -1816,7 +1847,8 @@ static int check_indicate_seq(struct recv_reorder_ctr= l *preorder_ctrl, u16 seq_n return true; } =20 -static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ct= rl, union recv_frame *prframe) +static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ct= rl, + union recv_frame *prframe) { struct rx_pkt_attrib *pattrib =3D &prframe->u.hdr.attrib; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; @@ -1861,7 +1893,8 @@ static int enqueue_reorder_recvframe(struct recv_reor= der_ctrl *preorder_ctrl, un =20 } =20 -static void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, u6= 4 prev_seq, u64 current_seq) +static void recv_indicatepkts_pkt_loss_cnt(struct debug_priv *pdbgpriv, + u64 prev_seq, u64 current_seq) { if (current_seq < prev_seq) pdbgpriv->dbg_rx_ampdu_loss_count +=3D (4096 + current_seq - prev_seq); @@ -1907,7 +1940,9 @@ static int rtw_recv_indicatepkt(struct adapter *padap= ter, union recv_frame *prec return _FAIL; } =20 -static int recv_indicatepkts_in_order(struct adapter *padapter, struct rec= v_reorder_ctrl *preorder_ctrl, int bforced) +static int recv_indicatepkts_in_order(struct adapter *padapter, + struct recv_reorder_ctrl *preorder_ctrl, + int bforced) { struct list_head *phead, *plist; union recv_frame *prframe; @@ -2115,7 +2150,8 @@ static int process_recv_indicatepkts(struct adapter *= padapter, union recv_frame if (phtpriv->ht_option =3D=3D true) { /* B/G/N Mode */ /* prframe->u.hdr.preorder_ctrl =3D &precvpriv->recvreorder_ctrl[pattrib= ->priority]; */ =20 - if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { /* inc= luding perform A-MPDU Rx Ordering Buffer Control */ + /* including perform A-MPDU Rx Ordering Buffer Control */ + if (recv_indicatepkt_reorder(padapter, prframe) !=3D _SUCCESS) { =20 if ((padapter->bDriverStopped =3D=3D false) && (padapter->bSurpriseRemoved =3D=3D false)) { @@ -2274,12 +2310,15 @@ static void rtw_signal_stat_timer_hdl(struct timer_= list *t) u8 avg_signal_qual =3D 0; u32 num_signal_strength =3D 0; u32 __maybe_unused num_signal_qual =3D 0; - u8 _alpha =3D 5; /* this value is based on converging_constant =3D 5000 = and sampling_interval =3D 1000 */ + /* based on converging_constant =3D 5000 and sampling_interval =3D 1000 */ + u8 _alpha =3D 5; =20 if (adapter->recvpriv.is_signal_dbg) { /* update the user specific value, signal_strength_dbg, to signal_streng= th, rssi */ - adapter->recvpriv.signal_strength =3D adapter->recvpriv.signal_strength_= dbg; - adapter->recvpriv.rssi =3D (s8)translate_percentage_to_dbm((u8)adapter->= recvpriv.signal_strength_dbg); + u8 strength_dbg =3D adapter->recvpriv.signal_strength_dbg; + + adapter->recvpriv.signal_strength =3D strength_dbg; + adapter->recvpriv.rssi =3D (s8)translate_percentage_to_dbm(strength_dbg); } else { =20 if (recvpriv->signal_strength_data.update_req =3D=3D 0) {/* update_req = is clear, means we got rx */ @@ -2297,9 +2336,11 @@ static void rtw_signal_stat_timer_hdl(struct timer_l= ist *t) } =20 if (num_signal_strength =3D=3D 0) { - if (rtw_get_on_cur_ch_time(adapter) =3D=3D 0 || - jiffies_to_msecs(jiffies - rtw_get_on_cur_ch_time(adapter)) < 2 * a= dapter->mlmeextpriv.mlmext_info.bcn_interval - ) { + unsigned long on_ch_time =3D rtw_get_on_cur_ch_time(adapter); + u32 bcn_intvl =3D adapter->mlmeextpriv.mlmext_info.bcn_interval; + + if (on_ch_time =3D=3D 0 || + jiffies_to_msecs(jiffies - on_ch_time) < 2 * bcn_intvl) { goto set_timer; } } --=20 2.52.0