From nobody Sun Feb 8 13:16:56 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013063.outbound.protection.outlook.com [40.93.201.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0E34285041 for ; Fri, 6 Feb 2026 06:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770357814; cv=fail; b=l9G044SjjdfhqUeT2oszS3mVGFfWSm0bB4SfpwPD/Nm9qQs4PJ3Q1GJaLvEVlVOH2S/aicwgkrsrT5KdpIGplHfsVyqXkWHycL3WN2NKjHOjJNVeSVSn6zBAs0PJaXVqixx8044Kz8azay36TYFVbpTqAO2nSbrnk8dWwYWPCz8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770357814; c=relaxed/simple; bh=XNywzYPBenHQWIR1m8ZOhpIxcn9W3gFx/SjFnFQV0A0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gHiFF5O22PCqWgzCEhYgW5sGXrWO3YVhQ1VxwjXUKEs1OS1YytAzCCOIlsSv1fovPNCuZXInWnH3jZXYfJxF1enPY2uJtjTrap0QB95EIJOpyynenz9A+wMxlcRaHlwyQwwFJSPyzMzNhMTfFMWvGk0qz1vP24xtAeiHBUtxeD0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eVgdk2L1; arc=fail smtp.client-ip=40.93.201.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eVgdk2L1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LmUOT/u+D6mB1VW39MrAwolSye3p05+gx5kcBex700SYZeHHGBp8F6EEb0AV/3bcqSWWpqsOm/mnGXtxvB7lW7XvBz+zrqLjC/4/gtdP3YxkDzj6M9J9SKyAPMu05nQ/REr1VYv6eP9REBejxDTSHuIq93owGLCGOV9Qp/aryaKphYJr03iEdiinRXXbxZUnmZLgRF9kR+zd2USYnCUMgvKw+Q0DdAIx0cejwGi9RvVvUz470btvY9eKKkTUxd2luaEJe4wDqy4yUjqbTfzxhX0jKA8U+s0KnHVG4z0lXSrVMMdxKPr3aZSCmBxs0qG/tYAzXRqMsZaQ57ZnvAC6MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jxGpOL5ETgFmMREocoawkzOkj7JN34zdhg2pExGG0hY=; b=uURK/R8qszOapTYYJ2NZjMowJ675UFaLd0cXf36UG2t3gg2jfMH2FjnA2R+xTc0HhFi3SQtbsmdsYicsQM45w1gu+Z/4jJEhqLk3FgZJLDFJsenk0HGOUGODBGxy8KQ7+37bFeEn2GloTmZDjX554br/9e+iEsJGcjONtQiPP6NfB7Gda7lpsrwCVNrOQ1+j08T9ZjP4mqDXJsdTXXHdL2DZh9cpACWL4OuXzXEXv8b/PcHkTVB6X5Zg9NTFiM9WEArOenD9SCPzpjPv+9yqdsW9xSksepVDP4pYjATfZ/A7NnHwXpr2p8NG+98oMOe6S28HANzZlrpi9MWVUQtWiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxGpOL5ETgFmMREocoawkzOkj7JN34zdhg2pExGG0hY=; b=eVgdk2L1te4Znyl0xHsD3IdyWZluKcoQftSUMhy4y3s9rEC+wm2yH0lUCTpQj4ewBxV1kXwnnbEjekz+Ng+shTiiCbTnyH8FA3o5I87lvaQ9s+dHA7Wbg+7Yq1J15wmvA4qNvKxF/7lcQhIJOqnAwF45Dt6rLCJcgKKddCyzVN4= Received: from BYAPR06CA0023.namprd06.prod.outlook.com (2603:10b6:a03:d4::36) by MN0PR12MB5739.namprd12.prod.outlook.com (2603:10b6:208:372::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.15; Fri, 6 Feb 2026 06:03:30 +0000 Received: from BY1PEPF0001AE17.namprd04.prod.outlook.com (2603:10b6:a03:d4:cafe::d) by BYAPR06CA0023.outlook.office365.com (2603:10b6:a03:d4::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9587.14 via Frontend Transport; Fri, 6 Feb 2026 06:03:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BY1PEPF0001AE17.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.10 via Frontend Transport; Fri, 6 Feb 2026 06:03:30 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 6 Feb 2026 00:03:12 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 5 Feb 2026 22:03:12 -0800 Received: from xsjlizhih51.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 5 Feb 2026 22:03:11 -0800 From: Lizhi Hou To: , , , CC: Lizhi Hou , , , , Subject: [PATCH V1] accel/amdxdna: Fix crash when destroying a suspended hardware context Date: Thu, 5 Feb 2026 22:03:06 -0800 Message-ID: <20260206060306.4050531-1-lizhi.hou@amd.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE17:EE_|MN0PR12MB5739:EE_ X-MS-Office365-Filtering-Correlation-Id: 0de555ec-4ecc-4dd3-cc46-08de654573ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UktgcEJTuTP63apnnD7igTzp1+47TFauXDfI1Dt7Ga8nJiFU1nKA19MmE/QU?= =?us-ascii?Q?+qebD8hKFl58Kt5WNkZLZtg8v12fIy3+nF70nIYTVzTHO0oeOM4nv55wf8WY?= =?us-ascii?Q?1gd4TOUW70FM1nMz1ae2ZVKlQSo0zc3jQ7QpjFt8kz2CYr21Guzj7fpC4JAG?= =?us-ascii?Q?/NYw6I8zRkvOADb/BsfSPAMbn/e6KEYER8yjrCCRCcFjb6VjAyhKRlmhhSAf?= =?us-ascii?Q?djkX1D5WMpnK+yj7R7ZSZPweHSTHhvj8eF3GbV1o0mSL7NW/MiMHowLvKImj?= =?us-ascii?Q?OormkUc1uq3ym/VQQuV4z9Z4wpHqBoKwy2Vn+6xQwvYJxUR5EhAdcm4mBoK5?= =?us-ascii?Q?f60mm8AYmREC7DxvfaAzhYZQW44w6tM9cDc5QIBCBYO9OiHn5jCdOgaOHAIx?= =?us-ascii?Q?18BYfMqyjPeuygKfRklDlU4X1HphnMDKDNP7wPu0cj65zv/lk9REmygeURcX?= =?us-ascii?Q?xx8KMfh8TRLQaH9/o/xE0dXwwzakUqwAP/glhPQ3S7gzeG5fg+XmhINtae9k?= =?us-ascii?Q?yOhNcHBnBmLZrqhaLV05ewpbU9NvVTugRJ1v5vTMMGr995IquSNoQ7inAUYk?= =?us-ascii?Q?zv8SwklTkQJUsSKKXgep80agWPrvjeU6pDudBDh1TNVgZ9+2jeJhKo82+STQ?= =?us-ascii?Q?Fhr9iFvfDfGpfUmf+gd134YyrEIU5jZn+q/9yWOvpVh0LXuN9uJaNoHHNium?= =?us-ascii?Q?eezUgOq5uzZJk7KRgU5P0xFN2z2RsiFg25YtbnJ29+u2gw6BTSjNUuUduk2O?= =?us-ascii?Q?cc/sXDQxnT8IK/Ihe/XEnfiSMEW3fIP3C6ladtidHfT43y0nhBfNE8yecs/n?= =?us-ascii?Q?GsucOJyZLbcGTEM0JUIkOc1gi946iFJGJSrSUOOl8oL+DHIFwWa4IN2drstb?= =?us-ascii?Q?+dQ3Yd16WX2nReQGkOgnEw7aSfziNbquoGXOkhG22U+J9AfdOCq31dPiMLVQ?= =?us-ascii?Q?qYskHWmQ3OF4qTjull3PnxmIv0qM6IzOXxxs4NVyP36PHbVVuqENGWCQ4WdE?= =?us-ascii?Q?eGMEmdwVIscQJ0B/YlMELyhtPnKeE7add3VwloMgRrHcqF5brffg7M/lBbiE?= =?us-ascii?Q?02ozkG33vvSVhQ+kWLLqLz9bhNAQQ2D1LLFMfdCV2GcPf0rCDWX9shxpIkD+?= =?us-ascii?Q?1JaW9mtLmZzy0wz+bQdycVu8UySMMG3sRgJwvK9vg6Wwx9qswvVqJyKsJd7G?= =?us-ascii?Q?jmZIu1UneVFOQPS6MrhdeKT/HN+hgK3NvYRMOM6yRIb+lGjzgk23Zyb+qkav?= =?us-ascii?Q?6VVzSjjk78N1xyk0Z80ikRY+rxcWSPy9eOxdW4k1pu5SjXmqKA4KDAk7b5Ld?= =?us-ascii?Q?BCB259gOoUVtmJJOasch9yu/RTH5R78SqnrzAINLKSIM2lSBz7yOXoD+q6qJ?= =?us-ascii?Q?ru2WTvPG+GvwgR7ZsQyN+gf/Qzi82OZFv2c3TwJfCK0Lil4D/nI2wJhrWuq3?= =?us-ascii?Q?I3okznup5nhpv2RTDSHHz3MFiU6/gmtC+4ZJ2KS9HZfbIEuqw4Dwn7vxcEqs?= =?us-ascii?Q?rtwpoinbM/oody8dKTaFMsgZAEPbQqWW7g2tk4ay2dEOZNfE2S8/6iPSqEY+?= =?us-ascii?Q?Sd+g7bcN9rWf1XOOKPQ2egntCPmth0/XWjk1w94fW2kmJjTEPG3B6GsVPp7S?= =?us-ascii?Q?eWXAs+yG3M0qQAV531/ChHN8r2/bWz4uRjpjuBw4M48J45SP9MKrXxwh4kvF?= =?us-ascii?Q?9RQbUQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: J6dtuI9GEI6V2YmAQxJvno34fWC+yHLwxgTUhYdBRiFZ1DRaqUv5reruwbsw7F4KsVdghoKsngWERmfbkvdkcAYL4A2t1olDPpErx2HEGaejp720d9wFHhVDENRwzWq2HSWmRuybHx1voqYZKhRYwdzyrpRNqqMWoQjBYZSbcO4t9cN75vzGzoyRiqC62rVsyEb00Jk5Vs1bI/SIVDXMYZ2yfp88iMoYi/FICTYlu8npLkRUNObhBdcu+Wxcgdvk6JHwFKfI28i2PvQ6TW87A+VsQEHgF8jNNni/EWAnPE9Q9o8EAaYy9FTodTIh2rx8jlqtDczdrQi3Q3phsxutNNbkqwxavjhpOHwyjlwEhEm+FTcAn8ztjEywe1r1kCs+oXMa3sktlotp9zDortqlkMv3dJrK5VzMxed6gYVKeIphi5NBfhu2wgdkT4EmIvKJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2026 06:03:30.5146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0de555ec-4ecc-4dd3-cc46-08de654573ff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE17.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5739 Content-Type: text/plain; charset="utf-8" If userspace issues an ioctl to destroy a hardware context that has already been automatically suspended, the driver may crash because the mailbox channel pointer is NULL for the suspended context. Fix this by checking the mailbox channel pointer in aie2_destroy_context() before accessing it. Fixes: 97f27573837e ("accel/amdxdna: Fix potential NULL pointer dereference= in context cleanup") Signed-off-by: Lizhi Hou Reviewed-by: Karol Wachowski --- drivers/accel/amdxdna/aie2_message.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/accel/amdxdna/aie2_message.c b/drivers/accel/amdxdna/a= ie2_message.c index 7d7dcfeaf794..ab1178850c47 100644 --- a/drivers/accel/amdxdna/aie2_message.c +++ b/drivers/accel/amdxdna/aie2_message.c @@ -318,6 +318,9 @@ int aie2_destroy_context(struct amdxdna_dev_hdl *ndev, = struct amdxdna_hwctx *hwc struct amdxdna_dev *xdna =3D ndev->xdna; int ret; =20 + if (!hwctx->priv->mbox_chann) + return 0; + xdna_mailbox_stop_channel(hwctx->priv->mbox_chann); ret =3D aie2_destroy_context_req(ndev, hwctx->fw_ctx_id); xdna_mailbox_destroy_channel(hwctx->priv->mbox_chann); --=20 2.34.1