From nobody Sun Feb 8 21:41:35 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC3623382EE for ; Fri, 6 Feb 2026 04:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770351009; cv=none; b=klk5mJoRbVvOJUYuo8L3tJZZfKz22X3diwTxuA70iPfq0QT7o1d6S7g6dRQhP9Eh2OZSp4+fWODGKkvkj3JUoLRMJ88ERicE0aMUu6kfGcZeXFW2eTWzGCt5Ird/F3Aw2SiuPtiTx4czdYkyCu2kxrKmTn5jAIHzFqgSgoMRzKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770351009; c=relaxed/simple; bh=8MdRWI9SHhywt8LjUMQ9GfPbf4bQ2hUC4FI+IzhADPM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DYz/1bTsmioc1x7dNNVZA0gd4R1/SswlQ3HJHxTtmug/PhZrVmGxKHobFDyiN2LulIMbGjJvRaj12EnUJwVHznDJl3gfucMjczAvNYi1pXrpUQZL66GaJGN12p2AGvn6wUAnja8NixQ3zKe74OpLbzfXBH9nLZG6Kaf+Oz4HgKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-03 (Coremail) with SMTP id rQCowABnhdyQaYVpbvXIBw--.53077S2; Fri, 06 Feb 2026 12:09:52 +0800 (CST) From: Chen Ni To: andy.yan@rock-chips.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, rgallaispou@gmail.com, luca.ceresoli@bootlin.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chen Ni , Andy Yan Subject: [PATCH v4] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind() Date: Fri, 6 Feb 2026 12:06:21 +0800 Message-Id: <20260206040621.4095517-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowABnhdyQaYVpbvXIBw--.53077S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KFykJw47CF1DtF1fCry3Arb_yoW8GF4fpF 4xJa15Kr9YqF43tayUCF1xCFnxAa4kt3yfu3y7Xw4Ivwn7WF1jy39FyrW3tr1DWa1UCF1Y yrs8Xr4fCF1jkaUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9E14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wrylc2xSY4AK67AK6r45MxAIw28IcxkI7VAKI4 8JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xv wVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjx v20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267 AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sR_PEfUUUUUU== X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" Return the value of devm_drm_bridge_add() in order to propagate the error properly, if it fails due to resource allocation failure or bridge registration failure. This ensures that the bind function fails safely rather than proceeding with a potentially incomplete bridge setup. Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before attach= ing") Signed-off-by: Chen Ni Reviewed-by: Andy Yan --- Changes in v4: - Add Reviewed-by tag from Andy Yan Changes in v3: - Remove dev_err_probe() logging Changes in v2: - Use ERR_PTR() instead of dev_err_ptr_probe() --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 432342452484..07f7a2e0d9f2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -2049,7 +2049,9 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct d= rm_encoder *encoder, bridge->type =3D DRM_MODE_CONNECTOR_DisplayPort; bridge->ycbcr_420_allowed =3D true; =20 - devm_drm_bridge_add(dev, bridge); + ret =3D devm_drm_bridge_add(dev, bridge); + if (ret) + return ERR_PTR(ret); =20 dp->aux.dev =3D dev; dp->aux.drm_dev =3D encoder->dev; --=20 2.25.1