From nobody Mon Feb 9 02:12:57 2026 Received: from out198-12.us.a.mail.aliyun.com (out198-12.us.a.mail.aliyun.com [47.90.198.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82AF024EAB1; Fri, 6 Feb 2026 02:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=47.90.198.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770344322; cv=none; b=RWOho7sUeZudRHa+mXvNNsWU8Pn+GlUk7hraVJRvqoU+ck/XgBTEKdou8eKrPFa59ZPuNpaQSJT472OoNy5moANr5hzxi1UH9bMiqe5bEg1VSnpz4IaJx2vW0nd2KEvTR9PqWwJoFXnYoIcwKCcouKL3VeEDpZmoXN6gkxxQZjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770344322; c=relaxed/simple; bh=AL3AZhPBmEc7Xa/w9zmQ7fwqMbLqwtO+LeyqPBccKgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cjvI3kpszx5J9fYmVoeSuaZ+WS79/kIRPuLYI34H4tVYRkqGlTK8QcIA+cF4SnqsuGLgnHPVMvchejo6m5jO+vx5GTO0/WqLISFuVDpDFjvukh0riI9vYF8qL1+uWUW/9VTj8jd0nLRpmE/YZBovac4R35lhJbYPI6g7us5wpwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nebula-matrix.com; spf=pass smtp.mailfrom=nebula-matrix.com; arc=none smtp.client-ip=47.90.198.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nebula-matrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nebula-matrix.com Received: from localhost.localdomain(mailfrom:illusion.wang@nebula-matrix.com fp:SMTPD_---.gQHg4s4_1770344300 cluster:ay29) by smtp.aliyun-inc.com; Fri, 06 Feb 2026 10:18:21 +0800 From: "illusion.wang" To: dimon.zhao@nebula-matrix.com, illusion.wang@nebula-matrix.com, alvin.wang@nebula-matrix.com, sam.chen@nebula-matrix.com, netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, corbet@lwn.net, kuba@kernel.org, linux-doc@vger.kernel.org, lorenzo@kernel.org, pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev, lukas.bulwahn@redhat.com, edumazet@google.com, linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 net-next 10/11] net/nebula-matrix: add common/ctrl dev init/reinit operation Date: Fri, 6 Feb 2026 10:16:02 +0800 Message-ID: <20260206021608.85381-11-illusion.wang@nebula-matrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260206021608.85381-1-illusion.wang@nebula-matrix.com> References: <20260206021608.85381-1-illusion.wang@nebula-matrix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Common Device Setup: nbl_dev_setup_common_dev configures mailbox queues, registers cleanup tasks, and requests IRQs. Control Device Setup (optional): nbl_dev_setup_ctrl_dev initializes the chip and configures all channel queues. Signed-off-by: illusion.wang --- .../nebula-matrix/nbl/nbl_core/nbl_dev.c | 178 ++++++++++++++++++ .../nebula-matrix/nbl/nbl_core/nbl_dev.h | 35 ++++ 2 files changed, 213 insertions(+) diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c b/dr= ivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c index fd7c97f3b0fe..9927dd3a1791 100644 --- a/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c @@ -6,6 +6,164 @@ =20 #include "nbl_dev.h" =20 +static void nbl_dev_register_common_irq(struct nbl_dev_mgt *dev_mgt) +{ + struct nbl_dev_common *dev_common =3D dev_mgt->common_dev; + struct nbl_msix_info *msix_info =3D &dev_common->msix_info; + + msix_info->serv_info[NBL_MSIX_MAILBOX_TYPE].num =3D 1; +} + +/* ---------- Channel config ---------- */ +static int nbl_dev_setup_chan_qinfo(struct nbl_dev_mgt *dev_mgt, u8 chan_t= ype) +{ + struct nbl_channel_ops *chan_ops =3D dev_mgt->chan_ops_tbl->ops; + struct nbl_channel_mgt *priv =3D dev_mgt->chan_ops_tbl->priv; + struct device *dev =3D dev_mgt->common->dev; + int ret =3D 0; + + if (!chan_ops->check_queue_exist(priv, chan_type)) + return 0; + + ret =3D chan_ops->cfg_chan_qinfo_map_table(priv, chan_type); + if (ret) + dev_err(dev, "setup chan:%d, qinfo map table failed\n", + chan_type); + + return ret; +} + +static int nbl_dev_setup_chan_queue(struct nbl_dev_mgt *dev_mgt, u8 chan_t= ype) +{ + struct nbl_channel_ops *chan_ops =3D dev_mgt->chan_ops_tbl->ops; + struct nbl_channel_mgt *priv =3D dev_mgt->chan_ops_tbl->priv; + int ret =3D 0; + + if (chan_ops->check_queue_exist(priv, chan_type)) + ret =3D chan_ops->setup_queue(priv, chan_type); + + return ret; +} + +static int nbl_dev_remove_chan_queue(struct nbl_dev_mgt *dev_mgt, u8 chan_= type) +{ + struct nbl_channel_ops *chan_ops =3D dev_mgt->chan_ops_tbl->ops; + struct nbl_channel_mgt *priv =3D dev_mgt->chan_ops_tbl->priv; + int ret =3D 0; + + if (chan_ops->check_queue_exist(priv, chan_type)) + ret =3D chan_ops->teardown_queue(priv, chan_type); + + return ret; +} + +static void nbl_dev_register_chan_task(struct nbl_dev_mgt *dev_mgt, + u8 chan_type, struct work_struct *task) +{ + struct nbl_channel_ops *chan_ops =3D dev_mgt->chan_ops_tbl->ops; + + if (chan_ops->check_queue_exist(dev_mgt->chan_ops_tbl->priv, chan_type)) + chan_ops->register_chan_task(dev_mgt->chan_ops_tbl->priv, + chan_type, task); +} + +/* ---------- Tasks config ---------- */ +static void nbl_dev_clean_mailbox_task(struct work_struct *work) +{ + struct nbl_dev_common *common_dev =3D + container_of(work, struct nbl_dev_common, clean_mbx_task); + struct nbl_dev_mgt *dev_mgt =3D common_dev->dev_mgt; + struct nbl_channel_ops *chan_ops =3D dev_mgt->chan_ops_tbl->ops; + + chan_ops->clean_queue_subtask(dev_mgt->chan_ops_tbl->priv, + NBL_CHAN_TYPE_MAILBOX); +} + +/* ---------- Dev init process ---------- */ +static int nbl_dev_setup_common_dev(struct nbl_adapter *adapter, + struct nbl_init_param *param) +{ + struct nbl_dev_mgt *dev_mgt =3D + (struct nbl_dev_mgt *)NBL_ADAP_TO_DEV_MGT(adapter); + struct nbl_dispatch_ops *disp_ops =3D dev_mgt->disp_ops_tbl->ops; + struct nbl_dispatch_mgt *priv =3D dev_mgt->disp_ops_tbl->priv; + struct nbl_common_info *common =3D dev_mgt->common; + struct nbl_dev_common *common_dev; + + common_dev =3D devm_kzalloc(&adapter->pdev->dev, + sizeof(struct nbl_dev_common), GFP_KERNEL); + if (!common_dev) + return -ENOMEM; + common_dev->dev_mgt =3D dev_mgt; + + if (nbl_dev_setup_chan_queue(dev_mgt, NBL_CHAN_TYPE_MAILBOX)) + goto setup_chan_fail; + + INIT_WORK(&common_dev->clean_mbx_task, nbl_dev_clean_mailbox_task); + common->vsi_id =3D disp_ops->get_vsi_id(priv, 0, NBL_VSI_DATA); + disp_ops->get_eth_id(priv, common->vsi_id, + &common->eth_mode, &common->eth_id, + &common->logic_eth_id); + + nbl_dev_register_chan_task(dev_mgt, NBL_CHAN_TYPE_MAILBOX, + &common_dev->clean_mbx_task); + + dev_mgt->common_dev =3D common_dev; + nbl_dev_register_common_irq(dev_mgt); + return 0; + +setup_chan_fail: + return -EFAULT; +} + +static void nbl_dev_remove_common_dev(struct nbl_adapter *adapter) +{ + struct nbl_dev_mgt *dev_mgt =3D + (struct nbl_dev_mgt *)NBL_ADAP_TO_DEV_MGT(adapter); + struct nbl_dev_common *common_dev =3D dev_mgt->common_dev; + + if (!common_dev) + return; + + nbl_dev_register_chan_task(dev_mgt, NBL_CHAN_TYPE_MAILBOX, NULL); + cancel_work_sync(&common_dev->clean_mbx_task); + nbl_dev_remove_chan_queue(dev_mgt, NBL_CHAN_TYPE_MAILBOX); +} + +static int nbl_dev_setup_ctrl_dev(struct nbl_adapter *adapter, + struct nbl_init_param *param) +{ + struct nbl_dev_mgt *dev_mgt =3D + (struct nbl_dev_mgt *)NBL_ADAP_TO_DEV_MGT(adapter); + struct nbl_dispatch_ops *disp_ops =3D dev_mgt->disp_ops_tbl->ops; + int i, ret =3D 0; + + ret =3D disp_ops->init_chip_module(dev_mgt->disp_ops_tbl->priv); + if (ret) + goto chip_init_fail; + + for (i =3D 0; i < NBL_CHAN_TYPE_MAX; i++) { + ret =3D nbl_dev_setup_chan_qinfo(dev_mgt, i); + if (ret) + goto setup_chan_q_fail; + } + + return 0; +setup_chan_q_fail: + disp_ops->deinit_chip_module(dev_mgt->disp_ops_tbl->priv); +chip_init_fail: + return ret; +} + +static void nbl_dev_remove_ctrl_dev(struct nbl_adapter *adapter) +{ + struct nbl_dev_mgt *dev_mgt =3D + (struct nbl_dev_mgt *)NBL_ADAP_TO_DEV_MGT(adapter); + struct nbl_dispatch_ops *disp_ops =3D dev_mgt->disp_ops_tbl->ops; + + disp_ops->deinit_chip_module(dev_mgt->disp_ops_tbl->priv); +} + static int nbl_dev_setup_dev_mgt(struct nbl_common_info *common, struct nbl_dev_mgt **dev_mgt) { @@ -35,13 +193,33 @@ int nbl_dev_init(struct nbl_adapter *adapter, struct n= bl_init_param *param) =20 (*dev_mgt)->disp_ops_tbl =3D disp_ops_tbl; (*dev_mgt)->chan_ops_tbl =3D chan_ops_tbl; + + ret =3D nbl_dev_setup_common_dev(adapter, param); + if (ret) + goto setup_common_dev_fail; + + if (common->is_ctrl) { + ret =3D nbl_dev_setup_ctrl_dev(adapter, param); + if (ret) + goto setup_ctrl_dev_fail; + } + return 0; + +setup_ctrl_dev_fail: + nbl_dev_remove_common_dev(adapter); +setup_common_dev_fail: setup_mgt_fail: return ret; } =20 void nbl_dev_remove(struct nbl_adapter *adapter) { + struct nbl_common_info *common =3D &adapter->common; + + if (common->is_ctrl) + nbl_dev_remove_ctrl_dev(adapter); + nbl_dev_remove_common_dev(adapter); } =20 /* ---------- Dev start process ---------- */ diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.h b/dr= ivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.h index d41ba06d00fb..1d48a91cd230 100644 --- a/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.h +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.h @@ -9,10 +9,45 @@ =20 #include "nbl_core.h" =20 +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | \ + NETIF_MSG_LINK | NETIF_MSG_IFDOWN | \ + NETIF_MSG_IFUP) + +#define NBL_STRING_NAME_LEN 32 + +enum nbl_msix_serv_type { + /* virtio_dev has a config vector_id, and the vector_id need is 0 */ + NBL_MSIX_VIRTIO_TYPE =3D 0, + NBL_MSIX_NET_TYPE, + NBL_MSIX_MAILBOX_TYPE, + NBL_MSIX_TYPE_MAX +}; + +struct nbl_msix_serv_info { + char irq_name[NBL_STRING_NAME_LEN]; + u16 num; + u16 base_vector_id; + /* true: hw report msix, hw need to mask actively */ + bool hw_self_mask_en; +}; + +struct nbl_msix_info { + struct nbl_msix_serv_info serv_info[NBL_MSIX_TYPE_MAX]; +}; + +struct nbl_dev_common { + struct nbl_dev_mgt *dev_mgt; + struct nbl_msix_info msix_info; + char mailbox_name[NBL_STRING_NAME_LEN]; + // for ctrl-dev/net-dev mailbox recv msg + struct work_struct clean_mbx_task; +}; + struct nbl_dev_mgt { struct nbl_common_info *common; struct nbl_dispatch_ops_tbl *disp_ops_tbl; struct nbl_channel_ops_tbl *chan_ops_tbl; + struct nbl_dev_common *common_dev; }; =20 #endif --=20 2.47.3