From nobody Tue Feb 10 14:33:12 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2593A0B2A for ; Fri, 6 Feb 2026 11:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770376711; cv=none; b=ryYgXZlQZy8bcZ8HtyKNqfev20YEznahwKjKr/RfrBA2Cei2iXK/F5+Ye9ptePpZGw4Xo5tc1KfC2hb9SYVz3vDqHBU4qe7ZNcGwz+ffMPtOQiMQhTM62CNJJoZuOnpwpbqO2aPySYXKHKuOpbZ6Z5fNQD3useSpqgCkmy4UN3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770376711; c=relaxed/simple; bh=V/jDZdY2a2x9VKVaT+HOgDdYxx2fx37Ib0WZgygLBV0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fkYqFGUlqE1aPEaa8PVGjO5WytrWXGkUkc19f24D6cw0+SV6Vp75f7Ls+1omK/JYZ7ICk6p3P721iltDMVWbw/NqpyqZZyi6dyeErbDCiKlk6xd1nM9RfjixkfrGWd3zHolsN5rZQjErJ983owd0ABRtyorr4gGptf6Ac4RT1uI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=tjkXMfNL; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="tjkXMfNL" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=NPa0rZndPCc94/FxYtt9K3I5hLAfnA+wDRnQ3Iwl8z8=; b=tjkXMfNLP8IWSDNmWGEHJrGfYb 3dQNDBBCL56op6sXBFN0VVERe2H10tNEEXq6uEKLFoCU4+S39vCr/+9boFV0JkcGBY2tH4U26PxP6 KVmgr2Pu1qYOYe/7522I8g2HyCCXsLG44jqGo47dhnJgHGOhLc8g3GgcHPOOyaQ49uXLbrrebs8mk bfc/kXG+CqJ9a8puFH6hLC3Sfa31Zcwr8nbMj2HSZer4qfWb+52RkTYBknLCgoN81rKqpTp/VDiZh HvbpXJIKJDohqZ2aq+j6VeFMAYREY9zoJPT4DXS20onOvrrLYmiXnXAUWyB+FQdQvqBHwxqD2knlF 5b/W7k1g==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1voJqw-0077ap-6l; Fri, 06 Feb 2026 11:18:22 +0000 From: Breno Leitao Date: Fri, 06 Feb 2026 03:18:02 -0800 Subject: [PATCH 2/2] workqueue: replace BUG_ON with panic in panic_on_wq_watchdog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260206-wqstall_panic_time-v1-2-f2a21d5d87a4@debian.org> References: <20260206-wqstall_panic_time-v1-0-f2a21d5d87a4@debian.org> In-Reply-To: <20260206-wqstall_panic_time-v1-0-f2a21d5d87a4@debian.org> To: Tejun Heo , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, osandov@osandov.com, rneu@meta.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=1391; i=leitao@debian.org; h=from:subject:message-id; bh=V/jDZdY2a2x9VKVaT+HOgDdYxx2fx37Ib0WZgygLBV0=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBphc3zwBAzoF+Gc+qu+m3GXzXVxn3US3/nuondZ 9MxBscgjvSJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaYXN8wAKCRA1o5Of/Hh3 bbWGEACDdfI6iTL7TXxwsaPsJV2Ivk7VtbEstepCHJMuC1IrdhmpIFRzP7zT66K44qq36NdH7WX vrdwHx+p8ezkBGjXeQmportIRT4bjmzLeWJ4kC9U5aHJf58386nazO98D/XZ/IA2XJd6eMdjIKS Y2N07arnYGQZgP25uIOs6dv1nS0GdGoCl3L694OaJKRTYX3mk6hn/kyy/zFuTOAssrEBS6vwVeN lKsN8s7j8iQH0EQI/TIOpOM0HMlnk+FyIzw5GEZrsJlBywqzOZMRLX+vJsKiSlDNFh0EX5huN+v H/7UmILwKDluhGBxFiX8eSSRzifaW/9IyEl7xb6z4oi+Zk8PUN0XoJGPWmQNJI1HbRqRP959Hpd QAQ4zZotO+1ao/PccNb8FiKbjAGo3j7qvuPdVRbaz8nUBZXrzD2hBTClZdlNvJGQ3ggUxDCpITF 9SpLwW+osLQAT9W71DY/t1wST66hFdi6CODahglSkizrgi1J4E8rOm31z/Qodz+0CkxE40oQpjR XqmPcZvjtbA/O5aWb4klzGFqRW2s5cSJNlLXweJALTUKxMkF+4OF0G0Ad4+261OlzUMzsjwoOsz ZrWYrFDSPj88A5XhctkB9NFj07Pa2tGR4qWziZZ47GFyO9sIinzuyw63TOVKduDgkLnKsha/zTy i6cgIrk2psGYhFA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Replace BUG_ON() with panic() in panic_on_wq_watchdog(). This is not a bug condition but a deliberate forced panic requested by the user via module parameters to crash the system for debugging purposes. Using panic() instead of BUG_ON() makes this intent clearer and provides more informative output about which threshold was exceeded and the actual values, making it easier to diagnose the stall condition from crash dumps. Signed-off-by: Breno Leitao --- kernel/workqueue.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 6f63899dd6317..754833b383fe9 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -7574,10 +7574,14 @@ static void panic_on_wq_watchdog(unsigned int stall= _time_sec) =20 if (wq_panic_on_stall) { wq_stall++; - BUG_ON(wq_stall >=3D wq_panic_on_stall); + if (wq_stall >=3D wq_panic_on_stall) + panic("workqueue: %u stall(s) exceeded threshold %u\n", + wq_stall, wq_panic_on_stall); } =20 - BUG_ON(wq_panic_on_stall_time && stall_time_sec >=3D wq_panic_on_stall_ti= me); + if (wq_panic_on_stall_time && stall_time_sec >=3D wq_panic_on_stall_time) + panic("workqueue: stall lasted %us, exceeding threshold %us\n", + stall_time_sec, wq_panic_on_stall_time); } =20 static void wq_watchdog_reset_touched(void) --=20 2.47.3