From nobody Tue Feb 10 03:44:33 2026 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E35E2E2DD2 for ; Fri, 6 Feb 2026 16:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770393756; cv=none; b=R1KhY+F8gaiPgjK9ny6F/t7W3YjJExCzRVz391lp5dUGBRBYroPdOsCTqZoeOCLs4S03B6a2wR21LxwKBSq76ZnCueb/edZIM/ugNH3l1wLi3aLR8MzexsXGOf7sr7VyLnFXcQx9L4frdOjN0j9rnwz3W/8IoeFFxUDbbAuKODs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770393756; c=relaxed/simple; bh=fChwIFKJfTPixFLygc7esVQKSwCogVhWPR6FrdOBr90=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=AZCCtbPNJPQBOAOf/Xjo5/MNqlpaqLJWVA+MqwIclsnKTkT/ldWansOfCJW1k74wTAMy4DIDgNUj3+LWy2/X0w4Rf3zFCvBVZM2C3RfL/WkaiK5BzqNlGJDPF/DUqAHqjhbvl1CbESuY8+q+bUtzXPU6Aawv+e4SQX8aOaVuxU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=Jbne3fBY; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="Jbne3fBY" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 616Co5nX3947023; Fri, 6 Feb 2026 16:02:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=j sxJqiLUnY8rGRevMOdGLFvbqwbIzPT3L79SxDSTwcE=; b=Jbne3fBYxIqb5Urbp Mfd9ji5cPyyp8PeelbJYSCrXBYQLxusNuPLlxr3TZY7S+8pHSuLsrMuOTCnK6hKp ep6PRwUIBpTYuOldGqsXW+NSHxkUEW8bEBwFQRuBzx3yVhbm7no1DnYhH8oI3xiN qdoW4hfb3L7QW5Q1BJ6zQBCCIJITuU7g5L1EL3FD8qC0OehVDVD+q49b+/dl+hcz R9p8FpC+L7VN5JM4wIsXFTcOVdjjRcb8RDqaBQnCiAp89faPu8PjU+3L8jeOnOqq ZvkVLM5ii6Mz4ksU91K+80T9Y7+0VVmOYGpXQZUCCAT3xJp5g7bDnuTCI6kXD5H7 D/UWg== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4c4jfy15k0-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Feb 2026 16:02:19 +0000 (GMT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa (172.25.6.240) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 6 Feb 2026 16:02:17 +0000 From: Matt Coster Date: Fri, 6 Feb 2026 16:02:12 +0000 Subject: [PATCH 1/2] drm/imagination: Improve handling of unknown FWCCB commands Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260206-improve-bad-fwccb-cmd-v1-1-831a852ca127@imgtec.com> References: <20260206-improve-bad-fwccb-cmd-v1-0-831a852ca127@imgtec.com> In-Reply-To: <20260206-improve-bad-fwccb-cmd-v1-0-831a852ca127@imgtec.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Frank Binns , Brajesh Gupta , Alessio Belle , Alexandru Dadu , , , "Matt Coster" X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1590; i=matt.coster@imgtec.com; h=from:subject:message-id; bh=fChwIFKJfTPixFLygc7esVQKSwCogVhWPR6FrdOBr90=; b=owGbwMvMwCFWuUfy8817WRsYT6slMWS2CXRIHjD0e7X6qCPL+5Abnw+UBO1ztebhdt2zNEXEl uN0lf3TjlIWBjEOBlkxRZYdKyxXqP1R05K48asYZg4rE8gQBi5OAZiIWBPD//SHN/Uuylbysfat fFicNi8m0t+2/vTlLa2xLYv+3LYTmsXIMIX1iqKGwet7EYlqlUtMPy5et76B6RbbvI/ZBwsNJTR mswAA X-Developer-Key: i=matt.coster@imgtec.com; a=openpgp; fpr=05A40CFCE7269D61D97100A1747F0A9036F90DFA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDExNiBTYWx0ZWRfX6TV0IfIwIG6g 3xGP/F7YFSasKCuNjEA6nvLOssR1PcHBjqO1+jvJ9BhXNQ/98bbJY2JIEVSOWbRT9yf5uiPpwLb a2cnC2Le1rCVZ6cj50KFPr93g2vsTRsXqmwmYMb5Adc+O0EtAB2jPw9PRQiQRuvoajuXFe/VNxc pLsrx9jxqZADYy+NZZz+iwfNvu2l0iJd9do32alhWiKi+gUrnDK4x2CXVRTeC9oBzBIq5H7tkgX CBoG2T4fF5MsDn51DJEaF1w/rysCnXa2eJqd6/ASf4TBXtOrg0EUiOFfzgUBx1T5+JjbYZhytAR Y1OG4+y94+CBYqsew3RP9Sdom6YacEk5f/R5bc3rlsvrDmcvhFtqI9QhJTh7s5dlaijIOhC61Q+ 1+QRgKkfiz1jwDxBXh2TTsp2ay2q2BbkvtvzuJKlxz4ZdxwgHIdswY/2JFzkTsYbPFP3Hv310vK T+KVLaXmRZvEUn5xR4w== X-Proofpoint-ORIG-GUID: eLMdNHTRBjFBRMj2Olo3LMqnCvYcxZga X-Proofpoint-GUID: eLMdNHTRBjFBRMj2Olo3LMqnCvYcxZga X-Authority-Analysis: v=2.4 cv=GakaXAXL c=1 sm=1 tr=0 ts=6986108b cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=N16aOacbDtMA:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=r_1tXGB3AAAA:8 a=2tjIQZU-TntZS31si9wA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 A couple small changes: - Validate the magic value at the head of FWCCB commands, and - Mask off the magic value before logging unknown command types to make them easier to interpret on sight. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_ccb.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagin= ation/pvr_ccb.c index 9294b4ba1de7..2f4356a1e69f 100644 --- a/drivers/gpu/drm/imagination/pvr_ccb.c +++ b/drivers/gpu/drm/imagination/pvr_ccb.c @@ -136,6 +136,14 @@ pvr_ccb_slot_available_locked(struct pvr_ccb *pvr_ccb,= u32 *write_offset) static void process_fwccb_command(struct pvr_device *pvr_dev, struct rogue_fwif_fwccb_= cmd *cmd) { + struct drm_device *drm_dev =3D from_pvr_device(pvr_dev); + + if ((cmd->cmd_type & ROGUE_CMD_MAGIC_DWORD_MASK) !=3D ROGUE_CMD_MAGIC_DWO= RD_SHIFTED) { + drm_warn_once(drm_dev, "Received FWCCB command with bad magic value; ign= oring (type=3D0x%08x)\n", + cmd->cmd_type); + return; + } + switch (cmd->cmd_type) { case ROGUE_FWIF_FWCCB_CMD_REQUEST_GPU_RESTART: pvr_power_reset(pvr_dev, false); @@ -151,8 +159,8 @@ process_fwccb_command(struct pvr_device *pvr_dev, struc= t rogue_fwif_fwccb_cmd *c break; =20 default: - drm_info(from_pvr_device(pvr_dev), "Received unknown FWCCB command %x\n", - cmd->cmd_type); + drm_info(drm_dev, "Received unknown FWCCB command (type=3D%d)\n", + cmd->cmd_type & ~ROGUE_CMD_MAGIC_DWORD_MASK); break; } } --=20 2.52.0