From nobody Sun Feb 8 14:34:25 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A851627FD76 for ; Fri, 6 Feb 2026 15:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770391375; cv=none; b=SpPYAWkt4LfI0nrZbis4z23TeNMkYofDA5EG6PI4vEnGOLbUD2aopJUdkqmHrEf03tFq/hDs7RCwmCKMwEvadSLiL4ytFlTplgGu7rQf/I/d6wpGZ66DgJ7R2qwLObeQO8liBGYMGWuZyrPQt1Kt/FZe9OX0LfKXVSg5QU8Px5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770391375; c=relaxed/simple; bh=/uWkP9PRboKuarSSP8lQm3aJ6iCyGPv88mOWL97eiRA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=fvOCm46d0iSolGhIPxVxpz2RAtE2S+GaDdbRcMcnOyNlwXSTqB/tRxAimoM5rwW86y6Bc/XcL/DYPCWKjY2ks6Tju9K8UOo595yYvuX9tH+O8qws4GqtUD0MbE3tUAQvDxTCaw7BfWIttFZPP4ipczlwoLX7WFvkqaC6cvhvIyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=saQNwTSz; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="saQNwTSz" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6166P2a23365304; Fri, 6 Feb 2026 15:22:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=dk201812; bh=9oZWQ90f8Znx4+QfgbJnJ/P BmzuORBxJttyvLTtiYdE=; b=saQNwTSzVxQExpslpfnBD3vs+ZhV4Stf1ftsqIJ xvfaRl3CbejTjI39GS/xrawXjVY0ShKgTlBgoHQQNljT2vq2y1Xu6RK2b3SwyMCD WXbzXVdSPDPgNa5iyBKD4/iDPzVc7ZnWHRgNa6XPc67ii+wNDVeThz1MOeISi5wf 4KQOG+3qBCnfppRlE7RmgJy9v8M6UVWpMm12mhErmQ/9lNQW1fqLREUUGrAzwY4N AdH0jmK5nHBoDJgSYLsQUEROO6SZM4B4e0wloef0hMwvaJpPy/xws6U4Qs26yqyz q4GhMl7ZJE4tr8BNzzbCmkV7dJoN1PYFk3PF4/wBiIzH+tg== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4c4je3s9k6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Feb 2026 15:22:37 +0000 (GMT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa (172.25.6.240) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 6 Feb 2026 15:22:35 +0000 From: Matt Coster Date: Fri, 6 Feb 2026 15:22:25 +0000 Subject: [PATCH] drm/imagination: Correctly check strscpy() in pvr_gpuid_decode_string() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260206-gpuid-strlen-fix-v1-1-238144ce306e@imgtec.com> X-B4-Tracking: v=1; b=H4sIADEHhmkC/x2MQQqAMAzAviI9W5gFd/Ar4kFdNwsypVMRxv7u8 JhAkiGxCicYmgzKjyQ5YoWubWDd5hgYxVUGMmQNGYvhvMVhunTniF5e7C3R2nnnzEJQs1O56n8 5TqV8kp3doWIAAAA= X-Change-ID: 20260206-gpuid-strlen-fix-5622c1fdd0b2 To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Alexandru Dadu , Frank Binns , Brajesh Gupta , "Alessio Belle" , Dan Carpenter , , , "Matt Coster" X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=matt.coster@imgtec.com; h=from:subject:message-id; bh=/uWkP9PRboKuarSSP8lQm3aJ6iCyGPv88mOWL97eiRA=; b=owGbwMvMwCFWuUfy8817WRsYT6slMWS2sVvfyCniUNF4+L7+bfSjaPNN1ffOpOqK3jr2ZKbYv Cb7tK/2HaUsDGIcDLJiiiw7VliuUPujpiVx41cxzBxWJpAhDFycAjCRSdWMDB+srGdsz0kqUeCM 23NpCs+MfR/nTS8I3C/Be8Xq+vKmhZcZ/lms+9/f4W5wX1N8YVRkff++T6vNfDQN/xjsF7vyl/v nRyYA X-Developer-Key: i=matt.coster@imgtec.com; a=openpgp; fpr=05A40CFCE7269D61D97100A1747F0A9036F90DFA X-Authority-Analysis: v=2.4 cv=TpLrRTXh c=1 sm=1 tr=0 ts=6986073d cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=N16aOacbDtMA:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=r_1tXGB3AAAA:8 a=gkP2uFfr1Wp6lTKQhcoA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDExMSBTYWx0ZWRfXzkWz5bSrtl31 QeuhTjzZ4vq0w4ZEyLnP/pZ9HM1sHPv1lfulAPdgmQ7GPhuHQWsrQTvSD8eg0zHi27rV68tpIiN 5w66NZLX3w84QEov0UIupx7XxsjIzNGyW/zR/pycaMzse+97086RiRvE7DA1r20kRgFDj7yLycX reCJ1rsfF8vfmjx6/4FQ7Lux0DopkBLkOy0X3QeO34rmS1qcgIgJZKj88be6GAMzmpyuUCsmZHV hwD7mhal8qUbNQlcsUhp++Imqm4pxFmp3luVOEAhoFvRR7XdQI6OtLFWlmDijMtBkxWeEbTpIF8 D3Nxingj5hTNapaZvp5i9l+kFdUWcJwm1QwzLVJJAq7J+ve0qiUw4hdodcQrWfer2rsy0GTeUOn Ti5i6mou53+Fc6zQmD4fHjZYwH9pQ7czlCeEfcTbUqCbKzigyC/YFVURljKNpDpqaZZYINrzppz ohH/qGEKV6hyoUYi/lw== X-Proofpoint-GUID: IlOLAvp_9SlgfSkiAgXsBlRx2ELJEcRq X-Proofpoint-ORIG-GUID: IlOLAvp_9SlgfSkiAgXsBlRx2ELJEcRq The constant PVR_GPUID_STRING_MIN_LENGTH was defined with a U suffix, causing the return value of strscpy() to be promoted to unsigned before it could be checked for a negative errno. Fix this by stripping the U suffix from PVR_GPUID_STRING_MIN_LENGTH (and PVR_GPUID_STRING_MAX_LENGTH for consistency). Fixes: 3bf74137340a ("drm/imagination: Add gpuid module parameter") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/aYXvElClUKW_DY_I@stanley.mountain/ Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_device.h b/drivers/gpu/drm/ima= gination/pvr_device.h index cfda215e7428..d742d7c1ec93 100644 --- a/drivers/gpu/drm/imagination/pvr_device.h +++ b/drivers/gpu/drm/imagination/pvr_device.h @@ -39,8 +39,8 @@ struct firmware; /* Forward declaration from */ struct pwrseq_desc; =20 -#define PVR_GPUID_STRING_MIN_LENGTH 7U -#define PVR_GPUID_STRING_MAX_LENGTH 32U +#define PVR_GPUID_STRING_MIN_LENGTH 7 +#define PVR_GPUID_STRING_MAX_LENGTH 32 =20 /** * struct pvr_gpu_id - Hardware GPU ID information for a PowerVR device --- base-commit: 69674c1c704c0199ca7a3947f3cdcd575973175d change-id: 20260206-gpuid-strlen-fix-5622c1fdd0b2