From nobody Sun Feb 8 18:28:29 2026 Received: from TWMBX01.aspeed.com (mail.aspeedtech.com [211.20.114.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1668A3358B9; Fri, 6 Feb 2026 03:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.20.114.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770347872; cv=none; b=msmlO9l1Fh1xqy+fyRI2ItVR+PNjiaw4ceC9obL/kMZAo1WKP/8g3wi0RF8zCTFZIsav6xpRCypvHs784tSXkv9CcuqLoKxJmg/NHjPVZF6p9nQMli3tEkaGdEQX5fpEbxDwZYLqRcMuTTxzfRxO391lnzAnx/7bjH3dDOcYKP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770347872; c=relaxed/simple; bh=OmD5Arfn3RrbJ25M0ctPE3l/LqvXsbLTQxMzqMnbtzU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=TG3sgwqDx/bSmWsh6ZgTmPqTPJq6FWbtZbLnBAsgG6HIax2gScJcofzz/d+pBRK0S3TmBbzPFlU/ISHC4GVdbyNpKyPrwLlrvoY0Et5IXjaKvft9/G/7OdAKUAp0IjC4Dq5vw8nRe6IEBiox8M73omMBK1pltZSOIJgugyYSgKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com; spf=pass smtp.mailfrom=aspeedtech.com; arc=none smtp.client-ip=211.20.114.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aspeedtech.com Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 6 Feb 2026 11:17:45 +0800 Received: from [127.0.1.1] (192.168.10.13) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Fri, 6 Feb 2026 11:17:45 +0800 From: Jacky Chou Date: Fri, 6 Feb 2026 11:17:47 +0800 Subject: [PATCH net-next v5 07/15] net: ftgmac100: Simplify error handling for ftgmac100_initial_mac Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260206-ftgmac-cleanup-v5-7-ad28a9067ea7@aspeedtech.com> References: <20260206-ftgmac-cleanup-v5-0-ad28a9067ea7@aspeedtech.com> In-Reply-To: <20260206-ftgmac-cleanup-v5-0-ad28a9067ea7@aspeedtech.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: , , Andrew Lunn , Jacky Chou , Simon Horman X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770347864; l=1005; i=jacky_chou@aspeedtech.com; s=20251031; h=from:subject:message-id; bh=v09SrIG5pIMosiqozTDRpfXyvuVR8w7kAu8PLHCKIaA=; b=ou+nUO4iudpkB3k/COB2jX5Bu3IxcW7Wy+ZeWnSmw6CPQgW8AL3hnqx/SSasfkkjL09Oq5XWN qCQ7ef4Io4SDhxvMQ0f2CtfrdMv2uF0c8LglmXTjjVz+JHUabIzsgBO X-Developer-Key: i=jacky_chou@aspeedtech.com; a=ed25519; pk=8XBx7KFM1drEsfCXTH9QC2lbMlGU4XwJTA6Jt9Mabdo= From: Andrew Lunn ftgmac100_initial_mac() does not allocate any resources. All resources by the probe function up until this call point use devm_ methods. So just return the error code rather than use a goto. Signed-off-by: Andrew Lunn Reviewed-by: Simon Horman Signed-off-by: Jacky Chou --- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/etherne= t/faraday/ftgmac100.c index 1fb03dd55c8f..e511d6d5f7c2 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1914,7 +1914,7 @@ static int ftgmac100_probe(struct platform_device *pd= ev) /* MAC address from chip or random one */ err =3D ftgmac100_initial_mac(priv); if (err) - goto err_phy_connect; + return err; =20 if (priv->mac_id =3D=3D FTGMAC100_AST2400 || priv->mac_id =3D=3D FTGMAC100_AST2500 || --=20 2.34.1