From nobody Sat Feb 7 17:55:15 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228AC2E1EE7 for ; Fri, 6 Feb 2026 06:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359412; cv=none; b=GMJMhIkdWn9vXjd/oa+7MAxyGDUY7bgEbIWqmqlP7YoYDip9MFQQAISKSqyeDCTncwOQcXnwf6EjX+aFfrZlWAhIjvFj8ydwIO1LkZG7BYqSDQZi2WrV+R5H2+0stNZvD9MFfPNBsBArtrm8OoHIPEkFdu9KolMmAf3uY6Y9mJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770359412; c=relaxed/simple; bh=tySiLComH42yw5CiXQiw6026PNWrWpTomOFKiRPk5D4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=IF2HCnQwSmOeok8JmRPB+uwLEdgFHOmBwDSDAYIwqc96Dac8z4thQV/giWLWx+8RnNgi6wBnrtFszj+91BCGGMal2vfkAsch9mwcV8KWt81eUODcfwfkfbPPR1kFxpq1/t1gSGDFYx97Ksa8+fdF38xct8Eo63zmW36P/HXXxLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aYcKgjHJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aYcKgjHJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2A89C116C6; Fri, 6 Feb 2026 06:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770359411; bh=tySiLComH42yw5CiXQiw6026PNWrWpTomOFKiRPk5D4=; h=From:To:Cc:Subject:Date:From; b=aYcKgjHJMciUhx8147reu6F0tOEEB7Z66i+/HrqWLDqtAtxG6OX4Tpf5CDA+aQWyY 1P+SnlkmXxr9Y36SFtmzELUCvtOqY7kiS/k6fa+7rDXfwEnIo+cSWdHihFniyxG9cS WxzgE8LVeWlIkGaBAHhcHTUeTuNTWlj+g6p3ah0Lp7R795ciRFEoeSW1C9rzSiobDV 6FQSucUSiqvWaZabM8As3SSEFsi1w1SrFGvI9EaU+IqTsqUBjpXbjjYhxRCbpgw9sV 7d/qGKb5Nl3wxqx/j7/Wrp7kUOqUhYnfqBzrrOtWlRYmcbBczAbYJfxYDYSzggd4H4 Fv2nKZzqh72zQ== From: Chao Yu To: xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chao Yu , stable@kernel.org Subject: [PATCH] erofs: fix UAF issue in erofs_fileio_rq_submit() Date: Fri, 6 Feb 2026 06:30:05 +0800 Message-Id: <20260205223005.72727-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ 9.269940][ T3222] Call trace: [ 9.269948][ T3222] ext4_file_read_iter+0xac/0x108 [ 9.269979][ T3222] vfs_iocb_iter_read+0xac/0x198 [ 9.269993][ T3222] erofs_fileio_rq_submit+0x12c/0x180 [ 9.270008][ T3222] erofs_fileio_submit_bio+0x14/0x24 [ 9.270030][ T3222] z_erofs_runqueue+0x834/0x8ac [ 9.270054][ T3222] z_erofs_read_folio+0x120/0x220 [ 9.270083][ T3222] filemap_read_folio+0x60/0x120 [ 9.270102][ T3222] filemap_fault+0xcac/0x1060 [ 9.270119][ T3222] do_pte_missing+0x2d8/0x1554 [ 9.270131][ T3222] handle_mm_fault+0x5ec/0x70c [ 9.270142][ T3222] do_page_fault+0x178/0x88c [ 9.270167][ T3222] do_translation_fault+0x38/0x54 [ 9.270183][ T3222] do_mem_abort+0x54/0xac [ 9.270208][ T3222] el0_da+0x44/0x7c [ 9.270227][ T3222] el0t_64_sync_handler+0x5c/0xf4 [ 9.270253][ T3222] el0t_64_sync+0x1bc/0x1c0 erofs may encounter above panic when enabling file-backed mount w/ directio mount option, the root cause is it may suffer UAF in below race condition: - z_erofs_read_folio wq s_dio_done_wq - z_erofs_runqueue - erofs_fileio_submit_bio - erofs_fileio_rq_submit - vfs_iocb_iter_read - ext4_file_read_iter - ext4_dio_read_iter - iomap_dio_rw : bio was submitted and return -EIOCBQUEUED - dio_aio_complete_work - dio_complete - dio->iocb->ki_complete (e= rofs_fileio_ki_complete()) - kfree(rq) : it frees iocb, iocb.ki_f= ilp can be UAF in file_accessed(). - file_accessed : access NULL file point Introduce a reference count in struct erofs_fileio_rq, and initialize it as two, both erofs_fileio_ki_complete() and erofs_fileio_rq_submit() will decrease reference count, the last one decreasing the reference count to zero will free rq. Cc: stable@kernel.org Fixes: fb176750266a ("erofs: add file-backed mount support") Signed-off-by: Chao Yu Reviewed-by: Gao Xiang --- fs/erofs/fileio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/erofs/fileio.c b/fs/erofs/fileio.c index 43998fe1cce1..4d5054dcac95 100644 --- a/fs/erofs/fileio.c +++ b/fs/erofs/fileio.c @@ -10,6 +10,7 @@ struct erofs_fileio_rq { struct bio bio; struct kiocb iocb; struct super_block *sb; + refcount_t ref; }; =20 struct erofs_fileio { @@ -38,7 +39,8 @@ static void erofs_fileio_ki_complete(struct kiocb *iocb, = long ret) } bio_endio(&rq->bio); bio_uninit(&rq->bio); - kfree(rq); + if (refcount_dec_and_test(&rq->ref)) + kfree(rq); } =20 static void erofs_fileio_rq_submit(struct erofs_fileio_rq *rq) @@ -60,6 +62,8 @@ static void erofs_fileio_rq_submit(struct erofs_fileio_rq= *rq) ret =3D vfs_iocb_iter_read(rq->iocb.ki_filp, &rq->iocb, &iter); if (ret !=3D -EIOCBQUEUED) erofs_fileio_ki_complete(&rq->iocb, ret); + if (refcount_dec_and_test(&rq->ref)) + kfree(rq); } =20 static struct erofs_fileio_rq *erofs_fileio_rq_alloc(struct erofs_map_dev = *mdev) @@ -70,6 +74,7 @@ static struct erofs_fileio_rq *erofs_fileio_rq_alloc(stru= ct erofs_map_dev *mdev) bio_init(&rq->bio, NULL, rq->bvecs, ARRAY_SIZE(rq->bvecs), REQ_OP_READ); rq->iocb.ki_filp =3D mdev->m_dif->file; rq->sb =3D mdev->m_sb; + refcount_set(&rq->ref, 2); return rq; } =20 --=20 2.40.1