From nobody Sun Feb 8 09:37:39 2026 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B38313E0A for ; Thu, 5 Feb 2026 19:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770318832; cv=none; b=UnE16jF1qUGgI8px2z6ebdNcvpK3/aBCfrtHtw6uf5eKPk3WYWcgFdx4/FlDxD/VjUfnjJJCFSLfp02o/OyudluSY2Ct46MZM5AimawoDU/dr8FhEBcAj/lER8gk8qknsfclN724jMwbzTARhWq3KW4SVOU2DT64NCazirdpQEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770318832; c=relaxed/simple; bh=+6d2IL2o7eM5i7mxS8QplzrHXrpM9Gu0pdRjT0VFBKM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FWIlWmBrFeTf7ZSn9jdga/KfV+3kUzwZr7sotF+rZVdJRmTkVel4acKrorBVlu2C4UwVNuLtnmu/7CrqB+DsErSoahB9au5/7IrSlOs8x+/VTXmPN8traINsDg2mNVhQFTPU9S6bdMzKh2ofgySAJbuwQqpmM2HhZoclHDzO6Kg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KVlN13gt; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KVlN13gt" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-4359108fd24so891909f8f.2 for ; Thu, 05 Feb 2026 11:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770318830; x=1770923630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aSmwX5jo1aHhNb1q51A/bPN0A3FfbNuaugD4NxvZhPg=; b=KVlN13gte0GtjXdtlShV93006LTTV+UsMYGQbHnsXEFUQuUCkGe28dZcHvUM11Q14I 1J9mLWf530dU+VJlz0IVmvwZKXshwWrZwNh841aKu8wcfZvNT5DCX9XEo3K+/C2psdwM xfQUptE/2cyA98sXpLS5xJ3X4i6VwfIhiqD+Ejm+EbK0wgxgy6G8CT/pQiEon5e5+1Ja mAvq9MI59sEY6d2035tFMLuziv1u2p0djlT6bcl+tX7HpvSNVsk/s+ShO09vw+9PyM88 LFx2UyxrZWcjdNW4sf5ClJSJ5Q2sBlsVJ1W8c/6RNF2mEnuKRVjlNTcyUlvIQIcBtH+d WYgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770318830; x=1770923630; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aSmwX5jo1aHhNb1q51A/bPN0A3FfbNuaugD4NxvZhPg=; b=P75sCeXEStaWvV0ejeYhvKBjopgNRwZzltNTP2lXX1ento5iHJO+byWfDfxRjjWTns Ed6TbeEV4/k8LwzmbY/AfrTJCc3Vc3yOcPYFH0Ran6x44E0IhGXVrT5pzaBWMSCXNao+ +b9ynvay7SlajMXCaPuyZ/5X9Gva8wP+xoG2CCP3U5Axuuvf35ejVxZHeBhT6YaW6Qk7 GXEykA7yQpDSXVO0YcN9mOWx0GOG4DYQypRIRnZ+f90rICHLs2tVLvjysFJFBMFf48U8 X97Qz5LBO6HxPDaLcsXUJNJY7YLu0gy6Kgni9WIRUixziHTrdm80A1T4FTsD8WHiY3/v bfIg== X-Forwarded-Encrypted: i=1; AJvYcCVhc40cNh5c2jELqfs75swhUrdQ6woUvoXjZ0Hs910oIZagGyhztFwd1QE5H0JM3PuEFzIQs/q/Acwk718=@vger.kernel.org X-Gm-Message-State: AOJu0YyFlCSekhR35XDPyvs6VAniNl27I5VyZNtByQJfZIT4JRqcN1Ta i8irYWRf9u8AJ7XGNRa8b6N9FgyZ8FC/6Hd/mvDW/CRoX2qP8mdjMnBKDf0jyzS9bq35lw== X-Gm-Gg: AZuq6aJzO6arCP+YoG/RkInD6YAle9JpxAY1bu9mQPLnHM3y0llCR19VbDSyAbSItpt QOyJd1c8n0ANJB1EcnqY4JGBhIn/VEh1ZQcyQ879MShzEcIdfhhIjaevsVYi+fPX3TJWxm1oqx0 2ULla0cWslBsUK89npIh7UwEtQQOZXjHn+UPnomjUD8iEK2AznvY+o2hfU1AjPeU+o8cXmN+hfZ Cm29i+Zx8HaBypSFU4Afbutp7ZuOLPQ2qSTDGh0OReVEOKIHghqgXwhrnuY/mLlnmvm3NtuDQEO I620PiFTKurER255nquQYXylSwFK35mxu4LzD/kx7ujhsAnTcAzwKox4prft/PMEatXr0tQbHbi 6pLNS/PAdoPD20LP6zQA/W+9jUvGgHN/SVbpf0XJeqIWe8PgNstbwG1OlZ36FD+OdsQx6WV2l4S TPdT2q+4B1u1/pBXbEyGxsNipB5h5t2hLFcysZ/gvKZp6hZ0+hcg6EHwzjb2RevVnenVI= X-Received: by 2002:a05:6000:1a86:b0:431:74:cca with SMTP id ffacd0b85a97d-4362968a649mr339852f8f.44.1770318829808; Thu, 05 Feb 2026 11:13:49 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([103.73.101.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362972fa41sm266057f8f.23.2026.02.05.11.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 11:13:49 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] staging: most: dim2: convert pr_info/err/warn to dev_info/err/warn Date: Fri, 6 Feb 2026 00:13:14 +0500 Message-ID: <20260205191315.8936-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dim2 driver currently uses generic pr_* logging macros. Hardware drivers should use the device-specific dev_* logging macros to provide better context in the system logs, especially in systems with multiple controller instances. This patch converts all applicable logging calls in dim2.c to use the proper device-specific APIs. Signed-off-by: Zeeshan Ahmad --- drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index dad2abe6c0c9..e6d99d9009b5 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -244,9 +244,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, stru= ct mbo *mbo) { u8 *data =3D mbo->virt_address; =20 - pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]); + dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[1= 7]); dev->link_state =3D data[18]; - pr_info("NIState: %d\n", dev->link_state); + dev_info(&dev->dev, "NIState: %d\n", dev->link_state); memcpy(dev->mac_addrs, data + 19, 6); dev->deliver_netinfo++; wake_up_interruptible(&dev->netinfo_waitq); @@ -470,13 +470,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_CONTROL: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_control(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -484,13 +484,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ASYNC: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_async(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -498,41 +498,41 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ISOC: new_size =3D dim_norm_isoc_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; case MOST_CH_SYNC: new_size =3D dim_norm_sync_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; default: - pr_err("%s: configure failed, bad channel type: %d\n", - hdm_ch->name, ccfg->data_type); + dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n", + hdm_ch->name, ccfg->data_type); return -EINVAL; } =20 if (hal_ret !=3D DIM_NO_ERROR) { spin_unlock_irqrestore(&dim_lock, flags); - pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n", - hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); + dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n", + hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); return -ENODEV; } =20 @@ -606,7 +606,7 @@ static void request_netinfo(struct most_interface *most= _iface, int ch_idx, return; =20 if (dev->atx_idx < 0) { - pr_err("Async Tx Not initialized\n"); + dev_err(&dev->dev, "Async Tx Not initialized\n"); return; } =20 @@ -655,7 +655,7 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) dev->atx_idx =3D -1; spin_unlock_irqrestore(&dim_lock, flags); if (hal_ret !=3D DIM_NO_ERROR) { - pr_err("HAL Failed to close channel %s\n", hdm_ch->name); + dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name); ret =3D -EFAULT; } =20 --=20 2.43.0