From nobody Sat Feb 7 15:10:13 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A59343D4F4 for ; Thu, 5 Feb 2026 17:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770312522; cv=none; b=eCdHVO+RzDIZuC3MYjIunYbG9w5RiyJruDIhFz8DxsOU3oFlfNayKgPUsDstNWAumm74xnWqg2e0AMTk3pJJyRiqcsv1EtXcHsfOFo8Pvlbkat8i8tZw/xrlNOeRqJJ6oBbvrX9xXFbp5yG3EI9S/mTMNBexj03bCmNie4NUwzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770312522; c=relaxed/simple; bh=ISPg1m/xtoHmadv+9qD4PF4qeTVVdwlXnG/d134LzZg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pNdPXrdxF93c/nueJb8lUiu7vzu0LnjrAmz59Pad8AKYywHi8DDu0IfLYZ8MoYZt6LzNSffxPpVGiAc638RnrA295Ya7Wp/08+Uoqdl3+quXyQ/bRZplhiSU6z38GkhwCTTYQM1zgf2FFvhKD0fpf7+loAn6RGESxYD8NB/RzIA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QGbRjM7j; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QGbRjM7j" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48068ed1eccso12740375e9.2 for ; Thu, 05 Feb 2026 09:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770312521; x=1770917321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Tyvs4xFeOgUlL1nJWOsM4wXcI5MSjDts4OzcTAQg/Sk=; b=QGbRjM7jf5jwvszCuzt60uATi21ZpJSACb/Qhjkqmu/sUjnNGmqk9Uu2LEYdnEjZzL kf4jO5LgBTTZhyUPLiUqOx66IpkzRlkj1Sy4ZhMJsCwxkqCIFbkw7nyF5hnvJa+tbsrw /fuqsMRSGnIT8NGwiAnvo/U2kJXe786jYaO79gEbyeLxzlbpOUN3VsxIDNFCb7sRLlR8 N8rSm3gt4yYbHQoLQBNqY/0Lfg2lQvQQmIzO0DbCmYH7o0atsprmBfhVZj4J3uO2/EFj KkKmuISzipml30D18ARQRzOTTTxMYCqa6rq5JQ+ROaHh4OCM/i1hgkazRGYEeOQgO0Q3 rlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770312521; x=1770917321; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tyvs4xFeOgUlL1nJWOsM4wXcI5MSjDts4OzcTAQg/Sk=; b=or62r7E4I9CQW708dv/tk63E85rXq8IAmngiWYt5M3ZCy8LXsps6QPAc1Yld+7UdB9 2rc5IkisEkjiMReEqEmpqBq3QhFCigWPdHMTvRNpyKcsk3kr3aAr0V8ULxwuOF7coqaW 9ZFVIY12ujmMnARrz/5/cn+jBxNX2hMQKvTfo2x0jDoiECJg5QxDWSLiG6bQJ516xrTu nJ2nyM2v8P9LRMNUGQ8ldaQW6QZHOS5YmVTEPkfhBVshU4Ul7NtyFQ7Tlz1qUz49F1W6 EMBHAq3IDikL+iFQUUHTC5ctqqBPY5pxKVAgfsLlAY2Rj+jlEwgF/tuWPcnZZzJ7AViH NEKQ== X-Forwarded-Encrypted: i=1; AJvYcCUt9rm04sF2kjl+hERkqkxRGaourQ34FY76DnvMMw60YmIYFReBMYHLxGQlFSnONdWV/FOtSOyUJQAVwAU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6Si73zG/k9fP20vPH1eqy7FBgAdglMiOHpcFPZNaSZDFckmBa M3PLqRi+ujc3I9lJncryH0QH2nOsdVKO/6FTpyDgh36/jY0w38Vd5xcU X-Gm-Gg: AZuq6aKm9G8NFJVB1xCwSYkAgfu1SVNcu63Pl8O0KZE9wEnl87oJmMABHeg4YKbN0ya ty8c1N8v/JNvpqM9SXOxyTMl+EgEJrFKREgbhlHpQ5J0eMcbepUHIe6g590D6nBULhiYo+UE6mF bcCLSde+6G8CwsehyPwMV+E1ElDw9wVbkVTEPfd4IsAN9znFMvtMwvt1sfdKwj9VlueQptr4FC3 17EB68/ft+/pSXD9Vm6u6hU7KyA4wXuxUhyoTPU6RwIw4XYg2zq2mgZm4el7GXkS099iN9puRAA Guk1mJCxPTYZP32gdQt09c0lLpBnXhXvb4VAwYaI6/L0Y4K9on0tLWcbgmDwhjUsogo+12s3mdt Mn38iG9vvwC+ghVKBjRElFvaZco7/M0iYsbEBCw29RTwLN0MfussMN05hKJic4wGuz3tNHA6Nv1 8c3obheJaBx/Jw X-Received: by 2002:a05:600c:19c7:b0:477:a54a:acba with SMTP id 5b1f17b1804b1-483202161edmr2260385e9.17.1770312520238; Thu, 05 Feb 2026 09:28:40 -0800 (PST) Received: from Max.. ([46.210.204.80]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ffc39b8sm53628265e9.17.2026.02.05.09.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 09:28:39 -0800 (PST) From: Max Brener To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Max Brener Subject: [PATCH] Input: libps2 - embed WARN_ON(1) macros into their enclosing if statements Date: Thu, 5 Feb 2026 19:27:55 +0200 Message-ID: <20260205172755.25117-1-linmaxi@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make WARN_ON(1) statements embedded inside their respective 'if' expression= s, to improve code clarity. Signed-off-by: Max Brener --- drivers/input/serio/libps2.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c index 269df83a167d..05b64277aecd 100644 --- a/drivers/input/serio/libps2.c +++ b/drivers/input/serio/libps2.c @@ -154,10 +154,8 @@ EXPORT_SYMBOL(ps2_end_command); */ void ps2_drain(struct ps2dev *ps2dev, size_t maxbytes, unsigned int timeou= t) { - if (maxbytes > sizeof(ps2dev->cmdbuf)) { - WARN_ON(1); + if (WARN_ON(maxbytes > sizeof(ps2dev->cmdbuf))) maxbytes =3D sizeof(ps2dev->cmdbuf); - } =20 ps2_begin_command(ps2dev); =20 @@ -270,15 +268,11 @@ int __ps2_command(struct ps2dev *ps2dev, u8 *param, u= nsigned int command) int i; u8 send_param[16]; =20 - if (receive > sizeof(ps2dev->cmdbuf)) { - WARN_ON(1); + if (WARN_ON(receive > sizeof(ps2dev->cmdbuf))) return -EINVAL; - } =20 - if (send && !param) { - WARN_ON(1); + if (WARN_ON(send && !param)) return -EINVAL; - } =20 memcpy(send_param, param, send); =20 --=20 2.43.0