From nobody Sun Feb 8 01:34:09 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04582421F05 for ; Thu, 5 Feb 2026 16:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770308799; cv=none; b=UeMRrTBd+UGoUQJH1ozy8gQHAPQSfBLpnmV37ruEmj7vyGGRaGscewbdL6ny1olIPGIuIFQoIOg9YhKa1TO6L3b0xjdtqRtSz9cPCcJae6BfRB185bRKRMIPszhZ8ilFjZkbZxCkMRpIyQvtMV9nLUmrswESXwa9hM93lRqmazQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770308799; c=relaxed/simple; bh=9r9EfnqgpePHSmknjj3jV71TCwg0Aj5TNW2hpF8F0ic=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SKpKLx53EMhwkIPx7RXpxwkkCuekDlckCKu76CNa1F1K0OL+3y/yUXgTheM1Lzk3UboxEJfGjvueGPoZdu1BqiyclTZ8EEoEAXg+5xOiDN6x2GHIILn4Mca5z85o9Xtzbk0c4n75+/a8CGNwZ5xJCsYWuzO1J0D3hmdF60k7+m4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EbNj22Vv; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EbNj22Vv" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-bc29d64b39dso361691a12.3 for ; Thu, 05 Feb 2026 08:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770308798; x=1770913598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JyEXpPncVH2GhAUyxHXUUpWjlgv8nEIxYO25mhp+H1s=; b=EbNj22Vv7QktYbdgH2aSSzrOQAWfDBs4vk65Rhuq+5CZxEp6kDql2lQzAcLMEKiAxb IvF4pZjqFA21TcfAoQdthQU9P6ueM8EeCgKfJx51iaDwuqkQ+TkJKc0C0FRs3hM+5/Q7 qlZZ/38Sj0efdTIFY5CYweUFL9hRdwH7vpEEGnvzFTWTuT48DrjpINunAl4Q+db6LQmC u4aqhsBiO7kmbNVsEEdhlV+6oVJBWARyRSGj2SLbuV1ap+lunJgwUfRP7rupMbvYtftd 1IJLOrxVBAjbe8ra8c8owzZJmeBrsgAiY6kaMhz67viVJzpgYjJf53RWysA7lA0CM6/W SNiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770308798; x=1770913598; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JyEXpPncVH2GhAUyxHXUUpWjlgv8nEIxYO25mhp+H1s=; b=LVQX3fzfMal+xSH9rhsg3axOlv0BB024zdzXHhblrocbu0XXDaMnmn9N8Ksk1kfgll CtMhD85N+FaFuhZnsPHZ/gH1su936d106DxvFfKftAc0yajhtQAvurgjPbrfjVRgAkus yYIbmcW+9e4utfFEKWZCa6L04v9BJPJw7ZlX2OVQH8NSHKbS8Mqq+1q6AG2+kjF3WDFI JhWcUeicBmUjgkBTviiw0UIYwFV3oPUFiCIC4qCNs+ltmY48YyYO9b1uHPYCEoK6QAW6 97xR8kBgWDorpNo2ybikm3ejsG4IqG1REUcQzLcmXJU3ZTNZB7JDrwfVDxRfbEmu/PH3 2Ujw== X-Forwarded-Encrypted: i=1; AJvYcCWucUu1tN/ucn7x3g5pQ//oG0OiWexZy2jqgk9d7/MuHgpmF3hX7hYTnRUf/+RQts4Seka10cL1ti7FF88=@vger.kernel.org X-Gm-Message-State: AOJu0YynuJrWQ4xkzw7f9xvepOFB6ogHSeLjV5yCBb974JzH04mupyi8 LeyKzZwtMDnbWpEUcYt6IBWTcGh7LfijQxJ6phOBeR0WUxRPKrrFr0ta X-Gm-Gg: AZuq6aIPPhCciJ/Wd4ynf/8w0DVMqP7UluovWuIEYgegRFlEE/LtjyvMoTh5+SlWcjY JsLlr82JXurVHfgVxZLhApHyHnMkjrwvS+1xvXN5xFan0486DdvbZsr0EvMJvuD27TeJ7uIBPQk 9AftaxUUbb94fxsu0/yynaiXdAQ48MdfJj3iBlEwEJG4Uo8IU3D1pjFtqm45esf3iW6/D8ZXqYZ jJ+mEZl1Z2GwxLooNMoR6FMBJgW6EPJeEZEDeqEzppi/yy1hRbCzZMP1UGGJ41mZlFvxRS9O8kB M1mFHAyxRueG7n4CFi1RrnCE9iPzZjXwGlY10ACrkdyDH3rPfxSg32h1hrN3q2YbhGJ9Ef5aHKf I+60EMWlZYW3orTmCUpAxDwQ6O37PTbnAz2piD1Q0lrOPZ6RbjX7LU/L1Ikh3s+L4np+kuIn1pQ E5x0IjG0NAZBapsuG4WOYjaMBsY7Rg+7dLHiBY X-Received: by 2002:a17:90b:1b11:b0:340:d578:f2a2 with SMTP id 98e67ed59e1d1-354870db3e3mr6719407a91.6.1770308798217; Thu, 05 Feb 2026 08:26:38 -0800 (PST) Received: from localhost.localdomain ([114.79.136.72]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c8553e6b1sm5444208a12.32.2026.02.05.08.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 08:26:37 -0800 (PST) From: Prithvi Tambewagh To: martin.petersen@oracle.com, d.bogdanov@yadro.com, bvanassche@acm.org Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh , syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH v3] scsi: target: fix recursive locking in __configfs_open_file() Date: Thu, 5 Feb 2026 21:56:24 +0530 Message-Id: <20260205162624.117957-1-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In flush_write_buffer, &p->frag_sem is acquired and then the loaded store function is called, which, here, is target_core_item_dbroot_store(). This function called filp_open(), following which these functions were called (in reverse order), according to the call trace: down_read __configfs_open_file do_dentry_open vfs_open do_open path_openat do_filp_open file_open_name filp_open target_core_item_dbroot_store flush_write_buffer configfs_write_iter target_core_item_dbroot_store() tries to validate the new file path by trying to open the file path provided to it; however, in this case, the bug report shows: db_root: not a directory: /sys/kernel/config/target/dbroot indicating that the same configfs file was tried to be opened, on which it is currently working on. Thus, it is trying to acquire frag_sem semaphore of the same file of which it already holds the semaphore obtained in flush_write_buffer(), leading to acquiring the semaphore in a nested manner and a possibility of recursive locking. Fix this by modifying target_core_item_dbroot_store() to use kern_path() instead of filp_open() to avoid opening the file using filesystem-specific function __configfs_open_file(), and further modifying it to make this fix compatible. Reported-by: syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Df6e8174215573a84b797 Tested-by: syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Prithvi Tambewagh Reviewed-by: Dmitry Bogdanov --- Changes since v2: - Add Reviewed-by tag received from Dmitry Bogdanov, which was accidentally left to be added in v2 patch. v2 link: https://lore.kernel.org/linux-scsi/20260122154051.64132-1-activpri= thvi@gmail.com/T/#u Reference for Reviewed-by Tag: https://lore.kernel.org/all/20260108191523.3= 03114-1-activprithvi@gmail.com/T/#mb22d0fc06e747e2b2df8320a15afd2a0670fd0e7 Changes since v1: - Update commit message to reflect the fact that same file, which code was=20 currently operating on, was tried to be opened again, leading to=20 acquiring the same semaphore in nested manner & possibility of recursive locking. v1 link: https://lore.kernel.org/all/20260108191523.303114-1-activprithvi@g= mail.com/T/ drivers/target/target_core_configfs.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_= core_configfs.c index b19acd662726..f29052e6a87d 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -108,8 +108,8 @@ static ssize_t target_core_item_dbroot_store(struct con= fig_item *item, const char *page, size_t count) { ssize_t read_bytes; - struct file *fp; ssize_t r =3D -EINVAL; + struct path path =3D {}; =20 mutex_lock(&target_devices_lock); if (target_devices) { @@ -131,17 +131,18 @@ static ssize_t target_core_item_dbroot_store(struct c= onfig_item *item, db_root_stage[read_bytes - 1] =3D '\0'; =20 /* validate new db root before accepting it */ - fp =3D filp_open(db_root_stage, O_RDONLY, 0); - if (IS_ERR(fp)) { + r =3D kern_path(db_root_stage, LOOKUP_FOLLOW, &path); + if (r) { pr_err("db_root: cannot open: %s\n", db_root_stage); goto unlock; } - if (!S_ISDIR(file_inode(fp)->i_mode)) { - filp_close(fp, NULL); + if (!d_is_dir(path.dentry)) { + path_put(&path); pr_err("db_root: not a directory: %s\n", db_root_stage); + r =3D -ENOTDIR; goto unlock; } - filp_close(fp, NULL); + path_put(&path); =20 strscpy(db_root, db_root_stage); pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root); base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 --=20 2.34.1